[libvirt PATCH 0/8] More VIR_FREE removals
by Laine Stump
Only 90 this time. These are all functions that behave similar to the
*Free() functions, but their names don't end in "Free" so I missed
them last time.
Laine Stump (8):
esx: replace VIR_FREE with g_free in any ESX_VI__TEMPLATE__FREE
conf: convert VIR_FREE to g_free in other functions that free their
arg
locking: convert VIR_FREE to g_free in other functions that free their
arg
openvz: convert VIR_FREE to g_free in other functions that free their
arg
remote: convert VIR_FREE to g_free in other functions that free their
arg
qemu: convert VIR_FREE to g_free in other functions that free their
arg
util: convert VIR_FREE to g_free in other functions that free their
arg
vmware: convert VIR_FREE to g_free in other functions that free their
arg
src/conf/capabilities.c | 38 +++++++++++++++----------------
src/esx/esx_vi.c | 18 +++++++--------
src/esx/esx_vi_types.c | 24 +++++++++----------
src/locking/lock_manager.c | 4 ++--
src/openvz/openvz_conf.c | 2 +-
src/qemu/qemu_domain.c | 2 +-
src/qemu/qemu_driver.c | 8 +++----
src/remote/remote_daemon_stream.c | 2 +-
src/util/virconf.c | 4 ++--
src/util/virerror.c | 4 ++--
src/util/virobject.c | 2 +-
src/util/virstring.c | 4 ++--
src/vmware/vmware_conf.c | 4 ++--
src/vmware/vmware_driver.c | 4 ++--
14 files changed, 60 insertions(+), 60 deletions(-)
--
2.29.2
4 years, 2 months
[PATCH 0/2] qemu: swtpm improvements
by Jim Fehlig
These patches are fallout from a discussion about TPM devices and aarch64
https://listman.redhat.com/archives/libvir-list/2021-February/msg00526.html
Jim Fehlig (2):
qemu: Fix swtpm device with aarch64
qemu: Validate TPM TIS device
src/qemu/qemu_command.c | 3 ++
src/qemu/qemu_validate.c | 7 ++++
.../aarch64-tpm.aarch64-latest.args | 37 +++++++++++++++++++
tests/qemuxml2argvdata/aarch64-tpm.xml | 15 ++++++++
tests/qemuxml2argvtest.c | 1 +
5 files changed, 63 insertions(+)
create mode 100644 tests/qemuxml2argvdata/aarch64-tpm.aarch64-latest.args
create mode 100644 tests/qemuxml2argvdata/aarch64-tpm.xml
--
2.29.2
4 years, 2 months
[libvirt PATCH 0/6] ci: Paint the pipeline green
by Andrea Bolognani
Various workarounds that are necessary due to breakages in external
services and distribution archives, plus fixes for a couple of issues
that were discovered in the process.
Andrea Bolognani (6):
ci: Shuffle cross-building jobs around
ci: Mark container build jobs as required/optional correctly
ci: Move ppc64le build from Debian sid to Debian 10
ci: Refresh Dockerfiles
ci: Add temporary workaround for Fedora Rawhide
ci: Build on FreeBSD 12.2
.gitlab-ci.yml | 66 +++++++++----------
ci/containers/ci-centos-7.Dockerfile | 3 +-
ci/containers/ci-centos-8.Dockerfile | 3 +-
ci/containers/ci-centos-stream.Dockerfile | 3 +-
.../ci-debian-10-cross-aarch64.Dockerfile | 3 +-
.../ci-debian-10-cross-armv6l.Dockerfile | 3 +-
.../ci-debian-10-cross-armv7l.Dockerfile | 3 +-
.../ci-debian-10-cross-i686.Dockerfile | 3 +-
.../ci-debian-10-cross-mips.Dockerfile | 3 +-
.../ci-debian-10-cross-mips64el.Dockerfile | 3 +-
.../ci-debian-10-cross-mipsel.Dockerfile | 3 +-
.../ci-debian-10-cross-ppc64le.Dockerfile | 3 +-
.../ci-debian-10-cross-s390x.Dockerfile | 3 +-
ci/containers/ci-debian-10.Dockerfile | 3 +-
.../ci-debian-sid-cross-aarch64.Dockerfile | 3 +-
.../ci-debian-sid-cross-armv6l.Dockerfile | 3 +-
.../ci-debian-sid-cross-armv7l.Dockerfile | 3 +-
.../ci-debian-sid-cross-i686.Dockerfile | 3 +-
.../ci-debian-sid-cross-mips64el.Dockerfile | 3 +-
.../ci-debian-sid-cross-mipsel.Dockerfile | 3 +-
.../ci-debian-sid-cross-ppc64le.Dockerfile | 3 +-
.../ci-debian-sid-cross-s390x.Dockerfile | 3 +-
ci/containers/ci-debian-sid.Dockerfile | 3 +-
ci/containers/ci-fedora-32.Dockerfile | 3 +-
ci/containers/ci-fedora-33.Dockerfile | 3 +-
...ci-fedora-rawhide-cross-mingw32.Dockerfile | 6 +-
...ci-fedora-rawhide-cross-mingw64.Dockerfile | 6 +-
ci/containers/ci-fedora-rawhide.Dockerfile | 6 +-
ci/containers/ci-opensuse-152.Dockerfile | 3 +-
ci/containers/ci-ubuntu-1804.Dockerfile | 3 +-
ci/containers/ci-ubuntu-2004.Dockerfile | 3 +-
31 files changed, 99 insertions(+), 66 deletions(-)
--
2.26.2
4 years, 2 months
[PATCH 0/7] support <teaming> (aka "QEMU virtio failover") with plain <hostdev>
by Laine Stump
This is explained in excruciating detail in Patch 5, but in short,
allowing the <teaming> element to be in a plain <hostdev> will permit
someone who is running libvirt unprivileged, or in a container with no
access to a PF device, to use the <teaming> feature, which
encapsulates a lot of functionality related to assigning an SRIOV
network device to a guest as a part of a failover bond device (the
other device in the pair is an emulated virtio NIC), which in turn
permits the guest to be migrated by transparently unplugging the SRIOV
NIC prior to migration, and plugging a new one in after migration is
completed.
(Previously we required <interface type='hostdev'> for this feature,
but that type of device needs to send netlink messages to the PF of
the SRIOV VF that's being assigned, and that simply isn't possible
sometimes.)
Laine Stump (7):
conf: make teaming info an official type
conf: use virDomainNetTeamingInfoPtr instead of
virDomainNetTeamingInfo
conf: separate Parse/Format functions for virDomainNetTeamingInfo
schema: separate teaming element definition from interface element
conf: parse/format <teaming> element in plain <hostdev>
qemu: plug <teaming> config from <hostdev> into qemu commandline
news: document support for <teaming> in <hostdev>
NEWS.rst | 6 ++
docs/formatdomain.rst | 51 +++++++++++
docs/schemas/domaincommon.rng | 42 +++++----
src/conf/domain_conf.c | 87 +++++++++++++------
src/conf/domain_conf.h | 13 ++-
src/conf/domain_validate.c | 45 +++++++---
src/conf/virconftypes.h | 3 +
src/libvirt_private.syms | 1 +
src/qemu/qemu_command.c | 17 ++--
src/qemu/qemu_domain.c | 2 +-
src/qemu/qemu_migration.c | 4 +-
src/qemu/qemu_validate.c | 42 ++++-----
.../net-virtio-teaming-hostdev.args | 40 +++++++++
.../net-virtio-teaming-hostdev.xml | 48 ++++++++++
tests/qemuxml2argvtest.c | 3 +
.../net-virtio-teaming-hostdev.xml | 64 ++++++++++++++
tests/qemuxml2xmltest.c | 3 +
17 files changed, 384 insertions(+), 87 deletions(-)
create mode 100644 tests/qemuxml2argvdata/net-virtio-teaming-hostdev.args
create mode 100644 tests/qemuxml2argvdata/net-virtio-teaming-hostdev.xml
create mode 100644 tests/qemuxml2xmloutdata/net-virtio-teaming-hostdev.xml
--
2.29.2
4 years, 2 months
[PATCH 0/3 V3] Linstor storage backend
by Rene Peinthor
I didn't get any feedback on V2, nor any updates if you still reviewing,
but I found myself a few issues.
First in V2 the <source/host> element wasn't optional
(which it should be) and I improved a few error messages,
because sometimes it wasn't clear from where the error
originated.
Best regards,
Rene
Rene Peinthor (3):
storage: Linstor configuration
storage: Linstor support
storage: Add tests for the Linstor storage backend
docs/schemas/storagepool.rng | 27 +
docs/storage.html.in | 39 +
include/libvirt/libvirt-storage.h | 1 +
meson.build | 6 +
meson_options.txt | 1 +
po/POTFILES.in | 1 +
src/conf/domain_conf.c | 1 +
src/conf/storage_conf.c | 13 +-
src/conf/storage_conf.h | 1 +
src/conf/virstorageobj.c | 4 +-
src/storage/meson.build | 25 +
src/storage/storage_backend.c | 6 +
src/storage/storage_backend_linstor.c | 783 ++++++++++++++++++
src/storage/storage_backend_linstor.h | 24 +
src/storage/storage_backend_linstor_priv.h | 53 ++
src/storage/storage_driver.c | 1 +
src/test/test_driver.c | 1 +
tests/linstorjsondata/broken.json | 1 +
tests/linstorjsondata/resource-group.json | 1 +
.../linstorjsondata/resource-list-test2.json | 332 ++++++++
.../storage-pools-ssdpool.json | 72 ++
tests/linstorjsondata/storage-pools.json | 192 +++++
tests/linstorjsondata/volume-def-list.json | 158 ++++
.../volume-definition-test2.json | 1 +
tests/meson.build | 6 +
tests/storagebackendlinstortest.c | 372 +++++++++
.../storagepoolcapsschemadata/poolcaps-fs.xml | 7 +
.../poolcaps-full.xml | 7 +
tests/storagepoolxml2argvtest.c | 1 +
tests/storagepoolxml2xmlin/pool-linstor.xml | 8 +
tests/storagevolxml2xmlin/vol-linstor.xml | 10 +
tools/virsh-pool.c | 3 +
32 files changed, 2156 insertions(+), 2 deletions(-)
create mode 100644 src/storage/storage_backend_linstor.c
create mode 100644 src/storage/storage_backend_linstor.h
create mode 100644 src/storage/storage_backend_linstor_priv.h
create mode 100644 tests/linstorjsondata/broken.json
create mode 100644 tests/linstorjsondata/resource-group.json
create mode 100644 tests/linstorjsondata/resource-list-test2.json
create mode 100644 tests/linstorjsondata/storage-pools-ssdpool.json
create mode 100644 tests/linstorjsondata/storage-pools.json
create mode 100644 tests/linstorjsondata/volume-def-list.json
create mode 100644 tests/linstorjsondata/volume-definition-test2.json
create mode 100644 tests/storagebackendlinstortest.c
create mode 100644 tests/storagepoolxml2xmlin/pool-linstor.xml
create mode 100644 tests/storagevolxml2xmlin/vol-linstor.xml
--
2.30.0
4 years, 2 months
[PATCH] qemu: match alias when looking for proper <interface> to detach.
by Laine Stump
Previously we only checked MAC address and PCI address (or CCW
address). This is not enough information in cases where PCI address
isn't provided and multiple interfaces have the same MAC address (for
example, a virtio + hostdev "teaming" pair - their MAC addresses are
always the same).
Resolves: https://bugzilla.redhat.com/1926190
Signed-off-by: Laine Stump <laine(a)redhat.com>
---
Arguably, it would be nice to overhaul the device matching used for
virDomainDeviceDetach for *all* the device types, as they could all be
matched by looking at alias (and PCI address, for that matter). On the
other hand, for all other device types there are already enough fields
being matched to assure a unique match even without looking at
alias/PCI address, and this patch is intended to fix a current problem
being experienced in the wild, meaning it's likely that it will need
to be backported to stable branches, and I'd rather not force
backporting a sweeping change to stable branches just to bring in a
fix for one corner case)
src/conf/domain_conf.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 07e6f39256..8f2207bdf6 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -16431,6 +16431,11 @@ virDomainNetFindIdx(virDomainDefPtr def, virDomainNetDefPtr net)
&net->info.addr.ccw))
continue;
+ if (net->info.alias &&
+ STRNEQ_NULLABLE(def->nets[i]->info.alias, net->info.alias)) {
+ continue;
+ }
+
if (matchidx >= 0) {
/* there were multiple matches on mac address, and no
* qualifying guest-side PCI/CCW address was given, so we must
--
2.29.2
4 years, 2 months
[PATCH v3 0/2] qemu: Do not use canonical path for system memory
by Michal Privoznik
v3 of:
https://listman.redhat.com/archives/libvir-list/2021-January/msg00684.html
diff to v2:
- Rebased as new capabilities and capabilities files were added since v2
- Replaced imaginary QEMU commit $HASH with actual commit hash (QEMU
part was merged meanwhile)
- Worked in Peter's review of v2
Michal Prívozník (2):
qemu_capabilities: Introduce
QEMU_CAPS_X_USE_CANONICAL_PATH_FOR_RAMBLOCK_ID
qemu: Do not Use canonical path for system memory
src/qemu/qemu_capabilities.c | 6 ++++
src/qemu/qemu_capabilities.h | 1 +
src/qemu/qemu_command.c | 35 ++++++++++++++++---
src/qemu/qemu_command.h | 3 +-
src/qemu/qemu_hotplug.c | 2 +-
.../caps_4.0.0.aarch64.xml | 1 +
.../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1 +
.../caps_4.0.0.riscv32.xml | 1 +
.../caps_4.0.0.riscv64.xml | 1 +
.../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 1 +
.../caps_4.0.0.x86_64.xml | 1 +
.../caps_4.1.0.x86_64.xml | 1 +
.../caps_4.2.0.aarch64.xml | 1 +
.../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 +
.../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 +
.../caps_4.2.0.x86_64.xml | 1 +
.../caps_5.0.0.aarch64.xml | 1 +
.../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 +
.../caps_5.0.0.riscv64.xml | 1 +
.../caps_5.0.0.x86_64.xml | 1 +
.../qemucapabilitiesdata/caps_5.1.0.sparc.xml | 1 +
.../caps_5.1.0.x86_64.xml | 1 +
.../caps_5.2.0.aarch64.xml | 1 +
.../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 1 +
.../caps_5.2.0.riscv64.xml | 1 +
.../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 1 +
.../caps_5.2.0.x86_64.xml | 1 +
.../caps_6.0.0.x86_64.xml | 1 +
.../disk-vhostuser.x86_64-latest.args | 3 +-
.../hugepages-memaccess3.x86_64-latest.args | 4 +--
30 files changed, 68 insertions(+), 9 deletions(-)
--
2.26.2
4 years, 2 months
[PATCH v2 0/2] rpc: avoid crash when system time jump back
by BiaoxiangYe
From: BiaoXiang Ye <yebiaoxiang(a)huawei.com>
Using monotonic timer instead of detecting a jump backwards
as suggested by Jano and Daniel, thanks for suggestions.
BiaoXiang Ye (2):
rpc: avoid crash when system time jump back
rpc: introduce macro MILLISECONDS_PER_SECOND
src/rpc/virkeepalive.c | 35 +++++++++++++++++++----------------
1 file changed, 19 insertions(+), 16 deletions(-)
--
2.23.0
4 years, 2 months
[libvirt PATCH] schemas: Add support for maximum CPU mode
by Jiri Denemark
Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com>
---
docs/schemas/cputypes.rng | 1 +
1 file changed, 1 insertion(+)
diff --git a/docs/schemas/cputypes.rng b/docs/schemas/cputypes.rng
index f66bc62ba7..77c8fa783b 100644
--- a/docs/schemas/cputypes.rng
+++ b/docs/schemas/cputypes.rng
@@ -9,6 +9,7 @@
<value>custom</value>
<value>host-model</value>
<value>host-passthrough</value>
+ <value>maximum</value>
</choice>
</attribute>
</define>
--
2.30.0
4 years, 2 months
[PATCH] build: Remove unused 'conflicts' key from virt_daemon_unit
by Jim Fehlig
The 'conflict' key in a virt_daemon_unit dictionary is not used when
generating systemd service and socket files. The comment associated
with the key claims the default is 'true', and a few build files
needlessly set it to 'true' when defining their virt_daemon_unit.
Remove the 'conflict' key and its use in the affect build files.
Signed-off-by: Jim Fehlig <jfehlig(a)suse.com>
---
src/interface/meson.build | 1 -
src/libxl/meson.build | 1 -
src/lxc/meson.build | 1 -
src/meson.build | 1 -
src/network/meson.build | 1 -
src/node_device/meson.build | 1 -
src/nwfilter/meson.build | 1 -
src/qemu/meson.build | 1 -
src/secret/meson.build | 1 -
src/storage/meson.build | 1 -
src/vbox/meson.build | 1 -
src/vz/meson.build | 1 -
12 files changed, 12 deletions(-)
diff --git a/src/interface/meson.build b/src/interface/meson.build
index 1092c5a267..2d4e30362c 100644
--- a/src/interface/meson.build
+++ b/src/interface/meson.build
@@ -48,7 +48,6 @@ if conf.has('WITH_INTERFACE')
'name': 'Libvirt interface',
'sockprefix': 'virtinterfaced',
'sockets': [ 'main', 'ro', 'admin' ],
- 'conflicts': true,
}
openrc_init_files += {
diff --git a/src/libxl/meson.build b/src/libxl/meson.build
index 783af6c667..9793899106 100644
--- a/src/libxl/meson.build
+++ b/src/libxl/meson.build
@@ -71,7 +71,6 @@ if conf.has('WITH_LIBXL')
'sockprefix': 'virtxend',
'sockets': [ 'main', 'ro', 'admin' ],
'deps': 'ConditionPathExists=/proc/xen/capabilities',
- 'conflicts': true,
}
openrc_init_files += {
diff --git a/src/lxc/meson.build b/src/lxc/meson.build
index f8e2a8852a..ad5c659dba 100644
--- a/src/lxc/meson.build
+++ b/src/lxc/meson.build
@@ -168,7 +168,6 @@ if conf.has('WITH_LXC')
'name': 'Libvirt lxc',
'sockprefix': 'virtlxcd',
'sockets': [ 'main', 'ro', 'admin' ],
- 'conflicts': true,
}
openrc_init_files += {
diff --git a/src/meson.build b/src/meson.build
index 74d932a32c..f13b85b74e 100644
--- a/src/meson.build
+++ b/src/meson.build
@@ -201,7 +201,6 @@ guest_unit_files = []
# * sockets - array of additional sockets (optional, default [ 'main', 'ro', 'admin' ])
# * socket_$name_in - additional socket source files (optional, default remote/libvirtd.socket.in )
# * deps - socket dependencies (optional, default '')
-# * conflicts - if the service conflicts with libvirtd (optional, true)
virt_daemon_units = []
# openrc_init_files
diff --git a/src/network/meson.build b/src/network/meson.build
index 3ec598c3f9..d6fb624bb7 100644
--- a/src/network/meson.build
+++ b/src/network/meson.build
@@ -65,7 +65,6 @@ if conf.has('WITH_NETWORK')
'name': 'Libvirt network',
'sockprefix': 'virtnetworkd',
'sockets': [ 'main', 'ro', 'admin' ],
- 'conflicts': true,
}
openrc_init_files += {
diff --git a/src/node_device/meson.build b/src/node_device/meson.build
index c4e4c3906b..15f9c3ad29 100644
--- a/src/node_device/meson.build
+++ b/src/node_device/meson.build
@@ -56,7 +56,6 @@ if conf.has('WITH_NODE_DEVICES')
'name': 'Libvirt nodedev',
'sockprefix': 'virtnodedevd',
'sockets': [ 'main', 'ro', 'admin' ],
- 'conflicts': true,
}
openrc_init_files += {
diff --git a/src/nwfilter/meson.build b/src/nwfilter/meson.build
index 715282ee77..a21e575925 100644
--- a/src/nwfilter/meson.build
+++ b/src/nwfilter/meson.build
@@ -54,7 +54,6 @@ if conf.has('WITH_NWFILTER')
'name': 'Libvirt nwfilter',
'sockprefix': 'virtnwfilterd',
'sockets': [ 'main', 'ro', 'admin' ],
- 'conflicts': true,
}
openrc_init_files += {
diff --git a/src/qemu/meson.build b/src/qemu/meson.build
index 08c1d20087..3898d23877 100644
--- a/src/qemu/meson.build
+++ b/src/qemu/meson.build
@@ -158,7 +158,6 @@ if conf.has('WITH_QEMU')
'name': 'Libvirt qemu',
'sockprefix': 'virtqemud',
'sockets': [ 'main', 'ro', 'admin' ],
- 'conflicts': true,
}
openrc_init_files += {
diff --git a/src/secret/meson.build b/src/secret/meson.build
index d576d3218e..a487055cde 100644
--- a/src/secret/meson.build
+++ b/src/secret/meson.build
@@ -37,7 +37,6 @@ if conf.has('WITH_SECRETS')
'name': 'Libvirt secret',
'sockprefix': 'virtsecretd',
'sockets': [ 'main', 'ro', 'admin' ],
- 'conflicts': true,
}
openrc_init_files += {
diff --git a/src/storage/meson.build b/src/storage/meson.build
index 153ff6f846..915ae46f61 100644
--- a/src/storage/meson.build
+++ b/src/storage/meson.build
@@ -119,7 +119,6 @@ if conf.has('WITH_STORAGE')
'name': 'Libvirt storage',
'sockprefix': 'virtstoraged',
'sockets': [ 'main', 'ro', 'admin' ],
- 'conflicts': true,
}
openrc_init_files += {
diff --git a/src/vbox/meson.build b/src/vbox/meson.build
index 3e608fa101..df0cfb40e8 100644
--- a/src/vbox/meson.build
+++ b/src/vbox/meson.build
@@ -62,7 +62,6 @@ if conf.has('WITH_VBOX')
'name': 'Libvirt vbox',
'sockprefix': 'virtvboxd',
'sockets': [ 'main', 'ro', 'admin' ],
- 'conflicts': true,
}
openrc_init_files += {
diff --git a/src/vz/meson.build b/src/vz/meson.build
index 2859dc7979..14f7280f66 100644
--- a/src/vz/meson.build
+++ b/src/vz/meson.build
@@ -52,7 +52,6 @@ if conf.has('WITH_VZ')
'name': 'Libvirt vz',
'sockprefix': 'virtvzd',
'sockets': [ 'main', 'ro', 'admin' ],
- 'conflicts': true,
}
openrc_init_files += {
--
2.29.2
4 years, 2 months
