July 2020 - Devel - libvirt List Archives

[libvirt PATCH 0/1] Use the default capabilities cache lookup rather than an arch based lookup
by Erik Skultety 03 Jul '20

03 Jul '20

https://bugzilla.redhat.com/show_bug.cgi?id=1852311 Erik Skultety (1): qemu: Use virQEMUCapsCacheLookupDefault instead of lookup by arch src/qemu/qemu_driver.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) -- 2.26.2

2 2

[libvirt-python][PATCH 0/3] Improve streams a bit
by Michal Privoznik 03 Jul '20

03 Jul '20

Inspired by patches I've sent for libvirt: https://www.redhat.com/archives/libvir-list/2020-July/msg00145.html Michal Privoznik (3): MANIFEST: Distribute sparsestream.py example virStream: Use larger buffer for sendAll/recvAll methods examples: Update sparsestream.py so that it handles block devices MANIFEST.in | 1 + examples/sparsestream.py | 73 ++++++++++++++++++++++++++--------- libvirt-override-virStream.py | 8 ++-- 3 files changed, 59 insertions(+), 23 deletions(-) -- 2.26.2

2 5

[PATCH] maint: Post-release version bump to 6.6.0
by Michal Privoznik 03 Jul '20

03 Jul '20

Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed under trivial rule. NEWS.rst | 10 ++++++++++ configure.ac | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/NEWS.rst b/NEWS.rst index 1663d11af7..7baf742e03 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -8,6 +8,16 @@ the changes introduced by each of them. For a more fine-grained view, use the `git log`_. +v6.6.0 (unreleased) +=================== + +* **New features** + +* **Improvements** + +* **Bug fixes** + + v6.5.0 (2020-07-03) =================== diff --git a/configure.ac b/configure.ac index 6c8ac2f04b..79055db9b1 100644 --- a/configure.ac +++ b/configure.ac @@ -16,7 +16,7 @@ dnl You should have received a copy of the GNU Lesser General Public dnl License along with this library. If not, see dnl <http://www.gnu.org/licenses/>. -AC_INIT([libvirt], [6.5.0], [libvir-list(a)redhat.com] [], [https://libvirt.org] +AC_INIT([libvirt], [6.6.0], [libvir-list(a)redhat.com] [], [https://libvirt.org] if test $srcdir = "." then -- 2.26.2

1 0

[PATCH v5 00/20] audio: deprecate -soundhw
by Gerd Hoffmann 02 Jul '20

02 Jul '20

v2: - use g_assert_not_reached() for stubs. - add deprecation notice. v3: - rebase to latest master. - adapt to armbru's device initialization changes. v4: - reorder patches, drop temporary -global setup, go straight to -machine pcspk-audiodev= instead. - update error messages and documentation accordingly. v5: - spell fixes (Eric). - fix mips build error. Gerd Hoffmann (20): stubs: add isa_create_simple stubs: add pci_create_simple audio: add deprecated_register_soundhw audio: deprecate -soundhw ac97 audio: deprecate -soundhw es1370 audio: deprecate -soundhw adlib audio: deprecate -soundhw cs4231a audio: deprecate -soundhw gus audio: deprecate -soundhw sb16 audio: deprecate -soundhw hda pc_basic_device_init: pass PCMachineState pc_basic_device_init: drop has_pit arg pc_basic_device_init: drop no_vmport arg softmmu: initialize spice and audio earlier audio: rework pcspk_init() audio: create pcspk device early audio: deprecate -soundhw pcspk audio: add soundhw deprecation notice pcspk: update docs/system/target-i386-desc.rst.inc audio: set default value for pcspk.iobase property include/hw/audio/pcspk.h | 12 ++---------- include/hw/audio/soundhw.h | 2 ++ include/hw/i386/pc.h | 6 +++--- hw/audio/ac97.c | 9 ++------- hw/audio/adlib.c | 8 +------- hw/audio/cs4231a.c | 8 +------- hw/audio/es1370.c | 9 ++------- hw/audio/gus.c | 8 +------- hw/audio/intel-hda.c | 3 +++ hw/audio/pcspk.c | 26 ++++++++++++++++++++++---- hw/audio/sb16.c | 9 ++------- hw/audio/soundhw.c | 24 +++++++++++++++++++++++- hw/i386/pc.c | 14 ++++++++------ hw/i386/pc_piix.c | 3 +-- hw/i386/pc_q35.c | 3 +-- hw/isa/i82378.c | 2 +- hw/mips/jazz.c | 2 +- qdev-monitor.c | 2 ++ softmmu/vl.c | 12 ++++++------ stubs/isa-bus.c | 7 +++++++ stubs/pci-bus.c | 7 +++++++ docs/system/deprecated.rst | 9 +++++++++ docs/system/target-i386-desc.rst.inc | 13 ++++++++++++- stubs/Makefile.objs | 2 ++ 24 files changed, 121 insertions(+), 79 deletions(-) create mode 100644 stubs/isa-bus.c create mode 100644 stubs/pci-bus.c -- 2.18.4

2 21

[libvirt PATCH] docs: Update CI documentation
by Andrea Bolognani 02 Jul '20

02 Jul '20

We're no longer using either Travis CI or the Jenkins-based CentOS CI, but we have started using Cirrus CI. Mention the libvirt-ci subproject as well, as a pointer for those who might want to learn more about our CI infrastructure. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- docs/ci.rst | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/docs/ci.rst b/docs/ci.rst index 2e88e06b1b..b321a67bd9 100644 --- a/docs/ci.rst +++ b/docs/ci.rst @@ -4,10 +4,14 @@ Libvirt Continuous Integration .. contents:: -The libvirt project primarily uses GitLab CI for automated testing of Linux -builds, and cross-compiled Windows builds. `Travis <https://travis-ci.org/libvirt/libvirt>`_ -is used for validating macOS builds, and `Jenkins <https://ci.centos.org/view/libvirt>`_ -is temporarily used for validating FreeBSD builds. +The libvirt project uses GitLab CI for automated testing. + +Linux builds and cross-compiled Windows builds happen on GitLab CI's shared +runners, while FreeBSD and macOS coverage is achieved by triggering `Cirrus CI +<https://cirrus-ci.com/>`_ jobs behind the scenes. + +Most of the tooling used to build CI pipelines is maintained as part of the +`libvirt-ci <https://gitlab.com/libvirt/libvirt-ci>`_ subproject. GitLab CI Dashboard =================== -- 2.25.4

2 1

[libvirt PATCH] NEWS: Update for libvirt 6.5.0
by Andrea Bolognani 02 Jul '20

02 Jul '20

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- NEWS.rst | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 0e9822cd03..499711fb18 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -47,8 +47,30 @@ v6.5.0 (unreleased) alphabetical order. Hook script in old place will be executed as first for backward compatibility. + * qemu: Add support for migratable host-passthrough CPU + + QEMU 2.12 made it possible for guests to use a migration-friendly + version of the host-passthrough CPU. This feature is now exposed by + libvirt. + * **Improvements** + * network: Support NAT with IPv6 + + It's now possible to use ``<nat ipv6="yes"/>`` in a libvirt network. + + * qemu: Auto-fill NUMA information for incomplete topologies + + If the NUMA topology is not fully described in the guest XML, libvirt + will complete it by putting all unspecified CPUs in the first NUMA node. + This is only done in the QEMU binary itself supports disjointed CPU + ranges for NUMA nodes. + + * qemu: Assign hostdev-backed interfaces to PCIe slots + + All SR-IOV capable devices are PCIe, so when their VFs are assigned to + guests they should end up in PCIe slots rather than conventional PCI ones. + * **Bug fixes** * qemu: fixed crash in ``qemuDomainBlockCommit`` @@ -61,6 +83,11 @@ v6.5.0 (unreleased) Removes the correlation between the zPCI address attributes uid and fid. Fixes the validation and autogeneration of zPCI address attributes. + * qemu: Skip pre-creation of NVMe disks during migration + + libvirt has no way to create NVMe devices on the target host, so it now + just makes sure they exist and let the migration proceed in that case. + v6.4.0 (2020-06-02) =================== -- 2.25.4

2 1

[libvirt PATCH] util: add access check for hooks to fix running as non-root
by Daniel P. Berrangé 01 Jul '20

01 Jul '20

Since feb83c1e710b9ea8044a89346f4868d03b31b0f1 libvirtd will abort on startup if run as non-root 2020-07-01 16:30:30.738+0000: 1647444: error : virDirOpenInternal:2869 : cannot open directory '/etc/libvirt/hooks/daemon.d': Permission denied The root cause flaw is that non-root libvirtd is using /etc/libvirt for its hooks. Traditionally that has been harmless though since we checked whether we could access the hook file and degraded gracefully. We need the same access check for iterating over the hook directory. Long term we should make it possible to have an unprivileged hook dir under $HOME. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/util/virhook.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/util/virhook.c b/src/util/virhook.c index 3e025fd3a6..a7ab98560c 100644 --- a/src/util/virhook.c +++ b/src/util/virhook.c @@ -171,6 +171,12 @@ virHookCheck(int no, const char *driver) } dir_path = g_strdup_printf("%s.d", path); + + if (access(dir_path, X_OK | R_OK) < 0) { + VIR_DEBUG("Hook dir %s is not accessible", dir_path); + return 1; + } + if ((ret = virDirOpenIfExists(&dir, dir_path)) < 0) return -1; @@ -415,6 +421,10 @@ virHookCall(int driver, } dir_path = g_strdup_printf("%s.d", path); + + if (access(dir_path, X_OK | R_OK) < 0) + return script_ret; + if ((ret = virDirOpenIfExists(&dir, dir_path)) < 0) return -1; -- 2.26.2

2 1

Entering freeze for libvirt-6.5.0
by Daniel Veillard 01 Jul '20

01 Jul '20

With the end of the month coming next week, it is better to enter freeze today and try to release before the July 4th long week-end in the US. I have just pushed the signed tarball and source rpm to the usual place https://libvirt.org/sources/ Seems to work fine in my very minimal tests, I hope people can do a bit of testing especially on other OSes and distro. If all goes fine I will push rc2 on Tuesday with hopefully a release of 6.5.0 on Thursday. Please give it some testing, thanks, Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

2 3

[PATCH] virnettlshelpers: Update private key
by Michal Privoznik 01 Jul '20

01 Jul '20

With the recent update of Fedora rawhide I've noticed virnettlssessiontest and virnettlscontexttest failing with: Our own certificate servercertreq-ctx.pem failed validation against cacertreq-ctx.pem: The certificate uses an insecure algorithm This is result of Fedora changes to support strong crypto [1]. RSA with 1024 bit key is viewed as legacy and thus insecure. Generate a new private key then. Moreover, switch to EC which is not only shorter but also not deprecated that often as RSA. Generated using the following command: openssl genpkey --outform PEM --out privkey.pem \ --algorithm EC --pkeyopt ec_paramgen_curve:P-384 \ --pkeyopt ec_param_enc:named_curve 1: https://fedoraproject.org/wiki/Changes/StrongCryptoSettings2 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- According to our CI all systems support ecliptic curves: https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/161932641 but maybe this should be merged only after the release? tests/virnettlshelpers.c | 20 ++++---------------- 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/tests/virnettlshelpers.c b/tests/virnettlshelpers.c index e2b8e8359a..979afed307 100644 --- a/tests/virnettlshelpers.c +++ b/tests/virnettlshelpers.c @@ -47,22 +47,10 @@ extern const ASN1_ARRAY_TYPE pkix_asn1_tab[]; gnutls_x509_privkey_t privkey; # define PRIVATE_KEY \ "-----BEGIN PRIVATE KEY-----\n" \ - "MIICdQIBADANBgkqhkiG9w0BAQEFAASCAl8wggJbAgEAAoGBALVcr\n" \ - "BL40Tm6yq88FBhJNw1aaoCjmtg0l4dWQZ/e9Fimx4ARxFpT+ji4FE\n" \ - "Cgl9s/SGqC+1nvlkm9ViSo0j7MKDbnDB+VRHDvMAzQhA2X7e8M0n9\n" \ - "rPolUY2lIVC83q0BBaOBkCj2RSmT2xTEbbC2xLukSrg2WP/ihVOxc\n" \ - "kXRuyFtzAgMBAAECgYB7slBexDwXrtItAMIH6m/U+LUpNe0Xx48OL\n" \ - "IOn4a4whNgO/o84uIwygUK27ZGFZT0kAGAk8CdF9hA6ArcbQ62s1H\n" \ - "myxrUbF9/mrLsQw1NEqpuUk9Ay2Tx5U/wPx35S3W/X2AvR/ZpTnCn\n" \ - "2q/7ym9fyiSoj86drD7BTvmKXlOnOwQJBAPOFMp4mMa9NGpGuEssO\n" \ - "m3Uwbp6lhcP0cA9MK+iOmeANpoKWfBdk5O34VbmeXnGYWEkrnX+9J\n" \ - "bM4wVhnnBWtgBMCQQC+qAEmvwcfhauERKYznMVUVksyeuhxhCe7EK\n" \ - "mPh+U2+g0WwdKvGDgO0PPt1gq0ILEjspMDeMHVdTwkaVBo/uMhAkA\n" \ - "Z5SsZyCP2aTOPFDypXRdI4eqRcjaEPOUBq27r3uYb/jeboVb2weLa\n" \ - "L1MmVuHiIHoa5clswPdWVI2y0em2IGoDAkBPSp/v9VKJEZabk9Frd\n" \ - "a+7u4fanrM9QrEjY3KhduslSilXZZSxrWjjAJPyPiqFb3M8XXA26W\n" \ - "nz1KYGnqYKhLcBAkB7dt57n9xfrhDpuyVEv+Uv1D3VVAhZlsaZ5Pp\n" \ - "dcrhrkJn2sa/+O8OKvdrPSeeu/N5WwYhJf61+CPoenMp7IFci\n" \ + "MIG2AgEAMBAGByqGSM49AgEGBSuBBAAiBIGeMIGbAgEBBDD39t6GRLeEmsYjRGR6\n" \ + "iQiIN2S4zXsgLGS/2GloXdG7K+i/3vEJDt9celZ0DfCLcG6hZANiAAQTJIe13jy7\n" \ + "k4KTXMkHQHEJa/asH263JaPL5kTbfRa6tMq3DS3pzWlOj+NHY/9JzthrKD+Ece+g\n" \ + "2g/POHa0gfXRYXGiHTs8mY0AHFqNNmF38eIVGjOqobIi90MkyI3wx4g=\n" \ "-----END PRIVATE KEY-----\n" /* -- 2.26.2

2 2

[libvirt PATCH v3 0/1] cirrus: Add templates and refresh script
by Andrea Bolognani 01 Jul '20

01 Jul '20

This makes the Cirrus CI configurations as maintainable as the Dockerfiles, by shifting the responsability of keeping the list of dependencies and other details up to date to lcitool. Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/161289292 For the refresh script to work, your copy of lcitool needs to include these patches: https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/30 Changes from [v2]: * 'lcitool dockerfile --variables' has been replaced with 'lcitool variables'. Changes from [v1]: * reduce duplication by only storing variables in the git repository and instantiating the template at runtime. [v2] https://www.redhat.com/archives/libvir-list/2020-June/msg01318.html [v1] https://www.redhat.com/archives/libvir-list/2020-June/msg01305.html Andrea Bolognani (1): cirrus: Generate jobs dynamically .gitlab-ci.yml | 36 ++++++++++++++- ci/cirrus/build.yml | 26 +++++++++++ ci/cirrus/freebsd-12.yml.j2 | 73 ------------------------------- ci/cirrus/libvirt-freebsd-12.vars | 7 +++ ci/cirrus/libvirt-macos-1015.vars | 7 +++ ci/cirrus/macos-1015.yml.j2 | 38 ---------------- ci/cirrus/refresh | 22 ++++++++++ 7 files changed, 97 insertions(+), 112 deletions(-) create mode 100644 ci/cirrus/build.yml delete mode 100644 ci/cirrus/freebsd-12.yml.j2 create mode 100644 ci/cirrus/libvirt-freebsd-12.vars create mode 100644 ci/cirrus/libvirt-macos-1015.vars delete mode 100644 ci/cirrus/macos-1015.yml.j2 create mode 100755 ci/cirrus/refresh -- 2.25.4

2 2