March 2020 - Devel - libvirt List Archives

[PATCH] qemu_agent.c: Use g_autofree in qemu_agent.c
by Seeteena Thoufeek 27 Mar '20

27 Mar '20

This is the only instance of g_autofree change applicable for qemu_agent.c Signed-off-by: Seeteena Thoufeek <s1seetee(a)linux.vnet.ibm.com> --- src/qemu/qemu_agent.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index 95a7d9b..c74bd0e 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -1083,7 +1083,7 @@ qemuAgentCommandFull(qemuAgentPtr agent, { int ret = -1; qemuAgentMessage msg; - char *cmdstr = NULL; + g_autofree char *cmdstr = NULL; int await_event = agent->await_event; *reply = NULL; @@ -1133,7 +1133,6 @@ qemuAgentCommandFull(qemuAgentPtr agent, ret = qemuAgentCheckError(cmd, *reply, report_unsupported); cleanup: - VIR_FREE(cmdstr); VIR_FREE(msg.txBuffer); agent->await_event = QEMU_AGENT_EVENT_NONE; -- 1.8.3.1

2 1

[PATCH] bhyve: fix typo in struct field accessor
by Daniel P. Berrangé 27 Mar '20

27 Mar '20

This fixes a FreeBSD build error from commit a11a0e6e8473fec6127b263a33f892135097648f Author: Rafael Fonseca <r4f4rfs(a)gmail.com> Date: Tue Mar 24 17:14:30 2020 +0100 bhyve: move video default logic to driver Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed as build fix src/bhyve/bhyve_domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/bhyve/bhyve_domain.c b/src/bhyve/bhyve_domain.c index 40ee461b19..95d6ffd31c 100644 --- a/src/bhyve/bhyve_domain.c +++ b/src/bhyve/bhyve_domain.c @@ -162,8 +162,8 @@ bhyveDomainDeviceDefPostParse(virDomainDeviceDefPtr dev, } if (dev->type == VIR_DOMAIN_DEVICE_VIDEO && - dev->data.video.type == VIR_DOMAIN_VIDEO_TYPE_DEFAULT) { - dev->data.video.type = VIR_DOMAIN_VIDEO_TYPE_GOP; + dev->data.video->type == VIR_DOMAIN_VIDEO_TYPE_DEFAULT) { + dev->data.video->type = VIR_DOMAIN_VIDEO_TYPE_GOP; } return 0; -- 2.24.1

1 0

[PATCH] qemuCheckpointCreateXML: Check VM liveness first
by Peter Krempa 27 Mar '20

27 Mar '20

Move the liveness check prior to the capability check. If the VM is offline the capabilities are not initialized and thus we'd report the wrong error. https://bugzilla.redhat.com/show_bug.cgi?id=1812531 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_checkpoint.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_checkpoint.c b/src/qemu/qemu_checkpoint.c index 62b6e87b53..3a510c9780 100644 --- a/src/qemu/qemu_checkpoint.c +++ b/src/qemu/qemu_checkpoint.c @@ -647,15 +647,15 @@ qemuCheckpointCreateXML(virDomainPtr domain, update_current = false; } - if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_INCREMENTAL_BACKUP)) { + if (!virDomainObjIsActive(vm)) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", - _("incremental backup is not supported yet")); + _("cannot create checkpoint for inactive domain")); return NULL; } - if (!virDomainObjIsActive(vm)) { + if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_INCREMENTAL_BACKUP)) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", - _("cannot create checkpoint for inactive domain")); + _("incremental backup is not supported yet")); return NULL; } -- 2.24.1

2 2

[PATCH 0/2] Two incremental backup related fixes
by Peter Krempa 27 Mar '20

27 Mar '20

Peter Krempa (2): qemuCheckpointDelete: Check VM liveness first qemuBackupBegin: Fix monitor access when rolling back due to failure src/qemu/qemu_backup.c | 2 +- src/qemu/qemu_checkpoint.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) -- 2.24.1

2 5

[libvirt-dockerfiles PATCH] trigger: Fetch Dockerfiles from GitLab
by Andrea Bolognani 27 Mar '20

27 Mar '20

We're moving libvirt development to GitLab, so it makes sense that we'd fetch Dockerfiles from there rather than GitHub going forward. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- trigger | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/trigger b/trigger index d2e853d..4e71d32 100755 --- a/trigger +++ b/trigger @@ -16,7 +16,7 @@ test "$outfile" || usage while read zip do repository="${zip%.zip}" - url="https://github.com/libvirt/libvirt-dockerfiles/raw/master/$zip" + url="https://gitlab.com/libvirt/libvirt-dockerfiles/-/raw/master/$zip" "$QUAYADMIN" create-build libvirt "$repository" "$url" -- 2.25.1

2 1

[libvirt-dockerfiles PATCH] Refresh after adding ccache and dwarves to CentOS
by Andrea Bolognani 26 Mar '20

26 Mar '20

The corresponding libvirt-jenkins-ci commit is cb8a5cc98818. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed under the Dockerfile refresh rule. buildenv-libosinfo-centos-7.zip | Bin 1659 -> 1665 bytes buildenv-libosinfo-centos-8.zip | Bin 589 -> 594 bytes buildenv-libvirt-centos-7.zip | Bin 1878 -> 1888 bytes buildenv-libvirt-centos-8.zip | Bin 793 -> 802 bytes 4 files changed, 0 insertions(+), 0 deletions(-) diff --git a/buildenv-libosinfo-centos-7.zip b/buildenv-libosinfo-centos-7.zip index 454ce5c..e4f5b87 100644 --- a/buildenv-libosinfo-centos-7.zip +++ b/buildenv-libosinfo-centos-7.zip @@ -38,6 +38,7 @@ WEiJKtQrZDJloqtyi/mmRa1VsV7RYR0VPJjhK/R8EQ7Ysshy\n\ bash \ bash-completion \ ca-certificates \ + ccache \ check-devel \ chrony \ gcc \ diff --git a/buildenv-libosinfo-centos-8.zip b/buildenv-libosinfo-centos-8.zip index 11621ba..53a49d0 100644 --- a/buildenv-libosinfo-centos-8.zip +++ b/buildenv-libosinfo-centos-8.zip @@ -10,6 +10,7 @@ RUN dnf install 'dnf-command(config-manager)' -y && \ bash \ bash-completion \ ca-certificates \ + ccache \ check-devel \ chrony \ gcc \ diff --git a/buildenv-libvirt-centos-7.zip b/buildenv-libvirt-centos-7.zip index c50693d..96cd758 100644 --- a/buildenv-libvirt-centos-7.zip +++ b/buildenv-libvirt-centos-7.zip @@ -41,11 +41,13 @@ WEiJKtQrZDJloqtyi/mmRa1VsV7RYR0VPJjhK/R8EQ7Ysshy\n\ bash \ bash-completion \ ca-certificates \ + ccache \ chrony \ cyrus-sasl-devel \ dbus-devel \ device-mapper-devel \ dnsmasq \ + dwarves \ ebtables \ fuse-devel \ gcc \ diff --git a/buildenv-libvirt-centos-8.zip b/buildenv-libvirt-centos-8.zip index a81abce..a63524b 100644 --- a/buildenv-libvirt-centos-8.zip +++ b/buildenv-libvirt-centos-8.zip @@ -13,11 +13,13 @@ RUN dnf install 'dnf-command(config-manager)' -y && \ bash \ bash-completion \ ca-certificates \ + ccache \ chrony \ cyrus-sasl-devel \ dbus-devel \ device-mapper-devel \ dnsmasq \ + dwarves \ ebtables \ fuse-devel \ gcc \ -- 2.25.1

1 0

[libvirt PATCH v2 0/9] gitlab: expand the CI job coverage (RESEND)
by Daniel P. Berrangé 26 Mar '20

26 Mar '20

There are main goals with this series - Introduce a minimal job building the website and publishing an artifact which can be deployed onto libvirt.org - Introduce a minimal job building the libvirt.pot for import into Weblate (only runs on git master branch) - Expanding CI jobs to get coverage closer to Travis/Jenkins - Reducing cross-build jobs to just interesting variants, since the full set hasn't shown value in detecting failures The Linux native job coverage is now a superset of that achieved by Travis/Jenkins. For post-merge testing the full set of jobs are run on git master (measured approx 50 minutes total duration) For pre-merge testing the Linux job count is reduced for quicker turnaround time for developers (measured ~35 minutes total duration) Changed in v2: - Add more native test jobs to run on git master - Restrict git clone depth - User variable for "make" command name - Add test job to build the master pot file - Remove extra configure args for website job - Re-ordered patches to reduce repeated changes Daniel P. Berrangé (9): gitlab: use CI for building website contents gitlab: reduce number of cross-build CI jobs gitlab: group jobs into stages gitlab: rename the cross build jobs gitlab: add mingw cross build CI jobs gitlab: add x86_64 native CI jobs gitlab: add variable for make command name gitlab: restrict git history to 100 commits gitlab: add job for building latest potfile .gitlab-ci.yml | 178 ++++++++++++++++++++++++++++++++++++++++--------- 1 file changed, 148 insertions(+), 30 deletions(-) -- 2.24.1

3 44

Question: building libvirt into the buildroot. Error *** No rule to make target `keycodemapdb/data/keymaps.csv'
by Komarov Egor 26 Mar '20

26 Mar '20

Hello! I'm tying to build libvirt into the buildroot project. When I build libvirt I have an error make[3]: Entering directory `/home/zoadmin/BRAIN4NET/buildroot/buildroot-2018.02.2/output/build/libvirt-v6.1.0/src' make[3]: *** No rule to make target `keycodemapdb/data/keymaps.csv', needed by `util/virkeycodetable_linux.h'. Stop. Please, Help me) What I do incorrect ? I tried build branch 6.1 and master. Completely build.log in attach. Thank you! P.S. My package/libvirt/libvirt.mk into the buildroot [zoadmin@BuildPC-SPECOS buildroot-2018.02.2]$ cat package/libvirt/libvirt.mk ###################################################################### # # # libvirt # # ##################################################################### LIBVIRT_VERSION = v6.1.0 #LIBVIRT_SOURCE = LIBVIRT_SITE = https://github.com/libvirt/libvirt LIBVIRT_SITE_METHOD = git LIBVIRT_AUTORECONF = YES LIBVIRT_CONF_OPTS = -prefix=/usr --sysconfdir=/etc --localstatedir=/var --with-storage-mpath=no LIBVIRT_INSTALL_TARGET = YES LIBVIRT_DEPENDENCIES = gnutls kvmtool qemu linux libxml2 libpciaccess libxslt libnl host-libxslt host-python-rst2html5 host-python-docutils host-python3 define LIBVIRT_PRE_CONFIGURE_GNU cd $(@D); ./bootstrap endef define LIBVIRT_PRE_CONFIGURE_DELETE_STRING cd $(@D); sed -i "21,24d" ./configure.ac # sed -i "3413,3416d" ./configure endef #LIBVIRT_PRE_CONFIGURE_HOOKS += LIBVIRT_PRE_CONFIGURE_GNU LIBVIRT_PRE_CONFIGURE_HOOKS += LIBVIRT_PRE_CONFIGURE_DELETE_STRING $(eval $(autotools-package)) fd ______________________________________________________________________________________ С уважением, Комаров Егор Инженер Департамента специальных работ (ДСР), АО <ЭЛВИС-ПЛЮС> тел. +7 (495) 276-02-11 доб.175 [cid:image003.jpg@01D602B6.5C6B7D20] www.elvis.ru<http://www.elvis.ru/>

2 5

[jenkins-ci PATCH] guests: enable ccache on CentOS installs
by Daniel P. Berrangé 26 Mar '20

26 Mar '20

Since we enabled use of EPEL in our CentOS installs, we should pull in the ccache package to speed up builds. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- guests/vars/mappings.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index 9833856..0f7af48 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -111,7 +111,6 @@ mappings: ccache: default: ccache - CentOS: check: default: check -- 2.24.1

2 1

[PATCH] rng: Interleave elements in source
by Han Han 26 Mar '20

26 Mar '20

Signed-off-by: Han Han <hhan(a)redhat.com> --- docs/schemas/domaincommon.rng | 350 ++++++++++++++++++---------------- 1 file changed, 186 insertions(+), 164 deletions(-) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index d79dee65..96eccaad 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -1642,21 +1642,23 @@ </optional> <optional> <element name="source"> - <optional> - <attribute name="file"> - <ref name="absFilePath"/> - </attribute> - </optional> - <ref name="diskSourceCommon"/> - <optional> - <ref name="storageStartupPolicy"/> - </optional> - <optional> - <ref name="encryption"/> - </optional> - <zeroOrMore> - <ref name='devSeclabel'/> - </zeroOrMore> + <interleave> + <optional> + <attribute name="file"> + <ref name="absFilePath"/> + </attribute> + </optional> + <ref name="diskSourceCommon"/> + <optional> + <ref name="storageStartupPolicy"/> + </optional> + <optional> + <ref name="encryption"/> + </optional> + <zeroOrMore> + <ref name='devSeclabel'/> + </zeroOrMore> + </interleave> </element> </optional> </define> @@ -1667,24 +1669,26 @@ </attribute> <optional> <element name="source"> - <optional> - <attribute name="dev"> - <ref name="absFilePath"/> - </attribute> - </optional> - <ref name="diskSourceCommon"/> - <optional> - <ref name="storageStartupPolicy"/> - </optional> - <optional> - <ref name="encryption"/> - </optional> - <optional> - <ref name="reservations"/> - </optional> - <zeroOrMore> - <ref name='devSeclabel'/> - </zeroOrMore> + <interleave> + <optional> + <attribute name="dev"> + <ref name="absFilePath"/> + </attribute> + </optional> + <ref name="diskSourceCommon"/> + <optional> + <ref name="storageStartupPolicy"/> + </optional> + <optional> + <ref name="encryption"/> + </optional> + <optional> + <ref name="reservations"/> + </optional> + <zeroOrMore> + <ref name='devSeclabel'/> + </zeroOrMore> + </interleave> </element> </optional> </define> @@ -1695,17 +1699,19 @@ </attribute> <optional> <element name="source"> - <attribute name="dir"> - <ref name="absFilePath"/> - </attribute> - <ref name="diskSourceCommon"/> - <optional> - <ref name="storageStartupPolicy"/> - </optional> - <optional> - <ref name="encryption"/> - </optional> - <empty/> + <interleave> + <attribute name="dir"> + <ref name="absFilePath"/> + </attribute> + <ref name="diskSourceCommon"/> + <optional> + <ref name="storageStartupPolicy"/> + </optional> + <optional> + <ref name="encryption"/> + </optional> + <empty/> + </interleave> </element> </optional> </define> @@ -1856,138 +1862,152 @@ <define name="diskSourceNetworkProtocolHTTPS"> <element name="source"> - <attribute name="protocol"> - <choice> - <value>https</value> - </choice> - </attribute> - <attribute name="name"/> - <ref name="diskSourceCommon"/> - <ref name="diskSourceNetworkHost"/> - <optional> - <ref name="encryption"/> - </optional> - <optional> - <ref name="diskSourceNetworkProtocolSSLVerify"/> - </optional> - <optional> - <ref name="diskSourceNetworkProtocolHTTPCookies"/> - </optional> - <ref name="diskSourceNetworkProtocolPropsCommon"/> + <interleave> + <attribute name="protocol"> + <choice> + <value>https</value> + </choice> + </attribute> + <attribute name="name"/> + <ref name="diskSourceCommon"/> + <ref name="diskSourceNetworkHost"/> + <optional> + <ref name="encryption"/> + </optional> + <optional> + <ref name="diskSourceNetworkProtocolSSLVerify"/> + </optional> + <optional> + <ref name="diskSourceNetworkProtocolHTTPCookies"/> + </optional> + <ref name="diskSourceNetworkProtocolPropsCommon"/> + </interleave> </element> </define> <define name="diskSourceNetworkProtocolHTTP"> <element name="source"> - <attribute name="protocol"> - <choice> - <value>http</value> - </choice> - </attribute> - <attribute name="name"/> - <ref name="diskSourceCommon"/> - <ref name="diskSourceNetworkHost"/> - <optional> - <ref name="encryption"/> - </optional> - <optional> - <ref name="diskSourceNetworkProtocolHTTPCookies"/> - </optional> - <ref name="diskSourceNetworkProtocolPropsCommon"/> + <interleave> + <attribute name="protocol"> + <choice> + <value>http</value> + </choice> + </attribute> + <attribute name="name"/> + <ref name="diskSourceCommon"/> + <ref name="diskSourceNetworkHost"/> + <optional> + <ref name="encryption"/> + </optional> + <optional> + <ref name="diskSourceNetworkProtocolHTTPCookies"/> + </optional> + <ref name="diskSourceNetworkProtocolPropsCommon"/> + </interleave> </element> </define> <define name="diskSourceNetworkProtocolFTPS"> <element name="source"> - <attribute name="protocol"> - <choice> - <value>ftps</value> - </choice> - </attribute> - <attribute name="name"/> - <ref name="diskSourceCommon"/> - <ref name="diskSourceNetworkHost"/> - <optional> - <ref name="encryption"/> - </optional> - <optional> - <ref name="diskSourceNetworkProtocolSSLVerify"/> - </optional> - <ref name="diskSourceNetworkProtocolPropsCommon"/> + <interleave> + <attribute name="protocol"> + <choice> + <value>ftps</value> + </choice> + </attribute> + <attribute name="name"/> + <ref name="diskSourceCommon"/> + <ref name="diskSourceNetworkHost"/> + <optional> + <ref name="encryption"/> + </optional> + <optional> + <ref name="diskSourceNetworkProtocolSSLVerify"/> + </optional> + <ref name="diskSourceNetworkProtocolPropsCommon"/> + </interleave> </element> </define> <define name="diskSourceNetworkProtocolSimple"> <element name="source"> - <attribute name="protocol"> - <choice> - <value>sheepdog</value> - <value>ftp</value> - <value>tftp</value> - </choice> - </attribute> - <attribute name="name"/> - <ref name="diskSourceCommon"/> - <ref name="diskSourceNetworkHost"/> - <optional> - <ref name="encryption"/> - </optional> - <ref name="diskSourceNetworkProtocolPropsCommon"/> + <interleave> + <attribute name="protocol"> + <choice> + <value>sheepdog</value> + <value>ftp</value> + <value>tftp</value> + </choice> + </attribute> + <attribute name="name"/> + <ref name="diskSourceCommon"/> + <ref name="diskSourceNetworkHost"/> + <optional> + <ref name="encryption"/> + </optional> + <ref name="diskSourceNetworkProtocolPropsCommon"/> + </interleave> </element> </define> <define name="diskSourceNetworkProtocolNBD"> <element name="source"> - <attribute name="protocol"> - <value>nbd</value> - </attribute> - <optional> - <attribute name="name"/> - </optional> - <optional> - <attribute name="tls"> - <ref name="virYesNo"/> + <interleave> + <attribute name="protocol"> + <value>nbd</value> </attribute> - </optional> - <ref name="diskSourceCommon"/> - <ref name="diskSourceNetworkHost"/> - <optional> - <ref name="encryption"/> - </optional> + <optional> + <attribute name="name"/> + </optional> + <optional> + <attribute name="tls"> + <ref name="virYesNo"/> + </attribute> + </optional> + <ref name="diskSourceCommon"/> + <ref name="diskSourceNetworkHost"/> + <optional> + <ref name="encryption"/> + </optional> + </interleave> </element> </define> <define name="diskSourceNetworkProtocolGluster"> <element name="source"> - <attribute name="protocol"> - <value>gluster</value> - </attribute> - <attribute name="name"/> - <ref name="diskSourceCommon"/> - <oneOrMore> - <ref name="diskSourceNetworkHost"/> - </oneOrMore> - <optional> - <ref name="encryption"/> - </optional> + <interleave> + <attribute name="protocol"> + <value>gluster</value> + </attribute> + <attribute name="name"/> + <ref name="diskSourceCommon"/> + <oneOrMore> + <ref name="diskSourceNetworkHost"/> + </oneOrMore> + <optional> + <ref name="encryption"/> + </optional> + </interleave> </element> </define> <define name="diskSourceNetworkProtocolVxHS"> <element name="source"> - <attribute name="protocol"> - <choice> - <value>vxhs</value> - </choice> - </attribute> - <attribute name="name"/> - <ref name="diskSourceCommon"/> - <optional> - <attribute name="tls"> - <ref name="virYesNo"/> + <interleave> + <attribute name="protocol"> + <choice> + <value>vxhs</value> + </choice> </attribute> - </optional> - <ref name="diskSourceNetworkHost"/> + <attribute name="name"/> + <ref name="diskSourceCommon"/> + <optional> + <attribute name="tls"> + <ref name="virYesNo"/> + </attribute> + </optional> + <ref name="diskSourceNetworkHost"/> + </interleave> </element> </define> @@ -2048,27 +2068,29 @@ </attribute> <optional> <element name="source"> - <attribute name="type"> - <value>pci</value> - </attribute> - <attribute name="namespace"> - <ref name="uint32"/> - </attribute> - <optional> - <attribute name="managed"> - <ref name="virYesNo"/> + <interleave> + <attribute name="type"> + <value>pci</value> </attribute> - </optional> - <element name="address"> - <ref name="pciaddress"/> - </element> - <ref name="diskSourceCommon"/> - <optional> - <ref name="storageStartupPolicy"/> - </optional> - <optional> - <ref name="encryption"/> - </optional> + <attribute name="namespace"> + <ref name="uint32"/> + </attribute> + <optional> + <attribute name="managed"> + <ref name="virYesNo"/> + </attribute> + </optional> + <element name="address"> + <ref name="pciaddress"/> + </element> + <ref name="diskSourceCommon"/> + <optional> + <ref name="storageStartupPolicy"/> + </optional> + <optional> + <ref name="encryption"/> + </optional> + </interleave> </element> </optional> </define> -- 2.25.0

2 1