March 2020 - Devel - libvirt List Archives

[libvirt PATCH 0/4] src: add configurable support for cgroups usage
by Daniel P. Berrangé 21 Mar '20

21 Mar '20

This simple series allows apps to choose how cgroups are managed by libvirt, between cgroupfs and machined, or disabled entirely. Daniel P. Berrangé (4): conf: allow different resource registration modes util: allow choice between machined or direct cgroups filesystem qemu: wire up support for controlling use of cgroups backend lxc: wire up support for controlling use of cgroups backend docs/formatdomain.html.in | 24 +++++++- docs/schemas/domaincommon.rng | 17 +++++- src/conf/domain_conf.c | 46 ++++++++++++---- src/conf/domain_conf.h | 13 +++++ src/libvirt_private.syms | 2 + src/lxc/lxc_cgroup.c | 32 +++++++++++ src/lxc/lxc_cgroup.h | 3 + src/lxc/lxc_process.c | 7 ++- src/qemu/qemu_cgroup.c | 67 +++++++++++++++++++++-- src/qemu/qemu_command.c | 9 +-- src/util/vircgroup.c | 57 ++++++++++++------- src/util/vircgroup.h | 7 +++ tests/lxcxml2xmldata/lxc-capabilities.xml | 2 +- tests/lxcxml2xmldata/lxc-idmap.xml | 2 +- 14 files changed, 239 insertions(+), 49 deletions(-) -- 2.24.1

3 13

[libvirt PATCH] docs: virtiofs: add missing aposthrophe
by Ján Tomko 20 Mar '20

20 Mar '20

Signed-off-by: Ján Tomko <jtomko(a)redhat.com> Reported-by: Dr. David Alan Gilbert <dgilbert(a)redhat.com> --- I pushed this on Monday, but forgot to send the e-mail. docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index b6ddfa8e0c..594146009d 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -3981,7 +3981,7 @@ <readonly/> </filesystem> <filesystem type='mount' accessmode='passthrough'> - <driver type='virtiofs queue='1024'/> + <driver type='virtiofs' queue='1024'/> <binary path='/usr/libexec/virtiofsd' xattr='on'> <cache mode='always'/> <lock posix='on' flock='on'/> -- 2.24.1

1 0

listen type socket support for rdp graphics
by Vasiliy Tolstov 20 Mar '20

20 Mar '20

Hi! How hard implement listen type socket support for rdp graphics? VNC and SPICE already have such options? And does this support for rdp available for qemu driver? (I need to access qemu vm via rdp) Thanks! -- Vasiliy Tolstov, e-mail: v.tolstov(a)selfip.ru

2 2

[PATCH] qemu: reset await_event in all error paths in qemuAgentCommand
by Nikolay Shirokovskiy 20 Mar '20

20 Mar '20

A fixup to patch [1]. We need to reset await_event in all error paths. [1] 52532073d : qemu: remove redundant needReply argument of qemuAgentCommand Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com> --- src/qemu/qemu_agent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index 9ea2c59..6ff5b11 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -1113,7 +1113,7 @@ qemuAgentCommand(qemuAgentPtr agent, } if (qemuAgentGuestSync(agent) < 0) - return -1; + goto cleanup; if (!(cmdstr = virJSONValueToString(cmd, false))) goto cleanup; -- 1.8.3.1

2 1

[PATCH 0/6] Parse back some legacy backing store strings
by Peter Krempa 20 Mar '20

20 Mar '20

See patch 4 for code and 6 for what we try to parse back. Peter Krempa (6): virBitmapNewEmpty: Use g_new0 to allocate and remove error checking virJSONValueObjectDeflattenWorker: Refactor cleanup util: json: Extract deflattening of keys into a separate function virjson: Deflatten arrays generated by the json->commandline generator jsontest: Add test cases for deflattening of arrays tests: virstoragetest: validate that array deflattening works for gluster src/util/virbitmap.c | 14 +-- src/util/virhostcpu.c | 6 +- src/util/virjson.c | 105 ++++++++++++++---- src/util/virtpm.c | 3 +- tests/virbitmaptest.c | 8 +- .../deflatten-dotted-array-in.json | 27 +++++ .../deflatten-dotted-array-out.json | 43 +++++++ tests/virjsontest.c | 1 + tests/virstoragetest.c | 18 +++ 9 files changed, 182 insertions(+), 43 deletions(-) create mode 100644 tests/virjsondata/deflatten-dotted-array-in.json create mode 100644 tests/virjsondata/deflatten-dotted-array-out.json -- 2.24.1

2 7

[PATCH] Minor doc fix
by Sebastian Mitterle 19 Mar '20

19 Mar '20

1. Fix link to knowledge base article 2. Use <h1> to make sure kbase.html has page title Signed-off-by Sebastian Mitterle <smitterl(a)redhat.com> --- docs/formatbackup.html.in | 2 +- docs/kbase.html.in | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/formatbackup.html.in b/docs/formatbackup.html.in index 543d913072..55acd13ddc 100644 --- a/docs/formatbackup.html.in +++ b/docs/formatbackup.html.in @@ -14,7 +14,7 @@ description of the actions to perform, as well as an optional second XML document <a href="formatcheckpoint.html">describing a checkpoint</a> to create at the same point in time. See - also <a href="domainstatecapture.html">a comparison</a> between + also <a href="kbase/domainstatecapture.html">a comparison</a> between the various state capture APIs. </p> <p> diff --git a/docs/kbase.html.in b/docs/kbase.html.in index 7055f4fda4..c586e0f676 100644 --- a/docs/kbase.html.in +++ b/docs/kbase.html.in @@ -2,7 +2,7 @@ <!DOCTYPE html> <html xmlns="http://www.w3.org/1999/xhtml"> <body class="docs"> - <h2>Knowledge base</h2> + <h1>Knowledge base</h1> <div class="panel"> <dl> -- 2.21.0

2 1

[PULL v2 00/11] Bitmaps patches
by John Snow 19 Mar '20

19 Mar '20

The following changes since commit d649689a8ecb2e276cc20d3af6d416e3c299cb17: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2020-03-17 18:33:05 +0000) are available in the Git repository at: https://github.com/jnsnow/qemu.git tags/bitmaps-pull-request for you to fetch changes up to 2d00cbd8e222a4adc08f415c399e84590ee8ff9a: block/qcow2-bitmap: use bdrv_dirty_bitmap_next_dirty (2020-03-18 14:03:46 -0400) ---------------------------------------------------------------- Pull request ---------------------------------------------------------------- Eric Blake (1): build: Silence clang warning on older glib autoptr usage Vladimir Sementsov-Ogievskiy (10): hbitmap: assert that we don't create bitmap larger than INT64_MAX hbitmap: move hbitmap_iter_next_word to hbitmap.c hbitmap: unpublish hbitmap_iter_skip_words hbitmap: drop meta bitmaps as they are unused block/dirty-bitmap: switch _next_dirty_area and _next_zero to int64_t block/dirty-bitmap: add _next_dirty API block/dirty-bitmap: improve _next_dirty_area API nbd/server: introduce NBDExtentArray nbd/server: use bdrv_dirty_bitmap_next_dirty_area block/qcow2-bitmap: use bdrv_dirty_bitmap_next_dirty configure | 20 +++ include/block/dirty-bitmap.h | 9 +- include/qemu/hbitmap.h | 95 +++-------- block/dirty-bitmap.c | 16 +- block/qcow2-bitmap.c | 15 +- nbd/server.c | 251 ++++++++++++++-------------- tests/test-hbitmap.c | 316 +++++++++++++---------------------- util/hbitmap.c | 134 +++++++++------ 8 files changed, 395 insertions(+), 461 deletions(-) -- 2.21.1

2 13

[PATCH] qemu: Don't crash when getting targets for a multipath
by Michal Privoznik 19 Mar '20

19 Mar '20

In one of my previous commits I've introduced code that creates all devices for given (possible) multipath target. But I've made a mistake there - the code accesses src->path without checking if the disk source is local. Note that the path is NULL if the source is not local. Fixes: a30078cb832646177defd256e77c632905f1e6d0 Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1814947 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_domain.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 0e2252f6cf..ef17829235 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -15862,19 +15862,19 @@ qemuDomainNamespaceSetupDisk(virDomainObjPtr vm, } tmpPath = g_strdup(next->path); + + if (virDevMapperGetTargets(next->path, &targetPaths) < 0 && + errno != ENOSYS && errno != EBADF) { + virReportSystemError(errno, + _("Unable to get devmapper targets for %s"), + next->path); + return -1; + } } if (virStringListAdd(&paths, tmpPath) < 0) return -1; - if (virDevMapperGetTargets(next->path, &targetPaths) < 0 && - errno != ENOSYS && errno != EBADF) { - virReportSystemError(errno, - _("Unable to get devmapper targets for %s"), - next->path); - return -1; - } - if (virStringListMerge(&paths, &targetPaths) < 0) return -1; } -- 2.24.1

4 4

[PATCH 0/2] Fix wrong copy of encryption 'usage' string
by Peter Krempa 19 Mar '20

19 Mar '20

Copying the pointer caused double-free when clearing the domain object. Peter Krempa (2): virSecretLookupDefCopy: Remove return value virStorageEncryptionSecretCopy: Properly copy internals src/util/virsecret.c | 3 +-- src/util/virsecret.h | 4 ++-- src/util/virstorageencryption.c | 8 +++----- src/util/virstoragefile.c | 3 +-- 4 files changed, 7 insertions(+), 11 deletions(-) -- 2.24.1

3 7

[PATCH 0/4] qemu: Fix usage of 'slice' and 'luks'
by Peter Krempa 19 Mar '20

19 Mar '20

We special cased some behaviour and it broke on combination with other special case. Peter Krempa (4): qemuxml2argvdata/disk-slices: Add test case for 'luks' encryption qemu: block: Extract logic decision when to use a separate 'raw' layer for slice qemuBlockStorageSourceNeedsStorageSliceLayer: Deal with 'luks' files qemu: block: Split up formatting of JSON props for 'raw' and 'luks' drivers src/qemu/qemu_block.c | 70 ++++++++++++++----- src/qemu/qemu_block.h | 3 + src/qemu/qemu_domain.c | 3 +- .../disk-slices.x86_64-latest.args | 41 +++++++---- tests/qemuxml2argvdata/disk-slices.xml | 13 ++++ .../disk-slices.x86_64-latest.xml | 16 ++++- 6 files changed, 112 insertions(+), 34 deletions(-) -- 2.24.1

2 5