October 2020 - Devel - libvirt List Archives

[libvirt PATCH 00/10] use g_autoptr with cgroups (glib chronicles)
by Pavel Hrdina 09 Oct '20

09 Oct '20

Pavel Hrdina (10): qemu_cgroup: introduce qemuRestoreCgroupThread helper util: vircgroup: use GLib alloc functions util: vircgroup: change virCgroupFree to take only virCgroupPtr util: vircgroup: introduce g_autoptr() for virCgroup libvirt-lxc: use g_autoptr for virCgroup lxc: use g_autoptr for virCgroup qemu: use g_autoptr for virCgroup util: use g_autoptr for virCgroup tests: use g_autoptr for virCgroup tools: use g_autoptr for virCgroup src/libvirt-lxc.c | 5 +- src/lxc/lxc_cgroup.c | 20 +-- src/lxc/lxc_container.c | 37 ++--- src/lxc/lxc_controller.c | 2 +- src/lxc/lxc_domain.c | 2 +- src/lxc/lxc_process.c | 9 +- src/qemu/qemu_cgroup.c | 87 ++++++----- src/qemu/qemu_domain.c | 3 +- src/qemu/qemu_driver.c | 139 ++++++------------ src/qemu/qemu_process.c | 2 +- src/util/vircgroup.c | 198 +++++++++++-------------- src/util/vircgroup.h | 4 +- src/util/vircgroupv1.c | 9 +- tests/vircgrouptest.c | 236 +++++++++++------------------- tools/virt-host-validate-common.c | 4 +- 15 files changed, 305 insertions(+), 452 deletions(-) -- 2.26.2

2 13

[libvirt PATCH] remote: remove leftover goto
by Ján Tomko 09 Oct '20

09 Oct '20

Signed-off-by: Ján Tomko <jtomko(a)redhat.com> Reported-by: John Ferlan <jferlan(a)redhat.com> Fixes: 8487595bee0c04e56b0d8e866c5c71318faf1689 Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- /me gets the paper bag src/remote/remote_driver.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 49769ac04d..d318224605 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -7636,7 +7636,6 @@ remoteDomainGetFSInfo(virDomainPtr dom, } info_ret = g_new0(virDomainFSInfoPtr, ret.info.info_len); - goto cleanup; for (i = 0; i < ret.info.info_len; i++) { src = &ret.info.info_val[i]; -- 2.26.2

2 1

[libvirt PATCH v2 0/9] spec: Improve feature and architecture handling
by Andrea Bolognani 09 Oct '20

09 Oct '20

Changes from [v1]: * address review feedback. [v1] https://www.redhat.com/archives/libvir-list/2020-October/msg00336.html Andrea Bolognani (9): spec: Simplify setting features off by default spec: firewalld is always enabled spec: bash completion actually defaults to on spec: Move with_numactl definition spec: Introduce with_dmidecode spec: Move _vpath_builddir definition spec: Drop s390 architecture from conditionals spec: Refactor qemu_kvm_arches definition spec: Introduce arches_* libvirt.spec.in | 116 ++++++++++++++++++++++++------------------------ 1 file changed, 57 insertions(+), 59 deletions(-) -- 2.26.2

2 10

[libvirt PATCH 00/15] various meson fixes and improvements
by Pavel Hrdina 09 Oct '20

09 Oct '20

Pavel Hrdina (15): meson_options: change VMware default from enabled to auto meson_options: change VirtualBox default from enabled to auto meson_options: move firewalld options to build feature options meson: no need to call meson.get_compiler() again meson: properly handle libpcap if it's explicitly disabled meson: properly handle readline if it's explicitly disabled meson: build nodedev driver only if libvirtd is compiled meson: add libnl build option meson: add rbd build option meson: prefix kvm_dep, m_dep and util_dep with lib meson: add missing libraries to summary meson: remove required libraries from summary meson: move build feature options to miscellaneous summary meson: add docs option to enable/disable generating documentation meson: add tests build option to enable/disable unit tests libvirt.spec.in | 2 + meson.build | 135 +++++++++++++++++++++++++----------------- meson_options.txt | 12 ++-- src/bhyve/meson.build | 4 +- src/util/meson.build | 4 +- 5 files changed, 96 insertions(+), 61 deletions(-) -- 2.26.2

2 23

[libvirt PATCH 0/8] delete VIR_ALLOC and VIR_ALLOC_N (glib chronicles)
by Ján Tomko 09 Oct '20

09 Oct '20

Ján Tomko (8): remote: refactor remoteSerializeDHCPLease libxl: xenParseXMOS: separate VIR_ALLOC call remote: use g_new0 instead of VIR_ALLOC remote: remoteDispatchAuthList: remove useless 'rv' src: use g_new0 instead of VIR_ALLOC tests: use g_new0 instead of VIR_ALLOC tests: delete VIR_ALLOC tests cases util: delete VIR_ALLOC and VIR_ALLOC_N src/access/viraccessmanager.c | 3 +- src/admin/admin_server_dispatch.c | 6 +- src/hypervisor/domain_driver.c | 3 +- src/hypervisor/virclosecallbacks.c | 7 +- src/libvirt_private.syms | 2 - src/libxl/xen_xm.c | 9 +- src/remote/remote_daemon_config.c | 3 +- src/remote/remote_daemon_dispatch.c | 279 +++++++++------------------- src/remote/remote_daemon_stream.c | 6 +- src/remote/remote_driver.c | 102 +++------- src/test/test_driver.c | 66 +++---- src/util/viralloc.c | 39 ---- src/util/viralloc.h | 33 ---- tests/viralloctest.c | 89 +-------- 14 files changed, 157 insertions(+), 490 deletions(-) -- 2.26.2

3 13

[PATCH 0/7] more Hyper-V APIs
by Matt Coleman 09 Oct '20

09 Oct '20

This set of patches adds several new APIs and fixes several others. Matt Coleman (7): hyperv: implement domainSetAutostart hyperv: implement nodeGetFreeMemory hyperv: implement domainReboot and domainReset hyperv: implement domainShutdown and domainShutdownFlags hyperv: fix domainSuspend and domainResume on Hyper-V V2 hyperv: fix domainManagedSave on Hyper-V V2 news: more Hyper-V APIs NEWS.rst | 7 +- src/hyperv/hyperv_driver.c | 268 +++++++++++++++++++++++++- src/hyperv/hyperv_wmi_classes.h | 3 + src/hyperv/hyperv_wmi_generator.input | 78 ++++++++ 4 files changed, 348 insertions(+), 8 deletions(-) -- 2.27.0

3 12

[libvirt PATCH 0/9] spec: Improve feature and architecture handling
by Andrea Bolognani 09 Oct '20

09 Oct '20

Make things more maintainable. Andrea Bolognani (9): spec: Simplify setting features off by default spec: firewalld is always enabled spec: bash completion actually defaults to on spec: Move with_numactl definition spec: Introduce with_dmidecode spec: Move _vpath_builddir definition spec: Drop s390 architecture from conditionals spec: Refactor qemu_kvm_arches definition spec: Introduce arches_* libvirt.spec.in | 117 ++++++++++++++++++++++++------------------------ 1 file changed, 58 insertions(+), 59 deletions(-) -- 2.26.2

3 30

[PATCH] qemu.conf: Re-word the description for *_tls_x509_verify
by Fangge Jin 09 Oct '20

09 Oct '20

The original descirption for *_tls_x509_verify is a little misleading by saying that "Enabling this option will reject any client who does not have a ca-cert.pem certificate". Signed-off-by: Fangge Jin <fjin(a)redhat.com> --- src/qemu/qemu.conf | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf index a96bedb114..b1bd3cecbd 100644 --- a/src/qemu/qemu.conf +++ b/src/qemu/qemu.conf @@ -109,9 +109,8 @@ # issuing an x509 certificate to every client who needs to connect. # # Enabling this option will reject any client that does not have a -# ca-cert.pem certificate signed by the CA in the vnc_tls_x509_cert_dir -# (or default_tls_x509_cert_dir) as well as the corresponding client-*.pem -# files described in default_tls_x509_cert_dir. +# certificate(as described in default_tls_x509_verify) signed by the +# CA in the vnc_tls_x509_cert_dir (or default_tls_x509_cert_dir). # # If this option is not supplied, it will be set to the value of # "default_tls_x509_verify". @@ -248,9 +247,8 @@ # issuing an x509 certificate to every client who needs to connect. # # Enabling this option will reject any client that does not have a -# ca-cert.pem certificate signed by the CA in the chardev_tls_x509_cert_dir -# (or default_tls_x509_cert_dir) as well as the corresponding client-*.pem -# files described in default_tls_x509_cert_dir. +# certificate(as described in default_tls_x509_verify) signed by the +# CA in the chardev_tls_x509_cert_dir (or default_tls_x509_cert_dir). # # If this option is not supplied, it will be set to the value of # "default_tls_x509_verify". @@ -375,9 +373,8 @@ # issuing an x509 certificate to every client who needs to connect. # # Enabling this option will reject any client that does not have a -# ca-cert.pem certificate signed by the CA in the migrate_tls_x509_cert_dir -# (or default_tls_x509_cert_dir) as well as the corresponding client-*.pem -# files described in default_tls_x509_cert_dir. +# certificate(as described in default_tls_x509_verify) signed by the +# CA in the migrate_tls_x509_cert_dir (or default_tls_x509_cert_dir). # # If this option is not supplied, it will be set to the value of # "default_tls_x509_verify". @@ -412,9 +409,8 @@ # issuing an x509 certificate to every client who needs to connect. # # Enabling this option will reject any client that does not have a -# ca-cert.pem certificate signed by the CA in the backup_tls_x509_cert_dir -# (or default_tls_x509_cert_dir) as well as the corresponding client-*.pem -# files described in default_tls_x509_cert_dir. +# certificate(as described in default_tls_x509_verify) signed by the +# CA in the backup_tls_x509_cert_dir (or default_tls_x509_cert_dir). # # If this option is not supplied, it will be set to the value of # "default_tls_x509_verify". -- 2.20.1

2 1

[PATCH v2 00/10] hyperv: implement new APIs & more
by Matt Coleman 09 Oct '20

09 Oct '20

These patches fix a couple bugs, consolidate duplicate code, and implement several APIs. Currently, some interactions with Hyper-V systems fail when the system is not configured for the "en-US" locale. Additionally, some CPU names also contain the clock frequency, making it too long for _virNodeInfo.model. The first two patches fix these bugs. The second two patches clean up the code a little: one moves repeated operations into new helper functions; the other replaces the generic "get WMI class list" functions with a macro. The next four patches implement the following APIs in the Hyper-V driver: * virConnectGetCapabilities() * virConnectGetMaxVcpus() * virConnectGetVersion() * virDomainGetAutostart() Changes since v1: * all NEWS updates are now in a single commit at the end * long function calls have been split up into multiple lines * improved error handling in hypervDomainLookupBy*(): they now throw VIR_ERR_NO_DOMAIN when appropriate * unnecessary calls to virReportError() have been removed from hypervDomainGetInfo() and hypervDomainGetXMLDesc() * HTML documentation for the unusual Hyper-V versions * the WMI schema fix has been split into a separate commit * hypervConnectGetVersion() uses a new hypervParseVersionString() and directly produces the unsigned long instead of calling virParseVersionString() Matt Coleman (10): hyperv: make Msvm_ComputerSystem WQL queries locale agnostic hyperv: fix nodeGetInfo failures caused by long CPU names hyperv: break out common lookups into separate functions hyperv: replace generic WMI class list helpers with a macro hyperv: implement connectGetCapabilities hyperv: implement connectGetMaxVcpus hyperv: fix Win32_OperatingSystem WMI queries hyperv: implement connectGetVersion hyperv: implement domainGetAutostart news: document new Hyper-V features and bug fixes NEWS.rst | 10 + docs/drvhyperv.html.in | 50 ++ src/hyperv/hyperv_driver.c | 751 ++++++++++++++++++-------- src/hyperv/hyperv_private.h | 2 + src/hyperv/hyperv_wmi.c | 83 +-- src/hyperv/hyperv_wmi.h | 28 +- src/hyperv/hyperv_wmi_classes.h | 4 +- src/hyperv/hyperv_wmi_generator.input | 2 +- 8 files changed, 596 insertions(+), 334 deletions(-) -- 2.27.0

4 28

[PATCH] the leading space in volmode check will never match the leading tab output from zfs get
by richardburakowski＠gmail.com 09 Oct '20

09 Oct '20

Signed-off-by: Richard Burakowski <richard.burakowski(a)gmail.com> --- src/storage/storage_backend_zfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/storage/storage_backend_zfs.c b/src/storage/storage_backend_zfs.c index dc692f47ed..439f5b2fd5 100644 --- a/src/storage/storage_backend_zfs.c +++ b/src/storage/storage_backend_zfs.c @@ -71,7 +71,7 @@ virStorageBackendZFSVolModeNeeded(void) return ret; } - if (strstr(error, " volmode ")) + if (strstr(error, "volmode ")) return 1; else return 0; -- 2.26.2

3 2