January 2020 - Devel - libvirt List Archives

[libvirt] [PATCH] man: virsh: Mention how to disable snapshot of disk in snapshot-create-as
by Peter Krempa 07 Jan '20

07 Jan '20

Document that --diskspec DISK,snapshot=no disables snapshot for the given disk. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- docs/manpages/virsh.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index d0f9e15c38..4522259657 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -6734,7 +6734,8 @@ form ``disk[,snapshot=type][,driver=type][,stype=type][,file=name]``. A *diskspec* must be provided for disks backed by block devices as libvirt doesn't auto-generate file names for those. The optional ``stype`` parameter allows to control the type of the source file. Supported values are 'file' -(default) and 'block'. +(default) and 'block'. To exclude a disk from an external snapshot use +``--diskspec disk,snapshot=no``. To include a literal comma in ``disk`` or in ``file=name``, escape it with a second comma. A literal *--diskspec* must precede each ``diskspec`` unless -- 2.24.1

2 1

[libvirt] [PATCH 0/7] Support rng backend model 'builtin'
by Han Han 07 Jan '20

07 Jan '20

https://bugzilla.redhat.com/show_bug.cgi?id=1785091 This rng backend is added since QEMU 4.2. It uses getrandom() syscall to generate random instread of external rng source. QEMU bug reference: https://bugzilla.redhat.com/show_bug.cgi?id=1689946 Han Han (7): qemu_capabilities: Introduce QEMU_CAPS_OBJECT_RNG_BUILTIN util: Do not assume comma after object id qemu: Implement builtin rng backend docs: Add schemas for rng backend builtin tests: Add tests fr virtio-rng backend builtin docs: Documents for virtio-rng backend builtin news: Update news for rng backend type builtin docs/formatdomain.html.in | 10 ++++++ docs/formatdomaincaps.html.in | 1 + docs/news.xml | 10 ++++++ docs/schemas/domaincommon.rng | 6 ++++ src/conf/domain_audit.c | 2 ++ src/conf/domain_conf.c | 9 ++++++ src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 4 +++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 15 +++++++++ src/qemu/qemu_domain.c | 3 ++ src/util/virqemu.c | 13 ++++---- .../domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 1 + .../qemu_4.2.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 1 + .../caps_4.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 + .../caps_4.2.0.x86_64.xml | 1 + .../qemuxml2argvdata/virtio-rng-builtin.args | 30 ++++++++++++++++++ tests/qemuxml2argvdata/virtio-rng-builtin.xml | 26 ++++++++++++++++ tests/qemuxml2argvtest.c | 3 ++ .../qemuxml2xmloutdata/virtio-rng-builtin.xml | 31 +++++++++++++++++++ tests/qemuxml2xmltest.c | 2 ++ 28 files changed, 172 insertions(+), 6 deletions(-) create mode 100644 tests/qemuxml2argvdata/virtio-rng-builtin.args create mode 100644 tests/qemuxml2argvdata/virtio-rng-builtin.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-rng-builtin.xml -- 2.23.0

2 17

[libvirt] Xen + libvirt + TPM
by Arthur Borsboom 07 Jan '20

07 Jan '20

Hello, I am trying to get TPM 2.0 pass through to work with Xen and libvirt, but I can't get it to work. According to the following sites both Xen and libirt have TPM 2.0 support. https://wiki.xen.org/wiki/Virtual_Trusted_Platform_Module_(vTPM) https://libvirt.org/formatdomain.html#elementsTpm However, when I add a TPM device to a VM (by virt-manager), the VM guest XML does contain the TPM configuration, but the VM guest (linux) does not show any TPM device. Also, when looking in /var/log/libvirt/libxl/vmguest.log there is no mention of tpm in the (converted libvirt XML to libxl) vm structure. Is this because libvirt only supports TPM with QEMU? If so, are there any development plans for TPM support with XEN? Is there a workaround for the time being? Best regards, Arthur Borsboom.

2 1

[libvirt] [PATCHv2 0/2] Introduce the support of Intel RDT-MBM
by Wang Huaqiang 07 Jan '20

07 Jan '20

This is a followup to Daniel's review in thread https://www.redhat.com/archives/libvir-list/2019-December/msg00978.html. Hi Daniel, In this series, patch 1/2 is trying to fix a bug that using the 64bit, instead of the current 32bit, interface, to hold cache monitor value reported by underlying 64bit counter. In last series, you have suggested of adding a new field such as "cpu.cache.monitor.%zu.bank.%zu.bytes64" for new 64bit counter result, and keep the old but already exported 32bit field, to avoid reporting a truncated cache monitor result to user. But considering the fact that, in reality, CPU cache size will never exceed 4GB in size, it is safe to truccate a 64bit counter to 32 bit since the counter is counting for the cache size that vcpus are using. Change List: v2: * Using old "cpu.cache.monitor.%zu.bank.%zu.bytes" field for cache monitor result, and keeping the interface consistent. * Add 'virsh domstats --memory' document in file 'virsh.rst' Wang Huaqiang (2): util, resctrl: using 64bit interface instead of 32bit for counters Introduce command 'virsh domstats --memory' for reporting memory BW docs/manpages/virsh.rst | 22 +++++- include/libvirt/libvirt-domain.h | 1 + src/libvirt-domain.c | 21 ++++++ src/qemu/qemu_driver.c | 118 ++++++++++++++++++++++++++++++- src/util/virfile.c | 40 +++++++++++ src/util/virfile.h | 2 + src/util/virresctrl.c | 6 +- src/util/virresctrl.h | 2 +- tools/virsh-domain-monitor.c | 7 ++ 9 files changed, 211 insertions(+), 8 deletions(-) -- 2.23.0

3 6

[libvirt] [PATCH 0/2] qemu_firmware: Try to autofill for old style UEFI specification
by Michal Privoznik 06 Jan '20

06 Jan '20

See 2/2 for info. Michal Prívozník (2): qemu_firmware: Pass virDomainDef into qemuFirmwareFillDomain() qemu_firmware: Try to autofill for old style UEFI specification src/qemu/qemu_firmware.c | 90 +++++++++++++++++++++++++++++++++------- src/qemu/qemu_firmware.h | 2 +- src/qemu/qemu_process.c | 2 +- 3 files changed, 78 insertions(+), 16 deletions(-) -- 2.24.1

2 5

[libvirt] [jenkins-ci PATCH 0/2] CentOS fixes
by Fabiano Fidêncio 06 Jan '20

06 Jan '20

This series consists in two simple patches: - Mention CentOS8 as a valid OS version; - Only install OpenVZ on CentOS 7; Fabiano Fidêncio (2): guests: Mention CentOS8 as a valid OS version guests: Only install OpenVZ on CentOS 7 guests/playbooks/update/tasks/base.yml | 1 + guests/vars/mappings.yml | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) -- 2.23.0

2 4

[libvirt] [PATCH] ci: Fetch list of available container images dynamically
by Andrea Bolognani 06 Jan '20

06 Jan '20

Any static list of images is destined to become outdated eventually, so let's start generating it dynamically instead. Unfortunately there doesn't seem to be a straightforward way to get Podman/Docker to list all repositories under quay.io/libvirt, so we have to resort to searching and filtering manually; and since the two tools behave slightly differently in that regard, it's more sane to have the logic in a separate shell script than it would be to keep it inline in the Makefile with all the annoying escaping that would entail. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- ci/Makefile | 37 +++++++++++++------------------------ ci/list-images.sh | 26 ++++++++++++++++++++++++++ 2 files changed, 39 insertions(+), 24 deletions(-) create mode 100644 ci/list-images.sh diff --git a/ci/Makefile b/ci/Makefile index 27c1049b38..acb655941c 100644 --- a/ci/Makefile +++ b/ci/Makefile @@ -238,6 +238,17 @@ ci-build@%: ci-check@%: $(MAKE) -C $(CI_ROOTDIR) ci-build@$* CI_MAKE_ARGS="check" +ci-list-images: + @echo + @echo "Available x86 container images:" + @echo + @sh list-images.sh "$(CI_ENGINE)" "$(CI_IMAGE_PREFIX)" | grep -v cross + @echo + @echo "Available cross-compiler container images:" + @echo + @sh list-images.sh "$(CI_ENGINE)" "$(CI_IMAGE_PREFIX)" | grep cross + @echo + ci-help: @echo "Build libvirt inside containers used for CI" @echo @@ -246,30 +257,8 @@ ci-help: @echo " ci-build@\$$IMAGE - run a default 'make'" @echo " ci-check@\$$IMAGE - run a 'make check'" @echo " ci-shell@\$$IMAGE - run an interactive shell" - @echo - @echo "Available x86 container images:" - @echo - @echo " centos-7" - @echo " debian-9" - @echo " debian-10" - @echo " debian-sid" - @echo " fedora-29" - @echo " fedora-30" - @echo " fedora-rawhide" - @echo " ubuntu-16" - @echo " ubuntu-18" - @echo - @echo "Available cross-compiler container images:" - @echo - @echo " debian-{9,10,sid}-cross-aarch64" - @echo " debian-{9,10,sid}-cross-armv6l" - @echo " debian-{9,10,sid}-cross-armv7l" - @echo " debian-{10,sid}-cross-i686" - @echo " debian-{9,10,sid}-cross-mips64el" - @echo " debian-{9,10,sid}-cross-mips" - @echo " debian-{9,10,sid}-cross-mipsel" - @echo " debian-{9,10,sid}-cross-ppc64le" - @echo " debian-{9,10,sid}-cross-s390x" + @echo " ci-list-images - list available images" + @echo " ci-help - show this help message" @echo @echo "Available make variables:" @echo diff --git a/ci/list-images.sh b/ci/list-images.sh new file mode 100644 index 0000000000..35efdb6982 --- /dev/null +++ b/ci/list-images.sh @@ -0,0 +1,26 @@ +#!/bin/sh + +engine="$1" +prefix="$2" + +do_podman() { + # Podman freaks out if the search term ends with a dash, which ours + # by default does, so let's strip it. The repository name is the + # second field in the output, and it already starts with the registry + podman search --limit 100 "${prefix%-}" | while read _ repo _; do + echo "$repo" + done +} + +do_docker() { + # Docker doesn't include the registry name in the output, so we have + # to add it. The repository name is the first field in the output + registry="${prefix%%/*}" + docker search --limit 100 "$prefix" | while read repo _; do + echo "$registry/$repo" + done +} + +"do_$engine" | grep "^$prefix" | sed "s,^$prefix,,g" | while read repo; do + echo " $repo" +done | sort -u -- 2.23.0

2 2

[libvirt] [PATCH 0/2] vircgroupv2devices: Avoid double close on map FD
by Michal Privoznik 06 Jan '20

06 Jan '20

*** BLURB HERE *** Michal Prívozník (2): vircgroupv2devices: Unexport virCgroupV2DevicesAttachProg() vircgroupv2devices: Avoid double close on map FD src/libvirt_private.syms | 1 - src/util/vircgroupv2devices.c | 29 +++++------------------------ src/util/vircgroupv2devices.h | 5 ----- 3 files changed, 5 insertions(+), 30 deletions(-) -- 2.24.1

2 3

[libvirt] [PATCH] qemu: backup: Move capability check after inactive check
by Peter Krempa 06 Jan '20

06 Jan '20

Inactive VM doesn't have qemuCaps set thus we'd never properly report that VM backups are supported only for running VMs. Move the capability check after the active check. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_backup.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_backup.c b/src/qemu/qemu_backup.c index c0445e0869..86b10a2b8a 100644 --- a/src/qemu/qemu_backup.c +++ b/src/qemu/qemu_backup.c @@ -750,12 +750,6 @@ qemuBackupBegin(virDomainObjPtr vm, virCheckFlags(VIR_DOMAIN_BACKUP_BEGIN_REUSE_EXTERNAL, -1); - if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_INCREMENTAL_BACKUP)) { - virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", - _("incremental backup is not supported yet")); - return -1; - } - if (!(def = virDomainBackupDefParseString(backupXML, priv->driver->xmlopt, 0))) return -1; @@ -793,6 +787,12 @@ qemuBackupBegin(virDomainObjPtr vm, goto endjob; } + if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_INCREMENTAL_BACKUP)) { + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", + _("incremental backup is not supported yet")); + goto endjob; + } + if (priv->backup) { virReportError(VIR_ERR_OPERATION_INVALID, "%s", _("another backup job is already running")); -- 2.24.1

2 1

[libvirt] [PATCH] util: time: Fix comment for virTimeFieldsNow
by Peter Krempa 06 Jan '20

06 Jan '20

Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/util/virtime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Trivial. diff --git a/src/util/virtime.c b/src/util/virtime.c index 54466b2f39..13f899cb91 100644 --- a/src/util/virtime.c +++ b/src/util/virtime.c @@ -223,7 +223,7 @@ int virTimeMillisNow(unsigned long long *now) /** - * virTimeFieldsNowRaw: + * virTimeFieldsNow: * @fields: filled with current time fields * * Retrieves the current time, in broken-down field format. -- 2.24.1

1 0