[libvirt] [PATCH] tests: virpcimock: remove unused variable 'devid'
by Ján Tomko
virpcimock.c:685:26: error: unused variable 'devid' [-Werror,-Wunused-variable]
VIR_AUTOFREE(char *) devid = NULL;
^
Fixes: 76b42294380d40282ed29560e4ae4a7491b9df05
Signed-off-by: Ján Tomko <jtomko(a)redhat.com>
---
Pushed as a trivial build fix.
tests/virpcimock.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/virpcimock.c b/tests/virpcimock.c
index 09a6c648af..ca6cc060fd 100644
--- a/tests/virpcimock.c
+++ b/tests/virpcimock.c
@@ -682,7 +682,6 @@ pci_driver_find_by_path(const char *path)
static struct pciDriver *
pci_driver_find_by_driver_override(struct pciDevice *dev)
{
- VIR_AUTOFREE(char *) devid = NULL;
VIR_AUTOFREE(char *) path = NULL;
char tmp[32];
size_t i;
--
2.20.1
5 years, 3 months
[libvirt] [PATCH] test_driver: implement virDomainSetBlockThreshold
by Ilias Stamatis
Store disk name - threshold pairs in vm-private data so they can be
retrieved by virConnectGetAllDomainStats later.
Signed-off-by: Ilias Stamatis <stamatis.iliass(a)gmail.com>
---
src/test/test_driver.c | 91 +++++++++++++++++++++++++++++++++++++++++-
src/test/test_driver.h | 9 +++++
2 files changed, 98 insertions(+), 2 deletions(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 9bf3728654..0b4646b0bb 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -396,6 +396,10 @@ struct _testDomainObjPrivate {
/* used by get/set time APIs */
long long seconds;
unsigned int nseconds;
+
+ /* used by domainSetBlockThreshold */
+ size_t num_thresholds;
+ testBlockThresholdPtr *thresholds;
};
@@ -413,6 +417,9 @@ testDomainObjPrivateAlloc(void *opaque)
priv->seconds = 627319920;
priv->nseconds = 0;
+ priv->num_thresholds = 0;
+ priv->thresholds = NULL;
+
return priv;
}
@@ -3974,6 +3981,71 @@ testDomainGetBlockIoTune(virDomainPtr dom,
#undef TEST_SET_PARAM
+static int
+testDomainSetBlockThreshold(virDomainPtr dom,
+ const char *dev,
+ unsigned long long threshold,
+ unsigned int flags)
+{
+ virDomainObjPtr vm = NULL;
+ virDomainDiskDefPtr disk;
+ testDomainObjPrivatePtr priv;
+ testBlockThresholdPtr blockthreshold = NULL;
+ size_t i;
+ int ret = -1;
+
+ virCheckFlags(0, -1);
+
+ if (!(vm = testDomObjFromDomain(dom)))
+ return -1;
+
+ if (virDomainObjCheckActive(vm) < 0)
+ goto cleanup;
+
+ if (!(disk = virDomainDiskByName(vm->def, dev, true))) {
+ virReportError(VIR_ERR_INVALID_ARG,
+ _("failed to find disk '%s'"),
+ dev);
+ goto cleanup;
+ }
+
+ priv = vm->privateData;
+
+ for (i = 0; i < priv->num_thresholds; i++) {
+ if (STREQ(dev, priv->thresholds[i]->name)) {
+ blockthreshold = priv->thresholds[i];
+ break;
+ }
+ }
+
+ if (blockthreshold != NULL) {
+ blockthreshold->threshold = threshold;
+ } else {
+ /* disk not found. add it to the list */
+ if (VIR_ALLOC(blockthreshold) < 0)
+ goto cleanup;
+ if (VIR_STRDUP(blockthreshold->name, dev) < 0)
+ goto cleanup;
+
+ blockthreshold->threshold = threshold;
+
+ if (VIR_APPEND_ELEMENT(priv->thresholds, priv->num_thresholds,
+ blockthreshold) < 0)
+ goto cleanup;
+ }
+
+ ret = 0;
+
+ cleanup:
+ if (ret < 0 && blockthreshold != NULL) {
+ VIR_FREE(blockthreshold->name);
+ VIR_FREE(blockthreshold);
+ }
+ virDomainObjEndAPI(&vm);
+ return ret;
+}
+
+
static int testConnectNumOfDefinedDomains(virConnectPtr conn)
{
testDriverPtr privconn = conn->privateData;
@@ -5070,10 +5142,12 @@ testDomainDeviceOperation(testDriverPtr driver,
virTestDeviceOperation operation,
const char *xml,
const char *alias,
+ virDomainObjPtr vm,
virDomainDefPtr def)
{
virDomainDeviceDefPtr dev = NULL;
unsigned int parse_flags = VIR_DOMAIN_DEF_PARSE_INACTIVE;
+ size_t i;
int ret = -1;
if (operation == TEST_DEVICE_DETACH)
@@ -5097,6 +5171,17 @@ testDomainDeviceOperation(testDriverPtr driver,
case TEST_DEVICE_DETACH:
if (testDomainDetachDeviceLiveAndConfig(def, dev) < 0)
goto cleanup;
+
+ if (dev->type == VIR_DOMAIN_DEVICE_DISK) {
+ testDomainObjPrivatePtr priv = vm->privateData;
+
+ for (i = 0; i < priv->num_thresholds; i++) {
+ if (STREQ(dev->data.disk->dst, priv->thresholds[i]->name)) {
+ VIR_DELETE_ELEMENT(priv->thresholds[i], i, priv->num_thresholds);
+ break;
+ }
+ }
+ }
break;
case TEST_DEVICE_UPDATE:
if (testDomainUpdateDeviceLiveAndConfig(def, dev) < 0)
@@ -5137,12 +5222,13 @@ testDomainAttachDetachUpdateDevice(virDomainPtr dom,
goto cleanup;
if (persistentDef) {
- if (testDomainDeviceOperation(driver, operation, xml, alias, persistentDef) < 0)
+ if (testDomainDeviceOperation(driver, operation, xml, alias, vm,
+ persistentDef) < 0)
goto cleanup;
}
if (def) {
- if (testDomainDeviceOperation(driver, operation, xml, alias, def) < 0)
+ if (testDomainDeviceOperation(driver, operation, xml, alias, vm, def) < 0)
goto cleanup;
}
@@ -10001,6 +10087,7 @@ static virHypervisorDriver testHypervisorDriver = {
.domainGetInterfaceParameters = testDomainGetInterfaceParameters, /* 5.6.0 */
.domainSetBlockIoTune = testDomainSetBlockIoTune, /* 5.7.0 */
.domainGetBlockIoTune = testDomainGetBlockIoTune, /* 5.7.0 */
+ .domainSetBlockThreshold = testDomainSetBlockThreshold, /* 5.7.0 */
.connectListDefinedDomains = testConnectListDefinedDomains, /* 0.1.11 */
.connectNumOfDefinedDomains = testConnectNumOfDefinedDomains, /* 0.1.11 */
.domainCreate = testDomainCreate, /* 0.1.11 */
diff --git a/src/test/test_driver.h b/src/test/test_driver.h
index 8c8a462db7..bcb5ffd7a4 100644
--- a/src/test/test_driver.h
+++ b/src/test/test_driver.h
@@ -23,4 +23,13 @@
#include "internal.h"
+
+typedef struct _testBlockThreshold testBlockThreshold;
+typedef testBlockThreshold *testBlockThresholdPtr;
+
+struct _testBlockThreshold {
+ char *name;
+ unsigned long long threshold;
+};
+
int testRegister(void);
--
2.22.0
5 years, 3 months
[libvirt] [PATCH 00/18] Enhance virpcimock and test VFIO instead of KVM
by Michal Privoznik
Kernel structure looks slightly different than what virpcimock creates.
This did not use to be a problem, because we are testing KVM device
assignment even though majority of systems we run on (if not all of
them) use VFIO assignment.
In order to switch our test suite (mainly virhostdevtest and virpcitest)
to test VFIO assignment, the virpcimock must be fixed. Firstly, it needs
to create symlinks under /sys/kernel/iommu_groups/... directories (patch
13/18) so that virhostdev module can iterate over them. Secondly, it
needs to create 'driver_override' file (which exists since
kernel-3.16.0) so that the virtual environment the mock creates matches
real up to date systems (patch 03/18).
Funny thing is, that enhancing the mock uncovered a bug we had (fix is
in 15/18) and also one latent bug (14/18).
As usual, these patches can be found on my github too:
https://github.com/zippy2/libvirt/tree/virpcimock
and just for the fun of it, here's the latest travis build of that
branch:
https://travis-ci.org/zippy2/libvirt/builds/571752953
Michal Prívozník (18):
virpcimock: Move actions checking one level up
Revert "virpcitest: Test virPCIDeviceDetach failure"
virpcimock: Create driver_override file in device dirs
virpcimock: Drop needless typecast
virpcimock: Use VIR_AUTOFREE()
virpcimock: Eliminate use of @fakesysfspcidir
virpcimock: Rename @fakesysfspcidir
virpcimock: Create devices/ and drivers/ under /sys/bus/pci upfront
virpcimock: Introduce and use pci_device_get_path()
virpcimock: Introduce and use pci_driver_get_path()
virpcimock: Store PCI address as ints not string
virpcimock: Create PCI devices under /sys/devices/pci*
virpcimock: Create symlink in /sys/kernel/iommu_groups/N/devices dir
virhostdev: Check driver name too in virHostdevIsPCINodeDeviceUsed()
virhostdev: Unify virHostdevPreparePCIDevices behaviour for KVM and
VFIO cases
qemuxml2argvtest: Switch to modern vfio backend
virhostdevtest: Use modern VFIO
virpcitest: Use modern VFIO
src/util/virhostdev.c | 26 +-
.../hostdev-pci-address-device.args | 2 +-
.../qemuxml2argvdata/hostdev-pci-address.args | 2 +-
.../net-hostdev-bootorder.args | 3 +-
.../net-hostdev-multidomain.args | 2 +-
tests/qemuxml2argvdata/net-hostdev.args | 2 +-
tests/qemuxml2argvdata/pci-rom.args | 4 +-
tests/qemuxml2argvtest.c | 14 +-
tests/virhostdevtest.c | 4 +-
tests/virpcimock.c | 394 ++++++++++++------
tests/virpcitest.c | 48 +--
11 files changed, 304 insertions(+), 197 deletions(-)
--
2.21.0
5 years, 3 months
[libvirt] [PATCH v2 0/6] test_driver: implement device attach/detach APIs
by Ilias Stamatis
This series needed a respin since there were conflicts when trying to
apply on the current master.
Ilias Stamatis (6):
test_driver: implement virDomainAttachDeviceFlags
test_driver: implement virDomainAttachDevice
test_driver: implement virDomainDetachDeviceFlags
test_driver: implement virDomainDetachDevice
test_driver: implement virDomainDetachDeviceAlias
test_driver: implement virDomainUpdateDeviceFlags
src/test/test_driver.c | 569 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 569 insertions(+)
--
2.22.0
5 years, 3 months
[libvirt] [PATCH v2 0/7] PCI Multifunction hotplug/unplug, part 1
by Daniel Henrique Barboza
v2:
- rebased without 3 patches from Michal that are under review
in his NVMe patch series
This is the first part of the feature discussed at [1]. These
patches are mostly cleanup and fixes, thus it is beneficial
to have them upstream right away.
The whole feature can be checked out at [2]. All patches survives
unit testing. The feature was stress tested with hundreds
of consecutive hotplug/unplugs of a Broadcom BCM5719 multifunction
network card in a guest running in a Power 8 server. Hopefully
I'll find a suitable x86 env to stress test the feature there
too.
[1] https://www.redhat.com/archives/libvir-list/2019-June/msg00703.html
[2] https://github.com/danielhb/libvirt/tree/multifunction_latest
Daniel Henrique Barboza (1):
util/virhostdev: enhance VFIO device is in use detection
Shivaprasad G Bhat (6):
tests: Fix the iommu group path in mock pci
tests: pci: Mock the iommu groups and vfio
virpcitest: Change the stub driver to vfio from pci-stub
virpcimock: Mock the SRIOV Virtual functions
tests: qemu: Add test case for pci-hostdev hotplug
tests: Add a baseline test for multifunction pci device use case
src/util/virhostdev.c | 74 +++++--
src/util/virprocess.h | 2 +-
tests/Makefile.am | 7 +
tests/qemuhotplugtest.c | 42 +++-
.../qemuhotplug-hostdev-pci.xml | 6 +
.../qemuhotplug-base-live+hostdev-pci.xml | 58 +++++
...uhotplug-pseries-base-live+hostdev-pci.xml | 51 +++++
.../qemuhotplug-pseries-base-live.xml | 43 ++++
.../hostdev-pci-multifunction.args | 35 +++
.../hostdev-pci-multifunction.xml | 59 +++++
.../hostdev-vfio-multidomain.args | 2 +-
.../hostdev-vfio-multidomain.xml | 2 +-
tests/qemuxml2argvdata/hostdev-vfio.args | 2 +-
tests/qemuxml2argvdata/hostdev-vfio.xml | 2 +-
tests/qemuxml2argvdata/net-hostdev-fail.xml | 2 +-
tests/qemuxml2argvdata/net-hostdev-vfio.args | 2 +-
tests/qemuxml2argvdata/net-hostdev-vfio.xml | 2 +-
tests/qemuxml2argvtest.c | 3 +
.../hostdev-pci-multifunction.xml | 79 +++++++
tests/qemuxml2xmloutdata/hostdev-vfio.xml | 2 +-
tests/qemuxml2xmloutdata/net-hostdev-vfio.xml | 2 +-
tests/qemuxml2xmltest.c | 1 +
tests/virhostdevtest.c | 4 +-
tests/virpcimock.c | 201 ++++++++++++++++--
tests/virpcitest.c | 12 +-
tests/virpcitestdata/0000-06-12.0.config | Bin 0 -> 256 bytes
tests/virpcitestdata/0000-06-12.1.config | Bin 0 -> 256 bytes
tests/virpcitestdata/0000-06-12.2.config | Bin 0 -> 256 bytes
tests/virprocessmock.c | 28 +++
29 files changed, 668 insertions(+), 55 deletions(-)
create mode 100644 tests/qemuhotplugtestdevices/qemuhotplug-hostdev-pci.xml
create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-base-live+hostdev-pci.xml
create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-pseries-base-live+hostdev-pci.xml
create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-pseries-base-live.xml
create mode 100644 tests/qemuxml2argvdata/hostdev-pci-multifunction.args
create mode 100644 tests/qemuxml2argvdata/hostdev-pci-multifunction.xml
create mode 100644 tests/qemuxml2xmloutdata/hostdev-pci-multifunction.xml
create mode 100644 tests/virpcitestdata/0000-06-12.0.config
create mode 100644 tests/virpcitestdata/0000-06-12.1.config
create mode 100644 tests/virpcitestdata/0000-06-12.2.config
create mode 100644 tests/virprocessmock.c
--
2.21.0
5 years, 3 months
[libvirt] [dockerfiles PATCH 0/3] refresh: Generate archived Dockerfiles
by Andrea Bolognani
See commit 1/3 for more information.
Andrea Bolognani (3):
refresh: Generate archived Dockerfiles
Remove plain Dockerfiles
Add archived Dockerfiles
.gitignore | 1 +
buildenv-libosinfo-centos-7.Dockerfile | 43 -------
buildenv-libosinfo-centos-7.zip | Bin 0 -> 458 bytes
...bosinfo-debian-10-cross-aarch64.Dockerfile | 64 ----------
...denv-libosinfo-debian-10-cross-aarch64.zip | Bin 0 -> 683 bytes
...ibosinfo-debian-10-cross-armv6l.Dockerfile | 64 ----------
buildenv-libosinfo-debian-10-cross-armv6l.zip | Bin 0 -> 682 bytes
...ibosinfo-debian-10-cross-armv7l.Dockerfile | 64 ----------
buildenv-libosinfo-debian-10-cross-armv7l.zip | Bin 0 -> 686 bytes
...-libosinfo-debian-10-cross-i686.Dockerfile | 64 ----------
buildenv-libosinfo-debian-10-cross-i686.zip | Bin 0 -> 682 bytes
...-libosinfo-debian-10-cross-mips.Dockerfile | 64 ----------
buildenv-libosinfo-debian-10-cross-mips.zip | Bin 0 -> 678 bytes
...osinfo-debian-10-cross-mips64el.Dockerfile | 64 ----------
...env-libosinfo-debian-10-cross-mips64el.zip | Bin 0 -> 689 bytes
...ibosinfo-debian-10-cross-mipsel.Dockerfile | 64 ----------
buildenv-libosinfo-debian-10-cross-mipsel.zip | Bin 0 -> 681 bytes
...bosinfo-debian-10-cross-ppc64le.Dockerfile | 64 ----------
...denv-libosinfo-debian-10-cross-ppc64le.zip | Bin 0 -> 687 bytes
...libosinfo-debian-10-cross-s390x.Dockerfile | 64 ----------
buildenv-libosinfo-debian-10-cross-s390x.zip | Bin 0 -> 680 bytes
buildenv-libosinfo-debian-10.Dockerfile | 50 --------
buildenv-libosinfo-debian-10.zip | Bin 0 -> 555 bytes
...ibosinfo-debian-9-cross-aarch64.Dockerfile | 64 ----------
buildenv-libosinfo-debian-9-cross-aarch64.zip | Bin 0 -> 682 bytes
...libosinfo-debian-9-cross-armv6l.Dockerfile | 64 ----------
buildenv-libosinfo-debian-9-cross-armv6l.zip | Bin 0 -> 681 bytes
...libosinfo-debian-9-cross-armv7l.Dockerfile | 64 ----------
buildenv-libosinfo-debian-9-cross-armv7l.zip | Bin 0 -> 685 bytes
...v-libosinfo-debian-9-cross-mips.Dockerfile | 64 ----------
buildenv-libosinfo-debian-9-cross-mips.zip | Bin 0 -> 678 bytes
...bosinfo-debian-9-cross-mips64el.Dockerfile | 64 ----------
...denv-libosinfo-debian-9-cross-mips64el.zip | Bin 0 -> 689 bytes
...libosinfo-debian-9-cross-mipsel.Dockerfile | 64 ----------
buildenv-libosinfo-debian-9-cross-mipsel.zip | Bin 0 -> 680 bytes
...ibosinfo-debian-9-cross-ppc64le.Dockerfile | 64 ----------
buildenv-libosinfo-debian-9-cross-ppc64le.zip | Bin 0 -> 687 bytes
...-libosinfo-debian-9-cross-s390x.Dockerfile | 64 ----------
buildenv-libosinfo-debian-9-cross-s390x.zip | Bin 0 -> 680 bytes
buildenv-libosinfo-debian-9.Dockerfile | 50 --------
buildenv-libosinfo-debian-9.zip | Bin 0 -> 554 bytes
...osinfo-debian-sid-cross-aarch64.Dockerfile | 64 ----------
...env-libosinfo-debian-sid-cross-aarch64.zip | Bin 0 -> 683 bytes
...bosinfo-debian-sid-cross-armv6l.Dockerfile | 64 ----------
...denv-libosinfo-debian-sid-cross-armv6l.zip | Bin 0 -> 682 bytes
...bosinfo-debian-sid-cross-armv7l.Dockerfile | 64 ----------
...denv-libosinfo-debian-sid-cross-armv7l.zip | Bin 0 -> 686 bytes
...libosinfo-debian-sid-cross-i686.Dockerfile | 64 ----------
buildenv-libosinfo-debian-sid-cross-i686.zip | Bin 0 -> 683 bytes
...libosinfo-debian-sid-cross-mips.Dockerfile | 64 ----------
buildenv-libosinfo-debian-sid-cross-mips.zip | Bin 0 -> 678 bytes
...sinfo-debian-sid-cross-mips64el.Dockerfile | 64 ----------
...nv-libosinfo-debian-sid-cross-mips64el.zip | Bin 0 -> 689 bytes
...bosinfo-debian-sid-cross-mipsel.Dockerfile | 64 ----------
...denv-libosinfo-debian-sid-cross-mipsel.zip | Bin 0 -> 681 bytes
...osinfo-debian-sid-cross-ppc64le.Dockerfile | 64 ----------
...env-libosinfo-debian-sid-cross-ppc64le.zip | Bin 0 -> 687 bytes
...ibosinfo-debian-sid-cross-s390x.Dockerfile | 64 ----------
buildenv-libosinfo-debian-sid-cross-s390x.zip | Bin 0 -> 680 bytes
buildenv-libosinfo-debian-sid.Dockerfile | 50 --------
buildenv-libosinfo-debian-sid.zip | Bin 0 -> 555 bytes
buildenv-libosinfo-fedora-29.Dockerfile | 49 --------
buildenv-libosinfo-fedora-29.zip | Bin 0 -> 488 bytes
buildenv-libosinfo-fedora-30.Dockerfile | 49 --------
buildenv-libosinfo-fedora-30.zip | Bin 0 -> 489 bytes
buildenv-libosinfo-fedora-rawhide.Dockerfile | 63 ----------
buildenv-libosinfo-fedora-rawhide.zip | Bin 0 -> 572 bytes
buildenv-libosinfo-ubuntu-16.Dockerfile | 50 --------
buildenv-libosinfo-ubuntu-16.zip | Bin 0 -> 558 bytes
buildenv-libosinfo-ubuntu-18.Dockerfile | 50 --------
buildenv-libosinfo-ubuntu-18.zip | Bin 0 -> 558 bytes
buildenv-libvirt-centos-7.Dockerfile | 81 -------------
buildenv-libvirt-centos-7.zip | Bin 0 -> 662 bytes
...libvirt-debian-10-cross-aarch64.Dockerfile | 100 ---------------
buildenv-libvirt-debian-10-cross-aarch64.zip | Bin 0 -> 887 bytes
...-libvirt-debian-10-cross-armv6l.Dockerfile | 98 ---------------
buildenv-libvirt-debian-10-cross-armv6l.zip | Bin 0 -> 880 bytes
...-libvirt-debian-10-cross-armv7l.Dockerfile | 99 ---------------
buildenv-libvirt-debian-10-cross-armv7l.zip | Bin 0 -> 884 bytes
...nv-libvirt-debian-10-cross-i686.Dockerfile | 99 ---------------
buildenv-libvirt-debian-10-cross-i686.zip | Bin 0 -> 883 bytes
...nv-libvirt-debian-10-cross-mips.Dockerfile | 99 ---------------
buildenv-libvirt-debian-10-cross-mips.zip | Bin 0 -> 878 bytes
...ibvirt-debian-10-cross-mips64el.Dockerfile | 99 ---------------
buildenv-libvirt-debian-10-cross-mips64el.zip | Bin 0 -> 892 bytes
...-libvirt-debian-10-cross-mipsel.Dockerfile | 99 ---------------
buildenv-libvirt-debian-10-cross-mipsel.zip | Bin 0 -> 882 bytes
...libvirt-debian-10-cross-ppc64le.Dockerfile | 99 ---------------
buildenv-libvirt-debian-10-cross-ppc64le.zip | Bin 0 -> 890 bytes
...v-libvirt-debian-10-cross-s390x.Dockerfile | 99 ---------------
buildenv-libvirt-debian-10-cross-s390x.zip | Bin 0 -> 883 bytes
buildenv-libvirt-debian-10.Dockerfile | 89 --------------
buildenv-libvirt-debian-10.zip | Bin 0 -> 773 bytes
...-libvirt-debian-9-cross-aarch64.Dockerfile | 101 ----------------
buildenv-libvirt-debian-9-cross-aarch64.zip | Bin 0 -> 896 bytes
...v-libvirt-debian-9-cross-armv6l.Dockerfile | 99 ---------------
buildenv-libvirt-debian-9-cross-armv6l.zip | Bin 0 -> 887 bytes
...v-libvirt-debian-9-cross-armv7l.Dockerfile | 100 ---------------
buildenv-libvirt-debian-9-cross-armv7l.zip | Bin 0 -> 893 bytes
...env-libvirt-debian-9-cross-mips.Dockerfile | 100 ---------------
buildenv-libvirt-debian-9-cross-mips.zip | Bin 0 -> 886 bytes
...libvirt-debian-9-cross-mips64el.Dockerfile | 100 ---------------
buildenv-libvirt-debian-9-cross-mips64el.zip | Bin 0 -> 898 bytes
...v-libvirt-debian-9-cross-mipsel.Dockerfile | 100 ---------------
buildenv-libvirt-debian-9-cross-mipsel.zip | Bin 0 -> 889 bytes
...-libvirt-debian-9-cross-ppc64le.Dockerfile | 100 ---------------
buildenv-libvirt-debian-9-cross-ppc64le.zip | Bin 0 -> 898 bytes
...nv-libvirt-debian-9-cross-s390x.Dockerfile | 100 ---------------
buildenv-libvirt-debian-9-cross-s390x.zip | Bin 0 -> 890 bytes
buildenv-libvirt-debian-9.Dockerfile | 90 --------------
buildenv-libvirt-debian-9.zip | Bin 0 -> 777 bytes
...ibvirt-debian-sid-cross-aarch64.Dockerfile | 100 ---------------
buildenv-libvirt-debian-sid-cross-aarch64.zip | Bin 0 -> 886 bytes
...libvirt-debian-sid-cross-armv6l.Dockerfile | 98 ---------------
buildenv-libvirt-debian-sid-cross-armv6l.zip | Bin 0 -> 879 bytes
...libvirt-debian-sid-cross-armv7l.Dockerfile | 99 ---------------
buildenv-libvirt-debian-sid-cross-armv7l.zip | Bin 0 -> 884 bytes
...v-libvirt-debian-sid-cross-i686.Dockerfile | 99 ---------------
buildenv-libvirt-debian-sid-cross-i686.zip | Bin 0 -> 883 bytes
...v-libvirt-debian-sid-cross-mips.Dockerfile | 99 ---------------
buildenv-libvirt-debian-sid-cross-mips.zip | Bin 0 -> 877 bytes
...bvirt-debian-sid-cross-mips64el.Dockerfile | 99 ---------------
...denv-libvirt-debian-sid-cross-mips64el.zip | Bin 0 -> 892 bytes
...libvirt-debian-sid-cross-mipsel.Dockerfile | 99 ---------------
buildenv-libvirt-debian-sid-cross-mipsel.zip | Bin 0 -> 882 bytes
...ibvirt-debian-sid-cross-ppc64le.Dockerfile | 99 ---------------
buildenv-libvirt-debian-sid-cross-ppc64le.zip | Bin 0 -> 890 bytes
...-libvirt-debian-sid-cross-s390x.Dockerfile | 99 ---------------
buildenv-libvirt-debian-sid-cross-s390x.zip | Bin 0 -> 883 bytes
buildenv-libvirt-debian-sid.Dockerfile | 89 --------------
buildenv-libvirt-debian-sid.zip | Bin 0 -> 773 bytes
buildenv-libvirt-fedora-29.Dockerfile | 89 --------------
buildenv-libvirt-fedora-29.zip | Bin 0 -> 694 bytes
buildenv-libvirt-fedora-30.Dockerfile | 89 --------------
buildenv-libvirt-fedora-30.zip | Bin 0 -> 695 bytes
buildenv-libvirt-fedora-rawhide.Dockerfile | 114 ------------------
buildenv-libvirt-fedora-rawhide.zip | Bin 0 -> 828 bytes
buildenv-libvirt-ubuntu-16.Dockerfile | 91 --------------
buildenv-libvirt-ubuntu-16.zip | Bin 0 -> 784 bytes
buildenv-libvirt-ubuntu-18.Dockerfile | 91 --------------
buildenv-libvirt-ubuntu-18.zip | Bin 0 -> 783 bytes
refresh | 21 +++-
142 files changed, 20 insertions(+), 5525 deletions(-)
create mode 100644 .gitignore
delete mode 100644 buildenv-libosinfo-centos-7.Dockerfile
create mode 100644 buildenv-libosinfo-centos-7.zip
delete mode 100644 buildenv-libosinfo-debian-10-cross-aarch64.Dockerfile
create mode 100644 buildenv-libosinfo-debian-10-cross-aarch64.zip
delete mode 100644 buildenv-libosinfo-debian-10-cross-armv6l.Dockerfile
create mode 100644 buildenv-libosinfo-debian-10-cross-armv6l.zip
delete mode 100644 buildenv-libosinfo-debian-10-cross-armv7l.Dockerfile
create mode 100644 buildenv-libosinfo-debian-10-cross-armv7l.zip
delete mode 100644 buildenv-libosinfo-debian-10-cross-i686.Dockerfile
create mode 100644 buildenv-libosinfo-debian-10-cross-i686.zip
delete mode 100644 buildenv-libosinfo-debian-10-cross-mips.Dockerfile
create mode 100644 buildenv-libosinfo-debian-10-cross-mips.zip
delete mode 100644 buildenv-libosinfo-debian-10-cross-mips64el.Dockerfile
create mode 100644 buildenv-libosinfo-debian-10-cross-mips64el.zip
delete mode 100644 buildenv-libosinfo-debian-10-cross-mipsel.Dockerfile
create mode 100644 buildenv-libosinfo-debian-10-cross-mipsel.zip
delete mode 100644 buildenv-libosinfo-debian-10-cross-ppc64le.Dockerfile
create mode 100644 buildenv-libosinfo-debian-10-cross-ppc64le.zip
delete mode 100644 buildenv-libosinfo-debian-10-cross-s390x.Dockerfile
create mode 100644 buildenv-libosinfo-debian-10-cross-s390x.zip
delete mode 100644 buildenv-libosinfo-debian-10.Dockerfile
create mode 100644 buildenv-libosinfo-debian-10.zip
delete mode 100644 buildenv-libosinfo-debian-9-cross-aarch64.Dockerfile
create mode 100644 buildenv-libosinfo-debian-9-cross-aarch64.zip
delete mode 100644 buildenv-libosinfo-debian-9-cross-armv6l.Dockerfile
create mode 100644 buildenv-libosinfo-debian-9-cross-armv6l.zip
delete mode 100644 buildenv-libosinfo-debian-9-cross-armv7l.Dockerfile
create mode 100644 buildenv-libosinfo-debian-9-cross-armv7l.zip
delete mode 100644 buildenv-libosinfo-debian-9-cross-mips.Dockerfile
create mode 100644 buildenv-libosinfo-debian-9-cross-mips.zip
delete mode 100644 buildenv-libosinfo-debian-9-cross-mips64el.Dockerfile
create mode 100644 buildenv-libosinfo-debian-9-cross-mips64el.zip
delete mode 100644 buildenv-libosinfo-debian-9-cross-mipsel.Dockerfile
create mode 100644 buildenv-libosinfo-debian-9-cross-mipsel.zip
delete mode 100644 buildenv-libosinfo-debian-9-cross-ppc64le.Dockerfile
create mode 100644 buildenv-libosinfo-debian-9-cross-ppc64le.zip
delete mode 100644 buildenv-libosinfo-debian-9-cross-s390x.Dockerfile
create mode 100644 buildenv-libosinfo-debian-9-cross-s390x.zip
delete mode 100644 buildenv-libosinfo-debian-9.Dockerfile
create mode 100644 buildenv-libosinfo-debian-9.zip
delete mode 100644 buildenv-libosinfo-debian-sid-cross-aarch64.Dockerfile
create mode 100644 buildenv-libosinfo-debian-sid-cross-aarch64.zip
delete mode 100644 buildenv-libosinfo-debian-sid-cross-armv6l.Dockerfile
create mode 100644 buildenv-libosinfo-debian-sid-cross-armv6l.zip
delete mode 100644 buildenv-libosinfo-debian-sid-cross-armv7l.Dockerfile
create mode 100644 buildenv-libosinfo-debian-sid-cross-armv7l.zip
delete mode 100644 buildenv-libosinfo-debian-sid-cross-i686.Dockerfile
create mode 100644 buildenv-libosinfo-debian-sid-cross-i686.zip
delete mode 100644 buildenv-libosinfo-debian-sid-cross-mips.Dockerfile
create mode 100644 buildenv-libosinfo-debian-sid-cross-mips.zip
delete mode 100644 buildenv-libosinfo-debian-sid-cross-mips64el.Dockerfile
create mode 100644 buildenv-libosinfo-debian-sid-cross-mips64el.zip
delete mode 100644 buildenv-libosinfo-debian-sid-cross-mipsel.Dockerfile
create mode 100644 buildenv-libosinfo-debian-sid-cross-mipsel.zip
delete mode 100644 buildenv-libosinfo-debian-sid-cross-ppc64le.Dockerfile
create mode 100644 buildenv-libosinfo-debian-sid-cross-ppc64le.zip
delete mode 100644 buildenv-libosinfo-debian-sid-cross-s390x.Dockerfile
create mode 100644 buildenv-libosinfo-debian-sid-cross-s390x.zip
delete mode 100644 buildenv-libosinfo-debian-sid.Dockerfile
create mode 100644 buildenv-libosinfo-debian-sid.zip
delete mode 100644 buildenv-libosinfo-fedora-29.Dockerfile
create mode 100644 buildenv-libosinfo-fedora-29.zip
delete mode 100644 buildenv-libosinfo-fedora-30.Dockerfile
create mode 100644 buildenv-libosinfo-fedora-30.zip
delete mode 100644 buildenv-libosinfo-fedora-rawhide.Dockerfile
create mode 100644 buildenv-libosinfo-fedora-rawhide.zip
delete mode 100644 buildenv-libosinfo-ubuntu-16.Dockerfile
create mode 100644 buildenv-libosinfo-ubuntu-16.zip
delete mode 100644 buildenv-libosinfo-ubuntu-18.Dockerfile
create mode 100644 buildenv-libosinfo-ubuntu-18.zip
delete mode 100644 buildenv-libvirt-centos-7.Dockerfile
create mode 100644 buildenv-libvirt-centos-7.zip
delete mode 100644 buildenv-libvirt-debian-10-cross-aarch64.Dockerfile
create mode 100644 buildenv-libvirt-debian-10-cross-aarch64.zip
delete mode 100644 buildenv-libvirt-debian-10-cross-armv6l.Dockerfile
create mode 100644 buildenv-libvirt-debian-10-cross-armv6l.zip
delete mode 100644 buildenv-libvirt-debian-10-cross-armv7l.Dockerfile
create mode 100644 buildenv-libvirt-debian-10-cross-armv7l.zip
delete mode 100644 buildenv-libvirt-debian-10-cross-i686.Dockerfile
create mode 100644 buildenv-libvirt-debian-10-cross-i686.zip
delete mode 100644 buildenv-libvirt-debian-10-cross-mips.Dockerfile
create mode 100644 buildenv-libvirt-debian-10-cross-mips.zip
delete mode 100644 buildenv-libvirt-debian-10-cross-mips64el.Dockerfile
create mode 100644 buildenv-libvirt-debian-10-cross-mips64el.zip
delete mode 100644 buildenv-libvirt-debian-10-cross-mipsel.Dockerfile
create mode 100644 buildenv-libvirt-debian-10-cross-mipsel.zip
delete mode 100644 buildenv-libvirt-debian-10-cross-ppc64le.Dockerfile
create mode 100644 buildenv-libvirt-debian-10-cross-ppc64le.zip
delete mode 100644 buildenv-libvirt-debian-10-cross-s390x.Dockerfile
create mode 100644 buildenv-libvirt-debian-10-cross-s390x.zip
delete mode 100644 buildenv-libvirt-debian-10.Dockerfile
create mode 100644 buildenv-libvirt-debian-10.zip
delete mode 100644 buildenv-libvirt-debian-9-cross-aarch64.Dockerfile
create mode 100644 buildenv-libvirt-debian-9-cross-aarch64.zip
delete mode 100644 buildenv-libvirt-debian-9-cross-armv6l.Dockerfile
create mode 100644 buildenv-libvirt-debian-9-cross-armv6l.zip
delete mode 100644 buildenv-libvirt-debian-9-cross-armv7l.Dockerfile
create mode 100644 buildenv-libvirt-debian-9-cross-armv7l.zip
delete mode 100644 buildenv-libvirt-debian-9-cross-mips.Dockerfile
create mode 100644 buildenv-libvirt-debian-9-cross-mips.zip
delete mode 100644 buildenv-libvirt-debian-9-cross-mips64el.Dockerfile
create mode 100644 buildenv-libvirt-debian-9-cross-mips64el.zip
delete mode 100644 buildenv-libvirt-debian-9-cross-mipsel.Dockerfile
create mode 100644 buildenv-libvirt-debian-9-cross-mipsel.zip
delete mode 100644 buildenv-libvirt-debian-9-cross-ppc64le.Dockerfile
create mode 100644 buildenv-libvirt-debian-9-cross-ppc64le.zip
delete mode 100644 buildenv-libvirt-debian-9-cross-s390x.Dockerfile
create mode 100644 buildenv-libvirt-debian-9-cross-s390x.zip
delete mode 100644 buildenv-libvirt-debian-9.Dockerfile
create mode 100644 buildenv-libvirt-debian-9.zip
delete mode 100644 buildenv-libvirt-debian-sid-cross-aarch64.Dockerfile
create mode 100644 buildenv-libvirt-debian-sid-cross-aarch64.zip
delete mode 100644 buildenv-libvirt-debian-sid-cross-armv6l.Dockerfile
create mode 100644 buildenv-libvirt-debian-sid-cross-armv6l.zip
delete mode 100644 buildenv-libvirt-debian-sid-cross-armv7l.Dockerfile
create mode 100644 buildenv-libvirt-debian-sid-cross-armv7l.zip
delete mode 100644 buildenv-libvirt-debian-sid-cross-i686.Dockerfile
create mode 100644 buildenv-libvirt-debian-sid-cross-i686.zip
delete mode 100644 buildenv-libvirt-debian-sid-cross-mips.Dockerfile
create mode 100644 buildenv-libvirt-debian-sid-cross-mips.zip
delete mode 100644 buildenv-libvirt-debian-sid-cross-mips64el.Dockerfile
create mode 100644 buildenv-libvirt-debian-sid-cross-mips64el.zip
delete mode 100644 buildenv-libvirt-debian-sid-cross-mipsel.Dockerfile
create mode 100644 buildenv-libvirt-debian-sid-cross-mipsel.zip
delete mode 100644 buildenv-libvirt-debian-sid-cross-ppc64le.Dockerfile
create mode 100644 buildenv-libvirt-debian-sid-cross-ppc64le.zip
delete mode 100644 buildenv-libvirt-debian-sid-cross-s390x.Dockerfile
create mode 100644 buildenv-libvirt-debian-sid-cross-s390x.zip
delete mode 100644 buildenv-libvirt-debian-sid.Dockerfile
create mode 100644 buildenv-libvirt-debian-sid.zip
delete mode 100644 buildenv-libvirt-fedora-29.Dockerfile
create mode 100644 buildenv-libvirt-fedora-29.zip
delete mode 100644 buildenv-libvirt-fedora-30.Dockerfile
create mode 100644 buildenv-libvirt-fedora-30.zip
delete mode 100644 buildenv-libvirt-fedora-rawhide.Dockerfile
create mode 100644 buildenv-libvirt-fedora-rawhide.zip
delete mode 100644 buildenv-libvirt-ubuntu-16.Dockerfile
create mode 100644 buildenv-libvirt-ubuntu-16.zip
delete mode 100644 buildenv-libvirt-ubuntu-18.Dockerfile
create mode 100644 buildenv-libvirt-ubuntu-18.zip
--
2.21.0
5 years, 3 months
[libvirt] [PATCH 0/2] network: fix crash during cleanup from failure to allocate port
by Laine Stump
The first patch fixes the bug. The 2nd patch just updates some code
that I noticed while fixing the bug (because I figured someone would
whine that I was just moving around calls to outdated APIs).
Laine Stump (2):
network: fix crash during cleanup from failure to allocate port
network: replace virSaveLastError() with virErrorPreserveLast()
src/network/bridge_driver.c | 23 +++++++++++------------
1 file changed, 11 insertions(+), 12 deletions(-)
--
2.21.0
5 years, 3 months
[libvirt] [PATCH] access: fix incorrect addition to virAccessPermNetwork
by Laine Stump
Commit e69444e17 (first appeared in libvirt-5.5.0) added the new value
"VIR_ACCESS_PERM_NETWORK_SEARCH_PORTS" to the virAccessPerNetwork
enum, and also the string "search_ports" to the VIR_ENUM_IMPL() macro
for that enum. Unfortunately, the enum value was added in the middle
of the list, while the string was added to the end of the
VIR_ENUM_IMPL().
This patch corrects that error by moving the new value to the end of
the enum definition, so that the order matches that of the string
list.
Resolves: https://bugzilla.redhat.com/1741428
Signed-off-by: Laine Stump <laine(a)redhat.com>
---
src/access/viraccessperm.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/access/viraccessperm.h b/src/access/viraccessperm.h
index a42512d5e0..7480ee8c2f 100644
--- a/src/access/viraccessperm.h
+++ b/src/access/viraccessperm.h
@@ -410,18 +410,18 @@ typedef enum {
*/
VIR_ACCESS_PERM_NETWORK_START,
- /**
- * @desc: List network ports
- * @message: Listing network ports requires authorization
- */
- VIR_ACCESS_PERM_NETWORK_SEARCH_PORTS,
-
/**
* @desc: Stop network
* @message: Stopping network requires authorization
*/
VIR_ACCESS_PERM_NETWORK_STOP,
+ /**
+ * @desc: List network ports
+ * @message: Listing network ports requires authorization
+ */
+ VIR_ACCESS_PERM_NETWORK_SEARCH_PORTS,
+
VIR_ACCESS_PERM_NETWORK_LAST
} virAccessPermNetwork;
--
2.21.0
5 years, 3 months
[libvirt] [PATCH] tests: virpcimock: Always declare __open_2
by Peter Krempa
In some cases e.g. with clang on fedora 30 __open2 isn't even declared
which results in the following build error:
/home/pipo/libvirt/tests/virpcimock.c:939:1: error: no previous prototype for function
'__open_2' [-Werror,-Wmissing-prototypes]
__open_2(const char *path, int flags)
Add a separate declaration to appease the compiler.
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
tests/virpcimock.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/tests/virpcimock.c b/tests/virpcimock.c
index 829d61cd3f..cfe91ba3ff 100644
--- a/tests/virpcimock.c
+++ b/tests/virpcimock.c
@@ -935,6 +935,11 @@ open(const char *path, int flags, ...)
}
+/* in some cases this function may not be present in headers, so we need
+ * a declaration to silence the complier */
+int
+__open_2(const char *path, int flags);
+
int
__open_2(const char *path, int flags)
{
--
2.21.0
5 years, 3 months
