March 2019 - Devel - libvirt List Archives

[libvirt] fix method delete() in src/main/java/org/libvirt/DomainSnapshot.java
by 傅姜晨 15 Mar '19

15 Mar '19

if VDSP is set to null during the method delete(), Object snapshot can't be freed in method free() in the same class. Showing 1 changed file with 1 addition and 7 deletions. View file 8 src/main/java/org/libvirt/DomainSnapshot.java | | @@ -35,13 +35,7 @@ public DomainSnapshot(Connect virConnect, DomainSnapshotPointer VDSP) { | | | | | * @throws LibvirtException | | | | | */ | | | | | publicintdelete(intflags) throwsLibvirtException { | | | | | int success =0; | | | | | if (VDSP!=null) { | | | | | success = processError(libvirt.virDomainSnapshotDelete(VDSP, flags)); | | | | | VDSP=null; | | | | | } | | | | | | | | | | return success; | | | | | return processError(libvirt.virDomainSnapshotDelete(VDSP, flags)); | | | | | } | | | | | | | | | | @Override |

2 1

[libvirt] [PATCH] news: Add entry describing support for Xen's max grant frames
by Jim Fehlig 15 Mar '19

15 Mar '19

Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- docs/news.xml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 896700fa97..f437a3f455 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -82,6 +82,16 @@ chooses. </description> </change> + <change> + <summary> + Xen: Add support for max grant frames setting + </summary> + <description> + Add support for Xen's max_grant_frames setting by adding a + new xenbus controller type with a maxGrantFrames attribute. + E.g. <code><controller type='xenbus' maxGrantFrames='64'/></code> + </description> + </change> </section> <section title="Improvements"> </section> -- 2.20.1

2 1

[libvirt] Seccomp profile for swtpm as default
by Stefan Berger 15 Mar '19

15 Mar '19

Hello! If you have some feedback regarding a seccomp profile extension for swtpm for v0.2, please let me know. I created this github issue here: https://github.com/stefanberger/swtpm/issues/115 Basically the choice is whether to make the creation of the seccomp profile a default behavior or have the caller explicitly pass the '--seccomp profile=default' on the command line, which then in turn would require libvirt for example to check whether this current version of swtpm supports the feature either by swtpm version or by strstr() the help page. Regards, Stefan

2 3

[libvirt] [PATCH] run: Don't export unnecessary paths
by Andrea Bolognani 15 Mar '19

15 Mar '19

We're using virFileFindResourceFull() to locate resources nowadays, which makes exporting these information in the environment unnecessary: see virDriverLoadModule() for LIBVIRT_DRIVER_DIR virLockManagerPluginNew() for LIBVIRT_LOCK_MANAGER_PLUGIN_DIR virLockManagerLockDaemonConnectionNew() for VIRTLOCKD_PATH doRemoteOpen() for LIBVIRTD_PATH As further proof that we don't need to expose the information this way anymore, we're not even exporting VIRTLOGD_PATH, which would be necessary if virLogManagerConnect() didn't already take care of that for us. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- run.in | 5 ----- 1 file changed, 5 deletions(-) diff --git a/run.in b/run.in index 06ad54b62b..9a1c6ea11a 100644 --- a/run.in +++ b/run.in @@ -60,11 +60,6 @@ else fi export PKG_CONFIG_PATH -export LIBVIRT_DRIVER_DIR="$b/src/.libs" -export LIBVIRT_LOCK_MANAGER_PLUGIN_DIR="$b/src/.libs" -export VIRTLOCKD_PATH="$b/src" -export LIBVIRTD_PATH="$b/src" - # This is a cheap way to find some use-after-free and uninitialized # read problems when using glibc. random_val="$(awk 'BEGIN{srand(); print 1+int(255*rand())}' < /dev/null)" -- 2.20.1

2 1

[libvirt] [PATCH v2 0/3] Define XDG variables for hypervisor domains
by Erik Skultety 15 Mar '19

15 Mar '19

v1 here: https://www.redhat.com/archives/libvir-list/2019-March/msg00323.html since v1: As per conversation with Dan P.B: - dropped XDG setting (apart from XDG_CACHE_HOME - we need that) for session QEMU - dropped setting HOME for session mode (HOME is passed from the session) - dropped previous patch 2 and decomposed the original patch into 2 units So for v2, this is what the settings will look like: system QEMU: HOME=/var/lib/libvirt/qemu/domain-5-f-live \ XDG_DATA_HOME=/var/lib/libvirt/qemu/domain-5-f-live/.local/share \ XDG_CACHE_HOME=/var/lib/libvirt/qemu/domain-5-f-live/.cache \ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain-5-f-live/.config \ session QEMU: XDG_CACHE_HOME=/home/eskultet/.config/libvirt/qemu/lib/domain-4-f-live/.cache \ NOTE: This version doesn't contain the test changes in order to bring down the patch size, so this won't compile, if you want to try it, see my github with full changeset: https://github.com/eskultety/libvirt/tree/xdg-vars Travis build: https://travis-ci.org/eskultety/libvirt/builds/503560867 Erik Skultety (3): util: command: Introduce virCommandAddEnvXDG helper qemu: command: Enforce setting XDG variables for system QEMU qemu: command: Override HOME variable for system QEMU src/libvirt_private.syms | 1 + src/qemu/qemu_command.c | 17 +++++++++++++++++ src/util/vircommand.c | 21 +++++++++++++++++++++ src/util/vircommand.h | 2 ++ 4 files changed, 41 insertions(+) -- 2.20.1

2 7

[libvirt] [PATCH v2 0/6] bhyve: model PCI ISA bridge
by Roman Bogorodskiy 15 Mar '19

15 Mar '19

Changes from v1: * Changed LPC controller type from PCI to ISA * Split bhyve changes into smaller chunks Also, I decided to keep PCI slot 1 reserved for LPC only, even if users choose other slot for LPC. If things work fine, it could be easily made available for other devices in future. Roman Bogorodskiy (6): conf: add 'isa' controller type bhyve: add bhyveDomainDefNeedsISAController helper bhyve: support 'isa' controller for LPC bhyve: automatically add 'isa' controller docs: bhyve: document isa-bridge addressing news: document bhyve isa-bridge changes docs/drvbhyve.html.in | 22 ++++++++++++ docs/news.xml | 10 ++++++ docs/schemas/domaincommon.rng | 13 +++++++ src/bhyve/bhyve_command.c | 30 ++++++++-------- src/bhyve/bhyve_device.c | 25 ++++++++++--- src/bhyve/bhyve_domain.c | 15 ++++++++ src/conf/domain_conf.c | 10 ++++++ src/conf/domain_conf.h | 9 +++++ src/qemu/qemu_command.c | 1 + src/qemu/qemu_domain.c | 2 ++ src/qemu/qemu_domain_address.c | 1 + src/vbox/vbox_common.c | 1 + ...ml2argv-addr-isa-controller-on-slot-1.args | 10 ++++++ ...2argv-addr-isa-controller-on-slot-1.ldargs | 3 ++ ...xml2argv-addr-isa-controller-on-slot-1.xml | 26 ++++++++++++++ ...l2argv-addr-isa-controller-on-slot-31.args | 10 ++++++ ...argv-addr-isa-controller-on-slot-31.ldargs | 3 ++ ...ml2argv-addr-isa-controller-on-slot-31.xml | 26 ++++++++++++++ ...argv-addr-non-isa-controller-on-slot-1.xml | 23 ++++++++++++ .../bhyvexml2argv-console.args | 2 +- .../bhyvexml2argv-isa-controller.args | 10 ++++++ .../bhyvexml2argv-isa-controller.ldargs | 3 ++ .../bhyvexml2argv-isa-controller.xml | 24 +++++++++++++ ...bhyvexml2argv-isa-multiple-controllers.xml | 25 +++++++++++++ .../bhyvexml2argv-serial-grub-nocons.args | 2 +- .../bhyvexml2argv-serial-grub.args | 2 +- .../bhyvexml2argv-serial.args | 2 +- .../bhyvexml2argvdata/bhyvexml2argv-uefi.args | 4 +-- .../bhyvexml2argv-vnc-autoport.args | 4 +-- .../bhyvexml2argv-vnc-vgaconf-io.args | 4 +-- .../bhyvexml2argv-vnc-vgaconf-off.args | 4 +-- .../bhyvexml2argv-vnc-vgaconf-on.args | 4 +-- .../bhyvexml2argvdata/bhyvexml2argv-vnc.args | 4 +-- tests/bhyvexml2argvtest.c | 5 +++ ...l2xmlout-addr-isa-controller-on-slot-1.xml | 36 +++++++++++++++++++ ...2xmlout-addr-isa-controller-on-slot-31.xml | 36 +++++++++++++++++++ .../bhyvexml2xmlout-console.xml | 3 ++ .../bhyvexml2xmlout-isa-controller.xml | 36 +++++++++++++++++++ .../bhyvexml2xmlout-serial-grub-nocons.xml | 3 ++ .../bhyvexml2xmlout-serial-grub.xml | 3 ++ .../bhyvexml2xmlout-serial.xml | 3 ++ .../bhyvexml2xmlout-vnc-autoport.xml | 3 ++ .../bhyvexml2xmlout-vnc-vgaconf-io.xml | 3 ++ .../bhyvexml2xmlout-vnc-vgaconf-off.xml | 3 ++ .../bhyvexml2xmlout-vnc-vgaconf-on.xml | 3 ++ .../bhyvexml2xmlout-vnc.xml | 3 ++ tests/bhyvexml2xmltest.c | 3 ++ 47 files changed, 443 insertions(+), 34 deletions(-) create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-on-slot-1.args create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-on-slot-1.ldargs create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-on-slot-1.xml create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-on-slot-31.args create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-on-slot-31.ldargs create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-on-slot-31.xml create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-addr-non-isa-controller-on-slot-1.xml create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-isa-controller.args create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-isa-controller.ldargs create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-isa-controller.xml create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-isa-multiple-controllers.xml create mode 100644 tests/bhyvexml2xmloutdata/bhyvexml2xmlout-addr-isa-controller-on-slot-1.xml create mode 100644 tests/bhyvexml2xmloutdata/bhyvexml2xmlout-addr-isa-controller-on-slot-31.xml create mode 100644 tests/bhyvexml2xmloutdata/bhyvexml2xmlout-isa-controller.xml -- 2.20.1

2 16

[libvirt] [PATCH] qemu: Set job statsType for external memory snapshot
by Jiri Denemark 15 Mar '19

15 Mar '19

Any job which is able to provide statistics that can be queried via virDomainGetJob{Stats,Info} has to set an appropriate statsType. Without a proper statsType qemuDomainJobInfoToParams and qemuDomainJobInfoToInfo have no idea what statistics should be sent to the API caller. https://bugzilla.redhat.com/show_bug.cgi?id=1688774 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e461fb51b0..0d0aac6048 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -15558,6 +15558,8 @@ qemuDomainSnapshotCreateActiveExternal(virQEMUDriverPtr driver, if (!qemuMigrationSrcIsAllowed(driver, vm, false, 0)) goto cleanup; + priv->job.current->statsType = QEMU_DOMAIN_JOB_STATS_TYPE_SAVEDUMP; + /* allow the migration job to be cancelled or the domain to be paused */ qemuDomainObjSetAsyncJobMask(vm, (QEMU_JOB_DEFAULT_MASK | JOB_MASK(QEMU_JOB_SUSPEND) | -- 2.21.0

2 1

[libvirt] [PATCH 0/4] libxl: add support for max grant frames
by Jim Fehlig 14 Mar '19

14 Mar '19

This patch series takes the long road on the way to adding support for Xen's max_grant_frames to libvirt. Patch1 adds a new 'xenbus' controller type that supports a maxGrantFrames attribute. maxGrantFrames describes the maximum IO buffer space (or DMA space) available in the xenbus controller for use by connected paravirtual devices. Patch2 adds a xenbus controller to the domXML in post-parse callback if one is not explicitly specified, with downside of requiring touching all test files. Patch3 adds support for max grant frames in the libxl driver and a test to check the libxl domain config generator. Patch4 adds support for the setting on the domXML<->native config converter and also includes a test. Jim Fehlig (4): conf: Add a new 'xenbus' controller type libxl: Add implicit xenbus controller libxl: Add support for max_grant_frames xenconfig: Add support for max_grant_frames docs/formatdomain.html.in | 6 ++ docs/schemas/domaincommon.rng | 11 +++ src/conf/domain_conf.c | 25 ++++++ src/conf/domain_conf.h | 8 ++ src/libxl/libxl_conf.c | 9 ++ src/libxl/libxl_domain.c | 5 ++ src/qemu/qemu_command.c | 1 + src/qemu/qemu_domain.c | 2 + src/qemu/qemu_domain_address.c | 1 + src/xenconfig/xen_xl.c | 56 ++++++++++++ .../max-gntframes-hvm.json | 90 +++++++++++++++++++ .../max-gntframes-hvm.xml | 37 ++++++++ tests/libxlxml2domconfigtest.c | 3 + tests/sexpr2xmldata/sexpr2xml-boot-grub.xml | 1 + .../sexpr2xmldata/sexpr2xml-bridge-ipaddr.xml | 1 + tests/sexpr2xmldata/sexpr2xml-curmem.xml | 1 + .../sexpr2xml-disk-block-shareable.xml | 1 + tests/sexpr2xmldata/sexpr2xml-disk-block.xml | 1 + .../sexpr2xml-disk-drv-blktap-qcow.xml | 1 + .../sexpr2xml-disk-drv-blktap-raw.xml | 1 + .../sexpr2xml-disk-drv-blktap2-raw.xml | 1 + tests/sexpr2xmldata/sexpr2xml-disk-file.xml | 1 + tests/sexpr2xmldata/sexpr2xml-fv-autoport.xml | 1 + .../sexpr2xml-fv-empty-kernel.xml | 1 + .../sexpr2xmldata/sexpr2xml-fv-force-hpet.xml | 1 + .../sexpr2xml-fv-force-nohpet.xml | 1 + tests/sexpr2xmldata/sexpr2xml-fv-kernel.xml | 1 + .../sexpr2xmldata/sexpr2xml-fv-localtime.xml | 1 + .../sexpr2xml-fv-net-netfront.xml | 1 + .../sexpr2xml-fv-parallel-tcp.xml | 1 + .../sexpr2xml-fv-serial-dev-2-ports.xml | 1 + .../sexpr2xml-fv-serial-dev-2nd-port.xml | 1 + .../sexpr2xml-fv-serial-file.xml | 1 + .../sexpr2xml-fv-serial-null.xml | 1 + .../sexpr2xml-fv-serial-pipe.xml | 1 + .../sexpr2xmldata/sexpr2xml-fv-serial-pty.xml | 1 + .../sexpr2xml-fv-serial-stdio.xml | 1 + .../sexpr2xml-fv-serial-tcp-telnet.xml | 1 + .../sexpr2xmldata/sexpr2xml-fv-serial-tcp.xml | 1 + .../sexpr2xmldata/sexpr2xml-fv-serial-udp.xml | 1 + .../sexpr2xml-fv-serial-unix.xml | 1 + .../sexpr2xmldata/sexpr2xml-fv-sound-all.xml | 1 + tests/sexpr2xmldata/sexpr2xml-fv-sound.xml | 1 + tests/sexpr2xmldata/sexpr2xml-fv-usbmouse.xml | 1 + .../sexpr2xmldata/sexpr2xml-fv-usbtablet.xml | 1 + tests/sexpr2xmldata/sexpr2xml-fv-utc.xml | 1 + tests/sexpr2xmldata/sexpr2xml-fv-v2.xml | 1 + tests/sexpr2xmldata/sexpr2xml-fv.xml | 1 + tests/sexpr2xmldata/sexpr2xml-net-bridged.xml | 1 + tests/sexpr2xmldata/sexpr2xml-net-e1000.xml | 1 + tests/sexpr2xmldata/sexpr2xml-net-routed.xml | 1 + .../sexpr2xml-no-source-cdrom.xml | 1 + tests/sexpr2xmldata/sexpr2xml-pci-devs.xml | 1 + .../sexpr2xml-pv-bootloader-cmdline.xml | 1 + .../sexpr2xmldata/sexpr2xml-pv-bootloader.xml | 1 + .../sexpr2xmldata/sexpr2xml-pv-localtime.xml | 1 + tests/sexpr2xmldata/sexpr2xml-pv-vcpus.xml | 1 + .../sexpr2xml-pv-vfb-new-vncdisplay.xml | 1 + tests/sexpr2xmldata/sexpr2xml-pv-vfb-new.xml | 1 + .../sexpr2xml-pv-vfb-type-crash.xml | 1 + tests/sexpr2xmldata/sexpr2xml-pv.xml | 1 + tests/sexpr2xmldata/sexpr2xml-vif-rate.xml | 1 + tests/xlconfigdata/test-channel-pty.xml | 1 + tests/xlconfigdata/test-channel-unix.xml | 1 + .../test-disk-positional-parms-full.xml | 1 + .../test-disk-positional-parms-partial.xml | 1 + tests/xlconfigdata/test-disk-qed.xml | 1 + tests/xlconfigdata/test-fullvirt-cpuid.xml | 1 + ...ullvirt-direct-kernel-boot-bogus-extra.xml | 1 + ...test-fullvirt-direct-kernel-boot-extra.xml | 1 + .../test-fullvirt-direct-kernel-boot.xml | 1 + .../xlconfigdata/test-fullvirt-hpet-timer.xml | 1 + .../test-fullvirt-multi-timer.xml | 1 + .../test-fullvirt-multiserial.xml | 1 + tests/xlconfigdata/test-fullvirt-multiusb.xml | 1 + .../test-fullvirt-nestedhvm-disabled.xml | 1 + .../xlconfigdata/test-fullvirt-nestedhvm.xml | 1 + tests/xlconfigdata/test-fullvirt-nohap.xml | 1 + tests/xlconfigdata/test-fullvirt-ovmf.xml | 1 + .../test-fullvirt-ovswitch-tagged.xml | 1 + .../test-fullvirt-ovswitch-trunked.xml | 1 + .../xlconfigdata/test-fullvirt-tsc-timer.xml | 1 + tests/xlconfigdata/test-fullvirt-type.xml | 1 + tests/xlconfigdata/test-fullvirt-vnuma.xml | 1 + tests/xlconfigdata/test-max-gntframes.cfg | 13 +++ tests/xlconfigdata/test-max-gntframes.xml | 32 +++++++ tests/xlconfigdata/test-new-disk.xml | 1 + ...test-paravirt-cmdline-bogus-extra-root.xml | 1 + .../test-paravirt-cmdline-extra-root.xml | 1 + tests/xlconfigdata/test-paravirt-cmdline.xml | 1 + tests/xlconfigdata/test-paravirt-maxvcpus.xml | 1 + tests/xlconfigdata/test-paravirt-type.xml | 1 + tests/xlconfigdata/test-pvh-type.xml | 1 + .../test-rbd-multihost-noauth.xml | 1 + tests/xlconfigdata/test-spice-features.xml | 1 + tests/xlconfigdata/test-spice.xml | 1 + tests/xlconfigdata/test-usb.xml | 1 + tests/xlconfigdata/test-usbctrl.xml | 1 + tests/xlconfigdata/test-vif-multi-ip.xml | 1 + tests/xlconfigdata/test-vif-rate.xml | 1 + tests/xlconfigdata/test-vif-typename.xml | 1 + tests/xlconfigtest.c | 4 + .../xmconfigdata/test-disk-drv-blktap-raw.xml | 1 + .../test-disk-drv-blktap2-raw.xml | 1 + tests/xmconfigdata/test-escape-paths.xml | 1 + .../test-fullvirt-default-feature.xml | 1 + .../xmconfigdata/test-fullvirt-force-hpet.xml | 1 + .../test-fullvirt-force-nohpet.xml | 1 + .../xmconfigdata/test-fullvirt-localtime.xml | 1 + .../test-fullvirt-net-netfront.xml | 1 + .../xmconfigdata/test-fullvirt-new-cdrom.xml | 1 + tests/xmconfigdata/test-fullvirt-nohap.xml | 1 + .../test-fullvirt-parallel-tcp.xml | 1 + .../test-fullvirt-serial-file.xml | 1 + .../test-fullvirt-serial-null.xml | 1 + .../test-fullvirt-serial-pipe.xml | 1 + .../xmconfigdata/test-fullvirt-serial-pty.xml | 1 + .../test-fullvirt-serial-stdio.xml | 1 + .../test-fullvirt-serial-tcp-telnet.xml | 1 + .../xmconfigdata/test-fullvirt-serial-tcp.xml | 1 + .../xmconfigdata/test-fullvirt-serial-udp.xml | 1 + .../test-fullvirt-serial-unix.xml | 1 + tests/xmconfigdata/test-fullvirt-sound.xml | 1 + tests/xmconfigdata/test-fullvirt-usbmouse.xml | 1 + .../xmconfigdata/test-fullvirt-usbtablet.xml | 1 + tests/xmconfigdata/test-fullvirt-utc.xml | 1 + tests/xmconfigdata/test-no-source-cdrom.xml | 1 + .../xmconfigdata/test-paravirt-extra-root.xml | 1 + tests/xmconfigdata/test-paravirt-maxvcpus.xml | 1 + .../xmconfigdata/test-paravirt-net-e1000.xml | 1 + .../test-paravirt-net-vifname.xml | 1 + .../test-paravirt-new-pvfb-vncdisplay.xml | 1 + tests/xmconfigdata/test-paravirt-new-pvfb.xml | 1 + tests/xmconfigdata/test-paravirt-root.xml | 1 + tests/xmconfigdata/test-paravirt-vcpu.xml | 1 + tests/xmconfigdata/test-pci-devs.xml | 1 + 136 files changed, 423 insertions(+) create mode 100644 tests/libxlxml2domconfigdata/max-gntframes-hvm.json create mode 100644 tests/libxlxml2domconfigdata/max-gntframes-hvm.xml create mode 100644 tests/xlconfigdata/test-max-gntframes.cfg create mode 100644 tests/xlconfigdata/test-max-gntframes.xml -- 2.20.1

3 12

[libvirt] [PATCH 0/2] Require YAJL for QEMU build
by Michal Privoznik 14 Mar '19

14 Mar '19

This also fixes a problem that Cole reported on IRC where qemufirmware test is failing on FreeBSD because QEMU driver is enabled but there's no YAJL. Michal Prívozník (2): virt-yajl.m4: Drop useless check for qemu virt-driver-qemu.m4: Require YAJL m4/virt-driver-qemu.m4 | 9 +++++++++ m4/virt-yajl.m4 | 20 -------------------- 2 files changed, 9 insertions(+), 20 deletions(-) -- 2.19.2

4 7

[libvirt] [PATCH] virstoragefile: identify GPFS as cluster FS
by Diego Michelotto 14 Mar '19

14 Mar '19

GPFS is 'IBM General Parallel File System', also called 'IBM Spectrum Scale', stalls when a process issues a lot of fsyncs in a short timeframe. It is better if the VM I/O is not synchronous. It is racommended to use writeback caching policy. In order to permit that it is added VIR_FILE_SHFS_GPFS to the list of shared file systems in virStorageFileIsClusterFS function. Signed-off-by: Diego Michelotto <diego.michelotto(a)cnaf.infn.it> --- src/util/virstoragefile.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index b2e308d81d..0fe2819dc6 100644 --- a/src/util/virstoragefile.c +++ b/src/util/virstoragefile.c @@ -1349,7 +1349,8 @@ int virStorageFileIsClusterFS(const char *path) return virFileIsSharedFSType(path, VIR_FILE_SHFS_GFS2 | VIR_FILE_SHFS_OCFS | - VIR_FILE_SHFS_CEPH); + VIR_FILE_SHFS_CEPH | + VIR_FILE_SHFS_GPFS); } #ifdef LVS -- 2.20.1

2 2