October 2019 - Devel - libvirt List Archives

[libvirt] [PATCH] conf: Do not validate resolution XML if 'x' or/and 'y' are 0.
by jcfaracco＠gmail.com 21 Oct '19

21 Oct '19

From: Julio Faracco <jcfaracco(a)gmail.com> There is an issue with <resolution/> when of 'x' or 'y' settings are 0. Function virDomainVideoResolutionDefParseXML() will validate this XML, but both 'x' and 'y' will be removed. One example, if someone defines this settings: <model ...> <resolution x='1024' y='0'/> <model/> After applying this settings, funcion libvirt will remove both resolutions because virDomainVideoResolutionDefFormat() requires 'x' and 'y' higher than 0. So, the example above will become: <model ...> <resolution/> <model/> Now, libvirt only adds <resolution/> with 'x' and 'y' if boths strings are not NULL AND they are higher than 0. Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- src/conf/domain_conf.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 88e93f6fb8..d89d8059ce 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -15375,7 +15375,7 @@ virDomainVideoResolutionDefParseXML(xmlNodePtr node) if (virStrToLong_uip(x, NULL, 10, &def->x) < 0) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("cannot parse video x-resolution '%s'"), x); - goto cleanup; + goto error; } } @@ -15383,12 +15383,21 @@ virDomainVideoResolutionDefParseXML(xmlNodePtr node) if (virStrToLong_uip(y, NULL, 10, &def->y) < 0) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("cannot parse video y-resolution '%s'"), y); - goto cleanup; + goto error; } } + /* QEMU ignores 'xres' or/and 'yres' with value 0. */ + if (!def->x || !def->y) + goto error; + cleanup: return def; + + error: + VIR_FREE(def); + def = NULL; + goto cleanup; } static virDomainVideoDriverDefPtr -- 2.20.1

2 1

[libvirt] [PATCH] vsh: mark ctl as unused in vshReadline
by Ján Tomko 21 Oct '19

21 Oct '19

My commit removed the last use in the version for platforms without readline. Fixes: c937c1d23db00cf0f33091f9d30f7ac33d9d6aa4 Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Fixed as a push builder break. tools/vsh.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/vsh.c b/tools/vsh.c index a10a9625e4..07eea4adf9 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -3028,7 +3028,8 @@ vshReadlineDeinit(vshControl *ctl G_GNUC_UNUSED) } char * -vshReadline(vshControl *ctl, const char *prompt) +vshReadline(vshControl *ctl G_GNUC_UNUSED, + const char *prompt) { char line[1024]; char *r; -- 2.21.0

1 0

[libvirt] [PATCH] gitdm: Add other emails into IBM company
by jcfaracco＠gmail.com 21 Oct '19

21 Oct '19

From: Julio Faracco <jcfaracco(a)gmail.com> Some people from IBM does not use 'ibm.com' domain emails. They use personal or other domains. Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- docs/gitdm/companies/ibm | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/gitdm/companies/ibm b/docs/gitdm/companies/ibm index ce0315df66..de05e1be29 100644 --- a/docs/gitdm/companies/ibm +++ b/docs/gitdm/companies/ibm @@ -4,3 +4,4 @@ ibm.com # to libvirt and we don't have the corresponding @ibm.com address on file. danielhb413(a)gmail.com +jcfaracco(a)gmail.com -- 2.20.1

2 1

[libvirt] [PATCH] qemu: fix CPU model error probing capabilities for ppc
by Daniel P. Berrangé 21 Oct '19

21 Oct '19

The CPU driver only supports CPU models for PPC64 architecture, not plain PPC. Failed to probe capabilities for /usr/bin/qemu-system-ppc: this function is not supported by the connection driver: 'ppc' architecture is not supported by CPU driver This fixes a bug in commit db873ab3bc5f6fbd7d227727a62ccfee3d1c3e9d Author: Jiri Denemark <jdenemar(a)redhat.com> Date: Thu May 17 17:08:42 2018 +0200 qemu: Adapt to changed ppc64 CPU model names Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/qemu/qemu_capabilities.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 3ce1556fc2..03093fd73b 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -2454,7 +2454,7 @@ virQEMUCapsFetchCPUDefinitions(qemuMonitorPtr mon, /* QEMU 2.11 for Power renamed all CPU models to lower case, we need to * translate them back to libvirt's upper case model names. */ - if (ARCH_IS_PPC(arch)) { + if (ARCH_IS_PPC64(arch)) { VIR_AUTOSTRINGLIST libvirtModels = NULL; char **name; -- 2.21.0

3 2

[libvirt] [PATCH 00/10] tools: remove vshStrdup (glib chronicles)
by Ján Tomko 21 Oct '19

21 Oct '19

Ján Tomko (10): tools: cmdDomblkinfoGet: reindent parameters virsh: use g_strdup in cmdDomblkinfoGet virsh: use g_strdup in virshDomainGetEditMetadata virsh: getSignalNumber: rename variables virsh: getSignalNumber: use g_autofree virsh: getSignalNumber: use g_strdup tools: vshCommandArgvGetArg: one parameter per line tools: vshCommandArgvGetArg: prefer g_strdup tools: prefer g_strdup to vshStrdup tools: delete vshStrdup tools/virsh-checkpoint.c | 4 +-- tools/virsh-domain-monitor.c | 27 ++++++++++---------- tools/virsh-domain.c | 38 ++++++++++++---------------- tools/virsh-nodedev.c | 5 ++-- tools/virsh-pool.c | 30 +++++++++++----------- tools/virsh-snapshot.c | 6 ++--- tools/virsh-volume.c | 11 ++++----- tools/virsh.c | 9 +++---- tools/virt-admin.c | 6 ++--- tools/vsh.c | 48 ++++++++++++++---------------------- tools/vsh.h | 4 --- 11 files changed, 81 insertions(+), 107 deletions(-) -- 2.21.0

3 14

[libvirt] [PATCH 0/2] Couple of g_strdup_printf() fixes
by Michal Privoznik 18 Oct '19

18 Oct '19

*** BLURB HERE *** Michal Prívozník (2): virstring: Reimplement g_strdup_printf() and g_strdup_vprintf() m4: Don't suggest attribute malloc m4/virt-compile-warnings.m4 | 1 + src/libvirt_private.syms | 2 ++ src/util/virstring.c | 29 +++++++++++++++++++++++++++++ src/util/virstring.h | 11 +++++++++++ 4 files changed, 43 insertions(+) -- 2.21.0

4 6

[libvirt] [PATCH] gitdm/companies: add 'ibm' file
by Daniel Henrique Barboza 18 Oct '19

18 Oct '19

Some people from IBM does not use 'ibm.com' domain emails. CC: jcfaracco(a)gmail.com Suggested-by: Leonardo Augusto Guimarães Garcia <lagarcia(a)br.ibm.com> Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com> --- Julio, I didn't add you in this list because I am not sure about the nature of your contributions to Libvirt. Let me know if you want your email to be added here as well. docs/gitdm/companies/ibm | 6 ++++++ docs/gitdm/companies/others | 1 - 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 docs/gitdm/companies/ibm diff --git a/docs/gitdm/companies/ibm b/docs/gitdm/companies/ibm new file mode 100644 index 0000000000..ce0315df66 --- /dev/null +++ b/docs/gitdm/companies/ibm @@ -0,0 +1,6 @@ +ibm.com + +# These IBM employees used their personal email address when contributing +# to libvirt and we don't have the corresponding @ibm.com address on file. + +danielhb413(a)gmail.com diff --git a/docs/gitdm/companies/others b/docs/gitdm/companies/others index db2c0061bd..99dc1ab31e 100644 --- a/docs/gitdm/companies/others +++ b/docs/gitdm/companies/others @@ -35,7 +35,6 @@ hitachi.com Hitachi hoster-ok.com hoster-ok.com hp.com HP huawei.com Huawei -ibm.com IBM inktank.com Inktank Storage intel.com Intel intellilink.co.jp NTT DATA INTELLILINK -- 2.21.0

2 1

[libvirt] [PATCH] build: fix substitution of RUNSTATEDIR in man pages
by Daniel P. Berrangé 18 Oct '19

18 Oct '19

When RUNSTATEDIR was introduced commit d29c917ef470a25149d1f3787ec494d006549f27 Author: Daniel P. Berrangé <berrange(a)redhat.com> Date: Tue Aug 20 16:05:12 2019 +0100 src: honour the RUNSTATEDIR variable in all code The makefile rules for man pages were accidentally not updated for the new variablle name. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/Makefile.am | 2 +- src/locking/Makefile.inc.am | 2 +- src/logging/Makefile.inc.am | 2 +- src/remote/Makefile.inc.am | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 937f5216da..a7c1ad0861 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -725,7 +725,7 @@ endif WITH_LIBVIRTD %.8: %.8.in $(top_srcdir)/configure.ac $(AM_V_GEN)sed \ -e 's|[@]sysconfdir[@]|$(sysconfdir)|g' \ - -e 's|[@]localstatedir[@]|$(localstatedir)|g' \ + -e 's|[@]runstatedir[@]|$(runstatedir)|g' \ < $< > $@-t && \ mv $@-t $@ diff --git a/src/locking/Makefile.inc.am b/src/locking/Makefile.inc.am index eccf7c3a4d..a0822f77d4 100644 --- a/src/locking/Makefile.inc.am +++ b/src/locking/Makefile.inc.am @@ -280,7 +280,7 @@ virtlockd.8.in: locking/virtlockd.pod if grep 'POD ERROR' $@-t1; then rm $@-t1; exit 1; fi && \ sed \ -e 's|SYSCONFDIR|\@sysconfdir\@|g' \ - -e 's|LOCALSTATEDIR|\@localstatedir\@|g' \ + -e 's|RUNSTATEDIR|\@runstatedir\@|g' \ < $@-t1 > $@-t2 && \ rm -f $@-t1 && \ mv $@-t2 $@ diff --git a/src/logging/Makefile.inc.am b/src/logging/Makefile.inc.am index 74e94636a6..6eda40275c 100644 --- a/src/logging/Makefile.inc.am +++ b/src/logging/Makefile.inc.am @@ -118,7 +118,7 @@ virtlogd.8.in: logging/virtlogd.pod if grep 'POD ERROR' $@-t1; then rm $@-t1; exit 1; fi && \ sed \ -e 's|SYSCONFDIR|\@sysconfdir\@|g' \ - -e 's|LOCALSTATEDIR|\@localstatedir\@|g' \ + -e 's|RUNSTATEDIR|\@runstatedir\@|g' \ < $@-t1 > $@-t2 && \ rm -f $@-t1 && \ mv $@-t2 $@ diff --git a/src/remote/Makefile.inc.am b/src/remote/Makefile.inc.am index 071d19d26a..0f4f1ae8d5 100644 --- a/src/remote/Makefile.inc.am +++ b/src/remote/Makefile.inc.am @@ -455,7 +455,7 @@ libvirtd.8.in: remote/libvirtd.pod if grep 'POD ERROR' $@-t1; then rm $@-t1; exit 1; fi && \ sed \ -e 's|SYSCONFDIR|\@sysconfdir\@|g' \ - -e 's|LOCALSTATEDIR|\@localstatedir\@|g' \ + -e 's|RUNSTATEDIR|\@runstatedir\@|g' \ < $@-t1 > $@-t2 && \ rm -f $@-t1 && \ mv $@-t2 $@ -- 2.21.0

3 2

[libvirt] [PATCH] Apparmor: Support Xen scripts in libexec
by Jim Fehlig 18 Oct '19

18 Oct '19

Upstream Xen has traditionally installed various hotplug and utility scripts in /etc/xen/scripts/. openSUSE is slowly moving all distribution provided configuration files and scripts from /etc to /usr. In the case of the Xen scripts provided under /etc/xen/scripts/, they will be moving to /usr/lib/xen/scripts/. Adjust the libvirtd Apparmor profile to allow executing scripts from this location. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- If this is deemed too distro-specific I'm happy to maintain a downstream patch. src/security/apparmor/usr.sbin.libvirtd | 1 + 1 file changed, 1 insertion(+) diff --git a/src/security/apparmor/usr.sbin.libvirtd b/src/security/apparmor/usr.sbin.libvirtd index 29f9936ad9..b0d23c80f3 100644 --- a/src/security/apparmor/usr.sbin.libvirtd +++ b/src/security/apparmor/usr.sbin.libvirtd @@ -104,6 +104,7 @@ profile libvirtd /usr/sbin/libvirtd flags=(attach_disconnected) { /usr/{lib,lib64}/libvirt/libvirt_iohelper ix, /etc/libvirt/hooks/** rmix, /etc/xen/scripts/** rmix, + /usr/{lib,lib64}/xen/scripts/** rmix, # allow changing to our UUID-based named profiles change_profile -> @{LIBVIRT}-[0-9a-f]*-[0-9a-f]*-[0-9a-f]*-[0-9a-f]*-[0-9a-f]*, -- 2.23.0

2 3

[libvirt] [PATCH] util: add stdlib.h include for abort() prototype
by Daniel P. Berrangé 18 Oct '19

18 Oct '19

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed as a build fix for Mingw src/util/glibcompat.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/util/glibcompat.c b/src/util/glibcompat.c index 25dedf0ed5..3f830840cf 100644 --- a/src/util/glibcompat.c +++ b/src/util/glibcompat.c @@ -18,6 +18,8 @@ #include <config.h> +#include <stdlib.h> + #include "glibcompat.h" #undef g_strdup_printf -- 2.21.0

1 0