[libvirt] [PATCH 0/8] Work-in-progress: Incremental Backup API additions
by Eric Blake
I'm offline the rest of this week, but wanted to post the
progress I've made on patches towards the Incremental Backup RFC:
https://www.redhat.com/archives/libvir-list/2018-May/msg01403.html
Comments welcome, including any naming suggestions
Still to go:
- Add .rng file for validating the XML format used in virDomainBackupBegin()
- Add flags for validating XML
- Add src/conf/checkpoint_conf.c mirroring src/conf/snapshot_conf.c for
tracking tree of checkpoints
- Add virsh wrappers for calling everything
- Add qemu implementation - my first addition will probably just be for
push model full backups, then additional patches to expand into
pull model (on the qemu list, I still need to review and incorporate
Vladimir's patches for exporting a bitmap over NBD)
- Bug fixes (but why would there be any bugs in the first place? :)
I've got portions of the qemu code working locally, but not polished
enough to post as a patch yet; my end goal is to have a working demo
against current qemu.git showing the use of virDomainBackupBegin()
for incremental backups with the push model prior to the code freeze
for 4.5.0 this month, even if that code doesn't get checked into
libvirt until later when the qemu code is changed to drop x- prefixes.
(That is, I'm hoping to demo that my API is sound, and thus we can
include the entrypoints in the libvirt.so for this release, even if
the libvirt code for driving pull mode over qemu waits until after a
qemu release where the pieces are promoted to a stable form.)
Eric Blake (8):
snapshots: Avoid term 'checkpoint' for full system snapshot
backup: Document nuances between different state capture APIs
backup: Introduce virDomainCheckpointPtr
backup: Document new XML for backups
backup: Introduce virDomainCheckpoint APIs
backup: Introduce virDomainBackup APIs
backup: Add new domain:checkpoint access control
backup: Implement backup APIs for remote driver
docs/Makefile.am | 3 +
docs/apibuild.py | 2 +
docs/docs.html.in | 9 +-
docs/domainstatecapture.html.in | 190 ++++++
docs/formatcheckpoint.html.in | 273 +++++++++
docs/formatsnapshot.html.in | 16 +-
docs/schemas/domaincheckpoint.rng | 89 +++
include/libvirt/libvirt-domain-checkpoint.h | 158 +++++
include/libvirt/libvirt-domain-snapshot.h | 10 +-
include/libvirt/libvirt-domain.h | 14 +-
include/libvirt/libvirt.h | 3 +-
include/libvirt/virterror.h | 5 +-
libvirt.spec.in | 2 +
mingw-libvirt.spec.in | 4 +
po/POTFILES | 1 +
src/Makefile.am | 2 +
src/access/viraccessperm.c | 5 +-
src/access/viraccessperm.h | 8 +-
src/conf/snapshot_conf.c | 2 +-
src/datatypes.c | 62 +-
src/datatypes.h | 31 +-
src/driver-hypervisor.h | 74 ++-
src/libvirt-domain-checkpoint.c | 908 ++++++++++++++++++++++++++++
src/libvirt-domain-snapshot.c | 4 +-
src/libvirt-domain.c | 8 +-
src/libvirt_private.syms | 2 +
src/libvirt_public.syms | 19 +
src/qemu/qemu_driver.c | 12 +-
src/remote/remote_daemon_dispatch.c | 15 +
src/remote/remote_driver.c | 31 +-
src/remote/remote_protocol.x | 237 +++++++-
src/remote_protocol-structs | 129 ++++
src/rpc/gendispatch.pl | 32 +-
src/util/virerror.c | 15 +-
tests/domaincheckpointxml2xmlin/empty.xml | 1 +
tests/domaincheckpointxml2xmlout/empty.xml | 10 +
tests/virschematest.c | 2 +
tools/virsh-domain.c | 3 +-
tools/virsh-snapshot.c | 2 +-
tools/virsh.pod | 14 +-
40 files changed, 2347 insertions(+), 60 deletions(-)
create mode 100644 docs/domainstatecapture.html.in
create mode 100644 docs/formatcheckpoint.html.in
create mode 100644 docs/schemas/domaincheckpoint.rng
create mode 100644 include/libvirt/libvirt-domain-checkpoint.h
create mode 100644 src/libvirt-domain-checkpoint.c
create mode 100644 tests/domaincheckpointxml2xmlin/empty.xml
create mode 100644 tests/domaincheckpointxml2xmlout/empty.xml
--
2.14.4
6 years, 3 months
[libvirt] [PATCH v3 0/2] Support network stats for VF representor interface
by Jai Singh Rana
With availability of switchdev model in linux, it is possible to capture
stats for SR-IOV device with interface_type as 'hostdev' provided device
supports VF represontor in switchdev mode[1] on host.
These stats are supported by adding helper APIs for getting/verifying VF
representor name based on PCI Bus:Device:Function information in domains
'hostdev' structure and querying required net sysfs directory and file
entries on host according to switchdev model. These helper APIs are then
used in qemu/conf to get the interface stats for VF representor on host
of pci SR-IOV device.
[1] https://www.kernel.org/doc/Documentation/networking/switchdev.txt
V2 https://www.redhat.com/archives/libvir-list/2018-February/msg00561.html
Jai Singh Rana (2):
util: Add helper APIs to get/verify VF Representor name
qemu: conf: Network stats support for VF Representors
docs/news.xml | 9 ++
po/POTFILES.in | 1 +
src/conf/domain_conf.c | 15 ++
src/libvirt_private.syms | 7 +
src/qemu/qemu_driver.c | 33 +++-
src/util/Makefile.inc.am | 2 +
src/util/virhostdev.c | 2 +-
src/util/virhostdev.h | 8 +
src/util/virnetdevhostdev.c | 374 ++++++++++++++++++++++++++++++++++++++++++++
src/util/virnetdevhostdev.h | 35 +++++
10 files changed, 481 insertions(+), 5 deletions(-)
create mode 100644 src/util/virnetdevhostdev.c
create mode 100644 src/util/virnetdevhostdev.h
--
2.13.6
6 years, 4 months
[libvirt] [jenkins-ci PATCH] guests: Make mappings more future proof
by Andrea Bolognani
We can reasonably expect the next major release of CentOS
to be somewhat close to current Fedora releases in terms of
packaging, and to ditch the soon-to-be-unsupported Python 2
in favor of Python 3.
Rewrite some of the mappings based on these expectations.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
guests/vars/mappings.yml | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index 92822cb..454afe5 100644
--- a/guests/vars/mappings.yml
+++ b/guests/vars/mappings.yml
@@ -651,12 +651,12 @@ mappings:
python3:
default: python3
- CentOS:
+ CentOS7:
python3-dbus:
default: python3-dbus
FreeBSD: py36-dbus
- CentOS:
+ CentOS7:
python3-devel:
deb: python3-dev
@@ -667,34 +667,34 @@ mappings:
deb: python3-gi
pkg: py36-gobject3
rpm: python3-gobject
- CentOS:
+ CentOS7:
python3-libxml2:
default: python3-libxml2
FreeBSD: py36-libxml2
- CentOS:
+ CentOS7:
Debian8:
Ubuntu16:
python3-lxml:
default: python3-lxml
FreeBSD: py36-lxml
- CentOS:
+ CentOS7:
python3-nose:
default: python3-nose
FreeBSD: py36-nose
- CentOS:
+ CentOS7:
python3-pytest:
default: python3-pytest
FreeBSD: py36-pytest
- CentOS:
+ CentOS7:
python3-requests:
default: python3-requests
FreeBSD: py36-requests
- CentOS:
+ CentOS7:
qemu-img:
default: qemu-utils
@@ -711,7 +711,7 @@ mappings:
rpcgen:
deb: libc-dev-bin
rpm: rpcgen
- CentOS: glibc-common
+ CentOS7: glibc-common
Fedora26: glibc-common
Fedora27: glibc-common
FreeBSD:
--
2.17.1
6 years, 4 months
[libvirt] [RFC] proposal for libiscsi storage pool
by Clementine Hayat
Hi everybody!
I am starting this thread to discuss a new storage pool backend for
iSCSI using libiSCSI.
There already is an iSCSI backend, however, it uses iscsiadm binary to
execute the desired operation. The binary can be spawned multiple
times during single execution of an API. This is suboptimal.
Moreover the iscsi storage pool is mapped by the kernel into a block
device in /dev/. Iscsiadm makes operations directly on that block
device. Libiscsi on the other hand is sending the commands directly to
a remote iscsi portal. According to that, to be able to use a storage
pool using libiscsi we have to implement the storage pool backend
entirely.
What we would have:
Pool XML using iscsiadm:
<pool type="iscsi" mode="host">
<name>virtimages</name>
<source>
<host name="iscsi.example.com"/>
<device path="iqn.2013-06.com.example:iscsi-pool"/>
<auth type='chap' username='myuser'>
<secret usage='libvirtiscsi'/>
</auth>
</source>
<target>
<path>/dev/disk/by-path</path>
</target>
</pool>
Pool XML using libiscsi:
<pool type="iscsi" mode="direct">
<name>virtimages</name>
<source>
<host name="iscsi.example.com"/>
<device path="iqn.2013-06.com.example:iscsi-pool"/>
<auth type='chap' username='myuser'>
<secret usage='libvirtiscsi'/>
</auth>
</source>
</pool>
The change that occurs is having a direct mode that will lead to the
libiscsi backend and the host mode that will lead to the actual
backend using iscsiadm.
To tie the backend to the front was thinking about adding something
like VIR_STORAGE_POOL_LIBISCSI to storage_conf.
About the domain XML only accept:
<disk type='volume' device='disk'>
<driver name='qemu' type='raw'/>
<source pool='iscsi-pool' volume='unit:0:0:2' mode='direct'/>
<target dev='vdc' bus='virtio'/>
</disk>
would be great using a switch case on VIR_STORAGE_POOL_LIBISCSI inside
domain_conf.
Best regards,
--
Clementine Hayat
6 years, 4 months
[libvirt] [PATCH v4 0/6] Support network stats for VF representor interface
by Jai Singh Rana
With availability of switchdev model in linux, it is possible to capture
stats for SR-IOV device with interface_type as 'hostdev' provided device
supports VF represontor in switchdev mode on host.
These stats are supported by adding helper APIs for getting/verifying VF
representor name based on PCI Bus:Device:Function information in domains
'hostdev' structure and querying required net sysfs directory and file
entries on host according to switchdev model. These helper APIs are then
used in qemu/conf to get the interface stats for VF representor of
pci SR-IOV device.
V4 includes changes based on feedback received for v3 patchset. Added new
generic API for linux is added to fetch stats from /proc/net/dev which
will be used by tap and hostdev devices. Also introduced new API to retrieve
net def from given domain based on the given hostdev which supports network.
[1] https://www.kernel.org/doc/Documentation/networking/switchdev.txt
V3: https://www.redhat.com/archives/libvir-list/2018-April/msg00306.html
Jai Singh Rana (6):
util: Add helper function to clean extra spaces in string
util: Add generic API to fetch network stats from procfs
util: Add helper APIs to get/verify VF Representor name
conf: util: Add API to find net def given its domain's hostdev
qemu: Network stats support for VF Representor
docs: Update news about Network stats support for VF Representor
docs/news.xml | 9 ++
po/POTFILES | 1 +
src/conf/domain_conf.c | 43 +++++++
src/conf/domain_conf.h | 2 +
src/libvirt_private.syms | 11 ++
src/qemu/qemu_driver.c | 34 ++++-
src/util/Makefile.inc.am | 2 +
src/util/virhostdev.c | 4 +-
src/util/virhostdev.h | 11 ++
src/util/virnetdev.c | 202 ++++++++++++++++++++++++++++-
src/util/virnetdev.h | 5 +
src/util/virnetdevhostdev.c | 300 ++++++++++++++++++++++++++++++++++++++++++++
src/util/virnetdevhostdev.h | 34 +++++
src/util/virnetdevtap.c | 71 +----------
src/util/virstring.c | 36 ++++++
src/util/virstring.h | 3 +
16 files changed, 691 insertions(+), 77 deletions(-)
create mode 100644 src/util/virnetdevhostdev.c
create mode 100644 src/util/virnetdevhostdev.h
--
2.13.7
6 years, 4 months
Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial
by Christian Borntraeger
On 06/15/2018 04:21 PM, Kevin Wolf wrote:
> The -drive option serial was deprecated in QEMU 2.10. It's time to
> remove it.
>
> Tests need to be updated to set the serial number with -global instead
> of using the -drive option.
libvirt 4.5 still creates those (at least on s390x)
<disk type='file' device='disk'>
<driver name='qemu' type='qcow2' cache='none' io='native' iothread='1'/>
<source file='/var/lib/libvirt/qemu/image.zhyp137'/>
<target dev='hda' bus='virtio'/>
<serial>skel</serial>
<boot order='1'/>
<address type='ccw' cssid='0xfe' ssid='0x0' devno='0x0000'/>
</disk>
->
[...]
-drive file=/var/lib/libvirt/qemu/image.zhyp137,format=qcow2,if=none,id=drive-virtio-disk0,serial=skel,cache=none,aio=native -device virtio-blk-ccw,iothread=iothread1,scsi=off,devno=fe.0.0000,drive=drive-virtio-disk0,id=virtio-disk0,bootindex=1,write-cache=on
[...]
2018-06-22T11:25:20.946024Z qemu-system-s390x: -drive file=/var/lib/libvirt/qemu/image.zhyp137,format=qcow2,if=none,id=drive-virtio-disk0,serial=skel,cache=none,aio=native: Block format 'qcow2' does not support the option 'serial'
2018-06-22 11:25:21.098+0000: shutting down, reason=failed
So it seems that this breaks s390x.
6 years, 4 months
[libvirt] [PATCH v3 00/35] use GNU C's cleanup attribute in src/util (batch I)
by Sukrit Bhatnagar
This series of patches first introduces a new set of macros which help
in using GNU C's __attribute__((cleanup)) in the code.
Then a few syntax-check rules are added which help in ensuring correct
usage of the newly introduced cleanup macros.
Then the patches modify a few files in src/util to use VIR_AUTOFREE
and VIR_AUTOPTR for automatic freeing of memory and get rid of some
VIR_FREE macro invocations and *Free function calls.
Sukrit Bhatnagar (35):
util: alloc: add macros for implementing automatic cleanup
functionality
cfg.mk: variable initialization when declared with cleanup macro
cfg.mk: correct spacing between type and asterisk in VIR_AUTOFREE
cfg.mk: single variable declaration per line when using cleanup macro
cfg.mk: no trailing semicolon at line invoking VIR_DEFINE_* cleanup
macro
util: string: introduce typedef for string
util: string: define cleanup function using VIR_DEFINE_AUTOPTR_FUNC
util: command: define cleanup function using VIR_DEFINE_AUTOPTR_FUNC
util: command: remove redundant include directive
util: command: use VIR_AUTOFREE instead of VIR_FREE for scalar types
util: command: use VIR_AUTOPTR for aggregate types
util: file: define cleanup function using VIR_DEFINE_AUTOPTR_FUNC
util: file: remove redundant include directive
util: file: use VIR_AUTOFREE instead of VIR_FREE for scalar types
util: file: use VIR_AUTOPTR for aggregate types
util: authconfig: define cleanup function using
VIR_DEFINE_AUTOPTR_FUNC
util: authconfig: remove redundant include directive
util: authconfig: use VIR_AUTOFREE instead of VIR_FREE for scalar
types
util: auth: remove redundant include directive
util: auth: use VIR_AUTOFREE instead of VIR_FREE for scalar types
util: auth: use VIR_AUTOPTR for aggregate types
util: json: define cleanup function using VIR_DEFINE_AUTOPTR_FUNC
util: json: remove redundant include directive
util: json: use VIR_AUTOFREE instead of VIR_FREE for scalar types
util: json: use VIR_AUTOPTR for aggregate types
util: bitmap: define cleanup function using VIR_DEFINE_AUTOPTR_FUNC
util: bitmap: remove redundant include directive
util: bitmap: use VIR_AUTOPTR for aggregate types
util: iohelper: use VIR_AUTOFREE instead of VIR_FREE for scalar types
util: arptable: use VIR_AUTOFREE instead of VIR_FREE for scalar types
util: audit: use VIR_AUTOFREE instead of VIR_FREE for scalar types
util: fcp: use VIR_AUTOFREE instead of VIR_FREE for scalar types
util: eventpoll: use VIR_AUTOFREE instead of VIR_FREE for scalar types
util: filecache: use VIR_AUTOFREE instead of VIR_FREE for scalar types
util: identity: use VIR_AUTOFREE instead of VIR_FREE for scalar types
cfg.mk | 37 ++++++
src/util/iohelper.c | 4 +-
src/util/viralloc.h | 44 +++++++
src/util/virarptable.c | 14 +-
src/util/viraudit.c | 3 +-
src/util/virauth.c | 61 +++------
src/util/virauthconfig.c | 35 ++---
src/util/virauthconfig.h | 3 +
src/util/virbitmap.c | 8 +-
src/util/virbitmap.h | 3 +
src/util/vircommand.c | 47 ++-----
src/util/vircommand.h | 2 +
src/util/vireventpoll.c | 7 +-
src/util/virfcp.c | 20 +--
src/util/virfile.c | 327 ++++++++++++++++-------------------------------
src/util/virfile.h | 3 +
src/util/virfilecache.c | 35 ++---
src/util/viridentity.c | 52 ++++----
src/util/virjson.c | 68 +++-------
src/util/virjson.h | 3 +
src/util/virstring.h | 5 +
21 files changed, 319 insertions(+), 462 deletions(-)
--
1.8.3.1
6 years, 4 months
[libvirt] [PATCH 0/5] Introduce new video model type 'none'
by Erik Skultety
Historically, we've always been adding a default video device onto the cmdline
whenever a graphical framebuffer was requested but a video device was missing.
With the appearance of mdev vgpus, having an emulated video device is
suboptimal, especially with spice where the streaming client will by default
open multiple windows, one for each video device (or 'head' in this case).
Therefore, we should have a mechanism to disable the 'default video device
addition' and this series does that by introducing a new video model 'none'.
This can be applied and tried independently, however, it truly only makes sense
on top of [1].
[1] https://www.redhat.com/archives/libvir-list/2018-June/msg01740.html
Erik Skultety (5):
qemu: address: Handle all the video devices within a single loop
conf: Introduce virDomainVideoDefClear helper
conf: Introduce virDomainDefPostParseVideo helper
qemu: validate: Enforce compile time switch type checking for videos
conf: Introduce new video type 'none'
docs/formatdomain.html.in | 10 ++-
docs/schemas/domaincommon.rng | 1 +
src/conf/domain_conf.c | 86 +++++++++++++++++-----
src/conf/domain_conf.h | 4 +-
src/libvirt_private.syms | 1 +
src/qemu/qemu_command.c | 13 +++-
src/qemu/qemu_domain.c | 6 +-
src/qemu/qemu_domain_address.c | 20 +++--
tests/domaincapsschemadata/full.xml | 1 +
.../video-invalid-multiple-devices.xml | 33 +++++++++
tests/qemuxml2argvdata/video-none-device.args | 27 +++++++
tests/qemuxml2argvdata/video-none-device.xml | 39 ++++++++++
tests/qemuxml2argvtest.c | 4 +-
tests/qemuxml2xmloutdata/video-none-device.xml | 42 +++++++++++
tests/qemuxml2xmltest.c | 1 +
15 files changed, 255 insertions(+), 33 deletions(-)
create mode 100644 tests/qemuxml2argvdata/video-invalid-multiple-devices.xml
create mode 100644 tests/qemuxml2argvdata/video-none-device.args
create mode 100644 tests/qemuxml2argvdata/video-none-device.xml
create mode 100644 tests/qemuxml2xmloutdata/video-none-device.xml
--
2.14.4
6 years, 4 months
[libvirt] [PATCH v1 00/11] Enable vfio-pci 'property' for mediated device
by Erik Skultety
See the RFC here:
https://www.redhat.com/archives/libvir-list/2018-May/msg02218.html
Since RFC:
- split graphics 'gl' to a standalone structure since it's now SPICE, SDL,
*and* VNC that will support it
- egl-headless support for VNC, since VNC doesn't support OpenGL natively like
SPICE does
- added a new attribute 'native' for spice which will instruct libvirt to use
'-display egl-headless' instead of libvirt trying to figure this on out by
itself, since egl-headless might have other uses besides mdev with VNC
- dropped formatting of the 'display' attribute to the domain XML if it had the
default value, so it will only be formatted if user explicitly set it
(previously patch 6)
- minor adjustments like splitting the second patch into 2 (now 2 and 3)
- more cleanup
Erik Skultety (11):
conf: Remove a redundant model/address-type check in mdev post parse
qemu: command: Move graphics iteration to its own function
qemu: command: Add virReportEnumRangeError to BuildHostdevCommandline
conf: Replace error label with cleanup in
virDomainGraphicsDefParseVNCXML
qemu: command: Fix building of the SDL display command line
conf: Make graphics's GL a standalone structure
conf: Allow usage of the <gl> element with VNC graphics
conf: Introduce new <gl> attribute 'native' for SPICE
qemu: caps: Add vfio-pci.display capability
conf: Introduce new <hostdev> attribute 'display'
qemu: command: Enable formatting vfio-pci.display option onto cmdline
docs/formatdomain.html.in | 33 ++-
docs/schemas/domaincommon.rng | 28 ++-
src/conf/domain_conf.c | 230 ++++++++++++++-------
src/conf/domain_conf.h | 14 +-
src/qemu/qemu_capabilities.c | 2 +
src/qemu/qemu_capabilities.h | 1 +
src/qemu/qemu_cgroup.c | 10 +-
src/qemu/qemu_command.c | 189 +++++++++++------
src/qemu/qemu_domain.c | 79 ++++++-
src/security/security_dac.c | 7 +-
tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 1 +
tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 1 +
tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml | 1 +
tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 +
tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 1 +
.../qemuxml2argvdata/graphics-sdl-fullscreen.args | 2 +-
tests/qemuxml2argvdata/graphics-sdl.args | 2 +-
.../qemuxml2argvdata/graphics-spice-gl-native.args | 26 +++
.../qemuxml2argvdata/graphics-spice-gl-native.xml | 25 +++
.../graphics-spice-gl-non-native.args | 27 +++
.../graphics-spice-gl-non-native.xml | 24 +++
tests/qemuxml2argvdata/graphics-vnc-gl-invalid.xml | 37 ++++
tests/qemuxml2argvdata/graphics-vnc-gl.args | 28 +++
tests/qemuxml2argvdata/graphics-vnc-gl.xml | 37 ++++
.../hostdev-mdev-display-missing-graphics.xml | 35 ++++
.../hostdev-mdev-display-spice-egl-headless.args | 32 +++
.../hostdev-mdev-display-spice-egl-headless.xml | 41 ++++
.../hostdev-mdev-display-spice-opengl.args | 31 +++
.../hostdev-mdev-display-spice-opengl.xml | 41 ++++
.../hostdev-mdev-display-vnc-egl-headless.args | 32 +++
.../hostdev-mdev-display-vnc-egl-headless.xml | 41 ++++
.../qemuxml2argvdata/hostdev-mdev-display-vnc.args | 31 +++
.../qemuxml2argvdata/hostdev-mdev-display-vnc.xml | 39 ++++
tests/qemuxml2argvdata/hostdev-mdev-display.xml | 39 ++++
.../qemuxml2argvdata/video-virtio-gpu-sdl-gl.args | 2 +-
tests/qemuxml2argvtest.c | 38 ++++
.../hostdev-mdev-display-active.xml | 47 +++++
.../hostdev-mdev-display-inactive.xml | 47 +++++
.../video-virtio-gpu-spice-gl.xml | 2 +-
tests/qemuxml2xmltest.c | 2 +
40 files changed, 1143 insertions(+), 163 deletions(-)
create mode 100644 tests/qemuxml2argvdata/graphics-spice-gl-native.args
create mode 100644 tests/qemuxml2argvdata/graphics-spice-gl-native.xml
create mode 100644 tests/qemuxml2argvdata/graphics-spice-gl-non-native.args
create mode 100644 tests/qemuxml2argvdata/graphics-spice-gl-non-native.xml
create mode 100644 tests/qemuxml2argvdata/graphics-vnc-gl-invalid.xml
create mode 100644 tests/qemuxml2argvdata/graphics-vnc-gl.args
create mode 100644 tests/qemuxml2argvdata/graphics-vnc-gl.xml
create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-missing-graphics.xml
create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-spice-egl-headless.args
create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-spice-egl-headless.xml
create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-spice-opengl.args
create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-spice-opengl.xml
create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-vnc-egl-headless.args
create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-vnc-egl-headless.xml
create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-vnc.args
create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-vnc.xml
create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display.xml
create mode 100644 tests/qemuxml2xmloutdata/hostdev-mdev-display-active.xml
create mode 100644 tests/qemuxml2xmloutdata/hostdev-mdev-display-inactive.xml
--
2.14.4
6 years, 4 months
[libvirt] [PATCH 0/2] Minor fixes for virTypedParams(De)Serialize
by Marc Hartmayer
Some minor fixes and two questions:
* Is the first method, which is described in the documentation for
virTypedParamsDeserialize, in sync with the actual code? ("Older
APIs do not rely on deserializer allocating memory for @params,
...")
* Do we also have to set *nparams = 0 in case of an error and the user
has allocated the memory? (virTypedParamsDeserialize)
Marc Hartmayer (2):
virTypedParamsSerialize: minor fixes
virTypedParamsDeserialize: minor fixes
src/util/virtypedparam.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
--
2.13.4
6 years, 4 months
