[libvirt] [PATCH 0/3] Fix more memory leaks
by Michal Privoznik
Ideally, these would be merged before the release. But I don't have
strong opinion on that.
Michal Privoznik (3):
virDomainDefParseXML: Free @tmp when parsing genid
qemuxml2argvtest: Don't initialize qemuCaps twice
virQEMUCapsSetHostModel: Free cpuData before setting it
src/conf/domain_conf.c | 1 +
src/qemu/qemu_capabilities.c | 4 ++++
tests/qemuxml2argvtest.c | 2 --
3 files changed, 5 insertions(+), 2 deletions(-)
--
2.16.1
6 years, 5 months
[libvirt] [PATCH 0/1] bug: fixup USB input bus check
by Xiao Feng Ren
There's one explicit bug(introduced in commit:317badb) when checking the bus of one input device is USB.
Let's fix it.
Xiao Feng Ren (1):
Fixup USB input bus check
src/conf/domain_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.16.3
6 years, 5 months
[libvirt] What is the strategy to update the CPU Models in src/cpu/cpu_map.xml based on?
by Dou Liyang
Hi All,
I am not sure about the update strategy of CPU models in libvirt.
IMO, It's depend on the CPU model in qemu-kvm, if some CPU models
were updated in qemu-kvm. Then, we should modify the src/cpu/cpu_map.xml
of libvirt to synchronize?
eg:
commit cad8054ece28("cpu: Add cpu definition for Intel Sandy Bridge
cpu type") in libvirt upstream.
https://bugzilla.redhat.com/show_bug.cgi?id=761005
If it's right, I found this commit b3a4f0b1a072("target-i386: add VME to
all CPUs") updated the VME feature in qemu upstream. But in the src/cpu
/cpu_map.xml of libvirt, It didn't be updated.
eg:
For the SandyBridge CPU,
- In QEmu, it has the 'vme' feature defined by CPUID_VME
- In libvirt, it doesn't has the 'vme' in cpu_map.xml file.
Why?
Thanks,
dou
6 years, 5 months
Re: [libvirt] What is the strategy to update the CPU Models in src/cpu/cpu_map.xml based on?
by Peter Krempa
[re-adding libvir-list]
On Wed, May 30, 2018 at 19:36:10 +0800, Dou Liyang wrote:
> Hi Peter,
>
> Sorry to trouble you offline.
Please keep conversations on the list, so that it does not get lost in
private inboxes.
> Recently, I forced on the PCID feature in CPU and
> found the SandyBridge didn't include the PCID feature
> in libvirt.
>
> commit cad8054ece285d1712880cd108e8a39f833f7e88
> Author: Peter Krempa <pkrempa(a)redhat.com>
> Date: Wed Feb 8 12:43:07 2012 +0100
>
> cpu: Add cpu definition for Intel Sandy Bridge cpu type
>
> I knew the SandyBridge CPU models in QEMU also
> didn't include the PCID feature.
>
> I want to know:
>
> - If we can't make sure PCID was supported in all SandyBridge?
> - If we avoided PCID definition intentionally ?
> - If we forgot to add it, and need to be fixed?
Qemu added it later than libvirt added the sandy-bridge cpu:
commit 434acb817b8ae747f31e91ec152f9f47ac514433
Author: Mao, Junjie <junjie.mao(a)intel.com>
Date: Fri Jul 20 07:08:21 2012 +0000
Recognize PCID feature
This patch makes Qemu recognize the PCID feature specified from configuration or command line options.
Jiri Denemark already covered why we can't/will not change existing
models in cpu_map.xml
>
> Thanks,
> dou
6 years, 5 months
[libvirt] [PATCH 0/5] storage: implement a skeleton for volume events.
by Julio Faracco
The series add a skeleton for a lifecycle event (and other events in the
future) for volumes to cover actions like create and delete. Others
events can be added in the future, but the storage driver has some
functions to support it.
Related: https://bugzilla.redhat.com/show_bug.cgi?id=1578836
Julio Faracco (5):
storage: adding a skeleton for libvirt volume events.
driver: adding two new driver functions to support volume events.
conf: implementing some functions to generate volume events.
virsh: implementing 'vol-event' command.
examples: adding volume events into event-test example.
examples/object-events/event-test.c | 65 ++++++++++
include/libvirt/libvirt-storage.h | 86 +++++++++++++
src/conf/storage_event.c | 155 ++++++++++++++++++++++
src/conf/storage_event.h | 19 +++
src/driver-storage.h | 13 ++
src/libvirt-storage.c | 125 ++++++++++++++++++
src/libvirt_private.syms | 2 +
src/libvirt_public.syms | 6 +
tools/virsh-completer.c | 27 ++++
tools/virsh-completer.h | 4 +
tools/virsh-volume.c | 192 ++++++++++++++++++++++++++++
tools/virsh-volume.h | 8 ++
12 files changed, 702 insertions(+)
--
2.17.0
6 years, 5 months
[libvirt] [PATCH 0/2] qemu: block: Add more tests and support for pr-manager
by Peter Krempa
Note that patch 1 can be applied only with the series adding TLS support
for NBD.
Patch 2 is independent.
Peter Krempa (2):
tests: qemublock: Test NBD with TLS
qemu: block: Add support for 'pr-manager' in
qemuBlockStorageSourceGetFileProps
src/qemu/qemu_block.c | 5 +++++
tests/qemublocktest.c | 2 ++
.../xml2json/block-raw-reservations.json | 14 ++++++++++++++
.../xml2json/block-raw-reservations.xml | 14 ++++++++++++++
.../qemublocktestdata/xml2json/network-nbd-tls.json | 20 ++++++++++++++++++++
tests/qemublocktestdata/xml2json/network-nbd-tls.xml | 18 ++++++++++++++++++
6 files changed, 73 insertions(+)
create mode 100644 tests/qemublocktestdata/xml2json/block-raw-reservations.json
create mode 100644 tests/qemublocktestdata/xml2json/block-raw-reservations.xml
create mode 100644 tests/qemublocktestdata/xml2json/network-nbd-tls.json
create mode 100644 tests/qemublocktestdata/xml2json/network-nbd-tls.xml
--
2.16.2
6 years, 5 months
[libvirt] [PATCH 0/2] Trivial memory leak fixes
by Ján Tomko
Hopefully pushed as trivial by the time you're reading this message.
Ján Tomko (2):
qemu: free migEvent in qemuMigrationCapsCheck
conf: fix vsock memory leaks
src/conf/domain_conf.c | 2 ++
src/qemu/qemu_migration_params.c | 1 +
2 files changed, 3 insertions(+)
--
2.16.1
6 years, 5 months
[libvirt] [PATCH] vmx: Remove check that numvcpus has to be an even number.
by Richard W.M. Jones
This patch removes what appears to be an unnecessary check in the VMX
driver which is preventing us from importing guests that have an odd
number of vCPUs with virt-v2v.
Unfortunately to test this it seems you need a real VMware server
somewhere (substitute for ‘example.com’ below).
Download the VMX file attached to
https://bugzilla.redhat.com/show_bug.cgi?id=1584091
$ virsh -c 'esx://example.com' domxml-from-native vmware-vmx window2016.vmx
Enter root's password for example.com:
error: internal error: Expecting VMX entry 'numvcpus' to be an unsigned integer (1 or a multiple of 2) but found 7
After applying the patch:
$ ~/d/libvirt/run ~/d/libvirt/tools/virsh -c 'esx://example.com' domxml-from-native vmware-vmx window2016.vmx
Enter root's password for example.com:
<domain type='vmware'>
...
<cpu>
<topology sockets='1' cores='7' threads='1'/>
...
Rich.
6 years, 5 months
[libvirt] [PATCH] spec: Fix permissions of nwfilter XMLs
by Jiri Denemark
The nwfilter XMLs in /etc are defined as %ghost in the spec file, which
means rpm will not install them, but it will record its existence and
permissions in the database. During installation the files are copied in
a %post scriptlet from /usr/share/libvirt/nwfilter, but once libvirtd is
restarted, it will rewrite the files to add generated UUIDs.
While RPM recorded 644 mode for the XMLs, libvirt saves them with 600
and thus any future attempt to verify the libvirt-daemon-config-nwfilter
package would fail. We need to tell RPM the ghost files are supposed to
have 600 permissions.
https://bugzilla.redhat.com/show_bug.cgi?id=1559284
Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com>
---
libvirt.spec.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 5e1e1df3f0..17d5d4dff7 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1369,6 +1369,8 @@ rm -f $RPM_BUILD_ROOT%{_sysconfdir}/libvirt/qemu/networks/autostart/default.xml
install -d -m 0755 $RPM_BUILD_ROOT%{_datadir}/libvirt/nwfilter/
cp -a $RPM_BUILD_ROOT%{_sysconfdir}/libvirt/nwfilter/*.xml \
$RPM_BUILD_ROOT%{_datadir}/libvirt/nwfilter/
+# libvirt saves these files with mode 600
+chmod 600 $RPM_BUILD_ROOT%{_sysconfdir}/libvirt/nwfilter/*.xml
# Strip auto-generated UUID - we need it generated per-install
sed -i -e "/<uuid>/d" $RPM_BUILD_ROOT%{_datadir}/libvirt/networks/default.xml
--
2.17.0
6 years, 5 months
[libvirt] [PATCH] tests: initialize some variables
by Ján Tomko
Found by cppcheck:
[tests/metadatatest.c:284]: (error) Uninitialized variable: test
[tests/objecteventtest.c:855]: (error) Uninitialized variable: test
Signed-off-by: Ján Tomko <jtomko(a)redhat.com>
---
tests/metadatatest.c | 2 +-
tests/objecteventtest.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/metadatatest.c b/tests/metadatatest.c
index d5a6f37119..b17a85c883 100644
--- a/tests/metadatatest.c
+++ b/tests/metadatatest.c
@@ -268,7 +268,7 @@ testTextMetadata(const void *data)
static int
mymain(void)
{
- struct metadataTest test;
+ struct metadataTest test = { 0 };
int ret = EXIT_SUCCESS;
if (!(test.conn = virConnectOpen("test:///default")))
diff --git a/tests/objecteventtest.c b/tests/objecteventtest.c
index 4b12572eb4..e6de11ec39 100644
--- a/tests/objecteventtest.c
+++ b/tests/objecteventtest.c
@@ -835,7 +835,7 @@ timeout(int id ATTRIBUTE_UNUSED, void *opaque ATTRIBUTE_UNUSED)
static int
mymain(void)
{
- objecteventTest test;
+ objecteventTest test = { 0 };
int ret = EXIT_SUCCESS;
int timer;
--
2.16.1
6 years, 5 months
