[libvirt] [PATCH] m4: fix pkgcheck detection
by Olaf Hering
AC_PATH_PROG searches either for a binary [pkcheck], or it uses the
user provided absolute path in the variable PKCHECK_PATH.
Since virt-polkit.m4 wipes the variable PKCHECK_PATH from environment
the user decision is never used.
Signed-off-by: Olaf Hering <olaf(a)aepfle.de>
--- a/m4/virt-polkit.m4
+++ b/m4/virt-polkit.m4
@@ -28,7 +28,6 @@ AC_DEFUN([LIBVIRT_CHECK_POLKIT], [
POLKIT_REQUIRED="0.6"
POLKIT_CFLAGS=
POLKIT_LIBS=
- PKCHECK_PATH=
with_polkit0=no
with_polkit1=no
6 years, 8 months
[libvirt] [tck PATCH 0/2] Fix no-mac-broadcast test
by Laine Stump
It's surprising that nobody ever noticed in the past that this test
was either failing, or wasn't testing what it intended to test.
An extra bonus to fixing the test is that we are now testing
virNWFilterDefineXML(), and while writing it I discovered that
define_nwfilter() has been missing from the perl bindings since the
very beginning (libvirt-0.8.0, nearly 7 years ago!). (Since nobody
complained before now, I guess anyone using nwfilter via perl was only
using pre-define filter rules).
Laine Stump (2):
cleanup all nwfilters beginning with ^tck
Fix no-mac-broadcast test
lib/Sys/Virt/TCK.pm | 16 ++++++++++++++++
scripts/nwfilter/230-no-mac-broadcast.t | 29 ++++++++++++++++++++++++++++-
2 files changed, 44 insertions(+), 1 deletion(-)
--
2.14.3
6 years, 8 months
[libvirt] [PATCH 0/2] test: Implement virConnectListAllNodeDevices
by Cole Robinson
First patch is prep work to teach generic nodedev code not
to access host info for the test driver, which is needed to
give correct results for patch 2
Cole Robinson (2):
conf: nodedev: Don't refresh host caps in testdriver
test: Implement virConnectListAllNodeDevices
src/conf/node_device_conf.c | 3 +++
src/conf/node_device_conf.h | 1 +
src/test/test_driver.c | 15 +++++++++++++++
3 files changed, 19 insertions(+)
--
2.14.3
6 years, 8 months
[libvirt] [PATCH 0/7] tests: qemu: Do proper status XML testing
by Peter Krempa
The 'fake' status XML testing we were doing until now was terrible and
would not catch most of the problems. Also the code was too complicated.
This adds a way simpler approach which actually works. (for the small
price of adding a lot of test data lines)
Peter Krempa (7):
tests: qemuxml2xml: Rename testInfoFree to testInfoClear
tests: qemuxml2xml: Remove testing with allowed format detection
tests: qemuxml2xml: Add proper domain status XML testing
tests: qemuxml2xml: Remove fake status XML testing
tests: util: Remove callback from testCompareDomXML2XMLFiles
tests: qemuxml2xml: Add modern example of status XML to the test
tests: qemuxml2xml: Add status XML with outgoing migration with NBD
tests/Makefile.am | 1 +
tests/genericxml2xmltest.c | 2 +-
tests/lxcxml2xmltest.c | 2 +-
tests/qemustatusxml2xmldata/blockjob-mirror-in.xml | 96 +++++
.../qemustatusxml2xmldata/blockjob-mirror-out.xml | 96 +++++
.../qemustatusxml2xmldata/migration-out-nbd-in.xml | 449 +++++++++++++++++++++
.../migration-out-nbd-out.xml | 449 +++++++++++++++++++++
tests/qemustatusxml2xmldata/modern-in.xml | 443 ++++++++++++++++++++
tests/qemustatusxml2xmldata/modern-out.xml | 443 ++++++++++++++++++++
tests/qemustatusxml2xmldata/vcpus-multi-in.xml | 343 ++++++++++++++++
tests/qemustatusxml2xmldata/vcpus-multi-out.xml | 343 ++++++++++++++++
.../qemuxml2argvdata/disk-drive-detect-zeroes.xml | 2 +-
tests/qemuxml2argvdata/hugepages-memaccess.xml | 1 +
tests/qemuxml2argvdata/hugepages-memaccess2.xml | 1 +
tests/qemuxml2argvdata/hugepages-pages4.xml | 1 +
tests/qemuxml2argvdata/hugepages-pages5.xml | 1 +
tests/qemuxml2argvdata/hugepages-pages6.xml | 1 +
.../memory-hotplug-nvdimm-access.xml | 1 +
.../memory-hotplug-nvdimm-label.xml | 1 +
tests/qemuxml2argvdata/memory-hotplug-nvdimm.xml | 1 +
.../serial-tcp-tlsx509-chardev-notls.xml | 1 +
.../aarch64-aavmf-virtio-mmio.xml | 1 +
.../aarch64-virtio-pci-default.xml | 1 +
.../aarch64-virtio-pci-manual-addresses.xml | 1 +
tests/qemuxml2xmloutdata/autoindex.xml | 1 +
tests/qemuxml2xmloutdata/balloon-device-auto.xml | 1 +
tests/qemuxml2xmloutdata/balloon-device-period.xml | 1 +
.../bios-nvram-os-interleave.xml | 1 +
tests/qemuxml2xmloutdata/bios-nvram.xml | 1 +
tests/qemuxml2xmloutdata/blkiotune-device.xml | 1 +
tests/qemuxml2xmloutdata/blkiotune.xml | 1 +
.../boot-menu-disable-with-timeout.xml | 1 +
tests/qemuxml2xmloutdata/boot-menu-disable.xml | 1 +
.../boot-menu-enable-with-timeout.xml | 1 +
tests/qemuxml2xmloutdata/boot-multi.xml | 1 +
tests/qemuxml2xmloutdata/boot-order.xml | 2 +
tests/qemuxml2xmloutdata/channel-guestfwd.xml | 1 +
tests/qemuxml2xmloutdata/channel-virtio-auto.xml | 1 +
.../channel-virtio-state-active.xml | 1 +
.../channel-virtio-state-inactive.xml | 1 +
tests/qemuxml2xmloutdata/channel-virtio.xml | 1 +
tests/qemuxml2xmloutdata/clock-catchup.xml | 1 +
tests/qemuxml2xmloutdata/console-compat-auto.xml | 1 +
tests/qemuxml2xmloutdata/console-virtio-many.xml | 1 +
tests/qemuxml2xmloutdata/console-virtio.xml | 1 +
.../cpu-host-passthrough-features.xml | 1 +
tests/qemuxml2xmloutdata/cputune-iothreads.xml | 1 +
.../cputune-iothreadsched-zeropriority.xml | 1 +
tests/qemuxml2xmloutdata/cputune-iothreadsched.xml | 1 +
tests/qemuxml2xmloutdata/cputune-zero-shares.xml | 1 +
tests/qemuxml2xmloutdata/cputune.xml | 1 +
.../qemuxml2xmloutdata/disk-drive-copy-on-read.xml | 2 +-
tests/qemuxml2xmloutdata/disk-drive-discard.xml | 2 +-
tests/qemuxml2xmloutdata/disk-mirror-active.xml | 5 +
tests/qemuxml2xmloutdata/disk-mirror-inactive.xml | 4 +
.../disk-mirror-old-inactive.xml | 4 +
tests/qemuxml2xmloutdata/disk-mirror-old.xml | 7 +-
tests/qemuxml2xmloutdata/disk-scsi-device-auto.xml | 2 +
tests/qemuxml2xmloutdata/disk-scsi-device.xml | 2 +
tests/qemuxml2xmloutdata/disk-scsi-disk-vpd.xml | 2 +
.../disk-scsi-lun-passthrough-sgio.xml | 2 +
tests/qemuxml2xmloutdata/disk-scsi-megasas.xml | 2 +
tests/qemuxml2xmloutdata/disk-scsi-mptsas1068.xml | 2 +
tests/qemuxml2xmloutdata/disk-scsi-virtio-scsi.xml | 2 +
tests/qemuxml2xmloutdata/disk-scsi-vscsi.xml | 2 +
tests/qemuxml2xmloutdata/disk-serial.xml | 3 +
tests/qemuxml2xmloutdata/disk-source-pool-mode.xml | 4 +
tests/qemuxml2xmloutdata/disk-source-pool.xml | 2 +
tests/qemuxml2xmloutdata/disk-usb-device.xml | 2 +
.../disk-virtio-scsi-cmd_per_lun.xml | 1 +
.../disk-virtio-scsi-ioeventfd.xml | 1 +
.../disk-virtio-scsi-max_sectors.xml | 1 +
.../disk-virtio-scsi-num_queues.xml | 1 +
.../qemuxml2xmloutdata/graphics-listen-network.xml | 1 +
.../graphics-listen-network2.xml | 1 +
.../graphics-spice-compression.xml | 1 +
.../qemuxml2xmloutdata/graphics-spice-qxl-vga.xml | 1 +
tests/qemuxml2xmloutdata/graphics-spice.xml | 1 +
.../hostdev-scsi-autogen-address.xml | 1 +
.../qemuxml2xmloutdata/hostdev-scsi-large-unit.xml | 1 +
.../hostdev-scsi-lsi-iscsi-auth.xml | 1 +
.../qemuxml2xmloutdata/hostdev-scsi-lsi-iscsi.xml | 1 +
tests/qemuxml2xmloutdata/hostdev-scsi-lsi.xml | 1 +
tests/qemuxml2xmloutdata/hostdev-scsi-rawio.xml | 1 +
tests/qemuxml2xmloutdata/hostdev-scsi-readonly.xml | 1 +
tests/qemuxml2xmloutdata/hostdev-scsi-sgio.xml | 1 +
.../qemuxml2xmloutdata/hostdev-scsi-shareable.xml | 1 +
.../hostdev-scsi-vhost-scsi-ccw.xml | 1 +
.../hostdev-scsi-vhost-scsi-pci.xml | 1 +
.../hostdev-scsi-virtio-iscsi-auth.xml | 1 +
.../hostdev-scsi-virtio-iscsi.xml | 1 +
.../hostdev-scsi-virtio-scsi.xml | 1 +
tests/qemuxml2xmloutdata/hostdev-vfio.xml | 1 +
tests/qemuxml2xmloutdata/hugepages-pages.xml | 1 +
tests/qemuxml2xmloutdata/hugepages-pages2.xml | 1 +
tests/qemuxml2xmloutdata/hugepages-pages3.xml | 1 +
tests/qemuxml2xmloutdata/hugepages-shared.xml | 1 +
tests/qemuxml2xmloutdata/hugepages.xml | 1 +
tests/qemuxml2xmloutdata/lease.xml | 2 +
.../machine-loadparm-multiple-disks-nets-s390.xml | 2 +
tests/qemuxml2xmloutdata/memory-hotplug-dimm.xml | 1 +
tests/qemuxml2xmloutdata/memory-hotplug.xml | 1 +
tests/qemuxml2xmloutdata/memtune-unlimited.xml | 1 +
tests/qemuxml2xmloutdata/memtune.xml | 1 +
tests/qemuxml2xmloutdata/metadata-duplicate.xml | 1 +
tests/qemuxml2xmloutdata/metadata.xml | 1 +
tests/qemuxml2xmloutdata/minimal.xml | 1 +
tests/qemuxml2xmloutdata/net-hostdev-vfio.xml | 1 +
tests/qemuxml2xmloutdata/net-hostdev.xml | 1 +
tests/qemuxml2xmloutdata/net-midonet.xml | 1 +
tests/qemuxml2xmloutdata/net-openvswitch.xml | 1 +
tests/qemuxml2xmloutdata/net-udp.xml | 1 +
tests/qemuxml2xmloutdata/net-virtio-device.xml | 1 +
.../net-virtio-disable-offloads.xml | 1 +
.../net-virtio-network-portgroup.xml | 1 +
.../net-virtio-rxtxqueuesize.xml | 1 +
.../numad-auto-memory-vcpu-cpuset.xml | 1 +
...ad-auto-memory-vcpu-no-cpuset-and-placement.xml | 1 +
.../numad-auto-vcpu-no-numatune.xml | 1 +
.../numad-static-vcpu-no-numatune.xml | 1 +
tests/qemuxml2xmloutdata/panic-isa.xml | 1 +
tests/qemuxml2xmloutdata/panic-no-address.xml | 1 +
tests/qemuxml2xmloutdata/panic.xml | 1 +
tests/qemuxml2xmloutdata/pci-rom.xml | 1 +
.../qemuxml2xmloutdata/pci-serial-dev-chardev.xml | 1 +
tests/qemuxml2xmloutdata/pcie-expander-bus.xml | 1 +
tests/qemuxml2xmloutdata/pcie-root-port.xml | 1 +
.../pcie-switch-downstream-port.xml | 1 +
.../pcie-switch-upstream-port.xml | 1 +
tests/qemuxml2xmloutdata/pcihole64-q35.xml | 1 +
tests/qemuxml2xmloutdata/q35-pcie-autoadd.xml | 1 +
tests/qemuxml2xmloutdata/q35-pcie.xml | 1 +
tests/qemuxml2xmloutdata/q35-usb2-multi.xml | 1 +
tests/qemuxml2xmloutdata/q35-usb2-reorder.xml | 1 +
tests/qemuxml2xmloutdata/q35-usb2.xml | 1 +
tests/qemuxml2xmloutdata/q35-virtio-pci.xml | 1 +
tests/qemuxml2xmloutdata/q35.xml | 1 +
tests/qemuxml2xmloutdata/seclabel-dac-none.xml | 1 +
.../seclabel-device-multiple.xml | 1 +
.../seclabel-dynamic-baselabel.xml | 1 +
.../seclabel-dynamic-labelskip.xml | 1 +
tests/qemuxml2xmloutdata/seclabel-dynamic-none.xml | 1 +
.../seclabel-dynamic-override.xml | 2 +
.../seclabel-dynamic-relabel.xml | 1 +
tests/qemuxml2xmloutdata/seclabel-none.xml | 1 +
.../seclabel-static-labelskip.xml | 1 +
tests/qemuxml2xmloutdata/seclabel-static.xml | 1 +
.../serial-spiceport-nospice.xml | 1 +
tests/qemuxml2xmloutdata/serial-spiceport.xml | 1 +
.../qemuxml2xmloutdata/serial-target-port-auto.xml | 1 +
.../serial-tcp-tlsx509-chardev.xml | 1 +
tests/qemuxml2xmloutdata/smbios-multiple-type2.xml | 1 +
tests/qemuxml2xmloutdata/smbios.xml | 1 +
tests/qemuxml2xmloutdata/sound-device.xml | 1 +
tests/qemuxml2xmloutdata/video-qxl-heads.xml | 1 +
tests/qemuxml2xmloutdata/video-qxl-noheads.xml | 1 +
tests/qemuxml2xmloutdata/vmcoreinfo.xml | 1 +
tests/qemuxml2xmltest.c | 283 ++++---------
tests/testutils.c | 8 +-
tests/testutils.h | 5 -
160 files changed, 2926 insertions(+), 221 deletions(-)
create mode 100644 tests/qemustatusxml2xmldata/blockjob-mirror-in.xml
create mode 100644 tests/qemustatusxml2xmldata/blockjob-mirror-out.xml
create mode 100644 tests/qemustatusxml2xmldata/migration-out-nbd-in.xml
create mode 100644 tests/qemustatusxml2xmldata/migration-out-nbd-out.xml
create mode 100644 tests/qemustatusxml2xmldata/modern-in.xml
create mode 100644 tests/qemustatusxml2xmldata/modern-out.xml
create mode 100644 tests/qemustatusxml2xmldata/vcpus-multi-in.xml
create mode 100644 tests/qemustatusxml2xmldata/vcpus-multi-out.xml
--
2.16.2
6 years, 8 months
[libvirt] [PATCH 0/4] Use and prefer change-vnc-password command
by John Ferlan
While investigating something else - 'change' QMP command for
the cdrom/floppy code, I noted the QMP schema lists the change
command as being deprecated for use with cdrom/floppy and changing
the VNC password. Further digging found that the existing set_password
QMP command would make the same call to change the password (qemu
API vnc_display_password) as long as "keep" was defined for connected
(which must be true for VNC). So altered the code to use the newer
command if available.
John Ferlan (4):
qemu: Alter current VNC set password to be legacy
qemu: Clean up formatting in virQEMUCapsCommands
qemu: Add change-vnc-password capability
qemu: Add support for change-vnc-password
src/qemu/qemu_capabilities.c | 8 +++--
src/qemu/qemu_capabilities.h | 1 +
src/qemu/qemu_hotplug.c | 12 ++++++--
src/qemu/qemu_monitor.c | 21 +++++++++++--
src/qemu/qemu_monitor.h | 2 ++
src/qemu/qemu_monitor_json.c | 34 ++++++++++++++++++++--
src/qemu/qemu_monitor_json.h | 2 ++
tests/qemucapabilitiesdata/caps_1.2.2.x86_64.xml | 1 +
tests/qemucapabilitiesdata/caps_1.3.1.x86_64.xml | 1 +
tests/qemucapabilitiesdata/caps_1.4.2.x86_64.xml | 1 +
tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 +
tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml | 1 +
tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml | 1 +
tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml | 1 +
.../caps_2.10.0-gicv2.aarch64.xml | 1 +
.../caps_2.10.0-gicv3.aarch64.xml | 1 +
tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml | 1 +
tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml | 1 +
tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 1 +
tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 +
tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 1 +
tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 1 +
.../caps_2.6.0-gicv2.aarch64.xml | 1 +
.../caps_2.6.0-gicv3.aarch64.xml | 1 +
tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml | 1 +
tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 +
tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml | 1 +
tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 1 +
tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 1 +
tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 1 +
tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml | 1 +
tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml | 1 +
tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 +
tests/qemumonitorjsontest.c | 2 ++
34 files changed, 98 insertions(+), 10 deletions(-)
--
2.13.6
6 years, 8 months
[libvirt] [PATCH 0/7] Some stylistic cleanups
by Ján Tomko
Ján Tomko (7):
maint: use parentheses after if
nwfilter: remove pointless assignment
openvz: pass sizeof to snprintf
virsh-edit: remove unreachable break
remote: remove unused label
virsh: use logical or for boolean values
Simplify some conditions
src/conf/domain_conf.c | 2 +-
src/nwfilter/nwfilter_gentech_driver.c | 1 -
src/openvz/openvz_driver.c | 3 +--
src/qemu/qemu_domain.c | 2 +-
src/qemu/qemu_migration.c | 2 +-
src/remote/remote_driver.c | 3 +--
tools/virsh-domain.c | 2 +-
tools/virsh-edit.c | 1 -
8 files changed, 6 insertions(+), 10 deletions(-)
--
2.16.1
6 years, 8 months
[libvirt] [PATCH perl 0/2] Fix missing methods in Perl binding
by Daniel P. Berrangé
Daniel P. Berrangé (2):
Add missing define_nwfilter and define_secret APIs
Fix docs for Sys::Virt::NWFilter undefine method
Changes | 3 ++-
lib/Sys/Virt.pm | 32 ++++++++++++++++++++++++++++++++
lib/Sys/Virt/NWFilter.pm | 6 ++----
3 files changed, 36 insertions(+), 5 deletions(-)
--
2.14.3
6 years, 8 months
[libvirt] [tck PATCH v3 0/2] new NetworkHelper function get_network_ip()
by Laine Stump
New for V3: added in the NetAddr::IP dependency to Build.PL, and added
a prequel patch that removes all tabs from that file.
Laine Stump (2):
Remove tab characters from Build.PL
new NetworkHelper function get_network_ip()
Build.PL | 105 +++++++++++++++++++------------------
lib/Sys/Virt/TCK/NetworkHelpers.pm | 22 ++++++++
2 files changed, 75 insertions(+), 52 deletions(-)
--
2.14.3
6 years, 8 months
[libvirt] [Question]Libvirt doesn't care about qemu monitor event if fail to destroy qemu process
by Wuzongyong (Euler Dept)
Hi,
We unregister qemu monitor after sending QEMU_PROCESS_EVENT_MONITOR_EOF to workerPool:
static void
qemuProcessHandleMonitorEOF(qemuMonitorPtr mon,
virDomainObjPtr vm,
void *opaque)
{
virQEMUDriverPtr driver = opaque;
qemuDomainObjPrivatePtr priv;
struct qemuProcessEvent *processEvent;
...
processEvent->eventType = QEMU_PROCESS_EVENT_MONITOR_EOF;
processEvent->vm = vm;
virObjectRef(vm);
if (virThreadPoolSendJob(driver->workerPool, 0, processEvent) < 0) {
ignore_value(virObjectUnref(vm));
VIR_FREE(processEvent);
goto cleanup;
}
/* We don't want this EOF handler to be called over and over while the
* thread is waiting for a job.
*/
qemuMonitorUnregister(mon);
...
}
Then we handle QEMU_PROCESS_EVENT_MONITOR_EOF in processMonitorEOFEvent function:
static void
processMonitorEOFEvent(virQEMUDriverPtr driver,
virDomainObjPtr vm)
{
...
if (qemuProcessBeginStopJob(driver, vm, QEMU_JOB_DESTROY, true) < 0)
return;
...
}
Here, libvirt will show that the vm state is running all the time if qemuProcessBeginStopJob return -1
even though qemu may terminate or be killed later.
So, may be we should re-register the monitor when qemuProcessBeginStopJob failed?
Thanks,
Zongyong Wu
6 years, 8 months
[libvirt] [PATCH] tests: force use of "NORMAL" TLS priority in test suite
by Daniel P. Berrangé
When generating certificates we rely on GNUTLS' built-in default setup
for the ciphers used in the certs. We then currently run with the distro
specific TLS priority setup which can be much stronger, to the extent
that the certificates we generate are considered untrustworthy. We don't
care about the quality of the ciphers we use in the test suite, so just
force the priority to "NORMAL" which should ensure our certs are
accepted by GNUTLS.
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
tests/virnettlscontexttest.c | 4 ++--
tests/virnettlssessiontest.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/virnettlscontexttest.c b/tests/virnettlscontexttest.c
index 089c10e964..86647f3014 100644
--- a/tests/virnettlscontexttest.c
+++ b/tests/virnettlscontexttest.c
@@ -72,7 +72,7 @@ static int testTLSContextInit(const void *opaque)
data->crt,
KEYFILE,
NULL,
- NULL,
+ "NORMAL",
true,
true);
} else {
@@ -80,7 +80,7 @@ static int testTLSContextInit(const void *opaque)
NULL,
data->crt,
KEYFILE,
- NULL,
+ "NORMAL",
true,
true);
}
diff --git a/tests/virnettlssessiontest.c b/tests/virnettlssessiontest.c
index 6d639e5b16..7e85607181 100644
--- a/tests/virnettlssessiontest.c
+++ b/tests/virnettlssessiontest.c
@@ -113,7 +113,7 @@ static int testTLSSessionInit(const void *opaque)
data->servercrt,
KEYFILE,
data->wildcards,
- NULL,
+ "NORMAL",
false,
true);
@@ -121,7 +121,7 @@ static int testTLSSessionInit(const void *opaque)
NULL,
data->clientcrt,
KEYFILE,
- NULL,
+ "NORMAL",
false,
true);
--
2.14.3
6 years, 8 months
