[libvirt] [PATCH v2 0/3] conf: don't ignore <target dev='blah'/> for macvtap interfaces
by Laine Stump
The parser had been clearing out *all* suggested device names for
type='direct' (aka macvtap) interfaces. All of the code implementing
macvtap allows for a user-specified device name, so we should allow
it. In the case that an interface name starts with "macvtap" or
"macvlan" though, we do still clear it out, just as we do with "vnet"
(which is the prefix used for automatically generated tap device
names), since those are the prefixes for the names we autogenerate for
macvtap and macvlan devices.
Resolves: https://bugzilla.redhat.com/1335798
Changes since V1:
* make a single #define for each of MACVLAN_PREFIX and MACVTAP_PREFIX
in virnetdevmacvlan.h rather than duplicating #defines from
virnetdevmacvlan.c into domain_conf.h (as suggested by Martin
* move/rename the auto-generated prefix for regular tap devices to be
consistent with the macvtap/macvlan prefixes.
Laine Stump (3):
util: make macvtap/macvlan generated name #defines available to other
files
conf: don't ignore <target dev='blah'/> for macvtap interfaces
util: rename/move VIR_NET_GENERATED_PREFIX to be consistent
docs/formatdomain.html.in | 6 ++--
src/bhyve/bhyve_command.c | 4 +--
src/conf/domain_conf.c | 11 ++++--
src/conf/domain_conf.h | 4 ---
src/interface/interface_backend_udev.c | 2 +-
src/qemu/qemu_interface.c | 8 ++---
src/uml/uml_conf.c | 4 +--
src/util/virnetdev.h | 5 +++
src/util/virnetdevmacvlan.c | 65 ++++++++++++++--------------------
src/util/virnetdevmacvlan.h | 6 ++++
10 files changed, 57 insertions(+), 58 deletions(-)
--
2.9.3
7 years, 11 months
[libvirt] [PATCH v2 0/5] add support for qemu-xhci USB controller
by Pavel Hrdina
Pavel Hrdina (5):
qemu: change the logic of setting default USB controller
qemu: use nec-usb-xhci as a default controller for aarch64 if
available
qemu: introduce QEMU_CAPS_DEVICE_QEMU_XHCI
qemu: add support for qemu-xhci USB controller
qemu: use qemu-xhci USB controller by default for ppc64 and aarch64
docs/formatdomain.html.in | 4 +-
docs/schemas/domaincommon.rng | 1 +
src/conf/domain_addr.c | 1 +
src/conf/domain_conf.c | 1 +
src/conf/domain_conf.h | 1 +
src/qemu/qemu_capabilities.c | 2 +
src/qemu/qemu_capabilities.h | 1 +
src/qemu/qemu_command.c | 8 +++-
src/qemu/qemu_domain.c | 47 ++++++++++++++--------
src/qemu/qemu_domain_address.c | 1 +
tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 +
...muxml2argv-aarch64-usb-controller-nec-xhci.args | 19 +++++++++
...emuxml2argv-aarch64-usb-controller-nec-xhci.xml | 16 ++++++++
...uxml2argv-aarch64-usb-controller-qemu-xhci.args | 19 +++++++++
...muxml2argv-aarch64-usb-controller-qemu-xhci.xml | 16 ++++++++
...emuxml2argv-ppc64-usb-controller-qemu-xhci.args | 19 +++++++++
...qemuxml2argv-ppc64-usb-controller-qemu-xhci.xml | 1 +
...qemuxml2argv-usb-controller-qemu-xhci-limit.xml | 14 +++++++
...l2argv-usb-controller-qemu-xhci-unavailable.xml | 1 +
.../qemuxml2argv-usb-controller-qemu-xhci.args | 19 +++++++++
.../qemuxml2argv-usb-controller-qemu-xhci.xml | 14 +++++++
tests/qemuxml2argvtest.c | 15 +++++++
22 files changed, 201 insertions(+), 20 deletions(-)
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-usb-controller-nec-xhci.args
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-usb-controller-nec-xhci.xml
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-usb-controller-qemu-xhci.args
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-usb-controller-qemu-xhci.xml
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-ppc64-usb-controller-qemu-xhci.args
create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-ppc64-usb-controller-qemu-xhci.xml
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-controller-qemu-xhci-limit.xml
create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-usb-controller-qemu-xhci-unavailable.xml
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-controller-qemu-xhci.args
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-controller-qemu-xhci.xml
--
2.12.2
7 years, 11 months
[libvirt] [PATCH v2 0/2] don't kill qemu process on restart if networkNotify fails
by Laine Stump
John thought I didn't go far enough in my removal of return codes in V1...
Laine Stump (2):
qemu: don't kill qemu process on restart if networkNotify fails
network: better log message when network is inactive during reconnect
src/network/bridge_driver.c | 17 +++++++++++------
src/network/bridge_driver.h | 7 +++----
src/qemu/qemu_process.c | 9 +++------
3 files changed, 17 insertions(+), 16 deletions(-)
--
2.9.3
7 years, 11 months
[libvirt] [PATCH v4 0/3] libxl: nestedhvm support
by Wim Ten Have
From: Wim ten Have <wim.ten.have(a)oracle.com>
This patch enhances host-passthrough capability to advertise the
required vendor CPU virtualization feature which will be used to
enable 'nestedhvm' in the libxl driver.
Wim ten Have (3):
libxl: set nestedhvm for mode host-passthrough
xenconfig: add conversions for xen-xl
xlconfigtest: add tests for 'nestedhvm' support
cfg.mk | 4 +-
src/libxl/libxl_conf.c | 39 ++++++++++-
src/libxl/libxl_conf.h | 1 +
src/libxl/libxl_domain.c | 2 +-
src/xenconfig/xen_xl.c | 76 ++++++++++++++++++++++
tests/testutilsxen.c | 30 +++++++++
.../test-fullvirt-nestedhvm-disabled.cfg | 26 ++++++++
.../test-fullvirt-nestedhvm-disabled.xml | 61 +++++++++++++++++
tests/xlconfigdata/test-fullvirt-nestedhvm.cfg | 26 ++++++++
tests/xlconfigdata/test-fullvirt-nestedhvm.xml | 59 +++++++++++++++++
tests/xlconfigtest.c | 2 +
11 files changed, 322 insertions(+), 4 deletions(-)
create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm-disabled.cfg
create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm-disabled.xml
create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm.cfg
create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm.xml
--
2.9.3
7 years, 11 months
[libvirt] [PATCH 0/4] qemu: process: Fix memleaks on VM restart
by Peter Krempa
Few leaks with automatic pinning, USB addresses and TLS migration, since
the private data structure needs to be cleared manually in qemuProcessStop.
Peter Krempa (4):
qemu: process: Clean automatic NUMA/cpu pinning information on
shutdown
qemu: process: Don't leak priv->usbaddrs after VM restart
qemu: process: Clean up priv->migTLSAlias
qemu: Move freeing of PCI address list to qemuProcessStop
src/qemu/qemu_domain_address.c | 1 -
src/qemu/qemu_process.c | 15 +++++++++++++++
2 files changed, 15 insertions(+), 1 deletion(-)
--
2.12.2
7 years, 11 months
[libvirt] [PATCH] qemu: Don't fail if physical size can't be updated in qemuDomainGetBlockInfo
by Peter Krempa
Since commit c5f6151390 qemuDomainBlockInfo tries to update the
"physical" storage size for all network storage and not only block
devices.
Since the storage driver APIs to do this are not implemented for certain
storage types (RBD, iSCSI, ...) the code would fail to retrieve any data
since the failure of qemuDomainStorageUpdatePhysical is fatal.
Since it's desired to return data even if the total size can't be
updated we need to ignore errors from that fucntion and return plausible
data.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1442344
---
Notes:
This function will require more fixing though. This is just a bandaid to
remove the regression. I'll post other patches as follow up later.
src/qemu/qemu_driver.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index e39de625d..8ff242597 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -11553,10 +11553,12 @@ qemuDomainGetBlockInfo(virDomainPtr dom,
if (info->allocation == 0)
info->allocation = entry->physical;
- if (qemuDomainStorageUpdatePhysical(driver, cfg, vm, disk->src) < 0)
- goto endjob;
-
- info->physical = disk->src->physical;
+ if (qemuDomainStorageUpdatePhysical(driver, cfg, vm, disk->src) == 0) {
+ info->physical = disk->src->physical;
+ } else {
+ virResetLastError();
+ info->physical = entry->physical;
+ }
} else {
info->physical = entry->physical;
}
--
2.12.2
7 years, 11 months
[libvirt] [PATCH 00/14] network schema refactor and addition of cookies for http disks
by Peter Krempa
Peter Krempa (14):
docs: schemas: Remove <interleave> from file/block/dir/volume disks
docs: schemas: Extract disk source host specification
docs: schemas: Move the interleave definition into network disk source
docs: schemas: Extract RBD-specific data
docs: schemas: Extract HTTP disk source specification
docs: schemas: Split out simple network protocols
docs: schemas: Split up definitions for NBD and gluster
conf: Extract formatting of network disk source into separate function
tests: genericxml2xml: Add test case for HTTP based disk
util: string: Introduce virStringHasChars
conf: Add support for cookies for HTTP based disks
qemu: command: Use switch to formatting additional network disk params
qemu: capabilities: Add capability for the new curl driver options
qemu: command: Add support for HTTP cookies
docs/formatdomain.html.in | 9 +
docs/schemas/domaincommon.rng | 316 +++++++++++++--------
src/conf/domain_conf.c | 205 ++++++++++---
src/qemu/qemu_capabilities.c | 2 +
src/qemu/qemu_capabilities.h | 1 +
src/qemu/qemu_command.c | 48 +++-
src/util/virstoragefile.c | 124 ++++++++
src/util/virstoragefile.h | 14 +
src/util/virstring.c | 23 +-
src/util/virstring.h | 2 +
.../generic-disk-network-http.xml | 48 ++++
tests/genericxml2xmltest.c | 1 +
tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 +
.../qemuxml2argv-disk-drive-network-http.args | 32 +++
.../qemuxml2argv-disk-drive-network-http.xml | 48 ++++
tests/qemuxml2argvtest.c | 1 +
16 files changed, 701 insertions(+), 174 deletions(-)
create mode 100644 tests/genericxml2xmlindata/generic-disk-network-http.xml
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-http.args
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-http.xml
--
2.12.2
7 years, 11 months
[libvirt] [PATCH 0/3] qemu: Allow turing of SSL verification for https/ftps drives
by Peter Krempa
This is a followup to the qemu cookie series and should be applied on top of it.
Since I already fixed a few things in the original series this would not apply
cleanly, thus you can fetch it at:
git fetch git://pipo.sk/pipo/libvirt.git qemu-ssl-verify-off
Peter Krempa (3):
conf: Use only one temporary string in virDomainDiskSourceParse
conf: Add support for modifying ssl validation for https/ftps disks
qemu: command: Implement ssl verification configuration
docs/formatdomain.html.in | 9 ++++
docs/schemas/domaincommon.rng | 50 +++++++++++++++++++++-
src/conf/domain_conf.c | 34 ++++++++++++---
src/qemu/qemu_command.c | 27 +++++++++++-
src/util/virstoragefile.h | 1 +
.../generic-disk-network-http.xml | 2 +
.../qemuxml2argv-disk-drive-network-http.args | 2 +-
.../qemuxml2argv-disk-drive-network-http.xml | 1 +
8 files changed, 114 insertions(+), 12 deletions(-)
--
2.12.2
7 years, 11 months
[libvirt] [PATCH 0/3] add support for qemu-xhci USB controller
by Pavel Hrdina
Pavel Hrdina (3):
qemu: introduce QEMU_CAPS_DEVICE_QEMU_XHCI
qemu: add support for qemu-xhci USB controller
qemu: use qemu-xhci USB controller by default for ppc64 and aarch64
docs/formatdomain.html.in | 2 +-
docs/schemas/domaincommon.rng | 1 +
src/conf/domain_addr.c | 1 +
src/conf/domain_conf.c | 1 +
src/conf/domain_conf.h | 1 +
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
src/qemu/qemu_command.c | 8 +++++--
src/qemu/qemu_domain.c | 25 ++++++++++++++------
src/qemu/qemu_domain_address.c | 1 +
tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 +
...uxml2argv-aarch64-usb-controller-qemu-xhci.args | 20 ++++++++++++++++
...muxml2argv-aarch64-usb-controller-qemu-xhci.xml | 27 ++++++++++++++++++++++
...emuxml2argv-ppc64-usb-controller-qemu-xhci.args | 19 +++++++++++++++
...qemuxml2argv-ppc64-usb-controller-qemu-xhci.xml | 1 +
...qemuxml2argv-usb-controller-qemu-xhci-limit.xml | 15 ++++++++++++
...l2argv-usb-controller-qemu-xhci-unavailable.xml | 15 ++++++++++++
.../qemuxml2argv-usb-controller-qemu-xhci.args | 19 +++++++++++++++
.../qemuxml2argv-usb-controller-qemu-xhci.xml | 15 ++++++++++++
tests/qemuxml2argvtest.c | 12 ++++++++++
20 files changed, 177 insertions(+), 10 deletions(-)
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-usb-controller-qemu-xhci.args
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-usb-controller-qemu-xhci.xml
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-ppc64-usb-controller-qemu-xhci.args
create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-ppc64-usb-controller-qemu-xhci.xml
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-controller-qemu-xhci-limit.xml
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-controller-qemu-xhci-unavailable.xml
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-controller-qemu-xhci.args
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-controller-qemu-xhci.xml
--
2.12.2
7 years, 11 months
[libvirt] [PATCH 0/2] Report VIR_DOMAIN_JOB_OPERATION in job stats
by Jiri Denemark
As agreed in [1] we should enhance job statistics returned by
virDomainGetJobStats API and VIR_DOMAIN_EVENT_ID_JOB_COMPLETED event
with a new typed parameter which would indicate what operation
(migration, snapshot, ...) the reported statistics belong to.
https://bugzilla.redhat.com/show_bug.cgi?id=1441563
[1] https://www.redhat.com/archives/libvir-list/2017-April/msg00540.html
Jiri Denemark (2):
Add VIR_DOMAIN_JOB_OPERATION typed parameter
qemu: Report VIR_DOMAIN_JOB_OPERATION
include/libvirt/libvirt-domain.h | 25 +++++++++++++++++++++++++
src/qemu/qemu_domain.c | 16 +++++++++++++---
src/qemu/qemu_domain.h | 4 +++-
src/qemu/qemu_driver.c | 32 ++++++++++++++++++++++----------
src/qemu/qemu_migration.c | 19 ++++++++++++-------
src/qemu/qemu_process.c | 6 ++++--
src/qemu/qemu_process.h | 3 ++-
tools/virsh-domain.c | 29 +++++++++++++++++++++++++++++
8 files changed, 110 insertions(+), 24 deletions(-)
--
2.12.2
7 years, 11 months