[libvirt] [PATCH] libvirt_public.syms: Fix virDomainSetBlockThreshold placement
by Michal Privoznik
The symbol was introduced in the 3.2.0 release (bb09798fbeb5f)
and not 3.1.0 release as its current placement in the file
suggests.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
src/libvirt_public.syms | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/libvirt_public.syms b/src/libvirt_public.syms
index 428cf2e..37a8a18 100644
--- a/src/libvirt_public.syms
+++ b/src/libvirt_public.syms
@@ -755,8 +755,12 @@ LIBVIRT_3.0.0 {
LIBVIRT_3.1.0 {
global:
- virDomainSetBlockThreshold;
virDomainSetVcpu;
} LIBVIRT_3.0.0;
+LIBVIRT_3.2.0 {
+ global:
+ virDomainSetBlockThreshold;
+} LIBVIRT_3.1.0;
+
# .... define new API here using predicted next version number ....
--
2.10.2
7 years, 7 months
[libvirt] [PATCH] vz: fix typo that breaks build
by Nikolay Shirokovskiy
---
I guess it should be back ported to 3.2.0 release too. Sorry that
we missed this during freeze period.
src/vz/vz_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c
index bb1afd0..da83a8f 100644
--- a/src/vz/vz_driver.c
+++ b/src/vz/vz_driver.c
@@ -121,7 +121,7 @@ vzBuildCapabilities(void)
verify(ARRAY_CARDINALITY(archs) == ARRAY_CARDINALITY(emulators));
- for (i = 0; i < ARRAY_CARDINALITY(os_types); i++)
+ for (i = 0; i < ARRAY_CARDINALITY(ostypes); i++)
for (j = 0; j < ARRAY_CARDINALITY(archs); j++)
for (k = 0; k < ARRAY_CARDINALITY(emulators); k++)
if (vzCapsAddGuestDomain(caps, ostypes[i], archs[j],
--
1.8.3.1
7 years, 7 months
[libvirt] [PATCH] qemu: Break endless loop if qemuMigrationResetTLS fails
by Jiri Denemark
Jumping to "endjob" label from a code after this label is not a very
good idea.
Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com>
---
src/qemu/qemu_migration.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index 87d7dcd0c..7f00a3d93 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -5351,9 +5351,7 @@ qemuMigrationFinish(virQEMUDriverPtr driver,
QEMU_ASYNC_JOB_MIGRATION_IN);
}
- if (qemuMigrationResetTLS(driver, vm, QEMU_ASYNC_JOB_MIGRATION_IN,
- NULL, NULL) < 0)
- goto endjob;
+ qemuMigrationResetTLS(driver, vm, QEMU_ASYNC_JOB_MIGRATION_IN, NULL, NULL);
qemuMigrationJobFinish(driver, vm);
if (!virDomainObjIsActive(vm))
--
2.12.2
7 years, 7 months
[libvirt] [PATCH 0/2] More clang-inspired fixes
by Ján Tomko
Hopefully, the split of library/non-library code will let us
tighten the frame limit in the future.
Ján Tomko (2):
util: ignore -Wcast-align in virNetlinkDumpCommand
Split out -Wframe-larger-than warning from WARN_CLFAGS
daemon/Makefile.am | 3 +++
m4/virt-compile-warnings.m4 | 4 ++--
src/Makefile.am | 1 +
src/util/virnetlink.c | 3 ++-
tests/Makefile.am | 2 ++
tools/Makefile.am | 6 ++++++
6 files changed, 16 insertions(+), 3 deletions(-)
--
2.10.2
7 years, 7 months
[libvirt] [PATCH v2 0/5] Fix gluster pool lookup issues
by Peter Krempa
Peter Krempa (5):
storage: util: Add boolean differentiating between gluster lookup type
storage: util: Split out the gluster volume extraction code into new
function
test: Introduce testing of virStorageUtilGlusterExtractPoolSources
storage: Fix XPath for looking up gluster volume name
storage: gluster: Use volume name as "<name>" field in the XML
src/storage/storage_backend_fs.c | 5 +-
src/storage/storage_backend_gluster.c | 3 +-
src/storage/storage_util.c | 110 ++++++++++++--------
src/storage/storage_util.h | 6 +-
tests/Makefile.am | 15 ++-
.../gluster-parse-basic-native.xml | 7 ++
.../gluster-parse-basic-netfs.xml | 7 ++
.../virstorageutildata/gluster-parse-basic-src.xml | 47 +++++++++
.../gluster-parse-multivol-native.xml | 17 +++
.../gluster-parse-multivol-netfs.xml | 17 +++
.../gluster-parse-multivol-src.xml | 32 ++++++
tests/virstorageutiltest.c | 114 +++++++++++++++++++++
12 files changed, 330 insertions(+), 50 deletions(-)
create mode 100644 tests/virstorageutildata/gluster-parse-basic-native.xml
create mode 100644 tests/virstorageutildata/gluster-parse-basic-netfs.xml
create mode 100644 tests/virstorageutildata/gluster-parse-basic-src.xml
create mode 100644 tests/virstorageutildata/gluster-parse-multivol-native.xml
create mode 100644 tests/virstorageutildata/gluster-parse-multivol-netfs.xml
create mode 100644 tests/virstorageutildata/gluster-parse-multivol-src.xml
create mode 100644 tests/virstorageutiltest.c
--
2.12.1
7 years, 7 months
[libvirt] [PATCH] news.rng: work around a bug in old libxml2
by Ján Tomko
Similar to commit c3c2cc6, use a literal newsline instead of \n
inside the brackets.
---
Pushed as a build fix.
docs/schemas/news.rng | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/docs/schemas/news.rng b/docs/schemas/news.rng
index ec4313f..a633e22 100644
--- a/docs/schemas/news.rng
+++ b/docs/schemas/news.rng
@@ -45,7 +45,9 @@
<element name="change">
<element name="summary">
<data type="string">
- <param name="pattern">\n[^\n]+\n +</param>
+ <!-- Use literal newline instead of \n for bug in libxml2 2.7.6 -->
+ <param name="pattern">\n[^
+]+\n +</param>
</data>
</element>
<optional>
--
2.10.2
7 years, 7 months
[libvirt] [PATCH 0/3] A couple of Coverity found issues
by John Ferlan
There's more, but many are false positives and there's also a couple
more that I have to think more deeply about...
John Ferlan (3):
tests: Pass BlockIOThrottle arguments by reference not value
qemu: Initialize 'data' argument
qemu: Fix resource leak in qemuDomainAddChardevTLSObjects error path
src/qemu/qemu_driver.c | 2 +-
src/qemu/qemu_migration.c | 11 ++++++++---
tests/qemumonitorjsontest.c | 38 +++++++++++++++++++-------------------
3 files changed, 28 insertions(+), 23 deletions(-)
--
2.9.3
7 years, 7 months
[libvirt] [PATCH 0/5] qemu: fix individual vcpu hotplug code
by Peter Krempa
Resolve a few corner cases which would create invalid configurations or produce
bad error messages.
Peter Krempa (5):
qemu: hotplug: Iterate over vcpu 0 in individual vcpu hotplug code
qemu: hotplug: Fix formatting strings in
qemuDomainFilterHotplugVcpuEntities
qemu: hotplug: Clear vcpu ordering for coldplug of vcpus
qemu: hotplug: Add validation for coldplug of individual vcpus
qemu: hotplug: Validate that vcpu-hotplug does not break config
src/qemu/qemu_hotplug.c | 73 +++++++++++++++++++++++++++++++++++++++++++------
1 file changed, 65 insertions(+), 8 deletions(-)
--
2.12.2
7 years, 7 months
[libvirt] [PATCH v2 00/10] hyperv: add support for Hyper-V 2012 and newer.
by Dawid Zamirski
Hello,
This is v2 with all the code review feedback addressed. Please see the
cover letter in v1 here:
https://www.redhat.com/archives/libvir-list/2017-March/msg01624.html
Changes in v2:
* checked each patch with make syntax-check individually
* fixed missing notices in hyperv_wmi_generator.py
* addressed an issue where a case of "v2-only" WMI classes was not
handled properly.
Patches 5-10 should be squashed onto 4 - those won't compile
individually as the code is too inter-dependent and are kept separately
just for review puroposes.
Regards,
Dawid Zamirski (10):
hyperv: store WMI version in hypervPrivate.
hyperv: introduce hypervWmiClassInfo struct.
hyperv: update hypervObject struct.
hyperv: add hypervWqlQuery struct.
hyperv: make hypervEnumAndPull use hypervWqlQuery
hyperv: update generator input file.
hyperv: update wmi code generator.
hyperv: add helper for getting WMI class lists.
hyperv: port rest of the driver to new stucts.
hyperv: add hypervInitConnection.
src/Makefile.am | 2 -
src/hyperv/hyperv_driver.c | 168 ++++++++-------
src/hyperv/hyperv_private.h | 8 +-
src/hyperv/hyperv_wmi.c | 173 +++++++++++----
src/hyperv/hyperv_wmi.h | 56 ++++-
src/hyperv/hyperv_wmi_classes.h | 30 +++
src/hyperv/hyperv_wmi_generator.input | 239 ++++++++++++++++++---
src/hyperv/hyperv_wmi_generator.py | 385 +++++++++++++++++++++++++---------
8 files changed, 810 insertions(+), 251 deletions(-)
--
2.9.3
7 years, 7 months
