May 2016 - Devel - libvirt List Archives

[libvirt] [PATCH v3 0/2] bhyve: implement domainShutdown
by Roman Bogorodskiy 05 May '16

05 May '16

Changes from v2: - Split domainDestroy changes and domainShutdown addition into two patches - In bhyveDestroy, close bhyve monitor after running 'bhyvectl --destroy' (reasoning in the commit message) Roman Bogorodskiy (2): bhyve: drop virProcessKillPainfully() from destroy bhyve: implement domainShutdown src/bhyve/bhyve_driver.c | 27 +++++++++++++++++++++++++++ src/bhyve/bhyve_process.c | 43 +++++++++++++++++++++++++++++-------------- src/bhyve/bhyve_process.h | 2 ++ 3 files changed, 58 insertions(+), 14 deletions(-) -- 2.7.4

2 5

[libvirt] ANNOUNCE: libvirt 1.3.3.1 maintenance release
by Cole Robinson 05 May '16

05 May '16

libvirt 1.3.3.1 is now available. This is a maintenance release of libvirt 1.3.3 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-1.3.3.1.tar.gz Changes in this version: * spec: Use proper indentation * libvirt.spec: remove duplicate files from -docs package * network: Fix segfault on daemon reload * send default USB controller in xml to destination during migration * virsh: Fix support for 64 migration options * qemu: Regenerate VNC socket paths * qemu: conf: Set default logging approach in virQEMUDriverConfigNew * qemu: Unref cfg in qemuDomainDefPostParse * spec: If installing default network, restart libvirtd * qemu: fix error log in qemuAssignPCIAddresses() * virsh: host: Use bitmap size in bytes rather than bit count * qemu: Fix off-by-one error in block I/O throttle messages * conf: Drop restrictions on rng backend path * vbox: VIR_WARN if we don't support the API version * qemu: Limit maximum block device I/O tune values * virconf: Handle conf file without ending newline * network: fix DHCPv6 on networks with prefix != 64 * rpc: Don't leak fd via CreateXMLWithFiles * libvirt: Fix crash on URI without scheme * tests: fix xen-related tests * man: Clarify virsh vol-clone works within a single pool * network: Don't use ERR_NO_SUPPORT for invalid net-update requests * Revert "daemon: use socket activation with systemd" * Explicitly error on uri=qemu://system * lxc: explicitly error on interface type=ethernet * tests: Fix syntax in iSCSI auth/secret tests * Libvirt: virTypedParamsValidate: Fix detection of multiple parameters * Resolve a couple of memory leaks * libxl: use LIBXL_API_VERSION 0x040200 * Add functions for handling exponential backoff loops. * spec: Only pull in API docs with -devel package * util: Add virGettextInitialize, convert the code * man: virsh: Document lxc-enter-namespace --noseclabel * storage: mpath: Don't error on target_type=NULL * qemu: command: don't overwrite watchdog dump action * rpc: daemon: Fix virtlog/virtlock daemon reload * conf: also mark the implicit video as primary * conf: move default video addition after XML parsing * virtlogd: Fix a couple minor memory leaks * qemu: Free priv->machineName * configure: Fix check for --with-login-shell on Windows * util: move ENODATA redefine to internal.h * libxl: libxl_domain_create_restore has an extra argument * qemu: perf: Fix crash/memory corruption on failed VM start * qemu: alias: Fix calculation of memory device aliases * Link libvirt_xenconfig instead of libvirt against libxl * virt-admin: get rid of LIBVIRT_DEFAULT_ADMIN_URI env var * libvirt-admin: do not crash on URI without a scheme * virsh: read default connection uri from env later * build: add GCC 6.0 -Wlogical-op workaround * build: cleanup GCC < 4.6 -Wlogical-op workaround * qemu: support virt-2.6 machine type on arm For info about past maintenance releases, see: http://wiki.libvirt.org/page/Maintenance_Releases Thanks, Cole

1 0

[libvirt] ANNOUNCE: libvirt 1.2.18.3 maintenance release
by Cole Robinson 05 May '16

05 May '16

libvirt 1.2.18.3 is now available. This is a maintenance release of libvirt 1.2.18 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-1.2.18.3.tar.gz Changes in this version: * spec: Use proper indentation * spec: If installing default network, restart libvirtd * rpc: Don't leak fd via CreateXMLWithFiles * libvirt.spec: remove duplicate files from -docs package * wireshark: Fix header of get_message_len() * wireshark: Replace WIRESHARK_COMPAT with actual version comparison * wireshark: s/tvb_length/tvb_captured_length/ * wireshark: s/ep_alloc/wmem_alloc/ * wireshark: s/proto_tree_add_text/proto_tree_add_item/ * spec: Only pull in API docs with -devel package * build: accomodate selinux 2.5 header API change * build: add GCC 6.0 -Wlogical-op workaround * build: cleanup GCC < 4.6 -Wlogical-op workaround * lxc: don't try to hide parent cgroups inside container * driver: log missing modules as INFO, not WARN * rpc: wait longer for session daemon to start up * util: virfile: Only setuid for virFileRemove if on NFS * util: virfile: Clarify setuid usage for virFileRemove * lxc: fuse: Stub out Slab bits in /proc/meminfo * lxc: fuse: Fill in MemAvailable for /proc/meminfo * lxc: fuse: Fix /proc/meminfo size calculation * lxc: fuse: Unindent meminfo logic * virfile: Fix error path for forked virFileRemove * security: Do not restore kernel and initrd labels * rpc: socket: Don't repeatedly attempt to launch daemon * rpc: socket: Explicitly error if we exceed retry count * rpc: socket: Minor cleanups * build: predictably generate systemtap tapsets (bz 1173641) * leaseshelper: fix crash when no mac is specified * schema: interleave domain name and uuid with other elements For info about past maintenance releases, see: http://wiki.libvirt.org/page/Maintenance_Releases Thanks, Cole

1 0

[libvirt] [PATCH] build: fix 32-bit build of admin
by Eric Blake 04 May '16

04 May '16

We can't guarantee which 64-bit type will be used in an RPC struct; while %lu worked on 64-bit Linux, that won't always be the type used on all 64-bit platforms; and certainly is not right for 32-bit: admin.c: In function 'adminDispatchClientGetInfo': admin.c:265:25: error: format '%lu' expects argument of type 'long unsigned int', but argument 7 has type 'uint64_t {aka long long unsigned int}' [-Werror=format=] Signed-off-by: Eric Blake <eblake(a)redhat.com> --- Pushing under the build-breaker rule daemon/admin.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/daemon/admin.c b/daemon/admin.c index 3de09ca..dbf49dd 100644 --- a/daemon/admin.c +++ b/daemon/admin.c @@ -262,8 +262,8 @@ adminDispatchClientGetInfo(virNetServerPtr server ATTRIBUTE_UNUSED, if (!(clnt = virNetServerGetClient(srv, args->clnt.id))) { virReportError(VIR_ERR_NO_CLIENT, - _("no client with matching id '%lu' found"), - args->clnt.id); + _("no client with matching id '%llu' found"), + (unsigned long long) args->clnt.id); goto cleanup; } -- 2.5.5

1 0

[libvirt] [PATCH] libvirt.spec.in: remove all changelog entries
by Daniel P. Berrange 04 May '16

04 May '16

The %changelog entries in the RPM are just a poor immitation of the release notes, which is not what %changelog section is for. It should be reflecting changes in the RPM packaging, not changes in the application releases. Further, this bogus list of changes has to be manually deleted every time we sync the RPM with Fedora. Remove them, since they serve no useful purpose. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- libvirt.spec.in | 804 -------------------------------------------------------- 1 file changed, 804 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 78eb8aa..2afe437 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1867,807 +1867,3 @@ exit 0 %changelog -* Sun May 1 2016 Daniel Veillard <veillard(a)redhat.com> - 1.3.4-1 -- Lot of work on documentation -- Add support for migration data compression -- many bug fixes and various improvements - -* Wed Apr 6 2016 Daniel Veillard <veillard(a)redhat.com> - 1.3.3-1 -- perf events -- post-copy migration support -- NSS module -- a lot of various improvements, and large number of bugs fixes - -* Tue Mar 1 2016 Daniel Veillard <veillard(a)redhat.com> - 1.3.2-1 -- Various improvements for the Xen libxl driver -- virt-admin improvement -- Various improvements for the RDB volumes -- many bug fixes and improvements - -* Sun Jan 17 2016 Daniel Veillard <veillard(a)redhat.com> - 1.3.1-1 -- Various improvements for the Xen libxl driver -- rbd: Add support for wiping and cloning images to storage driver -- PCI hostdev improvements and fixes -- many bug fixes and improvements - -* Wed Dec 9 2015 Daniel Veillard <veillard(a)redhat.com> - 1.3.0-1 -- virt-admin and administration API -- various improvements in virtio devices support -- log daemon, logging improvements and protocol -- many bug fixes and improvements - -* Wed Nov 4 2015 Daniel Veillard <veillard(a)redhat.com> - 1.2.21-1 -- a number of improvements and bug fixes - -* Fri Oct 2 2015 Daniel Veillard <veillard(a)redhat.com> - 1.2.20-1 -- security fixes for CVE-2015-5247 -- a number of improvements and bug fixes - -* Wed Sep 2 2015 Daniel Veillard <veillard(a)redhat.com> - 1.2.19-1 -- Big improvements on ppc64 support -- New virDomainRename API -- Support for QEMU new pci emulations -- a number of improvements and bug fixes - -* Mon Aug 3 2015 Daniel Veillard <veillard(a)redhat.com> - 1.2.18-1 -- libxl: support dom0 -- a number of improvements and bug fixes - -* Thu Jul 2 2015 Daniel Veillard <veillard(a)redhat.com> - 1.2.17-1 -- numerous improvements and refactoring of the parallels driver -- hardening of vcpu code -- hardening of migration code -- a lot of improvement and bug fixes - -* Mon Jun 1 2015 Daniel Veillard <veillard(a)redhat.com> - 1.2.16-1 -- Introduce pci-serial -- Introduce virDomainSetUserPassword API -- libvirt: Introduce protected key mgmt ops -- add domain vmport feature -- various bug fixes and improvements - -* Mon May 4 2015 Daniel Veillard <veillard(a)redhat.com> - 1.2.15-1 -- Implement virDomainAddIOThread and virDomainDelIOThread -- libxl: Introduce configuration file for libxl driver -- Add VIR_DOMAIN_EVENT_ID_DEVICE_ADDED event -- various improvements to parallels driver -- a lot of improvement and bug fixes - -* Thu Apr 2 2015 Daniel Veillard <veillard(a)redhat.com> - 1.2.14-1 -- qemu: Implement memory device hotplug -- Implement public API for virDomainPinIOThread -- Implement public API for virDomainGetIOThreadsInfo -- SRIOV NIC offload feature discovery -- a lot of improvement and bug fixes - -* Mon Mar 2 2015 Daniel Veillard <veillard(a)redhat.com> - 1.2.13-1 -- lot of improvements around NUMA code -- a lot of improvement and bug fixes - -* Tue Jan 27 2015 Daniel Veillard <veillard(a)redhat.com> - 1.2.12-1 -- CVE-2015-0236: qemu: Check ACLs when dumping security info from snapshots -- CVE-2015-0236: qemu: Check ACLs when dumping security info from save image -- a lot of improvement and bug fixes - -* Sat Dec 13 2014 Daniel Veillard <veillard(a)redhat.com> - 1.2.11-1 -- CVE-2014-8131: Fix possible deadlock and segfault in qemuConnectGetAllDomainStats() -- CVE-2014-7823: dumpxml: security hole with migratable flag -- Implement public API for virDomainGetFSInfo -- Add define support for the new throttle options -- a number of improvements and bug fixes - -* Mon Nov 3 2014 Daniel Veillard <veillard(a)redhat.com> - 1.2.10-1 -- vbox: various drivers improvements -- libxl: various drivers improvements -- Internal driver refactoring -- a number of improvements and bug fixes - -* Wed Oct 1 2014 Daniel Veillard <veillard(a)redhat.com> - 1.2.9-1 -- CVE-2014-3657: domain_conf: fix domain deadlock -- CVE-2014-3633: qemu: blkiotune: Use correct definition when looking up disk -- Introduce virNodeAllocPages -- event: introduce new event for tunable values -- add migration support for OpenVZ driver -- Add support for fetching statistics of completed jobs -- many improvements and bug fixes - -* Tue Sep 2 2014 Daniel Veillard <veillard(a)redhat.com> - 1.2.8-1 -- blockcopy: virDomainBlockCopy with XML destination, typed params -- Introduce API for retrieving bulk domain stats -- Introduce virDomainOpenGraphicsFD API -- storage: ZFS support -- many improvements and bug fixes - -* Sun Aug 3 2014 Daniel Veillard <veillard(a)redhat.com> - 1.2.7-1 -- Introduce virConnectGetDomainCapabilities -- many improvements and bug fixes - -* Wed Jul 2 2014 Daniel Veillard <veillard(a)redhat.com> - 1.2.6-1 -- libxl: add migration support and fixes -- various improvements and fixes for NUMA -- many improvements and bug fixes - -* Mon Jun 2 2014 Daniel Veillard <veillard(a)redhat.com> - 1.2.5-1 -- LSN-2014-0003: Don't expand entities when parsing XML (security) -- Introduce virDomain{Get,Set}Time APIs -- Introduce virDomainFSFreeze() and virDomainFSThaw() public API -- various improvements and bug fixes - -* Sun May 4 2014 Daniel Veillard <veillard(a)redhat.com> - 1.2.4-1 -- various improvements and bug fixes -- lot of internal code refactoring - -* Tue Apr 1 2014 Daniel Veillard <veillard(a)redhat.com> - 1.2.3-1 -- add new virDomainCoreDumpWithFormat API -- conf: Introduce virDomainDeviceGetInfo API -- more features and fixes on bhyve driver -- lot of cleanups and improvement on the Xen driver -- a lot of various improvements and bug fixes - -* Sun Mar 2 2014 Daniel Veillard <veillard(a)redhat.com> - 1.2.2-1 -- add LXC from native conversion tool -- vbox: add support for v4.2.20+ and v4.3.4+ -- Introduce Libvirt Wireshark dissector -- Fix CVE-2013-6456: Avoid unsafe use of /proc/$PID/root in LXC -- a lot of various improvements and bug fixes - -* Thu Jan 16 2014 Daniel Veillard <veillard(a)redhat.com> - 1.2.1-1 -- Fix s CVE-2014-0028 event: filter global events by domain:getattr ACL -- Fix CVE-2014-1447 Don't crash if a connection closes early -- Fix CVE-2013-6458-1 qemu: Do not access stale data in virDomainBlockStats -- Fix CVE-2013-6457 libxl: avoid crashing if calling `virsh numatune' on inactive domain -- Fix CVE-2013-6436: fix crash in lxcDomainGetMemoryParameters -- many doc and bug fixes and improvements - -* Mon Dec 2 2013 Daniel Veillard <veillard(a)redhat.com> - 1.2.0-1 -- Separation of python binding as libvirt-python srpm -- Add support for gluster pool -- vbox: add support for 4.3 APIs -- a number of doc, bug fixes and various improvements - -* Mon Nov 4 2013 Daniel Veillard <veillard(a)redhat.com> - 1.1.4-1 -- Add support for AArch64 architecture -- Various improvements on test code and test driver -- 4 security bug fixes -- a lot of bug fixes and various improvements - -* Tue Oct 1 2013 Daniel Veillard <veillard(a)redhat.com> - 1.1.3-1 -- VMware: Initial VMware Fusion support and various improvements -- libvirt: add new public API virConnectGetCPUModelNames -- various libxl driver improvements -- LXC many container driver improvement -- ARM cpu improvements -- 3 security bug fixes -- a lot of bug and leak fixes and various improvements - -* Mon Sep 2 2013 Daniel Veillard <veillard(a)redhat.com> - 1.1.2-1 -- various improvements to libxl driver -- systemd integration improvements -- Add flag to BaselineCPU API to return detailed CPU features -- Introduce a virt-login-shell binary -- conf: add startupPolicy attribute for harddisk -- various bug fixes and improvements including localizations - -* Tue Jul 30 2013 Daniel Veillard <veillard(a)redhat.com> - 1.1.1-1 -- Adding device removal or deletion events -- Introduce new domain create APIs to pass pre-opened FDs to LXC -- Add interface versions for Xen 4.3 -- Add new public API virDomainSetMemoryStatsPeriod -- Various LXC improvements -- various bug fixes and improvements including localizations - -* Mon Jul 1 2013 Daniel Veillard <veillard(a)redhat.com> - 1.1.0-1 -- CVE-2013-2218: Fix crash listing network interfaces with filters -- Fine grained ACL support for the API -- Extensible migration APIs -- various improvements in the Xen driver -- agent based vCPU hotplug support -- various bug fixes and improvements including localizations - -* Mon Jun 3 2013 Daniel Veillard <veillard(a)redhat.com> - 1.0.6-1 -- Move VirtualBox driver into libvirtd -- Support for static routes on a virtual bridge -- Various improvement for hostdev SCSI support -- Switch to VIR_STRDUP and VIR_STRNDUP -- Various cleanups and improvement in Xen and LXC drivers -- various bug fixes and improvements including localizations - -* Thu May 2 2013 Daniel Veillard <veillard(a)redhat.com> - 1.0.5-1 -- add support for NVRAM device -- Add XML config for resource partitions -- Add support for TPM -- NPIV storage migration support -- various bug fixes and improvements including localizations - -* Mon Apr 1 2013 Daniel Veillard <veillard(a)redhat.com> - 1.0.4-1 -- qemu: support passthrough for iscsi disks -- various S390 improvements -- various LXC bugs fixes and improvements -- Add API for thread cancellation -- various bug fixes and improvements - -* Tue Mar 5 2013 Daniel Veillard <veillard(a)redhat.com> - 1.0.3-1 -- Introduce virDomainMigrate*CompressionCache APIs -- Introduce virDomainGetJobStats API -- Add basic support for VDI images -- Introduce API virNodeDeviceLookupSCSIHostByWWN -- Various locking improvements -- a lot of bug fixes and overall improvements - -* Wed Jan 30 2013 Daniel Veillard <veillard(a)redhat.com> - 1.0.2-1 -- LXC improvements -- S390 architecture improvement -- Power architecture improvement -- large Coverity report cleanups and associated bug fixes -- virTypedParams* APIs to helps with those data structures -- a lot of bug fixes and overall improvements - -* Fri Nov 2 2012 Daniel Veillard <veillard(a)redhat.com> - 1.0.0-1 -- virNodeGetCPUMap: Define public API -- Add systemd journal support -- Add a qemu capabilities cache manager -- USB migration support -- various improvement and fixes when using QMP QEmu interface -- Support for Xen 4.2 -- Lot of localization enhancements -- a lot of bug fixes, improvements and portability work - -* Mon Sep 24 2012 Daniel Veillard <veillard(a)redhat.com> - 0.10.2-1 -- network: define new API virNetworkUpdate -- add support for QEmu sandbox support -- blockjob: add virDomainBlockCommit -- New APIs to get/set Node memory parameters -- new API virConnectListAllSecrets -- new API virConnectListAllNWFilters -- new API virConnectListAllNodeDevices -- parallels: add support of containers to the driver -- new API virConnectListAllInterfaces -- new API virConnectListAllNetworks -- new API virStoragePoolListAllVolumes -- Add PMSUSPENDED life cycle event -- new API virStorageListAllStoragePools -- Add per-guest S3/S4 state configuration -- qemu: Support for Block Device IO Limits -- a lot of bug fixes, improvements and portability work - -* Fri Aug 31 2012 Daniel Veillard <veillard(a)redhat.com> - 0.10.1-1 -- bugfixes and a brown paper bag - -* Wed Aug 29 2012 Daniel Veillard <veillard(a)redhat.com> - 0.10.0-1 -- agent: add qemuAgentArbitraryCommand() for general qemu agent command -- Introduce virDomainPinEmulator and virDomainGetEmulatorPinInfo functions -- network: use firewalld instead of iptables, when available -- network: make network driver vlan-aware -- esx: Implement network driver -- driver for parallels hypervisor -- Various LXC improvements -- Add virDomainGetHostname -- a lot of bug fixes, improvements and portability work - -* Mon Jul 2 2012 Daniel Veillard <veillard(a)redhat.com> - 0.9.13-1 -- S390: support for s390(x) -- snapshot: implement new APIs for esx and vbox -- snapshot: new query APIs and many improvements -- virsh: Allow users to reedit rejected XML -- nwfilter: add DHCP snooping -- Enable driver modules in libvirt RPM -- Default to enable driver modules for libvirtd -- storage backend: Add RBD (RADOS Block Device) support -- sVirt support for LXC domains inprovement -- a lot of bug fixes, improvements and portability work - -* Mon May 14 2012 Daniel Veillard <veillard(a)redhat.com> - 0.9.12-1 -- qemu: allow snapshotting of sheepdog and rbd disks -- blockjob: add new APIs -- a lot of bug fixes, improvements and portability work - -* Tue Apr 3 2012 Daniel Veillard <veillard(a)redhat.com> - 0.9.11-1 -- Add support for the suspend event -- Add support for event tray moved of removable disks -- qemu: Support numad -- cpustats: API, improvements and qemu support -- qemu: support type='hostdev' network devices at domain start -- Introduce virDomainPMWakeup API -- network: support Open vSwitch -- a number of snapshot improvements -- many improvements and bug fixes - -* Mon Feb 13 2012 Daniel Veillard <veillard(a)redhat.com> - 0.9.10-1 -- Add support for sVirt in the LXC driver -- block rebase: add new API virDomainBlockRebase -- API: Add api to set and get domain metadata -- virDomainGetDiskErrors public API -- conf: add rawio attribute to disk element of domain XML -- Add new public API virDomainGetCPUStats() -- Introduce virDomainPMSuspendForDuration API -- resize: add virStorageVolResize() API -- Add a virt-host-validate command to sanity check HV config -- Add new virDomainShutdownFlags API -- QEMU guest agent support -- many improvements and bug fixes - -* Sat Jan 7 2012 Daniel Veillard <veillard(a)redhat.com> - 0.9.9-1 -- Add API virDomain{S,G}etInterfaceParameters -- Add API virDomain{G, S}etNumaParameters -- Add support for ppc64 qemu -- Support Xen domctl v8 -- many improvements and bug fixes - -* Thu Dec 8 2011 Daniel Veillard <veillard(a)redhat.com> - 0.9.8-1 -- Add support for QEMU 1.0 -- Add preliminary PPC cpu driver -- Add new API virDomain{Set, Get}BlockIoTune -- block_resize: Define the new API -- Add a public API to invoke suspend/resume on the host -- various improvements for LXC containers -- Define keepalive protocol and add virConnectIsAlive API -- Add support for STP and VLAN filtering -- many improvements and bug fixes - -* Tue Nov 8 2011 Daniel Veillard <veillard(a)redhat.com> - 0.9.7-1 -- esx: support vSphere 5.x -- vbox: support for VirtualBox 4.1 -- Introduce the virDomainOpenGraphics API -- Add AHCI support to qemu driver -- snapshot: many improvements and 2 new APIs -- api: Add public api for 'reset' -- many improvements and bug fixes - -* Thu Sep 22 2011 Daniel Veillard <veillard(a)redhat.com> - 0.9.6-1 -- Fix the qemu reboot bug and a few others bug fixes - -* Tue Sep 20 2011 Daniel Veillard <veillard(a)redhat.com> - 0.9.5-1 -- many snapshot improvements (Eric Blake) -- latency: Define new public API and structure (Osier Yang) -- USB2 and various USB improvements (Marc-André Lureau) -- storage: Add fs pool formatting (Osier Yang) -- Add public API for getting migration speed (Jim Fehlig) -- Add basic driver for Microsoft Hyper-V (Matthias Bolte) -- many improvements and bug fixes - -* Wed Aug 3 2011 Daniel Veillard <veillard(a)redhat.com> - 0.9.4-1 -- network bandwidth QoS control -- Add new API virDomainBlockPull* -- save: new API to manipulate save file images -- CPU bandwidth limits support -- allow to send NMI and key event to guests -- new API virDomainUndefineFlags -- Implement code to attach to external QEMU instances -- bios: Add support for SGA -- various missing python binding -- many improvements and bug fixes - -* Mon Jul 4 2011 Daniel Veillard <veillard(a)redhat.com> - 0.9.3-1 -- new API virDomainGetVcpupinInfo -- Add TXT record support for virtual DNS service -- Support reboots with the QEMU driver -- New API virDomainGetControlInfo API -- New API virNodeGetMemoryStats -- New API virNodeGetCPUTime -- New API for send-key -- New API virDomainPinVcpuFlags -- support multifunction PCI device -- lxc: various improvements -- many improvements and bug fixes - -* Mon Jun 6 2011 Daniel Veillard <veillard(a)redhat.com> - 0.9.2-1 -- Framework for lock manager plugins -- API for network config change transactions -- flags for setting memory parameters -- virDomainGetState public API -- qemu: allow blkstat/blkinfo calls during migration -- Introduce migration v3 API -- Defining the Screenshot public API -- public API for NMI injection -- Various improvements and bug fixes - -* Thu May 5 2011 Daniel Veillard <veillard(a)redhat.com> - 0.9.1-1 -- support various persistent domain updates -- improvements on memory APIs -- Add virDomainEventRebootNew -- various improvements to libxl driver -- Spice: support audio, images and stream compression -- Various improvements and bug fixes - -* Mon Apr 4 2011 Daniel Veillard <veillard(a)redhat.com> - 0.9.0-1 -- Support cputune cpu usage tuning -- Add public APIs for storage volume upload/download -- Add public API for setting migration speed on the fly -- Add libxenlight driver -- qemu: support migration to fd -- libvirt: add virDomain{Get,Set}BlkioParameters -- setmem: introduce a new libvirt API (virDomainSetMemoryFlags) -- Expose event loop implementation as a public API -- Dump the debug buffer to libvirtd.log on fatal signal -- Audit support -- Various improvements and bug fixes - -* Thu Feb 17 2011 Daniel Veillard <veillard(a)redhat.com> - 0.8.8-1 -- expose new API for sysinfo extraction -- cgroup blkio weight support -- smartcard device support -- qemu: Support per-device boot ordering -- Various improvements and bug fixes - -* Tue Jan 4 2011 Daniel Veillard <veillard(a)redhat.com> - 0.8.7-1 -- Preliminary support for VirtualBox 4.0 -- IPv6 support -- Add VMware Workstation and Player driver driver -- Add network disk support -- Various improvements and bug fixes - -* Tue Nov 30 2010 Daniel Veillard <veillard(a)redhat.com> - 0.8.6-1 -- Add support for iSCSI target auto-discovery -- QED: Basic support for QED images -- remote console support -- support for SPICE graphics -- sysinfo and VMBIOS support -- virsh qemu-monitor-command -- various improvements and bug fixes - -* Fri Oct 29 2010 Daniel Veillard <veillard(a)redhat.com> - 0.8.5-1 -- Enable JSON and netdev features in QEMU >= 0.13 -- framework for auditing integration -- framework DTrace/SystemTap integration -- Setting the number of vcpu at boot -- Enable support for nested SVM -- Virtio plan9fs filesystem QEMU -- Memory parameter controls -- various improvements and bug fixes - -* Fri Sep 10 2010 Daniel Veillard <veillard(a)redhat.com> - 0.8.4-1 -- big improvements to UML driver -- various improvements and bug fixes - -* Wed Aug 4 2010 Daniel Veillard <veillard(a)redhat.com> - 0.8.3-1 -- esx: Support vSphere 4.1 -- Qemu arbitrary monitor commands -- Qemu Monitor API entry point -- various improvements and bug fixes - -* Mon Jul 5 2010 Daniel Veillard <veillard(a)redhat.com> - 0.8.2-1 -- phyp: adding support for IVM -- libvirt: introduce domainCreateWithFlags API -- add 802.1Qbh and 802.1Qbg switches handling -- Support for VirtualBox version 3.2 -- Init script for handling guests on shutdown/boot -- qemu: live migration with non-shared storage for kvm - -* Fri Apr 30 2010 Daniel Veillard <veillard(a)redhat.com> - 0.8.1-1 -- Starts dnsmasq from libvirtd with --dhcp-hostsfile -- Add virDomainGetBlockInfo API to query disk sizing -- a lot of bug fixes and cleanups - -* Mon Apr 12 2010 Daniel Veillard <veillard(a)redhat.com> - 0.8.0-1 -- Snapshotting support (QEmu/VBox/ESX) -- Network filtering API -- XenAPI driver -- new APIs for domain events -- Libvirt managed save API -- timer subselection for domain clock -- synchronous hooks -- API to update guest CPU to host CPU -- virDomainUpdateDeviceFlags new API -- migrate max downtime API -- volume wiping API -- and many bug fixes - -* Fri Mar 5 2010 Daniel Veillard <veillard(a)redhat.com> - 0.7.7-1 -- macvtap support -- async job handling -- virtio channel -- computing baseline CPU -- virDomain{Attach,Detach}DeviceFlags -- assorted bug fixes and lots of cleanups - -* Wed Feb 3 2010 Daniel Veillard <veillard(a)redhat.com> - 0.7.6-1 - -* Wed Dec 23 2009 Daniel Veillard <veillard(a)redhat.com> - 0.7.5-1 -- Add new API virDomainMemoryStats -- Public API and domain extension for CPU flags -- vbox: Add support for version 3.1 -- Support QEMU's virtual FAT block device driver -- a lot of fixes - -* Fri Nov 20 2009 Daniel Veillard <veillard(a)redhat.com> - 0.7.3-1 -- udev node device backend -- API to check object properties -- better QEmu monitor processing -- MAC address based port filtering for qemu -- support IPv6 and multiple addresses per interfaces -- a lot of fixes - -* Tue Sep 15 2009 Daniel Veillard <veillard(a)redhat.com> - 0.7.1-1 -- ESX, VBox driver updates -- mutipath support -- support for encrypted (qcow) volume -- compressed save image format for Qemu/KVM -- QEmu host PCI device hotplug support -- configuration of huge pages in guests -- a lot of fixes - -* Wed Aug 5 2009 Daniel Veillard <veillard(a)redhat.com> - 0.7.0-1 -- ESX, VBox3, Power Hypervisor drivers -- new net filesystem glusterfs -- Storage cloning for LVM and Disk backends -- interface implementation based on netcf -- Support cgroups in QEMU driver -- QEmu hotplug NIC support -- a lot of fixes - -* Fri Jul 3 2009 Daniel Veillard <veillard(a)redhat.com> - 0.6.5-1 -- release of 0.6.5 - -* Fri May 29 2009 Daniel Veillard <veillard(a)redhat.com> - 0.6.4-1 -- release of 0.6.4 -- various new APIs - -* Fri Apr 24 2009 Daniel Veillard <veillard(a)redhat.com> - 0.6.3-1 -- release of 0.6.3 -- VirtualBox driver - -* Fri Apr 3 2009 Daniel Veillard <veillard(a)redhat.com> - 0.6.2-1 -- release of 0.6.2 - -* Wed Mar 4 2009 Daniel Veillard <veillard(a)redhat.com> - 0.6.1-1 -- release of 0.6.1 - -* Sat Jan 31 2009 Daniel Veillard <veillard(a)redhat.com> - 0.6.0-1 -- release of 0.6.0 - -* Tue Nov 25 2008 Daniel Veillard <veillard(a)redhat.com> - 0.5.0-1 -- release of 0.5.0 - -* Tue Sep 23 2008 Daniel Veillard <veillard(a)redhat.com> - 0.4.6-1 -- release of 0.4.6 - -* Mon Sep 8 2008 Daniel Veillard <veillard(a)redhat.com> - 0.4.5-1 -- release of 0.4.5 - -* Wed Jun 25 2008 Daniel Veillard <veillard(a)redhat.com> - 0.4.4-1 -- release of 0.4.4 -- mostly a few bug fixes from 0.4.3 - -* Thu Jun 12 2008 Daniel Veillard <veillard(a)redhat.com> - 0.4.3-1 -- release of 0.4.3 -- lots of bug fixes and small improvements - -* Tue Apr 8 2008 Daniel Veillard <veillard(a)redhat.com> - 0.4.2-1 -- release of 0.4.2 -- lots of bug fixes and small improvements - -* Mon Mar 3 2008 Daniel Veillard <veillard(a)redhat.com> - 0.4.1-1 -- Release of 0.4.1 -- Storage APIs -- xenner support -- lots of assorted improvements, bugfixes and cleanups -- documentation and localization improvements - -* Tue Dec 18 2007 Daniel Veillard <veillard(a)redhat.com> - 0.4.0-1 -- Release of 0.4.0 -- SASL based authentication -- PolicyKit authentication -- improved NUMA and statistics support -- lots of assorted improvements, bugfixes and cleanups -- documentation and localization improvements - -* Sun Sep 30 2007 Daniel Veillard <veillard(a)redhat.com> - 0.3.3-1 -- Release of 0.3.3 -- Avahi support -- NUMA support -- lots of assorted improvements, bugfixes and cleanups -- documentation and localization improvements - -* Tue Aug 21 2007 Daniel Veillard <veillard(a)redhat.com> - 0.3.2-1 -- Release of 0.3.2 -- API for domains migration -- APIs for collecting statistics on disks and interfaces -- lots of assorted bugfixes and cleanups -- documentation and localization improvements - -* Tue Jul 24 2007 Daniel Veillard <veillard(a)redhat.com> - 0.3.1-1 -- Release of 0.3.1 -- localtime clock support -- PS/2 and USB input devices -- lots of assorted bugfixes and cleanups -- documentation and localization improvements - -* Mon Jul 9 2007 Daniel Veillard <veillard(a)redhat.com> - 0.3.0-1 -- Release of 0.3.0 -- Secure remote access support -- unification of daemons -- lots of assorted bugfixes and cleanups -- documentation and localization improvements - -* Fri Jun 8 2007 Daniel Veillard <veillard(a)redhat.com> - 0.2.3-1 -- Release of 0.2.3 -- lot of assorted bugfixes and cleanups -- support for Xen-3.1 -- new scheduler API - -* Tue Apr 17 2007 Daniel Veillard <veillard(a)redhat.com> - 0.2.2-1 -- Release of 0.2.2 -- lot of assorted bugfixes and cleanups -- preparing for Xen-3.0.5 - -* Thu Mar 22 2007 Jeremy Katz <katzj(a)redhat.com> - 0.2.1-2.fc7 -- don't require xen; we don't need the daemon and can control non-xen now -- fix scriptlet error (need to own more directories) -- update description text - -* Fri Mar 16 2007 Daniel Veillard <veillard(a)redhat.com> - 0.2.1-1 -- Release of 0.2.1 -- lot of bug and portability fixes -- Add support for network autostart and init scripts -- New API to detect the virtualization capabilities of a host -- Documentation updates - -* Fri Feb 23 2007 Daniel P. Berrange <berrange(a)redhat.com> - 0.2.0-4.fc7 -- Fix loading of guest & network configs - -* Fri Feb 16 2007 Daniel P. Berrange <berrange(a)redhat.com> - 0.2.0-3.fc7 -- Disable kqemu support since its not in Fedora qemu binary -- Fix for -vnc arg syntax change in 0.9.0 QEMU - -* Thu Feb 15 2007 Daniel P. Berrange <berrange(a)redhat.com> - 0.2.0-2.fc7 -- Fixed path to qemu daemon for autostart -- Fixed generation of <features> block in XML -- Pre-create config directory at startup - -* Wed Feb 14 2007 Daniel Veillard <veillard(a)redhat.com> 0.2.0-1.fc7 -- support for KVM and QEmu -- support for network configuration -- assorted fixes - -* Mon Jan 22 2007 Daniel Veillard <veillard(a)redhat.com> 0.1.11-1.fc7 -- finish inactive Xen domains support -- memory leak fix -- RelaxNG schemas for XML configs - -* Wed Dec 20 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.10-1.fc7 -- support for inactive Xen domains -- improved support for Xen display and vnc -- a few bug fixes -- localization updates - -* Thu Dec 7 2006 Jeremy Katz <katzj(a)redhat.com> - 0.1.9-2 -- rebuild against python 2.5 - -* Wed Nov 29 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.9-1 -- better error reporting -- python bindings fixes and extensions -- add support for shareable drives -- add support for non-bridge style networking -- hot plug device support -- added support for inactive domains -- API to dump core of domains -- various bug fixes, cleanups and improvements -- updated the localization - -* Tue Nov 7 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.8-3 -- it's pkgconfig not pgkconfig ! - -* Mon Nov 6 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.8-2 -- fixing spec file, added %%dist, -devel requires pkgconfig and xen-devel -- Resolves: rhbz#202320 - -* Mon Oct 16 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.8-1 -- fix missing page size detection code for ia64 -- fix mlock size when getting domain info list from hypervisor -- vcpu number initialization -- don't label crashed domains as shut off -- fix virsh man page -- blktapdd support for alternate drivers like blktap -- memory leak fixes (xend interface and XML parsing) -- compile fix -- mlock/munlock size fixes - -* Fri Sep 22 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.7-1 -- Fix bug when running against xen-3.0.3 hypercalls -- Fix memory bug when getting vcpus info from xend - -* Fri Sep 22 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.6-1 -- Support for localization -- Support for new Xen-3.0.3 cdrom and disk configuration -- Support for setting VNC port -- Fix bug when running against xen-3.0.2 hypercalls -- Fix reconnection problem when talking directly to http xend - -* Tue Sep 5 2006 Jeremy Katz <katzj(a)redhat.com> - 0.1.5-3 -- patch from danpb to support new-format cd devices for HVM guests - -* Tue Sep 5 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.5-2 -- reactivating ia64 support - -* Tue Sep 5 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.5-1 -- new release -- bug fixes -- support for new hypervisor calls -- early code for config files and defined domains - -* Mon Sep 4 2006 Daniel Berrange <berrange(a)redhat.com> - 0.1.4-5 -- add patch to address dom0_ops API breakage in Xen 3.0.3 tree - -* Mon Aug 28 2006 Jeremy Katz <katzj(a)redhat.com> - 0.1.4-4 -- add patch to support paravirt framebuffer in Xen - -* Mon Aug 21 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.4-3 -- another patch to fix network handling in non-HVM guests - -* Thu Aug 17 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.4-2 -- patch to fix virParseUUID() - -* Wed Aug 16 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.4-1 -- vCPUs and affinity support -- more complete XML, console and boot options -- specific features support -- enforced read-only connections -- various improvements, bug fixes - -* Wed Aug 2 2006 Jeremy Katz <katzj(a)redhat.com> - 0.1.3-6 -- add patch from pvetere to allow getting uuid from libvirt - -* Wed Aug 2 2006 Jeremy Katz <katzj(a)redhat.com> - 0.1.3-5 -- build on ia64 now - -* Thu Jul 27 2006 Jeremy Katz <katzj(a)redhat.com> - 0.1.3-4 -- don't BR xen, we just need xen-devel - -* Thu Jul 27 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.3-3 -- need rebuild since libxenstore is now versionned - -* Mon Jul 24 2006 Mark McLoughlin <markmc(a)redhat.com> - 0.1.3-2 -- Add BuildRequires: xen-devel - -* Wed Jul 12 2006 Jesse Keating <jkeating(a)redhat.com> - 0.1.3-1.1 -- rebuild - -* Tue Jul 11 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.3-1 -- support for HVM Xen guests -- various bugfixes - -* Mon Jul 3 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.2-1 -- added a proxy mechanism for read only access using httpu -- fixed header includes paths - -* Wed Jun 21 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.1-1 -- extend and cleanup the driver infrastructure and code -- python examples -- extend uuid support -- bug fixes, buffer handling cleanups -- support for new Xen hypervisor API -- test driver for unit testing -- virsh --conect argument - -* Mon Apr 10 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.0-1 -- various fixes -- new APIs: for Node information and Reboot -- virsh improvements and extensions -- documentation updates and man page -- enhancement and fixes of the XML description format - -* Tue Feb 28 2006 Daniel Veillard <veillard(a)redhat.com> 0.0.6-1 -- added error handling APIs -- small bug fixes -- improve python bindings -- augment documentation and regression tests - -* Thu Feb 23 2006 Daniel Veillard <veillard(a)redhat.com> 0.0.5-1 -- new domain creation API -- new UUID based APIs -- more tests, documentation, devhelp -- bug fixes - -* Fri Feb 10 2006 Daniel Veillard <veillard(a)redhat.com> 0.0.4-1 -- fixes some problems in 0.0.3 due to the change of names - -* Wed Feb 8 2006 Daniel Veillard <veillard(a)redhat.com> 0.0.3-1 -- changed library name to libvirt from libvir, complete and test the python - bindings - -* Sun Jan 29 2006 Daniel Veillard <veillard(a)redhat.com> 0.0.2-1 -- upstream release of 0.0.2, use xend, save and restore added, python bindings - fixed - -* Wed Nov 2 2005 Daniel Veillard <veillard(a)redhat.com> 0.0.1-1 -- created -- 2.5.5

2 1

[libvirt] [PATCH 0/2] virsh: Properly handle detach-interface --live --config.
by Nitesh Konkar 04 May '16

04 May '16

The virsh attach virsh detach interface command fails when both live and config are set and when the interface gets attached to different pci slots on live and config xml respectively. When we attach an interface with both --live and --config, the first time they get the same PCI slots, but the second time onwards it differs and hence the virsh detach-interface --live --config command fails. This patch makes sure that when both --live --config are set , qemuDomainDetachDeviceFlags is called twice, once with config xml and once with live xml. Steps to see the issue: virsh attach-interface --domain DomainName --type network --source default --mac 52:54:00:4b:76:5f --live --config virsh detach-interface --domain DomainName --type network --mac 52:54:00:4b:76:5f --live --config virsh attach-interface --domain DomainName --type network --source default --mac 52:54:00:4b:76:5f --live --config virsh detach-interface --domain DomainName --type network --mac 52:54:00:4b:76:5f --live --config Nitesh Konkar (2): virsh: Introduce virshDomainDetachInterface function virsh: Pass the correct live/config xml to virshDomainDetachInterface tools/virsh-domain.c | 128 +++++++++++++++++++++++++++++---------------------- 1 file changed, 73 insertions(+), 55 deletions(-) -- 1.8.3.1

2 5

[libvirt] [PATCH v2] bhyve: implement domainShutdown
by Roman Bogorodskiy 04 May '16

04 May '16

Bhyve supports ACPI shutdown by issuing SIGTERM signal to the bhyve process. Add the bhyveDomainShutdown() function and virBhyveProcessShutdown() helper function that just sends SIGTERM to VM's bhyve process. If a guest supports ACPI shutdown then process will be terminated and this event will be noticed by the bhyve monitor code that will handle setting proper status and clean up VM's resources. Also, remove usage of virProcessKillPainfully() from domainDestroy. First, it sends SIGTERM to the process that actually triggers ACPI reset and that's not we want to do. Second, we're doing bhyvectl --destroy later and it kills bhyve process, so there's no need to manually kill it. --- Changes from v1: - Sending SIGKILL dropped completely for destroy due to reasons described in the commit message. This is mainly based on the results of this (ongoing) discussion: https://lists.freebsd.org/pipermail/freebsd-virtualization/2016-April/00434… src/bhyve/bhyve_driver.c | 27 +++++++++++++++++++++++++++ src/bhyve/bhyve_process.c | 39 +++++++++++++++++++++++++++------------ src/bhyve/bhyve_process.h | 2 ++ 3 files changed, 56 insertions(+), 12 deletions(-) diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index 5526bb0..4fc504e 100644 --- a/src/bhyve/bhyve_driver.c +++ b/src/bhyve/bhyve_driver.c @@ -1018,6 +1018,32 @@ bhyveDomainDestroy(virDomainPtr dom) } static int +bhyveDomainShutdown(virDomainPtr dom) +{ + virDomainObjPtr vm; + int ret = -1; + + if (!(vm = bhyveDomObjFromDomain(dom))) + goto cleanup; + + if (virDomainShutdownEnsureACL(dom->conn, vm->def) < 0) + goto cleanup; + + if (!virDomainObjIsActive(vm)) { + virReportError(VIR_ERR_OPERATION_INVALID, + "%s", _("Domain is not running")); + goto cleanup; + } + + ret = virBhyveProcessShutdown(vm); + + cleanup: + if (vm) + virObjectUnlock(vm); + return ret; +} + +static int bhyveDomainOpenConsole(virDomainPtr dom, const char *dev_name ATTRIBUTE_UNUSED, virStreamPtr st, @@ -1502,6 +1528,7 @@ static virHypervisorDriver bhyveHypervisorDriver = { .domainCreateWithFlags = bhyveDomainCreateWithFlags, /* 1.2.3 */ .domainCreateXML = bhyveDomainCreateXML, /* 1.2.4 */ .domainDestroy = bhyveDomainDestroy, /* 1.2.2 */ + .domainShutdown = bhyveDomainShutdown, /* 1.3.3 */ .domainLookupByUUID = bhyveDomainLookupByUUID, /* 1.2.2 */ .domainLookupByName = bhyveDomainLookupByName, /* 1.2.2 */ .domainLookupByID = bhyveDomainLookupByID, /* 1.2.3 */ diff --git a/src/bhyve/bhyve_process.c b/src/bhyve/bhyve_process.c index 14588a9..e42ed74 100644 --- a/src/bhyve/bhyve_process.c +++ b/src/bhyve/bhyve_process.c @@ -281,23 +281,15 @@ virBhyveProcessStop(bhyveConnPtr driver, if ((priv != NULL) && (priv->mon != NULL)) bhyveMonitorClose(priv->mon); - /* First, try to kill 'bhyve' process */ - if (virProcessKillPainfully(vm->pid, true) != 0) - VIR_WARN("Failed to gracefully stop bhyve VM '%s' (pid: %d)", - vm->def->name, - (int)vm->pid); - - /* Cleanup network interfaces */ - bhyveNetCleanup(vm); - - /* No matter if shutdown was successful or not, we - * need to unload the VM */ if (!(cmd = virBhyveProcessBuildDestroyCmd(driver, vm->def))) - goto cleanup; + return -1; if (virCommandRun(cmd, NULL) < 0) goto cleanup; + /* Cleanup network interfaces */ + bhyveNetCleanup(vm); + ret = 0; virCloseCallbacksUnset(driver->closeCallbacks, vm, @@ -317,6 +309,29 @@ virBhyveProcessStop(bhyveConnPtr driver, } int +virBhyveProcessShutdown(virDomainObjPtr vm) +{ + if (vm->pid <= 0) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Invalid PID %d for VM"), + (int)vm->pid); + return -1; + } + + /* Bhyve tries to perform ACPI shutdown when it receives + * SIGTERM signal. So we just issue SIGTERM here and rely + * on the bhyve monitor to clean things up if process disappears. + */ + if (virProcessKill(vm->pid, SIGTERM) != 0) { + VIR_WARN("Failed to terminate bhyve process for VM '%s': %s", + vm->def->name, virGetLastErrorMessage()); + return -1; + } + + return 0; +} + +int virBhyveGetDomainTotalCpuStats(virDomainObjPtr vm, unsigned long long *cpustats) { diff --git a/src/bhyve/bhyve_process.h b/src/bhyve/bhyve_process.h index cfa80af..ebabe17 100644 --- a/src/bhyve/bhyve_process.h +++ b/src/bhyve/bhyve_process.h @@ -34,6 +34,8 @@ int virBhyveProcessStop(bhyveConnPtr driver, virDomainObjPtr vm, virDomainShutoffReason reason); +int virBhyveProcessShutdown(virDomainObjPtr vm); + int virBhyveGetDomainTotalCpuStats(virDomainObjPtr vm, unsigned long long *cpustats); -- 2.7.4

2 3

Re: [libvirt] [PATCHv2] virsh: blkdeviotune: accept human readable values for bytes
by Nitesh Konkar 04 May '16

04 May '16

Hello Nishith, Just a small suggestion on the indentation part of the patch. I think your indentation is off by 1 space. Thanks, Nitesh Konkar. On Wed, May 4, 2016 at 8:22 PM, Nitesh Konkar < niteshkonkar.libvirt(a)gmail.com> wrote: > Hello Nishith, > > Just a small suggestion on the indentation part of the patch. I think your > indentation is off by 1 space. > > Thanks, > Nitesh Konkar. > > > On Wed, May 4, 2016 at 7:55 PM, Nishith Shah <nishithshah.2211(a)gmail.com> > wrote: > >> Use vshCommandOptScaledInt instead of vshCommandOptULongLong so that >> values with suffixes can be passed when bytes are being passed along. >> Values for the iops parameters still need to be given in the absolute >> form as they are not bytes but numbers. Please refer to the bug link >> https://bugzilla.redhat.com/show_bug.cgi?id=885380 which can be closed. >> >> Signed-off-by: Nishith Shah <nishithshah.2211(a)gmail.com> >> --- >> tools/virsh-domain.c | 24 ++++++++++++------------ >> tools/virsh.pod | 18 ++++++++++++------ >> 2 files changed, 24 insertions(+), 18 deletions(-) >> >> diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c >> index 0a6caae..336a65f 100644 >> --- a/tools/virsh-domain.c >> +++ b/tools/virsh-domain.c >> @@ -1164,7 +1164,7 @@ static const vshCmdOptDef opts_blkdeviotune[] = { >> }, >> {.name = "total-bytes-sec", >> .type = VSH_OT_INT, >> - .help = N_("total throughput limit in bytes per second") >> + .help = N_("total throughput limit, as scaled integer (default >> bytes)") >> }, >> {.name = "read_bytes_sec", >> .type = VSH_OT_ALIAS, >> @@ -1172,7 +1172,7 @@ static const vshCmdOptDef opts_blkdeviotune[] = { >> }, >> {.name = "read-bytes-sec", >> .type = VSH_OT_INT, >> - .help = N_("read throughput limit in bytes per second") >> + .help = N_("read throughput limit, as scaled integer (default >> bytes)") >> }, >> {.name = "write_bytes_sec", >> .type = VSH_OT_ALIAS, >> @@ -1180,7 +1180,7 @@ static const vshCmdOptDef opts_blkdeviotune[] = { >> }, >> {.name = "write-bytes-sec", >> .type = VSH_OT_INT, >> - .help = N_("write throughput limit in bytes per second") >> + .help = N_("write throughput limit, as scaled integer (default >> bytes)") >> }, >> {.name = "total_iops_sec", >> .type = VSH_OT_ALIAS, >> @@ -1212,7 +1212,7 @@ static const vshCmdOptDef opts_blkdeviotune[] = { >> }, >> {.name = "total-bytes-sec-max", >> .type = VSH_OT_INT, >> - .help = N_("total max in bytes") >> + .help = N_("total max, as scaled integer (default bytes)") >> }, >> {.name = "read_bytes_sec_max", >> .type = VSH_OT_ALIAS, >> @@ -1220,7 +1220,7 @@ static const vshCmdOptDef opts_blkdeviotune[] = { >> }, >> {.name = "read-bytes-sec-max", >> .type = VSH_OT_INT, >> - .help = N_("read max in bytes") >> + .help = N_("read max, as scaled integer (default bytes)") >> }, >> {.name = "write_bytes_sec_max", >> .type = VSH_OT_ALIAS, >> @@ -1228,7 +1228,7 @@ static const vshCmdOptDef opts_blkdeviotune[] = { >> }, >> {.name = "write-bytes-sec-max", >> .type = VSH_OT_INT, >> - .help = N_("write max in bytes") >> + .help = N_("write max, as scaled integer (default bytes)") >> }, >> {.name = "total_iops_sec_max", >> .type = VSH_OT_ALIAS, >> @@ -1299,7 +1299,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) >> if (vshCommandOptStringReq(ctl, cmd, "device", &disk) < 0) >> goto cleanup; >> >> - if ((rv = vshCommandOptULongLong(ctl, cmd, "total-bytes-sec", >> &value)) < 0) { >> + if ((rv = vshCommandOptScaledInt(ctl, cmd, "total-bytes-sec", >> &value, 1, ULLONG_MAX)) < 0) { >> goto interror; >> } else if (rv > 0) { >> if (virTypedParamsAddULLong(&params, &nparams, &maxparams, >> @@ -1308,7 +1308,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) >> goto save_error; >> } >> >> - if ((rv = vshCommandOptULongLong(ctl, cmd, "read-bytes-sec", >> &value)) < 0) { >> + if ((rv = vshCommandOptScaledInt(ctl, cmd, "read-bytes-sec", &value, >> 1, ULLONG_MAX)) < 0) { >> goto interror; >> } else if (rv > 0) { >> if (virTypedParamsAddULLong(&params, &nparams, &maxparams, >> @@ -1317,7 +1317,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) >> goto save_error; >> } >> >> - if ((rv = vshCommandOptULongLong(ctl, cmd, "write-bytes-sec", >> &value)) < 0) { >> + if ((rv = vshCommandOptScaledInt(ctl, cmd, "write-bytes-sec", >> &value, 1, ULLONG_MAX)) < 0) { >> goto interror; >> } else if (rv > 0) { >> if (virTypedParamsAddULLong(&params, &nparams, &maxparams, >> @@ -1326,7 +1326,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) >> goto save_error; >> } >> >> - if ((rv = vshCommandOptULongLong(ctl, cmd, "total-bytes-sec-max", >> &value)) < 0) { >> + if ((rv = vshCommandOptScaledInt(ctl, cmd, "total-bytes-sec-max", >> &value, 1, ULLONG_MAX)) < 0) { >> goto interror; >> } else if (rv > 0) { >> if (virTypedParamsAddULLong(&params, &nparams, &maxparams, >> @@ -1335,7 +1335,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) >> goto save_error; >> } >> >> - if ((rv = vshCommandOptULongLong(ctl, cmd, "read-bytes-sec-max", >> &value)) < 0) { >> + if ((rv = vshCommandOptScaledInt(ctl, cmd, "read-bytes-sec-max", >> &value, 1, ULLONG_MAX)) < 0) { >> goto interror; >> } else if (rv > 0) { >> if (virTypedParamsAddULLong(&params, &nparams, &maxparams, >> @@ -1344,7 +1344,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) >> goto save_error; >> } >> >> - if ((rv = vshCommandOptULongLong(ctl, cmd, "write-bytes-sec-max", >> &value)) < 0) { >> + if ((rv = vshCommandOptScaledInt(ctl, cmd, "write-bytes-sec-max", >> &value, 1, ULLONG_MAX)) < 0) { >> goto interror; >> } else if (rv > 0) { >> if (virTypedParamsAddULLong(&params, &nparams, &maxparams, >> diff --git a/tools/virsh.pod b/tools/virsh.pod >> index 2a95df7..6844823 100644 >> --- a/tools/virsh.pod >> +++ b/tools/virsh.pod >> @@ -1097,15 +1097,21 @@ I<domain> (see also B<domblklist> for listing >> these names). >> >> If no limit is specified, it will query current I/O limits setting. >> Otherwise, alter the limits with these flags: >> -I<--total-bytes-sec> specifies total throughput limit in bytes per >> second. >> -I<--read-bytes-sec> specifies read throughput limit in bytes per second. >> -I<--write-bytes-sec> specifies write throughput limit in bytes per >> second. >> +I<--total-bytes-sec> specifies total throughput limit as a scaled >> integer, the >> +default being bytes per second if no suffix is specified. >> +I<--read-bytes-sec> specifies read throughput limit as a scaled integer, >> the >> +default being bytes per second if no suffix is specified. >> +I<--write-bytes-sec> specifies write throughput limit as a scaled >> integer, the >> +default being bytes per second if no suffix is specified. >> I<--total-iops-sec> specifies total I/O operations limit per second. >> I<--read-iops-sec> specifies read I/O operations limit per second. >> I<--write-iops-sec> specifies write I/O operations limit per second. >> -I<--total-bytes-sec-max> specifies maximum total throughput limit in >> bytes per second. >> -I<--read-bytes-sec-max> specifies maximum read throughput limit in bytes >> per second. >> -I<--write-bytes-sec-max> specifies maximum write throughput limit in >> bytes per second. >> +I<--total-bytes-sec-max> specifies maximum total throughput limit as a >> scaled >> +integer, the default being bytes per second if no suffix is specified >> +I<--read-bytes-sec-max> specifies maximum read throughput limit as a >> scaled >> +integer, the default being bytes per second if no suffix is specified. >> +I<--write-bytes-sec-max> specifies maximum write throughput limit as a >> scaled >> +integer, the default being bytes per second if no suffix is specified. >> I<--total-iops-sec-max> specifies maximum total I/O operations limit per >> second. >> I<--read-iops-sec-max> specifies maximum read I/O operations limit per >> second. >> I<--write-iops-sec-max> specifies maximum write I/O operations limit per >> second. >> -- >> 2.1.4 >> >> -- >> libvir-list mailing list >> libvir-list(a)redhat.com >> https://www.redhat.com/mailman/listinfo/libvir-list >> > >

3 3

[libvirt] [PATCH] admin: Add a check to reject negative argument for number of typed params
by Erik Skultety 04 May '16

04 May '16

Since nparams can be technically negative, it is a good practice throughout our code to check if nparams actually has a non-negative value. The same effect would be achieved by converting our internal typed params serializer argument to 'unsigned' type, but it definitely would not be the path of least resistance. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- src/libvirt-admin.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libvirt-admin.c b/src/libvirt-admin.c index a94f5dd..4ad816b 100644 --- a/src/libvirt-admin.c +++ b/src/libvirt-admin.c @@ -838,6 +838,7 @@ virAdmServerSetThreadPoolParameters(virAdmServerPtr srv, virCheckAdmServerReturn(srv, -1); virCheckNonNullArgGoto(params, error); + virCheckNonNegativeArgGoto(nparams, error); if (remoteAdminServerSetThreadPoolParameters(srv, params, nparams, flags) < 0) -- 2.4.11

2 2

[libvirt] [PATCH 0/4] virt-host-validate: add s390 support
by Bjoern Walk 04 May '16

04 May '16

This patch series adds support to the s390 platform for the virt-host-validate tool which detects virtualization capabilities of the host. It has been tested on x86 that no regression is introduced. Bjoern Walk (4): tools: virt-host-validate: fix missing translation marker tools: virt-host-validate: fix CPU flag detection tools: virt-host-validate: improve error handling tools: virt-host-validate: HW virt support on s390 tools/virt-host-validate-common.c | 12 +++++++----- tools/virt-host-validate-common.h | 1 + tools/virt-host-validate-qemu.c | 31 ++++++++++++++++++++++++------- 3 files changed, 32 insertions(+), 12 deletions(-) -- 2.6.6

2 5