[libvirt] [PATCH] docs: website: more header spacing tweaks
by Cole Robinson
- remove top padding for h1. this means page titles sit flush with the top
of the side bar (like 'The virtualization API' on the front page)
- up the top padding for the remaining sections. makes it visually easier
to tell adjacent header sections apart, especially in dense wiki pages
- use two different spacing levels for h2-h4 and h5-h6,
gives pages some more visual flexibility
- use a slightly lower bottom padding... this makes top padding stick out
more which makes it visually easier to differentiate between adjacent
header sections
---
Before: http://i.imgur.com/5TxW9Fg.png
After: http://i.imgur.com/1MPjzHR.png
docs/generic.css | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/docs/generic.css b/docs/generic.css
index 664e719..aeea17f 100644
--- a/docs/generic.css
+++ b/docs/generic.css
@@ -48,26 +48,31 @@ h1, h2, h3, h4, h5, h6 {
font-weight: bold;
margin: 0px;
padding: 0px;
- margin-top: 0.5em;
- margin-bottom: 0.5em;
+ margin-bottom: 0.25em;
border-bottom: 1px solid #aaa;
}
h1 {
+ margin-top: 0em;
font-size: 2em;
}
h2 {
+ margin-top: 1.0em;
font-size: 1.6em;
}
h3 {
+ margin-top: 1.0em;
font-size: 1.4em;
}
h4 {
+ margin-top: 1.0em;
font-size: 1.2em;
}
h5 {
+ margin-top: 0.75em;
font-size: 1em;
}
h6 {
+ margin-top: 0.75em;
font-size: 0.8em;
}
--
2.5.0
8 years, 8 months
[libvirt] [PATCH v2 0/3] Add support for more HyperV Enlightenment features
by Nikolay Shirokovskiy
Changes from v1:
================
1. hv_reset and hv_vendor_id are supported
2. preparation patches [2],[3] for hv_vendor_id to reduce code dups
Maxim Nestratov (1):
conf: qemu: Add support for more HyperV Enlightenment features
Nikolay Shirokovskiy (2):
conf: refactor hyperv features parsing
conf: refactor hyperv features xml output
docs/formatdomain.html.in | 41 +++++
docs/schemas/domaincommon.rng | 37 ++++
src/conf/domain_conf.c | 186 +++++++++++++--------
src/conf/domain_conf.h | 9 +
src/qemu/qemu_command.c | 11 ++
src/qemu/qemu_parse_command.c | 20 +++
tests/qemuxml2argvdata/qemuxml2argv-hyperv-off.xml | 6 +
tests/qemuxml2argvdata/qemuxml2argv-hyperv.args | 3 +-
tests/qemuxml2argvdata/qemuxml2argv-hyperv.xml | 6 +
.../qemuxml2xmlout-hyperv-off.xml | 6 +
tests/qemuxml2xmloutdata/qemuxml2xmlout-hyperv.xml | 6 +
11 files changed, 262 insertions(+), 69 deletions(-)
--
1.8.3.1
8 years, 8 months
[libvirt] [PATCH 0/2] Enable pool-rbd storagexml2xmltest
by Anatole Denis
The test for an RBD pool in storagepoolxml2xml was commited 4 years ago but it
was not enabled. It was also incorrect, but didn't generate errors because it
was never run.
These patches correct the test then enable it
Anatole Denis (2):
tests: storagepoolxml2xmltest: Fix pool-rbd test
tests: storagepoolxml2xmltest: Enable pool-rbd
tests/storagepoolxml2xmlin/pool-rbd.xml | 1 +
tests/storagepoolxml2xmlout/pool-rbd.xml | 2 +-
tests/storagepoolxml2xmltest.c | 3 +++
3 files changed, 5 insertions(+), 1 deletion(-)
--
2.7.2
8 years, 8 months
[libvirt] [PATCH] util: avoid getting stuck on macvtapN name created outside libvirt
by Laine Stump
After the patches that added tracking of in-use macvtap names (commit
370608, first appearing in libvirt-1.3.2), if the function to allocate
a new macvtap device came to a device name created outside libvirt, it
would retry the same device name MACVLAN_MAX_I (8191) times before
finally giving up in failure.
The problem was that virBitmapNextClearBit was always being called
with "0" rather than the value most recently checked (which would
increment each time through the loop).
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1321546
---
I'm not sure how this bug snuck in, because this is one of the
scenarios I tested. The only thing I can think of is that I screwed up
somehow during a rebase after testing and before posting/pushing (or possibly I had tested these cases in an earlier iteration, but forgot to do so with the final version) :-/ Sigh.
src/util/virnetdevmacvlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virnetdevmacvlan.c b/src/util/virnetdevmacvlan.c
index 2409113..d755b93 100644
--- a/src/util/virnetdevmacvlan.c
+++ b/src/util/virnetdevmacvlan.c
@@ -131,7 +131,7 @@ virNetDevMacVLanReserveID(int id, unsigned int flags,
}
if ((id < 0 || nextFree) &&
- (id = virBitmapNextClearBit(bitmap, 0)) < 0) {
+ (id = virBitmapNextClearBit(bitmap, id)) < 0) {
virReportError(VIR_ERR_INTERNAL_ERROR,
_("no unused %s names available"),
(flags & VIR_NETDEV_MACVLAN_CREATE_WITH_TAP) ?
--
2.5.5
8 years, 8 months
[libvirt] [PATCH 0/2] vz: fix handling inputs in config
by Nikolay Shirokovskiy
Input devices are not stored in SDK but we report them
on dumpxml if vnc is on. Thus we need to handle input devices
on define xml as well. The latter part have some problems.
Let's fix them.
Nikolay Shirokovskiy (2):
vz: add default input devices on post parse
vz: fix config input device check
src/vz/vz_driver.c | 26 +++++++++++++++++++++++++-
src/vz/vz_sdk.c | 27 ++++++++++++++++++---------
2 files changed, 43 insertions(+), 10 deletions(-)
--
1.8.3.1
8 years, 8 months
[libvirt] [PATCH] qemu: ignore EACCES error on hot unplug of PCI devices with VFIO
by Kothapally Madhu Pavan
When the hostdev managed=true, the VFIO devices are reattached
to the host driver before coming to qemuTeardownHostdevCgroup().
So, the /dev/vfio/<iommu> path would not exist. We ignore the
EACCES error here.
Signed-off-by: Kothapally Madhu Pavan <kmp(a)linux.vnet.ibm.com>
---
src/qemu/qemu_cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index c76d585..2850346 100644
--- a/src/qemu/qemu_cgroup.c
+++ b/src/qemu/qemu_cgroup.c
@@ -427,7 +427,7 @@ qemuTeardownHostdevCgroup(virDomainObjPtr vm,
VIR_DEBUG("Cgroup deny %s for PCI device assignment", path);
rv = virCgroupDenyDevicePath(priv->cgroup, path,
- VIR_CGROUP_DEVICE_RWM, false);
+ VIR_CGROUP_DEVICE_RWM, dev->managed);
virDomainAuditCgroupPath(vm, priv->cgroup,
"deny", path, "rwm", rv == 0);
if (rv < 0)
8 years, 8 months
[libvirt] [PATCH] storage: revert bogus raw volumes support check
by Roman Bogorodskiy
Commits bb5f2dc and 6682d62 added a check like:
if (vol->target.format != VIR_STORAGE_FILE_RAW)
to the CreateVol method for zfs and logical storage backends
respectively. However, this check is bogus because
virStorageVolDefParseXML() in conf/storage_conf.c sets target.format
only if volOptions in virStoragePoolTypeInfo has formatFromString set,
and that's not the case for zfs and logical backends. So the check
always fails and breaks volume creation.
Thus, revert those commits.
---
src/storage/storage_backend_logical.c | 6 ------
src/storage/storage_backend_zfs.c | 6 ------
2 files changed, 12 deletions(-)
diff --git a/src/storage/storage_backend_logical.c b/src/storage/storage_backend_logical.c
index 39e8b80..90a194e 100644
--- a/src/storage/storage_backend_logical.c
+++ b/src/storage/storage_backend_logical.c
@@ -912,12 +912,6 @@ virStorageBackendLogicalCreateVol(virConnectPtr conn,
struct stat sb;
bool created = false;
- if (vol->target.format != VIR_STORAGE_FILE_RAW) {
- virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
- _("only RAW volumes are supported by this storage pool"));
- return -1;
- }
-
if (vol->target.encryption != NULL) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
"%s", _("storage pool does not support encrypted "
diff --git a/src/storage/storage_backend_zfs.c b/src/storage/storage_backend_zfs.c
index 5238ecc..c66a808 100644
--- a/src/storage/storage_backend_zfs.c
+++ b/src/storage/storage_backend_zfs.c
@@ -301,12 +301,6 @@ virStorageBackendZFSCreateVol(virConnectPtr conn ATTRIBUTE_UNUSED,
int ret = -1;
int volmode_needed = -1;
- if (vol->target.format != VIR_STORAGE_FILE_RAW) {
- virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
- _("only RAW volumes are supported by this storage pool"));
- return -1;
- }
-
if (vol->target.encryption != NULL) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
"%s", _("storage pool does not support encrypted "
--
2.7.2
8 years, 8 months
[libvirt] "Only raw volumes are supported"
by Richard Laager
I think the two commits below need to be reverted. This is now
preventing me from creating ZFS volumes (and presumably would block
creating LVM volumes too). I don't know how this passed my testing
before and isn't working now, but that seems to be the case.
When I run `virsh vol-create-as --pool=zfs --name=sparse1 --capacity=1G
--format=raw`, target.format is 0 (VIR_STORAGE_FILE_NONE).
Also note that the equivalent code in RBD came in a commit with more
code. So I'm thinking I was on the wrong track with these two patches.
commit bb5f2dc91f43f48ff726aa589bdac546738d2980
Author: Richard Laager <rlaager(a)wiktel.com>
Date: Tue Mar 15 01:17:35 2016 -0500
zfs: Only raw volumes are supported
commit 6682d6219d4595b51f06867e0c30e7efd745f682
Author: Richard Laager <rlaager(a)wiktel.com>
Date: Tue Mar 15 01:17:34 2016 -0500
logical: Only raw volumes are supported
--
Richard
8 years, 8 months
[libvirt] I am Xin and I am a newcomer
by fu du
Hello :
My name is Dangxin Hou, my email address is conquergmial(a)gmail.com
and my nickname is Xin on the #virt IRC channel at OFTC. I got my
bachelor’s degree from Xidian University at July 2015, and majored in
software engineering. I am a postgraduate student studying in Peking
University, major in computer science.
I am interested in the project “Making virsh more bash like”.The project
will add an
intelligent auto-completer into virsh to auto complete the right objects
that a
command works with.
First arrived in your land, please give most concorn!
8 years, 8 months
[libvirt] [PATCH 0/7] qemu: block job/disk related cleanups
by Peter Krempa
I've accumulated quite a few patches in my branch to add support for allowing to
use 'detect zeroes' for the block copy job. These are pathches that make sense
to be posted separately.
Peter Krempa (7):
qemu: hotplug: Assume support for -device in qemuDomainAttachSCSIDisk
qemu: monitor: Drop qemuMonitorAttachDrive and leaves in call tree
qemu: monitor: Remove JSON impls of drive_add and drive_del
qemu: Kill qemuDiskPathToAlias
qemu: Split image access revoking from
qemuDomainPrepareDiskChainElement
qemu: Refactor qemuDomainPrepareDiskChainElement
qemu: domain: Move and export
qemuDomainDiskChainElement(Prepare|Revoke)
src/qemu/qemu_alias.c | 16 ++++
src/qemu/qemu_alias.h | 2 +
src/qemu/qemu_domain.c | 81 +++++++++++++++++++
src/qemu/qemu_domain.h | 11 +++
src/qemu/qemu_driver.c | 187 ++++++++++++-------------------------------
src/qemu/qemu_hotplug.c | 63 +++------------
src/qemu/qemu_monitor.c | 35 +++-----
src/qemu/qemu_monitor.h | 6 --
src/qemu/qemu_monitor_json.c | 29 -------
src/qemu/qemu_monitor_json.h | 6 --
src/qemu/qemu_monitor_text.c | 102 +----------------------
src/qemu/qemu_monitor_text.h | 5 --
12 files changed, 187 insertions(+), 356 deletions(-)
--
2.7.3
8 years, 8 months
