[libvirt] [PATCH 0/2] fix the error when get the vcpupin info and add a test
by Luyao Huang
I was so ashamed of writing a incorrect commit '848ab68' and didn't test with
it. Patch 1/2 fix the issue and Patch 2/2 introduce a test for it.
Luyao Huang (2):
virsh: really fix the error if vcpu number exceed the guest maxvcpu
number
test: introduce a function in test driver for check get vcpupin info
src/test/test_driver.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++++++
tests/vcpupin | 34 +++++++++++++++++++++++++++----
tools/virsh-domain.c | 4 ++--
3 files changed, 87 insertions(+), 6 deletions(-)
--
1.8.3.1
9 years, 3 months
[libvirt] [PATCH 0/2] Add support for ioeventfd for virtio-scsi
by Martin Kletzander
This series is based on top of Laine's v3 of Add new PCIe controllers.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1150484
Martin Kletzander (2):
conf: Add ioeventfd option for controllers
qemu: Enable ioeventfd usage for virtio-scsi controllers
docs/formatdomain.html.in | 8 ++++++
docs/schemas/domaincommon.rng | 3 +++
src/conf/domain_conf.c | 19 ++++++++++++--
src/conf/domain_conf.h | 1 +
src/qemu/qemu_command.c | 7 ++++++
.../qemuxml2argv-disk-virtio-scsi-ioeventfd.xml | 29 ++++++++++++++++++++++
tests/qemuxml2argvtest.c | 3 +++
tests/qemuxml2xmltest.c | 1 +
8 files changed, 69 insertions(+), 2 deletions(-)
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-virtio-scsi-ioeventfd.xml
--
2.4.6
9 years, 3 months
[libvirt] [PATCHv2 00/17] Add new PCIe controllers
by Laine Stump
I had previously sent patches adding these new controller types:
pcie-root-port
pcie-switch-upstream-port
pcie-switch-downstream-port
but there were issues with where the device name and guest-visible
attributes should be stored in the XML:
https://www.redhat.com/archives/libvir-list/2015-June/msg01084.html
In the end, I *think* we all agreed with mkletzan's suggestion to use this:
<controller type='pci' model='pcie-root-port'>
<model type='ioh3420'/>
<target chassis='5' port='0x18'/>
...
</controller>
so that is what I implemented this time around.
(note that the stuff in <model> and <target> are almost always
auto-generated by libvirt, just like PCI addresses, but need to remain
stable to preserve guest ABI during migration)
The first 4 patches of the original series (removing restrictions on
attaching a PCI device to a PCIe port or vice versa) were ACKed and
have already been pushed. In this series, there are new patches 1 - 3
which are completely new (2 is a bugfix, 1,3,4 are fixing up the code
to make later additions cleaner), then 5-6 implementing <model>, 7-8
implementing <target>, and finally 9-17 which are V2's of 5-13 in the
original posting.
Laine Stump (17):
conf: reorganize virNetworkDHCPDefParseXML
conf: pay attention to bus minSlot/maxSlot when autoassigning PCI
addresses
qemu: reorganize loop in qemuDomainAssignPCIAddresses
conf: add virDomainControllerDefNew()
conf: add new <model> subelement with type attribute to <controller>
qemu: implement <model> subelement to <controller>
conf: add new <target> subelement with chassisNr attribute to
<controller>
qemu: implement <target chassisNr='n'/> subelement/attribute of
<controller>
qemu: add capabilities bit for device ioh3420
conf: new pci controller model "pcie-root-port"
qemu: support new pci controller model "pcie-root-port"
qemu: add capabilities bit for device x3130-upstream
conf: new pci controller model "pcie-switch-upstream-port"
qemu: support new pci controller model "pcie-switch-upstream-port"
qemu: add capabilities bit for device xio3130-downstream
conf: new pcie-controller model "pcie-switch-downstream-port"
qemu: support new pci controller model "pcie-switch-downstream-port"
docs/formatdomain.html.in | 84 +++++++-
docs/schemas/domaincommon.rng | 42 ++++
src/conf/domain_addr.c | 97 +++++++---
src/conf/domain_addr.h | 12 +-
src/conf/domain_conf.c | 148 +++++++++++---
src/conf/domain_conf.h | 23 +++
src/conf/network_conf.c | 36 ++--
src/qemu/qemu_capabilities.c | 8 +-
src/qemu/qemu_capabilities.h | 5 +-
src/qemu/qemu_command.c | 214 +++++++++++++++++++--
tests/qemucapabilitiesdata/caps_1.2.2-1.caps | 3 +
tests/qemucapabilitiesdata/caps_1.3.1-1.caps | 3 +
tests/qemucapabilitiesdata/caps_1.4.2-1.caps | 3 +
tests/qemucapabilitiesdata/caps_1.5.3-1.caps | 3 +
tests/qemucapabilitiesdata/caps_1.6.0-1.caps | 3 +
tests/qemucapabilitiesdata/caps_1.6.50-1.caps | 3 +
tests/qemucapabilitiesdata/caps_2.1.1-1.caps | 3 +
tests/qemuhelptest.c | 10 +-
.../qemuxml2argv-pcie-root-port.args | 10 +
.../qemuxml2argv-pcie-root-port.xml | 36 ++++
.../qemuxml2argv-pcie-switch-downstream-port.args | 18 ++
.../qemuxml2argv-pcie-switch-downstream-port.xml | 44 +++++
.../qemuxml2argv-pcie-switch-upstream-port.args | 12 ++
.../qemuxml2argv-pcie-switch-upstream-port.xml | 37 ++++
tests/qemuxml2argvdata/qemuxml2argv-q35.args | 2 +-
tests/qemuxml2argvdata/qemuxml2argv-q35.xml | 9 +-
tests/qemuxml2argvtest.c | 25 +++
tests/qemuxml2xmloutdata/qemuxml2xmlout-q35.xml | 9 +-
tests/qemuxml2xmltest.c | 3 +
29 files changed, 809 insertions(+), 96 deletions(-)
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pcie-root-port.args
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pcie-root-port.xml
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pcie-switch-downstream-port.args
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pcie-switch-downstream-port.xml
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pcie-switch-upstream-port.args
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pcie-switch-upstream-port.xml
--
2.1.0
9 years, 3 months
[libvirt] [PATCH 1/2] storage: allow zero capacity with non-backing file to be created
by Chris J Arges
In commit fbcf7da95, a change was introduced that no longer allowed defining
volumes via XML with a capacity of '0'. Because we check for info.size_arg to be
non-zero, this use-case fails. This patch allows info.size_arg to be zero if no
backing store is specified.
Signed-off-by: Chris J Arges <chris.j.arges(a)canonical.com>
---
src/storage/storage_backend.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c
index ce59f63..c661662 100644
--- a/src/storage/storage_backend.c
+++ b/src/storage/storage_backend.c
@@ -1068,7 +1068,7 @@ virStorageBackendCreateQemuImgCmdFromVol(virConnectPtr conn,
if (info.inputPath)
virCommandAddArg(cmd, info.inputPath);
virCommandAddArg(cmd, info.path);
- if (!info.inputPath && info.size_arg)
+ if (!info.inputPath && (info.size_arg || !info.backingPath))
virCommandAddArgFormat(cmd, "%lluK", info.size_arg);
return cmd;
--
1.9.1
9 years, 3 months
[libvirt] Plan for next release
by Daniel Veillard
We are getting close to the end of the month, so we may need to freeze
next Monday or Tuesday. Are we ready for 1.3.0 now :-) ? I see that
configure.ac targets 1.2.18, so a priori no, but would rather have a
clear answer :-)
Thanks,
Daniel
--
Daniel Veillard | Open Source and Standards, Red Hat
veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | virtualization library http://libvirt.org/
9 years, 3 months
[libvirt] [PATCH glib 0/2] Clarify min required versions of deps
by Daniel P. Berrange
This sets out a policy for deciding when it is reasonable to
increase the min required versions of external deps, and then
updates current min versions accordingly.
The aim is to ensure libvirt-glib is easily buildable on latest
enterprise and community distros, to maximise the pool of
possible contributors to the project and simplify life for the
distro maintainers packaging it.
Daniel P. Berrange (2):
README: formally document intended platform support targets
configure.ac: update min required versions
README | 67 +++++++++++++++++++++++++++++++++++++++++++++++++-----------
configure.ac | 8 +++-----
2 files changed, 58 insertions(+), 17 deletions(-)
--
2.4.3
9 years, 3 months
[libvirt] [PATCH v2] fix typo in qemu_monitor
by Cao jin
Signed-off-by: Cao jin <caoj.fnst(a)cn.fujitsu.com>
---
src/qemu/qemu_monitor.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h
index 1e7b6bb..860e242 100644
--- a/src/qemu/qemu_monitor.h
+++ b/src/qemu/qemu_monitor.h
@@ -259,7 +259,7 @@ void qemuMonitorSetOptions(qemuMonitorPtr mon, virJSONValuePtr options)
ATTRIBUTE_NONNULL(1);
int qemuMonitorUpdateVideoMemorySize(qemuMonitorPtr mon,
virDomainVideoDefPtr video,
- const char *videName)
+ const char *videoName)
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3);
int qemuMonitorHMPCommandWithFd(qemuMonitorPtr mon,
const char *cmd,
--
2.1.0
9 years, 3 months
[libvirt] [PATCH] fix typo in qemu_monitor
by Cao jin
Signed-off-by: Cao jin <caoj.fnst(a)cn.fujitsu.com>
---
src/qemu/qemu_monitor.c | 2 +-
src/qemu/qemu_monitor.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
index 15ba39b..beaf585 100644
--- a/src/qemu/qemu_monitor.c
+++ b/src/qemu/qemu_monitor.c
@@ -3345,7 +3345,7 @@ qemuMonitorVMStatusToPausedReason(const char *status)
case QEMU_MONITOR_VM_STATUS_WATCHDOG:
return VIR_DOMAIN_PAUSED_WATCHDOG;
- case QEMU_MONITOR_VM_STATUS_GUEST_PANICKED:
+ case QEMU_MONITOR_VM_STATUS_GUEST_PANICED:
return VIR_DOMAIN_PAUSED_CRASHED;
/* unreachable from this point on */
diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h
index 1e7b6bb..f12aa99 100644
--- a/src/qemu/qemu_monitor.h
+++ b/src/qemu/qemu_monitor.h
@@ -259,7 +259,7 @@ void qemuMonitorSetOptions(qemuMonitorPtr mon, virJSONValuePtr options)
ATTRIBUTE_NONNULL(1);
int qemuMonitorUpdateVideoMemorySize(qemuMonitorPtr mon,
virDomainVideoDefPtr video,
- const char *videName)
+ const char *videoName)
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3);
int qemuMonitorHMPCommandWithFd(qemuMonitorPtr mon,
const char *cmd,
@@ -342,7 +342,7 @@ typedef enum {
QEMU_MONITOR_VM_STATUS_SAVE_VM,
QEMU_MONITOR_VM_STATUS_SHUTDOWN,
QEMU_MONITOR_VM_STATUS_WATCHDOG,
- QEMU_MONITOR_VM_STATUS_GUEST_PANICKED,
+ QEMU_MONITOR_VM_STATUS_GUEST_PANICED,
QEMU_MONITOR_VM_STATUS_LAST
} qemuMonitorVMStatus;
--
2.1.0
9 years, 3 months
[libvirt] [libvirt-glib] events: Mark 'eventlock' as static
by Christophe Fergeau
It's not used outside of the libvirt-glib-event.c file, so there is no
good reason for not having it static. As it was not listed in
libvirt-glib.sym, this will make no change to the publicly exported
symbols (ie this is not an ABI change).
---
libvirt-glib/libvirt-glib-event.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt-glib/libvirt-glib-event.c b/libvirt-glib/libvirt-glib-event.c
index f8227d6..4548aa6 100644
--- a/libvirt-glib/libvirt-glib-event.c
+++ b/libvirt-glib/libvirt-glib-event.c
@@ -110,7 +110,7 @@ struct gvir_event_timeout
virFreeCallback ff;
};
-GMutex *eventlock = NULL;
+static GMutex *eventlock = NULL;
static int nextwatch = 1;
static GPtrArray *handles;
--
2.4.3
9 years, 3 months
[libvirt] [PATCH] nodeinfo: Check for SYSFS_INFINIBAND_DIR before open
by John Ferlan
Commit id 'ac3ed2085' causes 'virsh nodedev-list --cap net' to fail
on any system without SYSFS_INFINIBAND_DIR (/sys/class/infiniband).
Rather than assume it's there and fail on the attempt to open the
non-existent directory, check if it's there - if not, return
success and move on.
As reported by Suren Hajyan <shajyan(a)redhat.com> from run of unit tests
Signed-off-by: John Ferlan <jferlan(a)redhat.com>
---
src/util/virnetdev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c
index 7d91e2c..eb6a9fb 100644
--- a/src/util/virnetdev.c
+++ b/src/util/virnetdev.c
@@ -2976,6 +2976,9 @@ virNetDevRDMAFeature(const char *ifname,
struct dirent *dp;
int ret = -1;
+ if (!virFileExists(SYSFS_INFINIBAND_DIR))
+ return 0;
+
if (!(dirp = opendir(SYSFS_INFINIBAND_DIR))) {
virReportSystemError(errno,
_("Failed to opendir path '%s'"),
--
2.1.0
9 years, 3 months
