[libvirt] [PATCH 0/2] esx: Make esxNodeGetFreeMemory always use ESX host.
by Dawid Zamirski
This patch is intended to make ESX driver behave more consistently.
When calling virNodeGetFreeMemory, it would return the free bytes
from a cluster when using vpx connection or ESX host when using esx
connection. However, virGetNodeInfo always returns info from ESX
host (specifying ESX host is mandatory, even for vpx connections)
so to make this consitent, these patches make virNodeGetFreeMemory
always return info from the ESX host.
Dawid Zamirski (2):
esx: add esxVI_GetInt
esx: esxNodeGetFreeMemory return info from host.
src/esx/esx_driver.c | 53 ++++++++++++++++++--------------------------------
src/esx/esx_vi.c | 32 ++++++++++++++++++++++++++++++
src/esx/esx_vi.h | 3 +++
src/esx/esx_vi_types.c | 3 +++
src/esx/esx_vi_types.h | 1 +
5 files changed, 58 insertions(+), 34 deletions(-)
--
2.1.0
9 years, 7 months
[libvirt] [PATCH 0/2] fix 2 bugs in virHostdevReAttachPCIDevices
by Huanle Han
Fix 1: Fix index error in loop after remove an element from the array
'virPCIDeviceList' is actually an array. Removing one element makes the
rest of the element move. Use while loop, increase index only when not
do 'virPCIDeviceListDel(pcidevs, dev)'
Fix 2:
In such a case:
1. Domain A and B xml contain the same SRIOV net hostdev(<interface
type='hostdev' /> with same pci address).
2. virsh start A (Successfully, and configure the SRIOV net with
custom mac)
3. virsh start B (Fail because of the hostdev used by domain A or other
reason.)
In step 3, 'virHostdevNetConfigRestore' is called for the hostdev
which is still used by domain A. It makes the mac/vlan of the SRIOV net
change.
Code Change in this fix:
1. As the pci used by other domain have been removed from
'pcidevs' in previous loop, we only restore the nic config for
the hostdev still in 'pcidevs'(used by this domain)
2. wrap a function 'virHostdevIsPCINetDevice', which detect whether the
hostdev is a pci net device or not.
3. update the comments to make it more clear
Huanle Han (2):
hostdev: Fix index error in loop after remove an element
hostdev: fix net config restore error
src/util/virhostdev.c | 56 ++++++++++++++++++++++++++++++++++++---------------
1 file changed, 40 insertions(+), 16 deletions(-)
--
1.9.1
9 years, 7 months
[libvirt] [PATCH] docs: Add Host sFlow into monitoring apps
by Martin Kletzander
Reported-by: Peter Phaal <peter.phaal(a)gmail.com>
Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
---
docs/apps.html.in | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/docs/apps.html.in b/docs/apps.html.in
index 79ee73a..fd45189 100644
--- a/docs/apps.html.in
+++ b/docs/apps.html.in
@@ -321,6 +321,12 @@
For a full description, please refer to the libvirt section in the
collectd.conf(5) manual page.
</dd>
+ <dt><a href="http://host-sflow.sourceforge.net/">Host sFlow</a></dt>
+ <dd>
+ Host sFlow is a lightweight agent running on KVM hypervisors that
+ links to libvirt library and exports standardized cpu, memory, network
+ and disk metrics for all virtual machines.
+ </dd>
<dt><a href="http://honk.sigxcpu.org/projects/libvirt/#munin">Munin</a></dt>
<dd>
The plugins provided by Guido Günther allow to monitor various things
--
2.3.3
9 years, 7 months
[libvirt] [PATCHv3 0/6] Allocate virtio-serial addresses
by Ján Tomko
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1076708
https://bugzilla.redhat.com/show_bug.cgi?id=890606
New in v3:
* preserve the behavior of honoring the controller if a partial address is specified:
<address type='virtio-serial' controller='2'/>
* automatically add a controller if we're out of free ports
and add a test for it
Ján Tomko (6):
Add test for virtio serial port assignment
Add functions to track virtio-serial addresses
Allocate virtio-serial addresses when starting a domain
Expand the address set when attaching a virtio-serial controller
Assign an address when hotplugging a virtio-serial device
Auto add virtio-serial controllers
src/conf/domain_addr.c | 435 +++++++++++++++++++++
src/conf/domain_addr.h | 61 +++
src/conf/domain_conf.c | 48 +--
src/conf/domain_conf.h | 1 +
src/libvirt_private.syms | 11 +
src/qemu/qemu_command.c | 63 +++
src/qemu/qemu_domain.c | 1 +
src/qemu/qemu_domain.h | 1 +
src/qemu/qemu_hotplug.c | 32 +-
src/qemu/qemu_process.c | 2 +
tests/qemuhotplugtest.c | 2 +-
.../qemuxml2argv-channel-virtio-auto.args | 2 +-
.../qemuxml2argv-channel-virtio-autoadd.args | 33 ++
.../qemuxml2argv-channel-virtio-autoadd.xml | 45 +++
.../qemuxml2argv-channel-virtio-autoassign.args | 20 +
.../qemuxml2argv-channel-virtio-autoassign.xml | 50 +++
tests/qemuxml2argvtest.c | 4 +
.../qemuxml2xmlout-channel-virtio-auto.xml | 9 +-
18 files changed, 777 insertions(+), 43 deletions(-)
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-channel-virtio-autoadd.args
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-channel-virtio-autoadd.xml
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-channel-virtio-autoassign.args
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-channel-virtio-autoassign.xml
--
2.0.5
9 years, 7 months
[libvirt] [PATCH 0/7] Introduce storage pool status XML
by Erik Skultety
All of the commits resolve BZ https://bugzilla.redhat.com/show_bug.cgi?id=1177733
Erik Skultety (7):
storage: Remove unused attribute conn from 'checkPool' callback
conf: Add support for storage state directory
conf: Add/modify storage formatting functions
storage: Modify stateInitialize to support storage state XML
conf: Introduce virStoragePoolLoadAllState && virStoragePoolLoadState
storage: Introduce storagePoolUpdateAllState function
storage: Create/Delete pool status XML
src/conf/storage_conf.c | 229 ++++++++++++++++++++++++++++------
src/conf/storage_conf.h | 14 ++-
src/libvirt_private.syms | 2 +
src/storage/storage_backend.h | 3 +-
src/storage/storage_backend_fs.c | 3 +-
src/storage/storage_backend_iscsi.c | 3 +-
src/storage/storage_backend_logical.c | 3 +-
src/storage/storage_backend_mpath.c | 3 +-
src/storage/storage_backend_scsi.c | 3 +-
src/storage/storage_backend_zfs.c | 3 +-
src/storage/storage_driver.c | 166 +++++++++++++++++++-----
11 files changed, 348 insertions(+), 84 deletions(-)
--
1.9.3
9 years, 7 months
[libvirt] [PATCH 0/2] qemu: Finish fixing of interlocking domain ops with blockjobs
by Peter Krempa
Peter Krempa (1):
qemu: snapshot: Check for block jobs individually
Shanzhi Yu (1):
conf: Rename virDomainHasDiskMirror and detect block jobs properly
src/conf/domain_conf.c | 25 ++++++++++++++++++++-----
src/conf/domain_conf.h | 3 ++-
src/libvirt_private.syms | 2 +-
src/qemu/qemu_driver.c | 19 +++++++++++--------
src/qemu/qemu_migration.c | 2 +-
5 files changed, 35 insertions(+), 16 deletions(-)
--
2.2.2
9 years, 7 months
[libvirt] [PATCH 0/8] Fix cgroups regresion when default cpuset is specified
by Peter Krempa
Since commit a39f69d2b libvirt would fail to start a VM if the default cpu set
was specified and individual vcpus were pinned to cpus outside of that cpuset.
Peter Krempa (8):
qemu: cgroup: Store auto cpuset instead of re-creating it on demand
qemu: cgroup: Refactor setup for IOThread cgroups
qemu: cgroup: Properly set up vcpu pinning
qemu: cgroup: Use priv->autoCpuset instead of using
qemuPrepareCpumap()
qemu: cgroup: Rename qemuSetupCgroupEmulatorPin to
qemuSetupCgroupCpusetCpus
qemu: cgroup: Kill qemuSetupCgroupIOThreadsPin()
qemu: cgroup: Kill qemuSetupCgroupVcpuPin()
qemu: Copy bitmap in a sane way
src/qemu/qemu_cgroup.c | 150 +++++++++++++++---------------------------------
src/qemu/qemu_cgroup.h | 13 +----
src/qemu/qemu_domain.c | 1 +
src/qemu/qemu_domain.h | 3 +
src/qemu/qemu_driver.c | 21 +++----
src/qemu/qemu_process.c | 93 +++++++++---------------------
src/qemu/qemu_process.h | 2 -
7 files changed, 85 insertions(+), 198 deletions(-)
--
2.2.2
9 years, 7 months
[libvirt] [PATCH 0/3] libxl: domain destroy fixes
by Jim Fehlig
This small series of patches fixes some issues wrt domain destroy in
the libxl driver. The primary motivation for this work is to
prevent locking the virDomainObj during long running destroy operations
on large memory domains.
Patch 1 moves job acquisition from libxlDomainStart to it's callers so
they have more control over when the job is acquired. Patch 2 fixes a
few spots where we never acquired a job during domain destroy. Patch 3
contains the interesting change, where the virDomainObj is unlocked
during the long-running destroy operation.
This series wraps up my work to improve parallel OpenStack Tempest runs
against the libxl driver. With libvirt.git master + this series + a
patched libxl [1], I've successfully run a reproducer that was hitting
the same issues encountered by Tempest.
[1] libxl commits from xen.git: 93699882d, f1335f0d, 4783c99a, 1c91d6fba,
and 188e9c54. I'll contact the stable branch maintainers and ask them
to include these commits in the next Xen 4.4.x and 4.5.x releases.
Jim Fehlig (3):
libxl: Move job acquisition in libxlDomainStart to callers
libxl: acquire a job when destroying a domain
libxl: drop virDomainObj lock when destroying a domain
src/libxl/libxl_domain.c | 77 +++++++++++++++++++----------------------------
src/libxl/libxl_domain.h | 4 ---
src/libxl/libxl_driver.c | 78 ++++++++++++++++++++++++++++++++++++------------
3 files changed, 89 insertions(+), 70 deletions(-)
--
1.8.4.5
9 years, 7 months
[libvirt] [PATCH 0/3] storage: handle scsi/iscsi error paths better
by John Ferlan
Adjust error path logic for processing LU's in order to better ascertain
the correct cause for failure. The first two patches are merely setting
for the third one which determines that the pool definition used a non
existent path in the configuration thus no 'real' targets were able to
be created.
John Ferlan (3):
iscsi: Check for presence of error before creating new one
scsi: Adjust return values from processLU
scsi: Check for invalid target.path after processLU failure
src/storage/storage_backend_iscsi.c | 5 +++--
src/storage/storage_backend_scsi.c | 13 +++++++++++--
2 files changed, 14 insertions(+), 4 deletions(-)
--
2.1.0
9 years, 7 months
