December 2015 - Devel - Libvirt List Archives

[libvirt] [PATCH LIBVIRT v1 0/2] Support maxvcpus (AKA >1 vcpu on Xen/ARM)

by Ian Campbell

libvirt currently clamps the maximum number of vcpus to MAX_VIRT_CPUS == XEN_LEGACY_MAX_VCPUS, which on ARM is 1 (because all guests are expected to support vcpu info placement). Even on x86 this limitation is a hold over from an older xm interface where the maximum number of vcpus was expressed as a bitmap and so limited to the number of bits in an unsigned long (for which XEN_LEGACY_MAX_VCPUS is a convenient proxy), which doesn't apply to xl on x86 which uses a bitmap data type to express larger bitmaps. To do this it was necessary to add a new value to xenConfigVersionEnum corresponding to this new version. I've tested with tests/x?configtest (including new test case) on x86 and on ARM with xlconfigtest and via domxml-from-native. As you might infer from some of the changlogs I feel a bit like I am abusing xendConfigVersion somewhat here (given that xl != xend, and that real xend never went passed xend_config_version) but its use is quite widespread in the common xl/xm support code in libvirt so a great deal of refactoring/renaming would otherwise seem to be required. I'm open to other ideas or suggestions though. Ian.

8 years, 11 months

3
6
0 / 0

Re: [libvirt] libvirt to report cpuWait of a guest.

by Daniel P. Berrange

On Fri, Dec 04, 2015 at 02:12:42PM +0200, Avi Weit wrote: > Hi, > > Thank you, it sounds good. Can you please let me know how Openstack > Ceilometer will access that wait counter (vcpu.NNN.wait)? To my > understanding Openstack uses libvirt python library to access domain data. The python API has a binding to let it invoke the virDomainListGetStats API. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

8 years, 11 months

1
0
0 / 0

[libvirt] libvirt to report cpuWait of a guest.

by Avi Weit

Hi, We are working on fixing CPU utilization calculation of guests (VMs) in Ceilometer metering service of OpenStack. Per that fix, we retrieve, at the host level, se.statistics.wait_sum (or se.wait_sum in old versions) Linux kernel schedstat counter of the KVM/QEMU threads ? that represent the VM. That counter denotes the time in milliseconds the thread 'wants' to run (but not actually running because of a contention). However, as Daniel Berrange mentioned in the fix review, it would be better to retrieve that information from libvirt instead and he asked me to raise this in this mailing list. I could not notice that libvirt exposes such a counter. It would be very good if virDomainInfo ( https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainInfo) can be added with cpuWait in addition to cpuTime it currently has so that cpuWait will denote the total *time* the VM *wants* to run. Adding cpuWait to any other location of domain is fine as well. Thanks, Avi Weit

8 years, 11 months

2
2
0 / 0

[libvirt] libvirt-php 0.5.1 - missing arginfo

by Remi Collet

Hi, arginfo are very important in PHP extensions, useful for users (documentation), and various tools rely on them (through reflection). Attached patch add some. Tell me if ok, and I will continue to add more. Remi.

8 years, 11 months

2
3
0 / 0

[libvirt] [libvirt-glib] gobject, gconfig: Drop redundant debug logging

by Zeeshan Ali (Khattak)

Justification from IRC chat: <zeenix> danpb: i'm not sure it's good to have a g_debug() for every libvirt-gobject/gconfig object creation/destruction <zeenix> danpb: the debug output becomes so big that at least I never think about enabling it at runtime and sometimes end up missing important debug info <danpb> yeah we could easily kill that <danpb> gobject has systemtap probes builtin these days which let you debug object create/finalize problems <zeenix> danpb: oh cool <zeenix> danpb: i'll write a patch --- libvirt-gconfig/libvirt-gconfig-capabilities-cpu-feature.c | 2 -- libvirt-gconfig/libvirt-gconfig-capabilities-cpu-model.c | 2 -- libvirt-gconfig/libvirt-gconfig-capabilities-cpu-topology.c | 2 -- libvirt-gconfig/libvirt-gconfig-capabilities-cpu.c | 2 -- libvirt-gconfig/libvirt-gconfig-capabilities-guest-arch.c | 2 -- libvirt-gconfig/libvirt-gconfig-capabilities-guest-domain.c | 2 -- libvirt-gconfig/libvirt-gconfig-capabilities-guest-feature.c | 2 -- libvirt-gconfig/libvirt-gconfig-capabilities-guest.c | 2 -- libvirt-gconfig/libvirt-gconfig-capabilities-host-secmodel.c | 2 -- libvirt-gconfig/libvirt-gconfig-capabilities-host.c | 2 -- libvirt-gconfig/libvirt-gconfig-capabilities.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-address-pci.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-address-usb.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-address.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-channel.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-chardev-source-pty.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-chardev-source-spiceport.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-chardev-source-spicevmc.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-chardev-source-unix.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-chardev-source.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-chardev.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-clock.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-console.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-controller-usb.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-controller.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-cpu-feature.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-cpu-model.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-cpu.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-device.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-disk-driver.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-disk.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-filesys.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-graphics-desktop.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-graphics-rdp.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-graphics-sdl.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-graphics.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-input.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-interface-bridge.c | 2 -- .../libvirt-gconfig-domain-interface-filterref-parameter.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-interface-filterref.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-interface-network.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-interface-user.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-interface.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-memballoon.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-os.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-parallel.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-power-management.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-redirdev.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-seclabel.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-serial.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-smartcard-host-certificates.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-smartcard-host.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-smartcard-passthrough.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-smartcard.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-snapshot-disk.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-snapshot.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-sound.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-timer-hpet.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-timer-pit.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-timer-rtc.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-timer.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain-video.c | 2 -- libvirt-gconfig/libvirt-gconfig-domain.c | 2 -- libvirt-gconfig/libvirt-gconfig-interface.c | 2 -- libvirt-gconfig/libvirt-gconfig-network-filter.c | 2 -- libvirt-gconfig/libvirt-gconfig-network.c | 2 -- libvirt-gconfig/libvirt-gconfig-node-device.c | 2 -- libvirt-gconfig/libvirt-gconfig-object.c | 4 ---- libvirt-gconfig/libvirt-gconfig-secret.c | 2 -- libvirt-gconfig/libvirt-gconfig-storage-permissions.c | 2 -- libvirt-gconfig/libvirt-gconfig-storage-pool-source.c | 2 -- libvirt-gconfig/libvirt-gconfig-storage-pool-target.c | 2 -- libvirt-gconfig/libvirt-gconfig-storage-pool.c | 2 -- libvirt-gconfig/libvirt-gconfig-storage-vol-backing-store.c | 2 -- libvirt-gconfig/libvirt-gconfig-storage-vol-target.c | 2 -- libvirt-gconfig/libvirt-gconfig-storage-vol.c | 2 -- libvirt-gconfig/libvirt-gconfig-xml-doc.c | 4 ---- libvirt-gobject/libvirt-gobject-connection.c | 4 ---- libvirt-gobject/libvirt-gobject-domain-device.c | 4 ---- libvirt-gobject/libvirt-gobject-domain-disk.c | 4 ---- libvirt-gobject/libvirt-gobject-domain-interface.c | 4 ---- libvirt-gobject/libvirt-gobject-domain-snapshot.c | 4 ---- libvirt-gobject/libvirt-gobject-domain.c | 4 ---- libvirt-gobject/libvirt-gobject-input-stream.c | 1 - libvirt-gobject/libvirt-gobject-interface.c | 4 ---- libvirt-gobject/libvirt-gobject-manager.c | 4 ---- libvirt-gobject/libvirt-gobject-network-dhcp-lease.c | 4 ---- libvirt-gobject/libvirt-gobject-network-filter.c | 4 ---- libvirt-gobject/libvirt-gobject-network.c | 4 ---- libvirt-gobject/libvirt-gobject-node-device.c | 4 ---- libvirt-gobject/libvirt-gobject-output-stream.c | 1 - libvirt-gobject/libvirt-gobject-secret.c | 4 ---- libvirt-gobject/libvirt-gobject-storage-pool.c | 4 ---- libvirt-gobject/libvirt-gobject-storage-vol.c | 4 ---- libvirt-gobject/libvirt-gobject-stream.c | 2 -- 97 files changed, 226 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-capabilities-cpu-feature.c b/libvirt-gconfig/libvirt-gconfig-capabilities-cpu-feature.c index b691b57..b52c0bf 100644 --- a/libvirt-gconfig/libvirt-gconfig-capabilities-cpu-feature.c +++ b/libvirt-gconfig/libvirt-gconfig-capabilities-cpu-feature.c @@ -44,8 +44,6 @@ static void gvir_config_capabilities_cpu_feature_class_init(GVirConfigCapabiliti static void gvir_config_capabilities_cpu_feature_init(GVirConfigCapabilitiesCpuFeature *feature) { - g_debug("Init GVirConfigCapabilitiesCpuFeature=%p", feature); - feature->priv = GVIR_CONFIG_CAPABILITIES_CPU_FEATURE_GET_PRIVATE(feature); } diff --git a/libvirt-gconfig/libvirt-gconfig-capabilities-cpu-model.c b/libvirt-gconfig/libvirt-gconfig-capabilities-cpu-model.c index 002b77f..14630a0 100644 --- a/libvirt-gconfig/libvirt-gconfig-capabilities-cpu-model.c +++ b/libvirt-gconfig/libvirt-gconfig-capabilities-cpu-model.c @@ -42,8 +42,6 @@ static void gvir_config_capabilities_cpu_model_class_init(GVirConfigCapabilities static void gvir_config_capabilities_cpu_model_init(GVirConfigCapabilitiesCpuModel *model) { - g_debug("Init GVirConfigCapabilitiesCpuModel=%p", model); - model->priv = GVIR_CONFIG_CAPABILITIES_CPU_MODEL_GET_PRIVATE(model); } diff --git a/libvirt-gconfig/libvirt-gconfig-capabilities-cpu-topology.c b/libvirt-gconfig/libvirt-gconfig-capabilities-cpu-topology.c index d3c7997..1ff879a 100644 --- a/libvirt-gconfig/libvirt-gconfig-capabilities-cpu-topology.c +++ b/libvirt-gconfig/libvirt-gconfig-capabilities-cpu-topology.c @@ -44,8 +44,6 @@ static void gvir_config_capabilities_cpu_topology_class_init(GVirConfigCapabilit static void gvir_config_capabilities_cpu_topology_init(GVirConfigCapabilitiesCpuTopology *topology) { - g_debug("Init GVirConfigCapabilitiesCpuTopology=%p", topology); - topology->priv = GVIR_CONFIG_CAPABILITIES_CPU_TOPOLOGY_GET_PRIVATE(topology); } diff --git a/libvirt-gconfig/libvirt-gconfig-capabilities-cpu.c b/libvirt-gconfig/libvirt-gconfig-capabilities-cpu.c index 294d60e..913c759 100644 --- a/libvirt-gconfig/libvirt-gconfig-capabilities-cpu.c +++ b/libvirt-gconfig/libvirt-gconfig-capabilities-cpu.c @@ -49,8 +49,6 @@ static void gvir_config_capabilities_cpu_class_init(GVirConfigCapabilitiesCpuCla static void gvir_config_capabilities_cpu_init(GVirConfigCapabilitiesCpu *cpu) { - g_debug("Init GVirConfigCapabilitiesCpu=%p", cpu); - cpu->priv = GVIR_CONFIG_CAPABILITIES_CPU_GET_PRIVATE(cpu); } diff --git a/libvirt-gconfig/libvirt-gconfig-capabilities-guest-arch.c b/libvirt-gconfig/libvirt-gconfig-capabilities-guest-arch.c index c08eebd..8da33dc 100644 --- a/libvirt-gconfig/libvirt-gconfig-capabilities-guest-arch.c +++ b/libvirt-gconfig/libvirt-gconfig-capabilities-guest-arch.c @@ -44,8 +44,6 @@ static void gvir_config_capabilities_guest_arch_class_init(GVirConfigCapabilitie static void gvir_config_capabilities_guest_arch_init(GVirConfigCapabilitiesGuestArch *arch) { - g_debug("Init GVirConfigCapabilitiesGuestArch=%p", arch); - arch->priv = GVIR_CONFIG_CAPABILITIES_GUEST_ARCH_GET_PRIVATE(arch); } diff --git a/libvirt-gconfig/libvirt-gconfig-capabilities-guest-domain.c b/libvirt-gconfig/libvirt-gconfig-capabilities-guest-domain.c index 148bfc7..3162ea1 100644 --- a/libvirt-gconfig/libvirt-gconfig-capabilities-guest-domain.c +++ b/libvirt-gconfig/libvirt-gconfig-capabilities-guest-domain.c @@ -45,8 +45,6 @@ static void gvir_config_capabilities_guest_domain_class_init(GVirConfigCapabilit static void gvir_config_capabilities_guest_domain_init(GVirConfigCapabilitiesGuestDomain *domain) { - g_debug("Init GVirConfigCapabilitiesGuestDomain=%p", domain); - domain->priv = GVIR_CONFIG_CAPABILITIES_GUEST_DOMAIN_GET_PRIVATE(domain); } diff --git a/libvirt-gconfig/libvirt-gconfig-capabilities-guest-feature.c b/libvirt-gconfig/libvirt-gconfig-capabilities-guest-feature.c index 51a0066..9e9533a 100644 --- a/libvirt-gconfig/libvirt-gconfig-capabilities-guest-feature.c +++ b/libvirt-gconfig/libvirt-gconfig-capabilities-guest-feature.c @@ -44,8 +44,6 @@ static void gvir_config_capabilities_guest_feature_class_init(GVirConfigCapabili static void gvir_config_capabilities_guest_feature_init(GVirConfigCapabilitiesGuestFeature *feature) { - g_debug("Init GVirConfigCapabilitiesGuestFeature=%p", feature); - feature->priv = GVIR_CONFIG_CAPABILITIES_GUEST_FEATURE_GET_PRIVATE(feature); } diff --git a/libvirt-gconfig/libvirt-gconfig-capabilities-guest.c b/libvirt-gconfig/libvirt-gconfig-capabilities-guest.c index bbc1408..128b22f 100644 --- a/libvirt-gconfig/libvirt-gconfig-capabilities-guest.c +++ b/libvirt-gconfig/libvirt-gconfig-capabilities-guest.c @@ -45,8 +45,6 @@ static void gvir_config_capabilities_guest_class_init(GVirConfigCapabilitiesGues static void gvir_config_capabilities_guest_init(GVirConfigCapabilitiesGuest *guest) { - g_debug("Init GVirConfigCapabilitiesGuest=%p", guest); - guest->priv = GVIR_CONFIG_CAPABILITIES_GUEST_GET_PRIVATE(guest); } diff --git a/libvirt-gconfig/libvirt-gconfig-capabilities-host-secmodel.c b/libvirt-gconfig/libvirt-gconfig-capabilities-host-secmodel.c index 9cbb585..77e0593 100644 --- a/libvirt-gconfig/libvirt-gconfig-capabilities-host-secmodel.c +++ b/libvirt-gconfig/libvirt-gconfig-capabilities-host-secmodel.c @@ -42,8 +42,6 @@ static void gvir_config_capabilities_host_secmodel_class_init(GVirConfigCapabili static void gvir_config_capabilities_host_secmodel_init(GVirConfigCapabilitiesHostSecModel *secmodel) { - g_debug("Init GVirConfigCapabilitiesHostSecModel=%p", secmodel); - secmodel->priv = GVIR_CONFIG_CAPABILITIES_HOST_SECMODEL_GET_PRIVATE(secmodel); } diff --git a/libvirt-gconfig/libvirt-gconfig-capabilities-host.c b/libvirt-gconfig/libvirt-gconfig-capabilities-host.c index a5d58e8..e26c2d0 100644 --- a/libvirt-gconfig/libvirt-gconfig-capabilities-host.c +++ b/libvirt-gconfig/libvirt-gconfig-capabilities-host.c @@ -45,8 +45,6 @@ static void gvir_config_capabilities_host_class_init(GVirConfigCapabilitiesHostC static void gvir_config_capabilities_host_init(GVirConfigCapabilitiesHost *host) { - g_debug("Init GVirConfigCapabilitiesHost=%p", host); - host->priv = GVIR_CONFIG_CAPABILITIES_HOST_GET_PRIVATE(host); } diff --git a/libvirt-gconfig/libvirt-gconfig-capabilities.c b/libvirt-gconfig/libvirt-gconfig-capabilities.c index 73d56f5..6cc5256 100644 --- a/libvirt-gconfig/libvirt-gconfig-capabilities.c +++ b/libvirt-gconfig/libvirt-gconfig-capabilities.c @@ -45,8 +45,6 @@ static void gvir_config_capabilities_class_init(GVirConfigCapabilitiesClass *kla static void gvir_config_capabilities_init(GVirConfigCapabilities *caps) { - g_debug("Init GVirConfigCapabilities=%p", caps); - caps->priv = GVIR_CONFIG_CAPABILITIES_GET_PRIVATE(caps); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-address-pci.c b/libvirt-gconfig/libvirt-gconfig-domain-address-pci.c index 262352b..4bf94cc 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-address-pci.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-address-pci.c @@ -44,8 +44,6 @@ static void gvir_config_domain_address_pci_class_init(GVirConfigDomainAddressPci static void gvir_config_domain_address_pci_init(GVirConfigDomainAddressPci *address) { - g_debug("Init GVirConfigDomainAddressPci=%p", address); - address->priv = GVIR_CONFIG_DOMAIN_ADDRESS_PCI_GET_PRIVATE(address); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-address-usb.c b/libvirt-gconfig/libvirt-gconfig-domain-address-usb.c index a0a35fe..a794922 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-address-usb.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-address-usb.c @@ -44,8 +44,6 @@ static void gvir_config_domain_address_usb_class_init(GVirConfigDomainAddressUsb static void gvir_config_domain_address_usb_init(GVirConfigDomainAddressUsb *address) { - g_debug("Init GVirConfigDomainAddressUsb=%p", address); - address->priv = GVIR_CONFIG_DOMAIN_ADDRESS_USB_GET_PRIVATE(address); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-address.c b/libvirt-gconfig/libvirt-gconfig-domain-address.c index 57501f5..c0f6ba6 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-address.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-address.c @@ -44,7 +44,5 @@ static void gvir_config_domain_address_class_init(GVirConfigDomainAddressClass * static void gvir_config_domain_address_init(GVirConfigDomainAddress *address) { - g_debug("Init GVirConfigDomainAddress=%p", address); - address->priv = GVIR_CONFIG_DOMAIN_ADDRESS_GET_PRIVATE(address); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-channel.c b/libvirt-gconfig/libvirt-gconfig-domain-channel.c index 9578bf3..20e79e3 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-channel.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-channel.c @@ -44,8 +44,6 @@ static void gvir_config_domain_channel_class_init(GVirConfigDomainChannelClass * static void gvir_config_domain_channel_init(GVirConfigDomainChannel *channel) { - g_debug("Init GVirConfigDomainChannel=%p", channel); - channel->priv = GVIR_CONFIG_DOMAIN_CHANNEL_GET_PRIVATE(channel); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-pty.c b/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-pty.c index a965417..c9fadc8 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-pty.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-pty.c @@ -45,8 +45,6 @@ static void gvir_config_domain_chardev_source_pty_class_init(GVirConfigDomainCha static void gvir_config_domain_chardev_source_pty_init(GVirConfigDomainChardevSourcePty *source) { - g_debug("Init GVirConfigDomainChardevSourcePty=%p", source); - source->priv = GVIR_CONFIG_DOMAIN_CHARDEV_SOURCE_PTY_GET_PRIVATE(source); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-spiceport.c b/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-spiceport.c index e867fa1..98ff221 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-spiceport.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-spiceport.c @@ -42,8 +42,6 @@ static void gvir_config_domain_chardev_source_spiceport_class_init(GVirConfigDom static void gvir_config_domain_chardev_source_spiceport_init(GVirConfigDomainChardevSourceSpicePort *source) { - g_debug("Init GVirConfigDomainChardevSourceSpicePort=%p", source); - source->priv = GVIR_CONFIG_DOMAIN_CHARDEV_SOURCE_SPICE_PORT_GET_PRIVATE(source); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-spicevmc.c b/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-spicevmc.c index 0352a6c..d0b876b 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-spicevmc.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-spicevmc.c @@ -44,8 +44,6 @@ static void gvir_config_domain_chardev_source_spicevmc_class_init(GVirConfigDoma static void gvir_config_domain_chardev_source_spicevmc_init(GVirConfigDomainChardevSourceSpiceVmc *source) { - g_debug("Init GVirConfigDomainChardevSourceSpiceVmc=%p", source); - source->priv = GVIR_CONFIG_DOMAIN_CHARDEV_SOURCE_SPICE_VMC_GET_PRIVATE(source); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-unix.c b/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-unix.c index 162b788..069340f 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-unix.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-unix.c @@ -45,8 +45,6 @@ static void gvir_config_domain_chardev_source_unix_class_init(GVirConfigDomainCh static void gvir_config_domain_chardev_source_unix_init(GVirConfigDomainChardevSourceUnix *source) { - g_debug("Init GVirConfigDomainChardevSourceUnix=%p", source); - source->priv = GVIR_CONFIG_DOMAIN_CHARDEV_SOURCE_UNIX_GET_PRIVATE(source); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-chardev-source.c b/libvirt-gconfig/libvirt-gconfig-domain-chardev-source.c index bbb4c75..117dbe1 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-chardev-source.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-chardev-source.c @@ -45,8 +45,6 @@ static void gvir_config_domain_chardev_source_class_init(GVirConfigDomainChardev static void gvir_config_domain_chardev_source_init(GVirConfigDomainChardevSource *source) { - g_debug("Init GVirConfigDomainChardevSource=%p", source); - source->priv = GVIR_CONFIG_DOMAIN_CHARDEV_SOURCE_GET_PRIVATE(source); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-chardev.c b/libvirt-gconfig/libvirt-gconfig-domain-chardev.c index 9847766..fd5e4c9 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-chardev.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-chardev.c @@ -44,8 +44,6 @@ static void gvir_config_domain_chardev_class_init(GVirConfigDomainChardevClass * static void gvir_config_domain_chardev_init(GVirConfigDomainChardev *chardev) { - g_debug("Init GVirConfigDomainChardev=%p", chardev); - chardev->priv = GVIR_CONFIG_DOMAIN_CHARDEV_GET_PRIVATE(chardev); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-clock.c b/libvirt-gconfig/libvirt-gconfig-domain-clock.c index 12516c7..9795565 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-clock.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-clock.c @@ -44,8 +44,6 @@ static void gvir_config_domain_clock_class_init(GVirConfigDomainClockClass *klas static void gvir_config_domain_clock_init(GVirConfigDomainClock *klock) { - g_debug("Init GVirConfigDomainClock=%p", klock); - klock->priv = GVIR_CONFIG_DOMAIN_CLOCK_GET_PRIVATE(klock); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-console.c b/libvirt-gconfig/libvirt-gconfig-domain-console.c index 20f8b9c..5192870 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-console.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-console.c @@ -44,8 +44,6 @@ static void gvir_config_domain_console_class_init(GVirConfigDomainConsoleClass * static void gvir_config_domain_console_init(GVirConfigDomainConsole *console) { - g_debug("Init GVirConfigDomainConsole=%p", console); - console->priv = GVIR_CONFIG_DOMAIN_CONSOLE_GET_PRIVATE(console); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-controller-usb.c b/libvirt-gconfig/libvirt-gconfig-domain-controller-usb.c index c910a84..4262465 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-controller-usb.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-controller-usb.c @@ -122,8 +122,6 @@ static void gvir_config_domain_controller_usb_class_init(GVirConfigDomainControl static void gvir_config_domain_controller_usb_init(GVirConfigDomainControllerUsb *controller_usb) { - g_debug("Init GVirConfigDomainControllerUsb=%p", controller_usb); - controller_usb->priv = GVIR_CONFIG_DOMAIN_CONTROLLER_USB_GET_PRIVATE(controller_usb); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-controller.c b/libvirt-gconfig/libvirt-gconfig-domain-controller.c index f318219..82994fe 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-controller.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-controller.c @@ -44,8 +44,6 @@ static void gvir_config_domain_controller_class_init(GVirConfigDomainControllerC static void gvir_config_domain_controller_init(GVirConfigDomainController *controller) { - g_debug("Init GVirConfigDomainController=%p", controller); - controller->priv = GVIR_CONFIG_DOMAIN_CONTROLLER_GET_PRIVATE(controller); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-cpu-feature.c b/libvirt-gconfig/libvirt-gconfig-domain-cpu-feature.c index c29a44e..dc5fa4e 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-cpu-feature.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-cpu-feature.c @@ -44,8 +44,6 @@ static void gvir_config_domain_cpu_feature_class_init(GVirConfigDomainCpuFeature static void gvir_config_domain_cpu_feature_init(GVirConfigDomainCpuFeature *feature) { - g_debug("Init GVirConfigDomainCpuFeature=%p", feature); - feature->priv = GVIR_CONFIG_DOMAIN_CPU_FEATURE_GET_PRIVATE(feature); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-cpu-model.c b/libvirt-gconfig/libvirt-gconfig-domain-cpu-model.c index 03024a6..06a3ec8 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-cpu-model.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-cpu-model.c @@ -44,8 +44,6 @@ static void gvir_config_domain_cpu_model_class_init(GVirConfigDomainCpuModelClas static void gvir_config_domain_cpu_model_init(GVirConfigDomainCpuModel *model) { - g_debug("Init GVirConfigDomainCpuModel=%p", model); - model->priv = GVIR_CONFIG_DOMAIN_CPU_MODEL_GET_PRIVATE(model); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-cpu.c b/libvirt-gconfig/libvirt-gconfig-domain-cpu.c index 0037763..2dffae3 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-cpu.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-cpu.c @@ -52,8 +52,6 @@ static void gvir_config_domain_cpu_class_init(GVirConfigDomainCpuClass *klass) static void gvir_config_domain_cpu_init(GVirConfigDomainCpu *cpu) { - g_debug("Init GVirConfigDomainCpu=%p", cpu); - cpu->priv = GVIR_CONFIG_DOMAIN_CPU_GET_PRIVATE(cpu); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-device.c b/libvirt-gconfig/libvirt-gconfig-domain-device.c index 7c97a0f..3d2b9b3 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-device.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-device.c @@ -44,8 +44,6 @@ static void gvir_config_domain_device_class_init(GVirConfigDomainDeviceClass *kl static void gvir_config_domain_device_init(GVirConfigDomainDevice *device) { - g_debug("Init GVirConfigDomainDevice=%p", device); - device->priv = GVIR_CONFIG_DOMAIN_DEVICE_GET_PRIVATE(device); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-disk-driver.c b/libvirt-gconfig/libvirt-gconfig-domain-disk-driver.c index ddf7ce2..fb05e18 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-disk-driver.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-disk-driver.c @@ -44,8 +44,6 @@ static void gvir_config_domain_disk_driver_class_init(GVirConfigDomainDiskDriver static void gvir_config_domain_disk_driver_init(GVirConfigDomainDiskDriver *driver) { - g_debug("Init GVirConfigDomainDiskDriver=%p", driver); - driver->priv = GVIR_CONFIG_DOMAIN_DISK_DRIVER_GET_PRIVATE(driver); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-disk.c b/libvirt-gconfig/libvirt-gconfig-domain-disk.c index 85d2bea..75aaa12 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-disk.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-disk.c @@ -44,8 +44,6 @@ static void gvir_config_domain_disk_class_init(GVirConfigDomainDiskClass *klass) static void gvir_config_domain_disk_init(GVirConfigDomainDisk *disk) { - g_debug("Init GVirConfigDomainDisk=%p", disk); - disk->priv = GVIR_CONFIG_DOMAIN_DISK_GET_PRIVATE(disk); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-filesys.c b/libvirt-gconfig/libvirt-gconfig-domain-filesys.c index 97b7bd6..56c3a01 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-filesys.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-filesys.c @@ -44,8 +44,6 @@ static void gvir_config_domain_filesys_class_init(GVirConfigDomainFilesysClass * static void gvir_config_domain_filesys_init(GVirConfigDomainFilesys *filesys) { - g_debug("Init GVirConfigDomainFilesys=%p", filesys); - filesys->priv = GVIR_CONFIG_DOMAIN_FILESYS_GET_PRIVATE(filesys); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-graphics-desktop.c b/libvirt-gconfig/libvirt-gconfig-domain-graphics-desktop.c index a7743f6..dadf684 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-graphics-desktop.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-graphics-desktop.c @@ -44,8 +44,6 @@ static void gvir_config_domain_graphics_desktop_class_init(GVirConfigDomainGraph static void gvir_config_domain_graphics_desktop_init(GVirConfigDomainGraphicsDesktop *graphics_desktop) { - g_debug("Init GVirConfigDomainGraphicsDesktop=%p", graphics_desktop); - graphics_desktop->priv = GVIR_CONFIG_DOMAIN_GRAPHICS_DESKTOP_GET_PRIVATE(graphics_desktop); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-graphics-rdp.c b/libvirt-gconfig/libvirt-gconfig-domain-graphics-rdp.c index 3d8357d..7a2cb4d 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-graphics-rdp.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-graphics-rdp.c @@ -44,8 +44,6 @@ static void gvir_config_domain_graphics_rdp_class_init(GVirConfigDomainGraphicsR static void gvir_config_domain_graphics_rdp_init(GVirConfigDomainGraphicsRdp *graphics_rdp) { - g_debug("Init GVirConfigDomainGraphicsRdp=%p", graphics_rdp); - graphics_rdp->priv = GVIR_CONFIG_DOMAIN_GRAPHICS_RDP_GET_PRIVATE(graphics_rdp); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-graphics-sdl.c b/libvirt-gconfig/libvirt-gconfig-domain-graphics-sdl.c index 2097383..1740494 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-graphics-sdl.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-graphics-sdl.c @@ -44,8 +44,6 @@ static void gvir_config_domain_graphics_sdl_class_init(GVirConfigDomainGraphicsS static void gvir_config_domain_graphics_sdl_init(GVirConfigDomainGraphicsSdl *graphics_sdl) { - g_debug("Init GVirConfigDomainGraphicsSdl=%p", graphics_sdl); - graphics_sdl->priv = GVIR_CONFIG_DOMAIN_GRAPHICS_SDL_GET_PRIVATE(graphics_sdl); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.c b/libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.c index 39e1a3e..c8b45d6 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.c @@ -45,8 +45,6 @@ static void gvir_config_domain_graphics_spice_class_init(GVirConfigDomainGraphic static void gvir_config_domain_graphics_spice_init(GVirConfigDomainGraphicsSpice *graphics_spice) { - g_debug("Init GVirConfigDomainGraphicsSpice=%p", graphics_spice); - graphics_spice->priv = GVIR_CONFIG_DOMAIN_GRAPHICS_SPICE_GET_PRIVATE(graphics_spice); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.c b/libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.c index 5b3059c..fc26bb9 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.c @@ -44,8 +44,6 @@ static void gvir_config_domain_graphics_vnc_class_init(GVirConfigDomainGraphicsV static void gvir_config_domain_graphics_vnc_init(GVirConfigDomainGraphicsVnc *graphics_vnc) { - g_debug("Init GVirConfigDomainGraphicsVnc=%p", graphics_vnc); - graphics_vnc->priv = GVIR_CONFIG_DOMAIN_GRAPHICS_VNC_GET_PRIVATE(graphics_vnc); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-graphics.c b/libvirt-gconfig/libvirt-gconfig-domain-graphics.c index e42e0cc..8b06e95 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-graphics.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-graphics.c @@ -44,8 +44,6 @@ static void gvir_config_domain_graphics_class_init(GVirConfigDomainGraphicsClass static void gvir_config_domain_graphics_init(GVirConfigDomainGraphics *graphics) { - g_debug("Init GVirConfigDomainGraphics=%p", graphics); - graphics->priv = GVIR_CONFIG_DOMAIN_GRAPHICS_GET_PRIVATE(graphics); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-input.c b/libvirt-gconfig/libvirt-gconfig-domain-input.c index e87c61c..7734c61 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-input.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-input.c @@ -44,8 +44,6 @@ static void gvir_config_domain_input_class_init(GVirConfigDomainInputClass *klas static void gvir_config_domain_input_init(GVirConfigDomainInput *device_input) { - g_debug("Init GVirConfigDomainInput=%p", device_input); - device_input->priv = GVIR_CONFIG_DOMAIN_INPUT_GET_PRIVATE(device_input); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-interface-bridge.c b/libvirt-gconfig/libvirt-gconfig-domain-interface-bridge.c index c942200..a10b3c1 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-interface-bridge.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-interface-bridge.c @@ -47,8 +47,6 @@ static void gvir_config_domain_interface_bridge_class_init(GVirConfigDomainInter static void gvir_config_domain_interface_bridge_init(GVirConfigDomainInterfaceBridge *bridge) { - g_debug("Init GVirConfigDomainInterfaceBridge=%p", bridge); - bridge->priv = GVIR_CONFIG_DOMAIN_INTERFACE_BRIDGE_GET_PRIVATE(bridge); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-interface-filterref-parameter.c b/libvirt-gconfig/libvirt-gconfig-domain-interface-filterref-parameter.c index f11fe29..abca213 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-interface-filterref-parameter.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-interface-filterref-parameter.c @@ -44,8 +44,6 @@ static void gvir_config_domain_interface_filterref_parameter_class_init(GVirConf static void gvir_config_domain_interface_filterref_parameter_init(GVirConfigDomainInterfaceFilterrefParameter *parameter) { - g_debug("Init GVirConfigDomainInterfaceFilterrefParameter=%p", parameter); - parameter->priv = GVIR_CONFIG_DOMAIN_INTERFACE_FILTERREF_PARAMETER_GET_PRIVATE(parameter); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-interface-filterref.c b/libvirt-gconfig/libvirt-gconfig-domain-interface-filterref.c index 0d90173..132d9f5 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-interface-filterref.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-interface-filterref.c @@ -43,8 +43,6 @@ static void gvir_config_domain_interface_filterref_class_init(GVirConfigDomainIn static void gvir_config_domain_interface_filterref_init(GVirConfigDomainInterfaceFilterref *filterref) { - g_debug("Init GVirConfigDomainInterfaceFilterref=%p", filterref); - filterref->priv = GVIR_CONFIG_DOMAIN_INTERFACE_FILTERREF_GET_PRIVATE(filterref); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-interface-network.c b/libvirt-gconfig/libvirt-gconfig-domain-interface-network.c index 8c0c920..27ad6ed 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-interface-network.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-interface-network.c @@ -46,8 +46,6 @@ static void gvir_config_domain_interface_network_class_init(GVirConfigDomainInte static void gvir_config_domain_interface_network_init(GVirConfigDomainInterfaceNetwork *iface) { - g_debug("Init GVirConfigDomainInterfaceNetwork=%p", iface); - iface->priv = GVIR_CONFIG_DOMAIN_INTERFACE_NETWORK_GET_PRIVATE(iface); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-interface-user.c b/libvirt-gconfig/libvirt-gconfig-domain-interface-user.c index 2f844dd..d5672d6 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-interface-user.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-interface-user.c @@ -46,8 +46,6 @@ static void gvir_config_domain_interface_user_class_init(GVirConfigDomainInterfa static void gvir_config_domain_interface_user_init(GVirConfigDomainInterfaceUser *iface) { - g_debug("Init GVirConfigDomainInterfaceUser=%p", iface); - iface->priv = GVIR_CONFIG_DOMAIN_INTERFACE_USER_GET_PRIVATE(iface); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-interface.c b/libvirt-gconfig/libvirt-gconfig-domain-interface.c index ce1b3f0..c5b57bd 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-interface.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-interface.c @@ -46,8 +46,6 @@ static void gvir_config_domain_interface_class_init(GVirConfigDomainInterfaceCla static void gvir_config_domain_interface_init(GVirConfigDomainInterface *interface) { - g_debug("Init GVirConfigDomainInterface=%p", interface); - interface->priv = GVIR_CONFIG_DOMAIN_INTERFACE_GET_PRIVATE(interface); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-memballoon.c b/libvirt-gconfig/libvirt-gconfig-domain-memballoon.c index f33d89c..c5d7768 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-memballoon.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-memballoon.c @@ -44,8 +44,6 @@ static void gvir_config_domain_memballoon_class_init(GVirConfigDomainMemballoonC static void gvir_config_domain_memballoon_init(GVirConfigDomainMemballoon *memballoon) { - g_debug("Init GVirConfigDomainMemballoon=%p", memballoon); - memballoon->priv = GVIR_CONFIG_DOMAIN_MEMBALLOON_GET_PRIVATE(memballoon); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-os.c b/libvirt-gconfig/libvirt-gconfig-domain-os.c index 429f75a..9a00ef4 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-os.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-os.c @@ -44,8 +44,6 @@ static void gvir_config_domain_os_class_init(GVirConfigDomainOsClass *klass) static void gvir_config_domain_os_init(GVirConfigDomainOs *os) { - g_debug("Init GVirConfigDomainOs=%p", os); - os->priv = GVIR_CONFIG_DOMAIN_OS_GET_PRIVATE(os); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-parallel.c b/libvirt-gconfig/libvirt-gconfig-domain-parallel.c index a31e755..f48d1b6 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-parallel.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-parallel.c @@ -43,8 +43,6 @@ static void gvir_config_domain_parallel_class_init(GVirConfigDomainParallelClass static void gvir_config_domain_parallel_init(GVirConfigDomainParallel *parallel) { - g_debug("Init GVirConfigDomainParallel=%p", parallel); - parallel->priv = GVIR_CONFIG_DOMAIN_PARALLEL_GET_PRIVATE(parallel); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-power-management.c b/libvirt-gconfig/libvirt-gconfig-domain-power-management.c index 0306170..c070a0f 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-power-management.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-power-management.c @@ -52,8 +52,6 @@ static void gvir_config_domain_power_management_class_init static void gvir_config_domain_power_management_init(GVirConfigDomainPowerManagement *pm) { - g_debug("Init GVirConfigDomainPowerManagement=%p", pm); - pm->priv = GVIR_CONFIG_DOMAIN_POWER_MANAGEMENT_GET_PRIVATE(pm); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-redirdev.c b/libvirt-gconfig/libvirt-gconfig-domain-redirdev.c index 7260f4f..5fd4dda 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-redirdev.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-redirdev.c @@ -44,8 +44,6 @@ static void gvir_config_domain_redirdev_class_init(GVirConfigDomainRedirdevClass static void gvir_config_domain_redirdev_init(GVirConfigDomainRedirdev *redirdev) { - g_debug("Init GVirConfigDomainRedirdev=%p", redirdev); - redirdev->priv = GVIR_CONFIG_DOMAIN_REDIRDEV_GET_PRIVATE(redirdev); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-seclabel.c b/libvirt-gconfig/libvirt-gconfig-domain-seclabel.c index 032672a..77d8aa0 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-seclabel.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-seclabel.c @@ -44,8 +44,6 @@ static void gvir_config_domain_seclabel_class_init(GVirConfigDomainSeclabelClass static void gvir_config_domain_seclabel_init(GVirConfigDomainSeclabel *seclabel) { - g_debug("Init GVirConfigDomainSeclabel=%p", seclabel); - seclabel->priv = GVIR_CONFIG_DOMAIN_SECLABEL_GET_PRIVATE(seclabel); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-serial.c b/libvirt-gconfig/libvirt-gconfig-domain-serial.c index a3f7e6d..84adb2a 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-serial.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-serial.c @@ -43,8 +43,6 @@ static void gvir_config_domain_serial_class_init(GVirConfigDomainSerialClass *kl static void gvir_config_domain_serial_init(GVirConfigDomainSerial *serial) { - g_debug("Init GVirConfigDomainSerial=%p", serial); - serial->priv = GVIR_CONFIG_DOMAIN_SERIAL_GET_PRIVATE(serial); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-smartcard-host-certificates.c b/libvirt-gconfig/libvirt-gconfig-domain-smartcard-host-certificates.c index 873d16c..ab5abc4 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-smartcard-host-certificates.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-smartcard-host-certificates.c @@ -44,8 +44,6 @@ static void gvir_config_domain_smartcard_host_certificates_class_init(GVirConfig static void gvir_config_domain_smartcard_host_certificates_init(GVirConfigDomainSmartcardHostCertificates *smartcard) { - g_debug("Init GVirConfigDomainSmartcardHostCertificates=%p", smartcard); - smartcard->priv = GVIR_CONFIG_DOMAIN_SMARTCARD_HOST_CERTIFICATES_GET_PRIVATE(smartcard); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-smartcard-host.c b/libvirt-gconfig/libvirt-gconfig-domain-smartcard-host.c index 437f2c8..b29e07b 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-smartcard-host.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-smartcard-host.c @@ -44,8 +44,6 @@ static void gvir_config_domain_smartcard_host_class_init(GVirConfigDomainSmartca static void gvir_config_domain_smartcard_host_init(GVirConfigDomainSmartcardHost *smartcard) { - g_debug("Init GVirConfigDomainSmartcardHost=%p", smartcard); - smartcard->priv = GVIR_CONFIG_DOMAIN_SMARTCARD_HOST_GET_PRIVATE(smartcard); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-smartcard-passthrough.c b/libvirt-gconfig/libvirt-gconfig-domain-smartcard-passthrough.c index 50f84e3..830faa4 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-smartcard-passthrough.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-smartcard-passthrough.c @@ -44,8 +44,6 @@ static void gvir_config_domain_smartcard_passthrough_class_init(GVirConfigDomain static void gvir_config_domain_smartcard_passthrough_init(GVirConfigDomainSmartcardPassthrough *smartcard) { - g_debug("Init GVirConfigDomainSmartcardPassthrough=%p", smartcard); - smartcard->priv = GVIR_CONFIG_DOMAIN_SMARTCARD_PASSTHROUGH_GET_PRIVATE(smartcard); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-smartcard.c b/libvirt-gconfig/libvirt-gconfig-domain-smartcard.c index d5316c0..7900c1a 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-smartcard.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-smartcard.c @@ -44,8 +44,6 @@ static void gvir_config_domain_smartcard_class_init(GVirConfigDomainSmartcardCla static void gvir_config_domain_smartcard_init(GVirConfigDomainSmartcard *smartcard) { - g_debug("Init GVirConfigDomainSmartcard=%p", smartcard); - smartcard->priv = GVIR_CONFIG_DOMAIN_SMARTCARD_GET_PRIVATE(smartcard); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-snapshot-disk.c b/libvirt-gconfig/libvirt-gconfig-domain-snapshot-disk.c index 3907bbb..ba7a40e 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-snapshot-disk.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-snapshot-disk.c @@ -45,8 +45,6 @@ static void gvir_config_domain_snapshot_disk_class_init(GVirConfigDomainSnapshot static void gvir_config_domain_snapshot_disk_init(GVirConfigDomainSnapshotDisk *disk) { - g_debug("Init GVirConfigDomainSnapshotDisk=%p", disk); - disk->priv = GVIR_CONFIG_DOMAIN_SNAPSHOT_DISK_GET_PRIVATE(disk); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-snapshot.c b/libvirt-gconfig/libvirt-gconfig-domain-snapshot.c index fc9a130..69b7df7 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-snapshot.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-snapshot.c @@ -46,8 +46,6 @@ static void gvir_config_domain_snapshot_class_init(GVirConfigDomainSnapshotClass static void gvir_config_domain_snapshot_init(GVirConfigDomainSnapshot *snapshot) { - g_debug("Init GVirConfigDomainSnapshot=%p", snapshot); - snapshot->priv = GVIR_CONFIG_DOMAIN_SNAPSHOT_GET_PRIVATE(snapshot); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-sound.c b/libvirt-gconfig/libvirt-gconfig-domain-sound.c index a1f5749..7ce71bd 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-sound.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-sound.c @@ -44,8 +44,6 @@ static void gvir_config_domain_sound_class_init(GVirConfigDomainSoundClass *klas static void gvir_config_domain_sound_init(GVirConfigDomainSound *sound) { - g_debug("Init GVirConfigDomainSound=%p", sound); - sound->priv = GVIR_CONFIG_DOMAIN_SOUND_GET_PRIVATE(sound); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-timer-hpet.c b/libvirt-gconfig/libvirt-gconfig-domain-timer-hpet.c index 1734428..ba74a28 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-timer-hpet.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-timer-hpet.c @@ -44,8 +44,6 @@ static void gvir_config_domain_timer_hpet_class_init(GVirConfigDomainTimerHpetCl static void gvir_config_domain_timer_hpet_init(GVirConfigDomainTimerHpet *timer) { - g_debug("Init GVirConfigDomainTimerHpet=%p", timer); - timer->priv = GVIR_CONFIG_DOMAIN_TIMER_HPET_GET_PRIVATE(timer); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-timer-pit.c b/libvirt-gconfig/libvirt-gconfig-domain-timer-pit.c index 975b372..af979b2 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-timer-pit.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-timer-pit.c @@ -44,8 +44,6 @@ static void gvir_config_domain_timer_pit_class_init(GVirConfigDomainTimerPitClas static void gvir_config_domain_timer_pit_init(GVirConfigDomainTimerPit *timer) { - g_debug("Init GVirConfigDomainTimerPit=%p", timer); - timer->priv = GVIR_CONFIG_DOMAIN_TIMER_PIT_GET_PRIVATE(timer); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-timer-rtc.c b/libvirt-gconfig/libvirt-gconfig-domain-timer-rtc.c index 1ae0542..0adcc66 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-timer-rtc.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-timer-rtc.c @@ -44,8 +44,6 @@ static void gvir_config_domain_timer_rtc_class_init(GVirConfigDomainTimerRtcClas static void gvir_config_domain_timer_rtc_init(GVirConfigDomainTimerRtc *timer) { - g_debug("Init GVirConfigDomainTimerRtc=%p", timer); - timer->priv = GVIR_CONFIG_DOMAIN_TIMER_RTC_GET_PRIVATE(timer); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-timer.c b/libvirt-gconfig/libvirt-gconfig-domain-timer.c index 2d778dd..e89e111 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-timer.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-timer.c @@ -44,8 +44,6 @@ static void gvir_config_domain_timer_class_init(GVirConfigDomainTimerClass *klas static void gvir_config_domain_timer_init(GVirConfigDomainTimer *timer) { - g_debug("Init GVirConfigDomainTimer=%p", timer); - timer->priv = GVIR_CONFIG_DOMAIN_TIMER_GET_PRIVATE(timer); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-video.c b/libvirt-gconfig/libvirt-gconfig-domain-video.c index 0330e9d..ba03c5a 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-video.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-video.c @@ -45,8 +45,6 @@ static void gvir_config_domain_video_class_init(GVirConfigDomainVideoClass *klas static void gvir_config_domain_video_init(GVirConfigDomainVideo *video) { - g_debug("Init GVirConfigDomainVideo=%p", video); - video->priv = GVIR_CONFIG_DOMAIN_VIDEO_GET_PRIVATE(video); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain.c b/libvirt-gconfig/libvirt-gconfig-domain.c index 8a6c676..de84fd4 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain.c +++ b/libvirt-gconfig/libvirt-gconfig-domain.c @@ -205,8 +205,6 @@ static void gvir_config_domain_class_init(GVirConfigDomainClass *klass) static void gvir_config_domain_init(GVirConfigDomain *domain) { - g_debug("Init GVirConfigDomain=%p", domain); - domain->priv = GVIR_CONFIG_DOMAIN_GET_PRIVATE(domain); } diff --git a/libvirt-gconfig/libvirt-gconfig-interface.c b/libvirt-gconfig/libvirt-gconfig-interface.c index 521455c..6c81325 100644 --- a/libvirt-gconfig/libvirt-gconfig-interface.c +++ b/libvirt-gconfig/libvirt-gconfig-interface.c @@ -44,8 +44,6 @@ static void gvir_config_interface_class_init(GVirConfigInterfaceClass *klass) static void gvir_config_interface_init(GVirConfigInterface *iface) { - g_debug("Init GVirConfigInterface=%p", iface); - iface->priv = GVIR_CONFIG_INTERFACE_GET_PRIVATE(iface); } diff --git a/libvirt-gconfig/libvirt-gconfig-network-filter.c b/libvirt-gconfig/libvirt-gconfig-network-filter.c index 68c5c79..eddf05c 100644 --- a/libvirt-gconfig/libvirt-gconfig-network-filter.c +++ b/libvirt-gconfig/libvirt-gconfig-network-filter.c @@ -44,8 +44,6 @@ static void gvir_config_network_filter_class_init(GVirConfigNetworkFilterClass * static void gvir_config_network_filter_init(GVirConfigNetworkFilter *filter) { - g_debug("Init GVirConfigNetworkFilter=%p", filter); - filter->priv = GVIR_CONFIG_NETWORK_FILTER_GET_PRIVATE(filter); } diff --git a/libvirt-gconfig/libvirt-gconfig-network.c b/libvirt-gconfig/libvirt-gconfig-network.c index e14b9c7..963d056 100644 --- a/libvirt-gconfig/libvirt-gconfig-network.c +++ b/libvirt-gconfig/libvirt-gconfig-network.c @@ -44,8 +44,6 @@ static void gvir_config_network_class_init(GVirConfigNetworkClass *klass) static void gvir_config_network_init(GVirConfigNetwork *network) { - g_debug("Init GVirConfigNetwork=%p", network); - network->priv = GVIR_CONFIG_NETWORK_GET_PRIVATE(network); } diff --git a/libvirt-gconfig/libvirt-gconfig-node-device.c b/libvirt-gconfig/libvirt-gconfig-node-device.c index eab4aab..b89690f 100644 --- a/libvirt-gconfig/libvirt-gconfig-node-device.c +++ b/libvirt-gconfig/libvirt-gconfig-node-device.c @@ -44,8 +44,6 @@ static void gvir_config_node_device_class_init(GVirConfigNodeDeviceClass *klass) static void gvir_config_node_device_init(GVirConfigNodeDevice *device) { - g_debug("Init GVirConfigNodeDevice=%p", device); - device->priv = GVIR_CONFIG_NODE_DEVICE_GET_PRIVATE(device); } diff --git a/libvirt-gconfig/libvirt-gconfig-object.c b/libvirt-gconfig/libvirt-gconfig-object.c index 5557165..bf328f3 100644 --- a/libvirt-gconfig/libvirt-gconfig-object.c +++ b/libvirt-gconfig/libvirt-gconfig-object.c @@ -123,8 +123,6 @@ static void gvir_config_object_finalize(GObject *object) GVirConfigObject *gvir_object = GVIR_CONFIG_OBJECT(object); GVirConfigObjectPrivate *priv = gvir_object->priv; - g_debug("Finalize GVirConfigObject=%p", gvir_object); - g_free(priv->schema); if (priv->doc != NULL) { @@ -184,8 +182,6 @@ static void gvir_config_object_class_init(GVirConfigObjectClass *klass) static void gvir_config_object_init(GVirConfigObject *object) { - g_debug("Init GVirConfigObject=%p", object); - object->priv = GVIR_CONFIG_OBJECT_GET_PRIVATE(object); } diff --git a/libvirt-gconfig/libvirt-gconfig-secret.c b/libvirt-gconfig/libvirt-gconfig-secret.c index c2dbcff..73a3fc3 100644 --- a/libvirt-gconfig/libvirt-gconfig-secret.c +++ b/libvirt-gconfig/libvirt-gconfig-secret.c @@ -44,8 +44,6 @@ static void gvir_config_secret_class_init(GVirConfigSecretClass *klass) static void gvir_config_secret_init(GVirConfigSecret *secret) { - g_debug("Init GVirConfigSecret=%p", secret); - secret->priv = GVIR_CONFIG_SECRET_GET_PRIVATE(secret); } diff --git a/libvirt-gconfig/libvirt-gconfig-storage-permissions.c b/libvirt-gconfig/libvirt-gconfig-storage-permissions.c index 066ee11..79c3b9e 100644 --- a/libvirt-gconfig/libvirt-gconfig-storage-permissions.c +++ b/libvirt-gconfig/libvirt-gconfig-storage-permissions.c @@ -44,8 +44,6 @@ static void gvir_config_storage_permissions_class_init(GVirConfigStoragePermissi static void gvir_config_storage_permissions_init(GVirConfigStoragePermissions *perms) { - g_debug("Init GVirConfigStoragePermissions=%p", perms); - perms->priv = GVIR_CONFIG_STORAGE_PERMISSIONS_GET_PRIVATE(perms); } diff --git a/libvirt-gconfig/libvirt-gconfig-storage-pool-source.c b/libvirt-gconfig/libvirt-gconfig-storage-pool-source.c index ad8b28d..07af50b 100644 --- a/libvirt-gconfig/libvirt-gconfig-storage-pool-source.c +++ b/libvirt-gconfig/libvirt-gconfig-storage-pool-source.c @@ -45,8 +45,6 @@ static void gvir_config_storage_pool_source_class_init(GVirConfigStoragePoolSour static void gvir_config_storage_pool_source_init(GVirConfigStoragePoolSource *source) { - g_debug("Init GVirConfigStoragePoolSource=%p", source); - source->priv = GVIR_CONFIG_STORAGE_POOL_SOURCE_GET_PRIVATE(source); } diff --git a/libvirt-gconfig/libvirt-gconfig-storage-pool-target.c b/libvirt-gconfig/libvirt-gconfig-storage-pool-target.c index f76b26c..72ea21d 100644 --- a/libvirt-gconfig/libvirt-gconfig-storage-pool-target.c +++ b/libvirt-gconfig/libvirt-gconfig-storage-pool-target.c @@ -45,8 +45,6 @@ static void gvir_config_storage_pool_target_class_init(GVirConfigStoragePoolTarg static void gvir_config_storage_pool_target_init(GVirConfigStoragePoolTarget *target) { - g_debug("Init GVirConfigStoragePoolTarget=%p", target); - target->priv = GVIR_CONFIG_STORAGE_POOL_TARGET_GET_PRIVATE(target); } diff --git a/libvirt-gconfig/libvirt-gconfig-storage-pool.c b/libvirt-gconfig/libvirt-gconfig-storage-pool.c index 87caeb6..0c7940d 100644 --- a/libvirt-gconfig/libvirt-gconfig-storage-pool.c +++ b/libvirt-gconfig/libvirt-gconfig-storage-pool.c @@ -46,8 +46,6 @@ static void gvir_config_storage_pool_class_init(GVirConfigStoragePoolClass *klas static void gvir_config_storage_pool_init(GVirConfigStoragePool *pool) { - g_debug("Init GVirConfigStoragePool=%p", pool); - pool->priv = GVIR_CONFIG_STORAGE_POOL_GET_PRIVATE(pool); } diff --git a/libvirt-gconfig/libvirt-gconfig-storage-vol-backing-store.c b/libvirt-gconfig/libvirt-gconfig-storage-vol-backing-store.c index 9fa648d..14a0e22 100644 --- a/libvirt-gconfig/libvirt-gconfig-storage-vol-backing-store.c +++ b/libvirt-gconfig/libvirt-gconfig-storage-vol-backing-store.c @@ -45,8 +45,6 @@ static void gvir_config_storage_vol_backing_store_class_init(GVirConfigStorageVo static void gvir_config_storage_vol_backing_store_init(GVirConfigStorageVolBackingStore *backing_store) { - g_debug("Init GVirConfigStorageVolBackingStore=%p", backing_store); - backing_store->priv = GVIR_CONFIG_STORAGE_VOL_BACKING_STORE_GET_PRIVATE(backing_store); } diff --git a/libvirt-gconfig/libvirt-gconfig-storage-vol-target.c b/libvirt-gconfig/libvirt-gconfig-storage-vol-target.c index b72b304..cf4c0c7 100644 --- a/libvirt-gconfig/libvirt-gconfig-storage-vol-target.c +++ b/libvirt-gconfig/libvirt-gconfig-storage-vol-target.c @@ -45,8 +45,6 @@ static void gvir_config_storage_vol_target_class_init(GVirConfigStorageVolTarget static void gvir_config_storage_vol_target_init(GVirConfigStorageVolTarget *target) { - g_debug("Init GVirConfigStorageVolTarget=%p", target); - target->priv = GVIR_CONFIG_STORAGE_VOL_TARGET_GET_PRIVATE(target); } diff --git a/libvirt-gconfig/libvirt-gconfig-storage-vol.c b/libvirt-gconfig/libvirt-gconfig-storage-vol.c index 6690dd7..2dade7e 100644 --- a/libvirt-gconfig/libvirt-gconfig-storage-vol.c +++ b/libvirt-gconfig/libvirt-gconfig-storage-vol.c @@ -46,8 +46,6 @@ static void gvir_config_storage_vol_class_init(GVirConfigStorageVolClass *klass) static void gvir_config_storage_vol_init(GVirConfigStorageVol *vol) { - g_debug("Init GVirConfigStorageVol=%p", vol); - vol->priv = GVIR_CONFIG_STORAGE_VOL_GET_PRIVATE(vol); } diff --git a/libvirt-gconfig/libvirt-gconfig-xml-doc.c b/libvirt-gconfig/libvirt-gconfig-xml-doc.c index d7a5ea9..d17da21 100644 --- a/libvirt-gconfig/libvirt-gconfig-xml-doc.c +++ b/libvirt-gconfig/libvirt-gconfig-xml-doc.c @@ -81,8 +81,6 @@ static void gvir_config_xml_doc_finalize(GObject *object) GVirConfigXmlDoc *doc = GVIR_CONFIG_XML_DOC(object); GVirConfigXmlDocPrivate *priv = doc->priv; - g_debug("Finalize GVirConfigXmlDoc=%p", doc); - xmlFreeDoc(priv->doc); G_OBJECT_CLASS(gvir_config_xml_doc_parent_class)->finalize(object); @@ -113,8 +111,6 @@ static void gvir_config_xml_doc_init(GVirConfigXmlDoc *xml_doc) { GVirConfigXmlDocPrivate *priv; - g_debug("Init GVirConfigXmlDoc=%p", xml_doc); - priv = xml_doc->priv = GVIR_CONFIG_XML_DOC_GET_PRIVATE(xml_doc); memset(priv, 0, sizeof(*priv)); diff --git a/libvirt-gobject/libvirt-gobject-connection.c b/libvirt-gobject/libvirt-gobject-connection.c index 9e7bb68..61ae364 100644 --- a/libvirt-gobject/libvirt-gobject-connection.c +++ b/libvirt-gobject/libvirt-gobject-connection.c @@ -143,8 +143,6 @@ static void gvir_connection_finalize(GObject *object) GVirConnection *conn = GVIR_CONNECTION(object); GVirConnectionPrivate *priv = conn->priv; - g_debug("Finalize GVirConnection=%p", conn); - if (gvir_connection_is_open(conn)) gvir_connection_close(conn); @@ -241,8 +239,6 @@ static void gvir_connection_init(GVirConnection *conn) { GVirConnectionPrivate *priv; - g_debug("Init GVirConnection=%p", conn); - priv = conn->priv = GVIR_CONNECTION_GET_PRIVATE(conn); priv->lock = g_mutex_new(); diff --git a/libvirt-gobject/libvirt-gobject-domain-device.c b/libvirt-gobject/libvirt-gobject-domain-device.c index cfb849a..8986e44 100644 --- a/libvirt-gobject/libvirt-gobject-domain-device.c +++ b/libvirt-gobject/libvirt-gobject-domain-device.c @@ -101,8 +101,6 @@ static void gvir_domain_device_finalize(GObject *object) GVirDomainDevice *self = GVIR_DOMAIN_DEVICE(object); GVirDomainDevicePrivate *priv = self->priv; - g_debug("Finalize GVirDomainDevice=%p", self); - g_clear_object(&priv->domain); g_clear_object(&priv->config); @@ -142,8 +140,6 @@ static void gvir_domain_device_class_init(GVirDomainDeviceClass *klass) static void gvir_domain_device_init(GVirDomainDevice *self) { - g_debug("Init GVirDomainDevice=%p", self); - self->priv = GVIR_DOMAIN_DEVICE_GET_PRIVATE(self); } diff --git a/libvirt-gobject/libvirt-gobject-domain-disk.c b/libvirt-gobject/libvirt-gobject-domain-disk.c index f276c4a..770acff 100644 --- a/libvirt-gobject/libvirt-gobject-domain-disk.c +++ b/libvirt-gobject/libvirt-gobject-domain-disk.c @@ -53,8 +53,6 @@ static void gvir_domain_disk_finalize(GObject *object) { GVirDomainDisk *self = GVIR_DOMAIN_DISK(object); - g_debug("Finalize GVirDomainDisk=%p", self); - G_OBJECT_CLASS(gvir_domain_disk_parent_class)->finalize(object); } @@ -68,8 +66,6 @@ static void gvir_domain_disk_class_init(GVirDomainDiskClass *klass) static void gvir_domain_disk_init(GVirDomainDisk *self) { - g_debug("Init GVirDomainDisk=%p", self); - self->priv = GVIR_DOMAIN_DISK_GET_PRIVATE(self); } diff --git a/libvirt-gobject/libvirt-gobject-domain-interface.c b/libvirt-gobject/libvirt-gobject-domain-interface.c index d8ad359..57896fd 100644 --- a/libvirt-gobject/libvirt-gobject-domain-interface.c +++ b/libvirt-gobject/libvirt-gobject-domain-interface.c @@ -53,8 +53,6 @@ static void gvir_domain_interface_finalize(GObject *object) { GVirDomainInterface *self = GVIR_DOMAIN_INTERFACE(object); - g_debug("Finalize GVirDomainInterface=%p", self); - G_OBJECT_CLASS(gvir_domain_interface_parent_class)->finalize(object); } @@ -68,8 +66,6 @@ static void gvir_domain_interface_class_init(GVirDomainInterfaceClass *klass) static void gvir_domain_interface_init(GVirDomainInterface *self) { - g_debug("Init GVirDomainInterface=%p", self); - self->priv = GVIR_DOMAIN_INTERFACE_GET_PRIVATE(self); } diff --git a/libvirt-gobject/libvirt-gobject-domain-snapshot.c b/libvirt-gobject/libvirt-gobject-domain-snapshot.c index 8e71612..2a4338b 100644 --- a/libvirt-gobject/libvirt-gobject-domain-snapshot.c +++ b/libvirt-gobject/libvirt-gobject-domain-snapshot.c @@ -101,8 +101,6 @@ static void gvir_domain_snapshot_finalize(GObject *object) GVirDomainSnapshot *snapshot = GVIR_DOMAIN_SNAPSHOT(object); GVirDomainSnapshotPrivate *priv = snapshot->priv; - g_debug("Finalize GVirDomainSnapshot=%p", snapshot); - virDomainSnapshotFree(priv->handle); G_OBJECT_CLASS(gvir_domain_snapshot_parent_class)->finalize(object); @@ -134,8 +132,6 @@ static void gvir_domain_snapshot_class_init(GVirDomainSnapshotClass *klass) static void gvir_domain_snapshot_init(GVirDomainSnapshot *snapshot) { - g_debug("Init GVirDomainSnapshot=%p", snapshot); - snapshot->priv = GVIR_DOMAIN_SNAPSHOT_GET_PRIVATE(snapshot); } diff --git a/libvirt-gobject/libvirt-gobject-domain.c b/libvirt-gobject/libvirt-gobject-domain.c index c768cd3..7bb3b13 100644 --- a/libvirt-gobject/libvirt-gobject-domain.c +++ b/libvirt-gobject/libvirt-gobject-domain.c @@ -135,8 +135,6 @@ static void gvir_domain_finalize(GObject *object) GVirDomain *domain = GVIR_DOMAIN(object); GVirDomainPrivate *priv = domain->priv; - g_debug("Finalize GVirDomain=%p", domain); - if (priv->snapshots) { g_hash_table_unref(priv->snapshots); } @@ -255,8 +253,6 @@ static void gvir_domain_class_init(GVirDomainClass *klass) static void gvir_domain_init(GVirDomain *domain) { - g_debug("Init GVirDomain=%p", domain); - domain->priv = GVIR_DOMAIN_GET_PRIVATE(domain); domain->priv->lock = g_mutex_new(); } diff --git a/libvirt-gobject/libvirt-gobject-input-stream.c b/libvirt-gobject/libvirt-gobject-input-stream.c index 58e3037..788e16e 100644 --- a/libvirt-gobject/libvirt-gobject-input-stream.c +++ b/libvirt-gobject/libvirt-gobject-input-stream.c @@ -88,7 +88,6 @@ static void gvir_input_stream_finalize(GObject *object) { GVirInputStream *stream = GVIR_INPUT_STREAM(object); - g_debug("Finalize input stream GVirStream=%p", stream->priv->stream); stream->priv->stream = NULL; // unowned if (G_OBJECT_CLASS(gvir_input_stream_parent_class)->finalize) diff --git a/libvirt-gobject/libvirt-gobject-interface.c b/libvirt-gobject/libvirt-gobject-interface.c index 6b2df59..ed7421f 100644 --- a/libvirt-gobject/libvirt-gobject-interface.c +++ b/libvirt-gobject/libvirt-gobject-interface.c @@ -101,8 +101,6 @@ static void gvir_interface_finalize(GObject *object) GVirInterface *iface = GVIR_INTERFACE(object); GVirInterfacePrivate *priv = iface->priv; - g_debug("Finalize GVirInterface=%p", iface); - virInterfaceFree(priv->handle); G_OBJECT_CLASS(gvir_interface_parent_class)->finalize(object); @@ -134,8 +132,6 @@ static void gvir_interface_class_init(GVirInterfaceClass *klass) static void gvir_interface_init(GVirInterface *iface) { - g_debug("Init GVirInterface=%p", iface); - iface->priv = GVIR_INTERFACE_GET_PRIVATE(iface); } diff --git a/libvirt-gobject/libvirt-gobject-manager.c b/libvirt-gobject/libvirt-gobject-manager.c index e20343e..bbd5f84 100644 --- a/libvirt-gobject/libvirt-gobject-manager.c +++ b/libvirt-gobject/libvirt-gobject-manager.c @@ -63,8 +63,6 @@ static void gvir_manager_finalize(GObject *object) GVirManager *man = GVIR_MANAGER(object); GVirManagerPrivate *priv = man->priv; - g_debug("Finalize GVirManager=%p", man); - GList *tmp = priv->connections; while (tmp) { GVirConnection *conn = tmp->data; @@ -112,8 +110,6 @@ static void gvir_manager_init(GVirManager *manager) { GVirManagerPrivate *priv; - g_debug("Init GVirManager=%p", manager); - priv = manager->priv = GVIR_MANAGER_GET_PRIVATE(manager); priv->lock = g_mutex_new(); diff --git a/libvirt-gobject/libvirt-gobject-network-dhcp-lease.c b/libvirt-gobject/libvirt-gobject-network-dhcp-lease.c index 90a402b..7d1c979 100644 --- a/libvirt-gobject/libvirt-gobject-network-dhcp-lease.c +++ b/libvirt-gobject/libvirt-gobject-network-dhcp-lease.c @@ -101,8 +101,6 @@ static void gvir_network_dhcp_lease_finalize(GObject *object) GVirNetworkDHCPLeasePrivate *priv = lease->priv; #endif /* HAVE_VIR_NETWORK_GET_DHCP_LEASES */ - g_debug("Finalize GVirNetworkDHCPLease=%p", lease); - #ifdef HAVE_VIR_NETWORK_GET_DHCP_LEASES virNetworkDHCPLeaseFree(priv->handle); #endif /* HAVE_VIR_NETWORK_GET_DHCP_LEASES */ @@ -134,8 +132,6 @@ static void gvir_network_dhcp_lease_class_init(GVirNetworkDHCPLeaseClass *klass) static void gvir_network_dhcp_lease_init(GVirNetworkDHCPLease *lease) { - g_debug("Init GVirNetworkDHCPLease=%p", lease); - lease->priv = GVIR_NETWORK_DHCP_LEASE_GET_PRIVATE(lease); } diff --git a/libvirt-gobject/libvirt-gobject-network-filter.c b/libvirt-gobject/libvirt-gobject-network-filter.c index 60756c0..7c5d6c0 100644 --- a/libvirt-gobject/libvirt-gobject-network-filter.c +++ b/libvirt-gobject/libvirt-gobject-network-filter.c @@ -102,8 +102,6 @@ static void gvir_network_filter_finalize(GObject *object) GVirNetworkFilter *nf = GVIR_NETWORK_FILTER(object); GVirNetworkFilterPrivate *priv = nf->priv; - g_debug("Finalize GVirNetworkFilter=%p", nf); - virNWFilterFree(priv->handle); G_OBJECT_CLASS(gvir_network_filter_parent_class)->finalize(object); @@ -150,8 +148,6 @@ static void gvir_network_filter_class_init(GVirNetworkFilterClass *klass) static void gvir_network_filter_init(GVirNetworkFilter *filter) { - g_debug("Init GVirNetworkFilter=%p", filter); - filter->priv = GVIR_NETWORK_FILTER_GET_PRIVATE(filter); } diff --git a/libvirt-gobject/libvirt-gobject-network.c b/libvirt-gobject/libvirt-gobject-network.c index e666f45..0dd80a5 100644 --- a/libvirt-gobject/libvirt-gobject-network.c +++ b/libvirt-gobject/libvirt-gobject-network.c @@ -105,8 +105,6 @@ static void gvir_network_finalize(GObject *object) GVirNetwork *network = GVIR_NETWORK(object); GVirNetworkPrivate *priv = network->priv; - g_debug("Finalize GVirNetwork=%p", network); - virNetworkFree(priv->handle); G_OBJECT_CLASS(gvir_network_parent_class)->finalize(object); @@ -150,8 +148,6 @@ static void gvir_network_class_init(GVirNetworkClass *klass) static void gvir_network_init(GVirNetwork *network) { - g_debug("Init GVirNetwork=%p", network); - network->priv = GVIR_NETWORK_GET_PRIVATE(network); } diff --git a/libvirt-gobject/libvirt-gobject-node-device.c b/libvirt-gobject/libvirt-gobject-node-device.c index 18394d1..b7b7c9e 100644 --- a/libvirt-gobject/libvirt-gobject-node-device.c +++ b/libvirt-gobject/libvirt-gobject-node-device.c @@ -101,8 +101,6 @@ static void gvir_node_device_finalize(GObject *object) GVirNodeDevice *device = GVIR_NODE_DEVICE(object); GVirNodeDevicePrivate *priv = device->priv; - g_debug("Finalize GVirNodeDevice=%p", device); - virNodeDeviceFree(priv->handle); G_OBJECT_CLASS(gvir_node_device_parent_class)->finalize(object); @@ -134,8 +132,6 @@ static void gvir_node_device_class_init(GVirNodeDeviceClass *klass) static void gvir_node_device_init(GVirNodeDevice *device) { - g_debug("Init GVirNodeDevice=%p", device); - device->priv = GVIR_NODE_DEVICE_GET_PRIVATE(device); } diff --git a/libvirt-gobject/libvirt-gobject-output-stream.c b/libvirt-gobject/libvirt-gobject-output-stream.c index 463b691..97feb80 100644 --- a/libvirt-gobject/libvirt-gobject-output-stream.c +++ b/libvirt-gobject/libvirt-gobject-output-stream.c @@ -88,7 +88,6 @@ static void gvir_output_stream_finalize(GObject *object) { GVirOutputStream *stream = GVIR_OUTPUT_STREAM(object); - g_debug("Finalize output stream GVirStream=%p", stream->priv->stream); stream->priv->stream = NULL; // unowned if (G_OBJECT_CLASS(gvir_output_stream_parent_class)->finalize) diff --git a/libvirt-gobject/libvirt-gobject-secret.c b/libvirt-gobject/libvirt-gobject-secret.c index f03b44c..bf15931 100644 --- a/libvirt-gobject/libvirt-gobject-secret.c +++ b/libvirt-gobject/libvirt-gobject-secret.c @@ -102,8 +102,6 @@ static void gvir_secret_finalize(GObject *object) GVirSecret *secret = GVIR_SECRET(object); GVirSecretPrivate *priv = secret->priv; - g_debug("Finalize GVirSecret=%p", secret); - virSecretFree(priv->handle); G_OBJECT_CLASS(gvir_secret_parent_class)->finalize(object); @@ -149,8 +147,6 @@ static void gvir_secret_class_init(GVirSecretClass *klass) static void gvir_secret_init(GVirSecret *secret) { - g_debug("Init GVirSecret=%p", secret); - secret->priv = GVIR_SECRET_GET_PRIVATE(secret); } diff --git a/libvirt-gobject/libvirt-gobject-storage-pool.c b/libvirt-gobject/libvirt-gobject-storage-pool.c index 5f97691..227bf23 100644 --- a/libvirt-gobject/libvirt-gobject-storage-pool.c +++ b/libvirt-gobject/libvirt-gobject-storage-pool.c @@ -106,8 +106,6 @@ static void gvir_storage_pool_finalize(GObject *object) GVirStoragePool *pool = GVIR_STORAGE_POOL(object); GVirStoragePoolPrivate *priv = pool->priv; - g_debug("Finalize GVirStoragePool=%p", pool); - if (priv->volumes) { g_hash_table_unref(priv->volumes); priv->volumes = NULL; @@ -163,8 +161,6 @@ static void gvir_storage_pool_init(GVirStoragePool *pool) { GVirStoragePoolPrivate *priv; - g_debug("Init GVirStoragePool=%p", pool); - priv = pool->priv = GVIR_STORAGE_POOL_GET_PRIVATE(pool); priv->lock = g_mutex_new(); diff --git a/libvirt-gobject/libvirt-gobject-storage-vol.c b/libvirt-gobject/libvirt-gobject-storage-vol.c index 54bb0c2..18aa8b3 100644 --- a/libvirt-gobject/libvirt-gobject-storage-vol.c +++ b/libvirt-gobject/libvirt-gobject-storage-vol.c @@ -112,8 +112,6 @@ static void gvir_storage_vol_finalize(GObject *object) GVirStorageVol *vol = GVIR_STORAGE_VOL(object); GVirStorageVolPrivate *priv = vol->priv; - g_debug("Finalize GVirStorageVol=%p", vol); - virStorageVolFree(priv->handle); G_OBJECT_CLASS(gvir_storage_vol_parent_class)->finalize(object); @@ -156,8 +154,6 @@ static void gvir_storage_vol_class_init(GVirStorageVolClass *klass) static void gvir_storage_vol_init(GVirStorageVol *vol) { - g_debug("Init GVirStorageVol=%p", vol); - vol->priv = GVIR_STORAGE_VOL_GET_PRIVATE(vol); } diff --git a/libvirt-gobject/libvirt-gobject-stream.c b/libvirt-gobject/libvirt-gobject-stream.c index 00b58be..03a0308 100644 --- a/libvirt-gobject/libvirt-gobject-stream.c +++ b/libvirt-gobject/libvirt-gobject-stream.c @@ -228,8 +228,6 @@ static void gvir_stream_finalize(GObject *object) GVirStreamPrivate *priv = self->priv; GList *tmp; - g_debug("Finalize GVirStream=%p", self); - if (self->priv->input_stream) g_object_unref(self->priv->input_stream); -- 2.5.0

8 years, 11 months

2
1
0 / 0

[libvirt] [PATCH 0/3] virsh: error reporting for empty string parameters

by Ján Tomko

https://bugzilla.redhat.com/show_bug.cgi?id=1281707 Ján Tomko (3): virsh: report errors for empty strings virsh: remove custom error for cpulist from cmdIOThreadPin virsh: rename vshCommandOptString to vshCommandOptStringQuiet tools/virsh-domain-monitor.c | 4 ++-- tools/virsh-domain.c | 34 ++++++++++++++++------------------ tools/virsh-network.c | 4 ++-- tools/virsh-nodedev.c | 4 ++-- tools/virsh-volume.c | 2 +- tools/vsh.c | 12 ++++++------ tools/vsh.h | 4 ++-- 7 files changed, 31 insertions(+), 33 deletions(-) -- 2.4.6

8 years, 11 months

2
4
0 / 0

[libvirt] [PATCH] bridge: check for invalid MAC in networkGetDHCPLeases

by Ján Tomko

Instead of comparing garbage strings against real MAC addresses, introduce an error mesage for unparsable ones: $ virsh net-dhcp-leases default --mac t12 error: Failed to get leases info for default error: invalid MAC address: t12 https://bugzilla.redhat.com/show_bug.cgi?id=1261432 --- src/network/bridge_driver.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index a0f6494..362e294 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -3648,9 +3648,16 @@ networkGetDHCPLeases(virNetworkPtr network, virNetworkDHCPLeasePtr lease = NULL; virNetworkDHCPLeasePtr *leases_ret = NULL; virNetworkObjPtr obj; + virMacAddr mac_addr; virCheckFlags(0, -1); + /* only to check if the MAC is valid */ + if (mac && virMacAddrParse(mac, &mac_addr) < 0) { + virReportError(VIR_ERR_INVALID_MAC, "%s", mac); + return -1; + } + if (!(obj = networkObjFromNetwork(network))) return -1; -- 2.4.6

8 years, 11 months

2
1
0 / 0

[libvirt] [PATCH] libxl: add support for mounts in HVM guests

by Cédric Bosdonnat

Xen HVM guests are running a QEMU, libxl allows passing QEMU parameters in the d_config.b_info.extra list. Take advantage of that to implement support for 9pfs mounts. For this to work, xen's qemu needs to be built with virtfs enabled, or an upstream qemu needs to be used. --- Note that two functions have been picked from the qemu driver's code. src/libxl/libxl_conf.c | 174 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 174 insertions(+) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 4eed5ca..4437e8f 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -55,6 +55,7 @@ VIR_LOG_INIT("libxl.libxl_conf"); /* see xen-unstable.hg/xen/include/asm-x86/cpufeature.h */ #define LIBXL_X86_FEATURE_PAE_MASK 0x40 +#define LIBXL_FSDEV_HOST_PREFIX "fsdev-" struct guest_arch { virArch arch; @@ -84,6 +85,15 @@ static int libxlConfigOnceInit(void) VIR_ONCE_GLOBAL_INIT(libxlConfig) +VIR_ENUM_DECL(libxlDomainFSDriver) +VIR_ENUM_IMPL(libxlDomainFSDriver, VIR_DOMAIN_FS_DRIVER_TYPE_LAST, + "local", + "local", + "handle", + NULL, + NULL, + NULL); + static void libxlDriverConfigDispose(void *obj) { @@ -1854,6 +1864,167 @@ libxlMakeCapabilities(libxl_ctx *ctx) return NULL; } +static char * +libxlBuildQemuFSStr(virDomainFSDefPtr fs) +{ + virBuffer opt = VIR_BUFFER_INITIALIZER; + const char *driver = libxlDomainFSDriverTypeToString(fs->fsdriver); + const char *wrpolicy = virDomainFSWrpolicyTypeToString(fs->wrpolicy); + + if (fs->type != VIR_DOMAIN_FS_TYPE_MOUNT) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("only supports mount filesystem type")); + goto error; + } + + if (!driver) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Filesystem driver type not supported")); + goto error; + } + virBufferAdd(&opt, driver, -1); + + if (fs->fsdriver == VIR_DOMAIN_FS_DRIVER_TYPE_PATH || + fs->fsdriver == VIR_DOMAIN_FS_DRIVER_TYPE_DEFAULT) { + if (fs->accessmode == VIR_DOMAIN_FS_ACCESSMODE_MAPPED) { + virBufferAddLit(&opt, ",security_model=mapped"); + } else if (fs->accessmode == VIR_DOMAIN_FS_ACCESSMODE_PASSTHROUGH) { + virBufferAddLit(&opt, ",security_model=passthrough"); + } else if (fs->accessmode == VIR_DOMAIN_FS_ACCESSMODE_SQUASH) { + virBufferAddLit(&opt, ",security_model=none"); + } + } else { + /* For other fs drivers, default(passthru) should always + * be supported */ + if (fs->accessmode != VIR_DOMAIN_FS_ACCESSMODE_PASSTHROUGH) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("only supports passthrough accessmode")); + goto error; + } + } + + if (fs->wrpolicy) + virBufferAsprintf(&opt, ",writeout=%s", wrpolicy); + + virBufferAsprintf(&opt, ",id=%s%s", LIBXL_FSDEV_HOST_PREFIX, fs->info.alias); + virBufferAsprintf(&opt, ",path=%s", fs->src); + + if (fs->readonly) + virBufferAddLit(&opt, ",readonly"); + + if (virBufferCheckError(&opt) < 0) + goto error; + + return virBufferContentAndReset(&opt); + + error: + virBufferFreeAndReset(&opt); + return NULL; +} + + +static char * +libxlBuildQemuFSDevStr(virDomainFSDefPtr fs) +{ + virBuffer opt = VIR_BUFFER_INITIALIZER; + + if (fs->type != VIR_DOMAIN_FS_TYPE_MOUNT) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("can only passthrough directories")); + goto error; + } + + if (fs->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW) + virBufferAddLit(&opt, "virtio-9p-ccw"); + else + virBufferAddLit(&opt, "virtio-9p-pci"); + + virBufferAsprintf(&opt, ",id=%s", fs->info.alias); + virBufferAsprintf(&opt, ",fsdev=%s%s", LIBXL_FSDEV_HOST_PREFIX, fs->info.alias); + virBufferAsprintf(&opt, ",mount_tag=%s", fs->dst); + + if (virBufferCheckError(&opt) < 0) + goto error; + + return virBufferContentAndReset(&opt); + + error: + virBufferFreeAndReset(&opt); + return NULL; +} + +static int +libxlMakeMountList(virDomainDefPtr def, + libxl_domain_config *d_config) +{ + int ret = -1; + size_t i; + size_t nextra = 0; + char *fsstr = NULL; + char *fsdevstr = NULL; + char *fsdevargstr = NULL; + char *deviceargstr = NULL; + + if (def->nfss > 0 && def->os.type != VIR_DOMAIN_OSTYPE_HVM) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("only HVM guests supports mounts")); + return ret; + } + + /* Make sure we have an allocated array, not ending with NULL */ + if (!d_config->b_info.extra) { + if (VIR_ALLOC(d_config->b_info.extra) < 0) + return ret; + nextra = 0; + } else { + nextra = virStringListLength(d_config->b_info.extra) + 1; + if (VIR_DELETE_ELEMENT(d_config->b_info.extra, nextra, nextra) < 0) + return ret; + } + + /* Add the QEMU options to d_config->b_info->extra + * -fsdev local,id=virtio9p,path=%s,security_model=none + * -device virtio-9p-pci,fsdev=virtio9p,mount_tag=%s + */ + for (i = 0; i < def->nfss; i++) { + virDomainFSDefPtr fs = def->fss[i]; + + /* Assign an alias */ + if (virAsprintf(&fs->info.alias, "fs%zu", i) < 0) + goto cleanup; + + if (!(fsstr = libxlBuildQemuFSStr(fs))) + goto cleanup; + if (!(fsdevstr = libxlBuildQemuFSDevStr(fs))) + goto cleanup; + + if (VIR_STRDUP(fsdevargstr, "-fsdev") < 0 || + VIR_STRDUP(deviceargstr, "-device") < 0) + goto cleanup; + + + /* Append to the extras before terminating NULL */ + if (VIR_APPEND_ELEMENT(d_config->b_info.extra, nextra, fsdevargstr) < 0 || + VIR_APPEND_ELEMENT(d_config->b_info.extra, nextra, fsstr) < 0 || + VIR_APPEND_ELEMENT(d_config->b_info.extra, nextra, deviceargstr) < 0 || + VIR_APPEND_ELEMENT(d_config->b_info.extra, nextra, fsdevstr) < 0) + goto cleanup; + } + ret = 0; + + /* Add the terminating NULL item */ + if (VIR_RESIZE_N(d_config->b_info.extra, nextra, nextra, 1) < 0) + goto cleanup; + d_config->b_info.extra[nextra++] = NULL; + + cleanup: + VIR_FREE(fsstr); + VIR_FREE(fsdevstr); + VIR_FREE(fsdevargstr); + VIR_FREE(deviceargstr); + return ret; +} + int libxlBuildDomainConfig(virPortAllocatorPtr graphicsports, virDomainDefPtr def, @@ -1883,6 +2054,9 @@ libxlBuildDomainConfig(virPortAllocatorPtr graphicsports, if (libxlMakePCIList(def, d_config) < 0) return -1; + if (libxlMakeMountList(def, d_config) < 0) + return -1; + /* * Now that any potential VFBs are defined, update the build info with * the data of the primary display. Some day libxl might implicitely do -- 2.1.4

8 years, 11 months

4
3
0 / 0

[libvirt] blockcopy qemu fail and libvirt

by Vasiliy Tolstov

Hi, i'm use qemu 2.4.0 and libvirt 1.2.16 and try blockcopy to migrate vm disk virsh -c qemu+ssh://root@xxx/system blockcopy domain sda /dev/nbd2 --wait --pivot libvirt says: Successfully pivoted 2015-12-01 14:37:18.188+0000: 18288: info : libvirt version: 1.2.16 2015-12-01 14:37:18.188+0000: 18288: warning : virEventPollUpdateTimeout:268 : Ignoring invalid update timer -1 but virsh command returns zero exit code qemu blockcopy failed and target device contains zeroes. i see some qemu git commits about block/migration and block that can fix this isse, does qemu-devs confirm that this bug is fixed? Also libvirt devs - do you know about this libvirt issue (when virsh doing blockcopy and qemu process does not success complete blockcopy) ? -- Vasiliy Tolstov, e-mail: v.tolstov(a)selfip.ru

8 years, 11 months

1
0
0 / 0

[libvirt] [PATCH] add a nodnsmasq option for networks

by Serge Hallyn

Some people want to define a libvirt network but have dns served by another daemon. Libvirt used to support that, but hasn't for several years. Two long-open bugs on this are https://bugzilla.redhat.com/show_bug.cgi?id=636115 https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/584862 I'm not certain whether we really want to support this, as another option is to simply create the bridge with external tools and tell libvirt vms to use that bridge. However, if we do want to support it, this patch provides that support. This patch allows an admin to set <nodnsmasq>true</nodnsmasq> in a bridge definition to avoid having libvirt start a dnsmasq. Signed-off-by: Serge Hallyn <serge.hallyn(a)ubuntu.com> --- src/conf/network_conf.c | 15 +++++++++++++++ src/conf/network_conf.h | 1 + src/network/bridge_driver.c | 2 +- 3 files changed, 17 insertions(+), 1 deletion(-) Index: libvirt-1.2.16/src/conf/network_conf.c =================================================================== --- libvirt-1.2.16.orig/src/conf/network_conf.c +++ libvirt-1.2.16/src/conf/network_conf.c @@ -1985,6 +1985,7 @@ virNetworkDefParseXML(xmlXPathContextPtr xmlNodePtr virtPortNode = NULL; xmlNodePtr forwardNode = NULL; char *ipv6nogwStr = NULL; + char *noDnsmasqStr = NULL; char *trustGuestRxFilters = NULL; xmlNodePtr save = ctxt->node; xmlNodePtr bandwidthNode = NULL; @@ -2018,6 +2019,20 @@ virNetworkDefParseXML(xmlXPathContextPtr def->uuid_specified = true; } + /* check if user requested no dnsmasq */ + noDnsmasqStr = virXPathString("string(./nodnsmasq[1])", ctxt); + if (noDnsmasqStr) { + if (STREQ(noDnsmasqStr, "yes") || STREQ(noDnsmasqStr, "true")) { + def->nodnsmasq = true; + } else if (STRNEQ(noDnsmasqStr, "no") && STRNEQ(noDnsmasqStr, "false")) { + virReportError(VIR_ERR_XML_ERROR, + _("Invalid nodnsmasq setting '%s' in network '%s'"), + noDnsmasqStr, def->name); + goto error; + } + VIR_FREE(noDnsmasqStr); + } + /* check if definitions with no IPv6 gateway addresses is to * allow guest-to-guest communications. */ @@ -2660,6 +2675,9 @@ virNetworkDefFormatBuf(virBufferPtr buf, virUUIDFormat(uuid, uuidstr); virBufferAsprintf(buf, "<uuid>%s</uuid>\n", uuidstr); + if (def->nodnsmasq) + virBufferAsprintf(buf, "<nodnsmasq>true</nodnsmasq>\n"); + if (def->forward.type != VIR_NETWORK_FORWARD_NONE) { const char *dev = NULL; if (!def->forward.npfs) Index: libvirt-1.2.16/src/conf/network_conf.h =================================================================== --- libvirt-1.2.16.orig/src/conf/network_conf.h +++ libvirt-1.2.16/src/conf/network_conf.h @@ -231,6 +231,7 @@ struct _virNetworkDef { bool stp; /* Spanning tree protocol */ virMacAddr mac; /* mac address of bridge device */ bool mac_specified; + bool nodnsmasq; /* specified if ip6tables rules added * when no ipv6 gateway addresses specified. Index: libvirt-1.2.16/src/network/bridge_driver.c =================================================================== --- libvirt-1.2.16.orig/src/network/bridge_driver.c +++ libvirt-1.2.16/src/network/bridge_driver.c @@ -2146,7 +2146,7 @@ networkStartNetworkVirtual(virNetworkDri /* start dnsmasq if there are any IP addresses (v4 or v6) */ - if ((v4present || v6present) && + if ((v4present || v6present) && !network->def->nodnsmasq && networkStartDhcpDaemon(driver, network) < 0) goto err3;

8 years, 11 months

2
2
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Devel December 2015