[libvirt] Build failed in Jenkins: libvirt-syntax-check #2434
by Jenkins CI
See <http://honk.sigxcpu.org:8001/job/libvirt-syntax-check/2434/>
------------------------------------------
Started by upstream project "libvirt-build" build number 2747
Building on master in workspace <http://honk.sigxcpu.org:8001/job/libvirt-syntax-check/ws/>
[workspace] $ /bin/sh -xe /tmp/hudson2596201862121310184.sh
+ make syntax-check
GEN bracket-spacing-check
GFDL_version
0.53 GFDL_version
TAB_in_indentation
0.51 TAB_in_indentation
Wundef_boolean
0.22 Wundef_boolean
avoid_attribute_unused_in_header
0.31 avoid_attribute_unused_in_header
avoid_ctype_macros
0.69 avoid_ctype_macros
avoid_if_before_free
6.16 avoid_if_before_free
avoid_strcase
0.79 avoid_strcase
avoid_write
0.33 avoid_write
bindtextdomain
0.27 bindtextdomain
cast_of_argument_to_free
0.61 cast_of_argument_to_free
cast_of_x_alloc_return_value
0.55 cast_of_x_alloc_return_value
changelog
0.21 changelog
const_long_option
0.53 const_long_option
copyright_check
0.69 copyright_check
copyright_format
1.77 copyright_format
copyright_usage
1.46 copyright_usage
correct_id_types
0.68 correct_id_types
curly_braces_style
0.85 curly_braces_style
error_message_period
0.44 error_message_period
error_message_warn_fatal
0.45 error_message_warn_fatal
flags_debug
1.12 flags_debug
flags_usage
1.09 flags_usage
forbid_const_pointer_typedef
1.15 forbid_const_pointer_typedef
forbid_manual_xml_indent
0.53 forbid_manual_xml_indent
libvirt_unmarked_diagnostics
1.72 libvirt_unmarked_diagnostics
m4_quote_check
0.24 m4_quote_check
makefile_TAB_only_indentation
0.26 makefile_TAB_only_indentation
makefile_at_at_check
0.20 makefile_at_at_check
makefile_conditionals
0.26 makefile_conditionals
po_check
14.88 po_check
preprocessor_indentation
0.65 preprocessor_indentation
prohibit_HAVE_MBRTOWC
0.74 prohibit_HAVE_MBRTOWC
prohibit_PATH_MAX
0.60 prohibit_PATH_MAX
prohibit_VIR_ERR_NO_MEMORY
0.57 prohibit_VIR_ERR_NO_MEMORY
prohibit_access_xok
0.59 prohibit_access_xok
prohibit_always-defined_macros
1.99 prohibit_always-defined_macros
prohibit_always_true_header_tests
0.83 prohibit_always_true_header_tests
prohibit_argmatch_without_use
grep: write error
grep: write error
/bin/sed: couldn't write 25 items to stdout: Broken pipe
sed: couldn't write 57 items to stdout: Broken pipe
0.44 prohibit_argmatch_without_use
prohibit_asprintf
1.39 prohibit_asprintf
prohibit_assert_without_use
grep: write error
grep: write error
/bin/sed: couldn't write 51 items to stdout: Broken pipe
sed: couldn't write 65 items to stdout: Broken pipe
0.48 prohibit_assert_without_use
prohibit_atoi
0.76 prohibit_atoi
prohibit_backup_files
0.16 prohibit_backup_files
prohibit_c_ctype_without_use
grep: write error
grep: write error
/bin/sed: couldn't write 25 items to stdout: Broken pipe
sed: couldn't write 57 items to stdout: Broken pipe
0.45 prohibit_c_ctype_without_use
prohibit_canonicalize_without_use
grep: write error
grep: write error
/bin/sed: couldn't write 25 items to stdout: Broken pipe
sed: couldn't write 57 items to stdout: Broken pipe
0.49 prohibit_canonicalize_without_use
prohibit_cloexec_without_use
grep: write error
grep: write error
/bin/sed: couldn't write 38 items to stdout: Broken pipe
sed: couldn't write 54 items to stdout: Broken pipe
0.85 prohibit_cloexec_without_use
prohibit_close
1.58 prohibit_close
prohibit_close_stream_without_use
grep: write error
grep: write error
/bin/sed: couldn't write 25 items to stdout: Broken pipe
sed: couldn't write 57 items to stdout: Broken pipe
0.43 prohibit_close_stream_without_use
prohibit_config_h_in_headers
0.32 prohibit_config_h_in_headers
prohibit_cross_inclusion
8.51 prohibit_cross_inclusion
prohibit_ctype_h
0.67 prohibit_ctype_h
prohibit_cvs_keyword
0.66 prohibit_cvs_keyword
prohibit_defined_have_decl_tests
0.79 prohibit_defined_have_decl_tests
prohibit_diagnostic_without_format
1.72 prohibit_diagnostic_without_format
prohibit_dirent_without_use
grep: write error
grep: write error
/bin/sed: couldn't write 57 items to stdout: Broken pipe
sed: couldn't write 52 items to stdout: Broken pipe
0.50 prohibit_dirent_without_use
prohibit_doubled_word
6.65 prohibit_doubled_word
prohibit_duplicate_header
13.42 prohibit_duplicate_header
prohibit_empty_first_line
1.95 prohibit_empty_first_line
prohibit_empty_lines_at_EOF
0.95 prohibit_empty_lines_at_EOF
prohibit_error_without_use
grep: write error
grep: write error
/bin/sed: couldn't write 69 items to stdout: Broken pipe
sed: couldn't write 64 items to stdout: Broken pipe
0.95 prohibit_error_without_use
prohibit_exit_in_tests
0.85 prohibit_exit_in_tests
prohibit_fork_wrappers
1.20 prohibit_fork_wrappers
prohibit_getenv
0.70 prohibit_getenv
prohibit_gethostby
0.64 prohibit_gethostby
prohibit_gethostname
0.67 prohibit_gethostname
prohibit_getopt_without_use
grep: write error
grep: write error
/bin/sed: couldn't write 25 items to stdout: Broken pipe
sed: couldn't write 57 items to stdout: Broken pipe
0.46 prohibit_getopt_without_use
prohibit_gettext_markup
0.70 prohibit_gettext_markup
prohibit_gettext_noop
0.68 prohibit_gettext_noop
prohibit_hash_pjw_without_use
grep: write error
grep: write error
/bin/sed: couldn't write 25 items to stdout: Broken pipe
sed: couldn't write 57 items to stdout: Broken pipe
0.41 prohibit_hash_pjw_without_use
prohibit_have_config_h
0.64 prohibit_have_config_h
prohibit_ignore_value_without_use
grep: write error
grep: write error
/bin/sed: couldn't write 25 items to stdout: Broken pipe
sed: couldn't write 57 items to stdout: Broken pipe
0.45 prohibit_ignore_value_without_use
prohibit_include_public_headers_brackets
0.49 prohibit_include_public_headers_brackets
prohibit_include_public_headers_quote
0.46 prohibit_include_public_headers_quote
prohibit_int_ijk
0.93 prohibit_int_ijk
prohibit_internal_functions
0.82 prohibit_internal_functions
prohibit_intprops_without_use
grep: write error
grep: write error
/bin/sed: couldn't write 25 items to stdout: Broken pipe
sed: couldn't write 57 items to stdout: Broken pipe
0.47 prohibit_intprops_without_use
prohibit_inttostr_without_use
grep: write error
grep: write error
/bin/sed: couldn't write 51 items to stdout: Broken pipe
sed: couldn't write 65 items to stdout: Broken pipe
0.41 prohibit_inttostr_without_use
prohibit_libgen
0.95 prohibit_libgen
prohibit_long_lines
src/Makefile.am:1146:libvirt_driver_vbox_impl_la_LIBADD = $(DLOPEN_LIBS) $(MSCOM_LIBS) $(LIBXML_LIBS)
maint.mk: Wrap long lines in Makefiles
make: *** [sc_prohibit_long_lines] Error 1
Build step 'Execute shell' marked build as failure
10 years, 9 months
[libvirt] [PATCH] libxl: add PV console if not explicitly specified
by Jim Fehlig
Xen PV domains always have a PV console, so add one to the domain
config via post-parse callback if not explicitly specified in
the XML. The legacy Xen driver behaves similarly, causing a
regression when switching to the new Xen toolstack. I.e.
virsh console pv-domain
will no longer work after upgrading a xm/xend stack to xl/libxl.
Signed-off-by: Jim Fehlig <jfehlig(a)suse.com>
---
src/libxl/libxl_domain.c | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
index da3f241..0c86601 100644
--- a/src/libxl/libxl_domain.c
+++ b/src/libxl/libxl_domain.c
@@ -503,9 +503,38 @@ libxlDomainDeviceDefPostParse(virDomainDeviceDefPtr dev,
return 0;
}
+static int
+libxlDomainDefPostParse(virDomainDefPtr def,
+ virCapsPtr caps ATTRIBUTE_UNUSED,
+ void *opaque ATTRIBUTE_UNUSED)
+{
+ if (STREQ(def->os.type, "hvm"))
+ return 0;
+
+ if (def->nconsoles == 0) {
+ virDomainChrDefPtr chrdef;
+
+ if (!(chrdef = virDomainChrDefNew()))
+ return -1;
+
+ chrdef->source.type = VIR_DOMAIN_CHR_TYPE_PTY;
+ chrdef->deviceType = VIR_DOMAIN_CHR_DEVICE_TYPE_CONSOLE;
+ chrdef->target.port = 0;
+ chrdef->targetType = VIR_DOMAIN_CHR_CONSOLE_TARGET_TYPE_XEN;
+
+ if (VIR_ALLOC_N(def->consoles, 1) < 0)
+ return -1;
+
+ def->nconsoles = 1;
+ def->consoles[0] = chrdef;
+ }
+ return 0;
+}
+
virDomainDefParserConfig libxlDomainDefParserConfig = {
.macPrefix = { 0x00, 0x16, 0x3e },
.devicesPostParseCallback = libxlDomainDeviceDefPostParse,
+ .domainPostParseCallback = libxlDomainDefPostParse,
};
--
1.8.4.5
10 years, 9 months
[libvirt] [PATCH] build: fix 'make syntax-check' after commit c6cf5df3
by Jim Fehlig
The commit caused prohibit_long_lines to fail in src/Makefile.am.
Signed-off-by: Jim Fehlig <jfehlig(a)suse.com>
---
Pushing under the build-breaker rule.
src/Makefile.am | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 10c35d7..35720be 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -1143,7 +1143,9 @@ libvirt_driver_vbox_impl_la_CFLAGS = \
-I$(top_srcdir)/src/conf \
$(AM_CFLAGS)
libvirt_driver_vbox_impl_la_LDFLAGS = $(AM_LDFLAGS)
-libvirt_driver_vbox_impl_la_LIBADD = $(DLOPEN_LIBS) $(MSCOM_LIBS) $(LIBXML_LIBS)
+libvirt_driver_vbox_impl_la_LIBADD = $(DLOPEN_LIBS) \
+ $(MSCOM_LIBS) \
+ $(LIBXML_LIBS)
libvirt_driver_vbox_impl_la_SOURCES = $(VBOX_DRIVER_SOURCES)
endif WITH_VBOX
--
1.8.4.5
10 years, 9 months
[libvirt] [PATCH] vbox: fix linker error
by Jim Fehlig
Noticed the following error when building the vbox driver
in the openSUSE build service
CCLD vboxsnapshotxmltest
/usr/lib64/gcc/x86_64-suse-linux/4.8/../../../../x86_64-suse-linux/bin/ld:
../src/.libs/libvirt_driver_vbox_impl.a
(libvirt_driver_vbox_impl_la-vbox_snapshot_conf.o):
undefined reference to symbol 'xmlXPathRegisterNs@(a)LIBXML2_2.4.30'
/usr/lib64/libxml2.so: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
Fixed by adding LIBXML_LIBS to libvirt_driver_vbox_impl_la_LIBADD
Signed-off-by: Jim Fehlig <jfehlig(a)suse.com>
---
Oddly, I don't see this when doing local builds, but haven't really
found out what is different between my build environments.
src/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 2b9ac61..10c35d7 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -1143,7 +1143,7 @@ libvirt_driver_vbox_impl_la_CFLAGS = \
-I$(top_srcdir)/src/conf \
$(AM_CFLAGS)
libvirt_driver_vbox_impl_la_LDFLAGS = $(AM_LDFLAGS)
-libvirt_driver_vbox_impl_la_LIBADD = $(DLOPEN_LIBS) $(MSCOM_LIBS)
+libvirt_driver_vbox_impl_la_LIBADD = $(DLOPEN_LIBS) $(MSCOM_LIBS) $(LIBXML_LIBS)
libvirt_driver_vbox_impl_la_SOURCES = $(VBOX_DRIVER_SOURCES)
endif WITH_VBOX
--
1.8.4.5
10 years, 9 months