December 2014 - Devel - libvirt List Archives

[libvirt] [PATCH v3 0/3] parallels: a set of fixes for nova
by Dmitry Guryanov 15 Dec '14

15 Dec '14

Hello, This 3 patches fix different things, used by nova. Dmitry Guryanov (3): parallels: support NULL virDomainVideoAccelDefPtr parallels: set format for real disk devices parallels: fix usage of disk->info.addr.drive structure src/parallels/parallels_sdk.c | 34 ++++++++++++++++++++++++++++++---- 1 file changed, 30 insertions(+), 4 deletions(-) -- 2.1.0

2 5

[libvirt] ANNOUNCE: libvirt-glib release 0.2.0
by Daniel P. Berrange 15 Dec '14

15 Dec '14

I am pleased to announce that a new release of the libvirt-glib package, version 0.2.0, is now available from ftp://libvirt.org/libvirt/glib/ The packages are GPG signed with Key fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF (4096R) Changes in this release: - Support keyboard input device config - Annotate some unused parameters - Add support for new graphics attach API libvirt-glib comprises three distinct libraries: - libvirt-glib - Integrate with the GLib event loop and error handling - libvirt-gconfig - Representation of libvirt XML documents as GObjects - libvirt-gobject - Mapping of libvirt APIs into the GObject type system NB: While libvirt aims to be API/ABI stable forever, with libvirt-glib we are not currently guaranteeing that libvirt-glib libraries are permanently API/ABI stable. That said we do not expect to break the API/ABI for the forseeable future and will always strive avoid it. Follow up comments about libvirt-glib should be directed to the regular libvir-list(a)redhat.com development list. Thanks to all the people involved in contributing to this release. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

1 0

[libvirt] [PATCH] qemu: Auto generate a controller when attach hostdev and chr device
by Luyao Huang 15 Dec '14

15 Dec '14

https://bugzilla.redhat.com/show_bug.cgi?id=1174154 When we use attach-device add a hostdev or chr device which have a iscsi address or others (just like guest agent, subsys iscsi disk...), we will find there is no basic controller for our new attached device. Somtimes this will make guest cannot start after we add them (although they can start at the second time). Signed-off-by: Luyao Huang <lhuang(a)redhat.com> --- src/qemu/qemu_driver.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index df3ba6d..62fb784 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7250,6 +7250,8 @@ qemuDomainAttachDeviceConfig(virQEMUCapsPtr qemuCaps, if (virDomainHostdevInsert(vmdef, hostdev)) return -1; dev->data.hostdev = NULL; + if (virDomainDefAddImplicitControllers(vmdef) < 0) + return -1; if (qemuDomainAssignAddresses(vmdef, qemuCaps, NULL) < 0) return -1; break; @@ -7290,6 +7292,8 @@ qemuDomainAttachDeviceConfig(virQEMUCapsPtr qemuCaps, if (qemuDomainChrInsert(vmdef, dev->data.chr) < 0) return -1; dev->data.chr = NULL; + if (virDomainDefAddImplicitControllers(vmdef) < 0) + return -1; break; case VIR_DOMAIN_DEVICE_FS: -- 1.8.3.1

2 1

[libvirt] [PATCH V2 0/3] qemu: support update graphic device persistently
by Wang Rui 15 Dec '14

15 Dec '14

We can change vnc password by using virDomainUpdateDeviceFlags API with live flag. But it can't be changed with config flag. v1: https://www.redhat.com/archives/libvir-list/2014-November/msg00627.html diff to v1: according to Jan's suggestion, 1. (patch 1/3) change error number to VIR_ERR_OPERATION_UNSUPPORTED 2. (patch 3/3) add 'VIR_DOMAIN_XML_SECURE' to flags in initialization. 3. (patch 3/3) Introduce a new function qemuDomainFindGraphicsIndex. Free the old graphics def and replace it with the new one as what we did for DEVICE_NET. Wang Rui (3): qemu: report properer error number when change graphics failed qemu: fix alignment of qemuDomainFindGraphics qemu: make persistent update of graphics device supported src/conf/domain_conf.c | 2 +- src/qemu/qemu_driver.c | 18 +++++++++++++++++- src/qemu/qemu_hotplug.c | 36 ++++++++++++++++++++++++------------ src/qemu/qemu_hotplug.h | 2 ++ 4 files changed, 44 insertions(+), 14 deletions(-) -- 1.7.12.4

2 4

[libvirt] [PATCH] conf: fix virDomainLeaseIndex cannot work when both parameter have lockspaces present
by Luyao Huang 15 Dec '14

15 Dec '14

https://bugzilla.redhat.com/show_bug.cgi?id=1174096 When both parameter have lockspaces present, virDomainLeaseIndex will always -1 even there is a lease the same with the one we check. I think we shouldn't do 'continue' when the two lockspaces are the same. Signed-off-by: Luyao Huang <lhuang(a)redhat.com> --- src/conf/domain_conf.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 5cf0b1a..f36affc 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11667,13 +11667,14 @@ int virDomainLeaseIndex(virDomainDefPtr def, for (i = 0; i < def->nleases; i++) { vlease = def->leases[i]; - /* Either both must have lockspaces present which match.. */ - if (vlease->lockspace && lease->lockspace && - STRNEQ(vlease->lockspace, lease->lockspace)) - continue; + /* Either both must have lockspaces present which match.. */ + if (vlease->lockspace && lease->lockspace) { + if (STRNEQ(vlease->lockspace, lease->lockspace)) + continue; /* ...or neither must have a lockspace present */ - if (vlease->lockspace || lease->lockspace) + } else if (vlease->lockspace || lease->lockspace) continue; + if (STREQ(vlease->key, lease->key)) return i; } -- 1.8.3.1

2 2

[libvirt] [PATCH] xenconfig: fix boot device parsing
by Wei Liu 15 Dec '14

15 Dec '14

The original code always checked *boot which was in effect boot[0]. It should use boot[i]. Signed-off-by: Wei Liu <wei.liu2(a)citrix.com> --- src/xenconfig/xen_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/xenconfig/xen_common.c b/src/xenconfig/xen_common.c index 7f4ec89..48431a7 100644 --- a/src/xenconfig/xen_common.c +++ b/src/xenconfig/xen_common.c @@ -1071,7 +1071,7 @@ xenParseOS(virConfPtr conf, virDomainDefPtr def) return -1; for (i = 0; i < VIR_DOMAIN_BOOT_LAST && boot[i]; i++) { - switch (*boot) { + switch (boot[i]) { case 'a': def->os.bootDevs[i] = VIR_DOMAIN_BOOT_FLOPPY; break; -- 1.7.10.4

3 2

[libvirt] [PATCH] conf: fix crash when match a network iscsi hostdev with a host iscsi hostdev
by Luyao Huang 15 Dec '14

15 Dec '14

https://bugzilla.redhat.com/show_bug.cgi?id=1174053 When we use attach-device to coldplug a network iscsi hostdev, libvirt will check if there is already a device in XML. But if the 'b' is a host iscsi hostdev and 'a' is a network iscsi hostdev , libvirtd will crash in virDomainHostdevMatchSubsysSCSIiSCSI, because 'b' doesn't have a hostname. Add a check in virDomainHostdevMatchSubsys, if the a's protocol and b's protocol is not the same. backtrace like this: 0 0x00007f850d6bc307 in virDomainHostdevMatchSubsysSCSIiSCSI at conf/domain_conf.c:10889 1 virDomainHostdevMatchSubsys at conf/domain_conf.c:10911 2 virDomainHostdevMatch at conf/domain_conf.c:10973 3 virDomainHostdevFind at conf/domain_conf.c:10998 4 0x00007f84f6a10560 in qemuDomainAttachDeviceConfig at qemu/qemu_driver.c:7223 5 qemuDomainAttachDeviceFlags at qemu/qemu_driver.c:7554 Signed-off-by: Luyao Huang <lhuang(a)redhat.com> --- src/conf/domain_conf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 5cf0b1a..eb63c93 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11184,7 +11184,9 @@ static int virDomainHostdevMatchSubsys(virDomainHostdevDefPtr a, virDomainHostdevDefPtr b) { - if (a->source.subsys.type != b->source.subsys.type) + if (a->source.subsys.type != b->source.subsys.type || + (a->source.subsys.type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI && + a->source.subsys.u.scsi.protocol != b->source.subsys.u.scsi.protocol)) return 0; switch (a->source.subsys.type) { -- 1.8.3.1

2 2

[libvirt] [PATCH 01/10] parallels: support NULL virDomainVideoAccelDefPtr
by Dmitry Guryanov 15 Dec '14

15 Dec '14

I support if virDomainVideoAccelDefPtr is NULL it means default values for video acceleration. So we don't need to report error. --- src/parallels/parallels_sdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/parallels/parallels_sdk.c b/src/parallels/parallels_sdk.c index 0b05bc1..0980f50 100644 --- a/src/parallels/parallels_sdk.c +++ b/src/parallels/parallels_sdk.c @@ -2029,7 +2029,7 @@ static int prlsdkCheckVideoUnsupportedParams(virDomainDefPtr def) return -1; } - if (v->accel == NULL || v->accel->support2d || v->accel->support3d) { + if (v->accel != NULL && (v->accel->support2d || v->accel->support3d)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("Parallels Cloud Server doesn't support " "setting video acceleration parameters.")); -- 2.1.0

1 11

[libvirt] [PATCH] fix typo in sanlock driver s/VIR_CONF_UONG/VIR_CONF_ULONG/
by Daniel P. Berrange 15 Dec '14

15 Dec '14

fix typo introduced in previous commit Pushed as build-breaker fix --- src/locking/lock_driver_sanlock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/locking/lock_driver_sanlock.c b/src/locking/lock_driver_sanlock.c index b24e910..60f305c 100644 --- a/src/locking/lock_driver_sanlock.c +++ b/src/locking/lock_driver_sanlock.c @@ -141,7 +141,7 @@ static int virLockManagerSanlockLoadConfig(const char *configFile) } p = virConfGetValue(conf, "host_id"); - CHECK_TYPE("host_id", VIR_CONF_UONG); + CHECK_TYPE("host_id", VIR_CONF_ULONG); if (p) driver->hostID = p->l; p = virConfGetValue(conf, "require_lease_for_disks"); -- 2.1.0

1 0

[libvirt] [PATCH 0/3] Fix starting/stopping of netdevs when starting/stopping CPUs
by Laine Stump 15 Dec '14

15 Dec '14

The first two patches provide a cleaner, more complete fix to a fix that was recently pushed for https://bugzilla.redhat.com/show_bug.cgi?id=1081461 While the original patch does fix the symptoms in the report, applying these two additional patches handle some situations that weren't addressed by the original. Patch 3 fixes a similar problem with tap devices when the newly added macTableManager='libvirt' is used. It should make migration of guests with this new type of network connection work properly with no loss of network connectivity (including once post-copy migration is working). Laine Stump (3): qemu: always call qemuInterfaceStartDevices() when starting CPUs qemu: add a qemuInterfaceStopDevices(), called when guest CPUs stop qemu: add/remove bridge fdb entries as guest CPUs are started/stopped src/qemu/qemu_command.c | 10 ++---- src/qemu/qemu_hotplug.c | 8 +++++ src/qemu/qemu_interface.c | 92 +++++++++++++++++++++++++++++++++++++++++++++++ src/qemu/qemu_interface.h | 2 ++ src/qemu/qemu_process.c | 7 ++-- 5 files changed, 109 insertions(+), 10 deletions(-) -- 1.9.3

3 6