May 2013 - Devel - libvirt List Archives

[libvirt] patch set for virt-sandbox-service
by dwalsh＠redhat.com 10 May '13

10 May '13

The patch will add proper handling of duplicate Generic Sandbox. It will also add support for adding mount points via virt-sandbox-service using the same syntax as virt-sandbox. [sandbox PATCH 1/2] Verify that a created Generic Sandbox does not [sandbox PATCH 2/2] Add support for virt-sandbox-service to add

2 4

[libvirt] [PATCH] Update hellolibvirt to demo virGetLastErrorMessage()
by Daniel P. Berrange 10 May '13

10 May '13

From: "Daniel P. Berrange" <berrange(a)redhat.com> Update the hellolibvirt example program to demonstrate use of the virGetLastErrorMessage() API for quick error reporting Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- examples/hellolibvirt/hellolibvirt.c | 64 ++++++++---------------------------- 1 file changed, 14 insertions(+), 50 deletions(-) diff --git a/examples/hellolibvirt/hellolibvirt.c b/examples/hellolibvirt/hellolibvirt.c index 26dd67f..4ae60fc 100644 --- a/examples/hellolibvirt/hellolibvirt.c +++ b/examples/hellolibvirt/hellolibvirt.c @@ -9,42 +9,6 @@ #include <libvirt/libvirt.h> #include <libvirt/virterror.h> -static void -showError(virConnectPtr conn) -{ - int ret; - virErrorPtr err; - - err = malloc(sizeof(*err)); - if (!err) { - printf("Could not allocate memory for error data\n"); - goto out; - } - - ret = virConnCopyLastError(conn, err); - - switch (ret) { - case 0: - printf("No error found\n"); - break; - - case -1: - printf("Parameter error when attempting to get last error\n"); - break; - - default: - printf("libvirt reported: \"%s\"\n", err->message); - break; - } - - virResetError(err); - free(err); - -out: - return; -} - - static int showHypervisorInfo(virConnectPtr conn) { @@ -59,15 +23,15 @@ showHypervisorInfo(virConnectPtr conn) hvType = virConnectGetType(conn); if (!hvType) { ret = 1; - printf("Failed to get hypervisor type\n"); - showError(conn); + printf("Failed to get hypervisor type: %s\n", + virGetLastErrorMessage()); goto out; } if (0 != virConnectGetVersion(conn, &hvVer)) { ret = 1; - printf("Failed to get hypervisor version\n"); - showError(conn); + printf("Failed to get hypervisor version: %s\n", + virGetLastErrorMessage()); goto out; } @@ -102,16 +66,16 @@ showDomains(virConnectPtr conn) numActiveDomains = virConnectNumOfDomains(conn); if (numActiveDomains == -1) { ret = 1; - printf("Failed to get number of active domains\n"); - showError(conn); + printf("Failed to get number of active domains: %s\n", + virGetLastErrorMessage()); goto out; } numInactiveDomains = virConnectNumOfDefinedDomains(conn); if (numInactiveDomains == -1) { ret = 1; - printf("Failed to get number of inactive domains\n"); - showError(conn); + printf("Failed to get number of inactive domains: %s\n", + virGetLastErrorMessage()); goto out; } @@ -157,16 +121,16 @@ main(int argc, char *argv[]) if (!conn) { ret = 1; - printf("No connection to hypervisor\n"); - showError(conn); + printf("No connection to hypervisor: %s\n", + virGetLastErrorMessage()); goto out; } uri = virConnectGetURI(conn); if (!uri) { ret = 1; - printf("Failed to get URI for hypervisor connection\n"); - showError(conn); + printf("Failed to get URI for hypervisor connection: %s\n", + virGetLastErrorMessage()); goto disconnect; } @@ -185,8 +149,8 @@ main(int argc, char *argv[]) disconnect: if (0 != virConnectClose(conn)) { - printf("Failed to disconnect from hypervisor\n"); - showError(conn); + printf("Failed to disconnect from hypervisor: %s\n", + virGetLastErrorMessage()); ret = 1; } else { printf("Disconnected from hypervisor\n"); -- 1.8.2.1

2 1

[libvirt] [PATCH 0/3] Test case for fdstream / iohelper code
by Daniel P. Berrange 10 May '13

10 May '13

From: "Daniel P. Berrange" <berrange(a)redhat.com> There was a recent embarassing regression in the fdstream iohelper code which broke many commands/APIs. The problem code in question is quite easily testable via the unit tests. Daniel P. Berrange (3): Add a virGetLastErrorMessage() function Allow the iohelper path to be customized by test programs Add a test case for the fdstream file read/write code .gitignore | 1 + include/libvirt/virterror.h | 2 + src/fdstream.c | 14 +- src/fdstream.h | 3 + src/libvirt_private.syms | 1 + src/libvirt_public.syms | 5 + src/util/virerror.c | 21 +++ tests/Makefile.am | 5 + tests/fdstreamtest.c | 353 ++++++++++++++++++++++++++++++++++++++++++++ 9 files changed, 404 insertions(+), 1 deletion(-) create mode 100644 tests/fdstreamtest.c -- 1.8.2.1

2 7

[libvirt] [PATCH] Fix iohelper usage with streams opened for read
by Daniel P. Berrange 10 May '13

10 May '13

From: "Daniel P. Berrange" <berrange(a)redhat.com> In b2878ed860ceceec3cd6481424fed0b543b687cd we added the O_NOCTTY flag when opening files in the stream code. Unfortunately a later piece of code was comparing the flags == O_RDONLY, without masking out the non-access mode flags. This broke the iohelper when used with streams for read, since it caused us to attach the stream output pipe to the stream input FD instead of output FD :-( Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- src/fdstream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/fdstream.c b/src/fdstream.c index 6f8ce53..a9a4851 100644 --- a/src/fdstream.c +++ b/src/fdstream.c @@ -641,7 +641,7 @@ virFDStreamOpenFileInternal(virStreamPtr st, virCommandTransferFD(cmd, fd); virCommandAddArgFormat(cmd, "%d", fd); - if (oflags == O_RDONLY) { + if ((oflags & O_ACCMODE) == O_RDONLY) { childfd = fds[1]; fd = fds[0]; virCommandSetOutputFD(cmd, &childfd); -- 1.8.2.1

2 2

[libvirt] [PATCH] Build breaker - requires VIR_FROM_THIS
by John Ferlan 10 May '13

10 May '13

Push under build-breaker --- tests/storagebackendsheepdogtest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/storagebackendsheepdogtest.c b/tests/storagebackendsheepdogtest.c index 39b2299..d4fa479 100644 --- a/tests/storagebackendsheepdogtest.c +++ b/tests/storagebackendsheepdogtest.c @@ -34,6 +34,7 @@ #include "storage/storage_backend_sheepdog.h" #include "virstring.h" +#define VIR_FROM_THIS VIR_FROM_NONE typedef struct { const char *output; -- 1.8.1.4

1 0

[libvirt] [libvirt-java] [PATCH] trivial remove unused imports
by Stefan Majer 10 May '13

10 May '13

Signed-off-by: Stefan Majer <stefan.majer at gmail dot com> --- src/main/java/org/libvirt/jna/Libvirt.java | 1 - src/main/java/org/libvirt/jna/virError.java | 1 - 2 files changed, 2 deletions(-) diff --git a/src/main/java/org/libvirt/jna/Libvirt.java b/src/main/java/org/libvirt/jna/Libvirt.java index 0a5e372..6da368f 100644 --- a/src/main/java/org/libvirt/jna/Libvirt.java +++ b/src/main/java/org/libvirt/jna/Libvirt.java @@ -7,7 +7,6 @@ import com.sun.jna.NativeLong; import com.sun.jna.Pointer; import com.sun.jna.ptr.IntByReference; import com.sun.jna.ptr.LongByReference; -import com.sun.jna.ptr.PointerByReference; /** * The libvirt interface which is exposed via JNA. The complete API is diff --git a/src/main/java/org/libvirt/jna/virError.java b/src/main/java/org/libvirt/jna/virError.java index 3c11311..36b9f69 100644 --- a/src/main/java/org/libvirt/jna/virError.java +++ b/src/main/java/org/libvirt/jna/virError.java @@ -3,7 +3,6 @@ package org.libvirt.jna; import java.util.Arrays; import java.util.List; -import com.sun.jna.Pointer; import com.sun.jna.Structure; /** -- 1.8.1.2 -- Stefan Majer

3 2

[libvirt] This patch allows virt-sandbox-service to add additional mount points.
by dwalsh＠redhat.com 10 May '13

10 May '13

We want to allow an admin to specify additional mount points at the command line. [sandbox PATCH 1/1] Add support for adding mountpoints via the

2 2

[libvirt] [PATCH 0/6 v3] Support NBD volumes with LXC containers
by Daniel P. Berrange 10 May '13

10 May '13

From: "Daniel P. Berrange" <berrange(a)redhat.com> A third version of: https://www.redhat.com/archives/libvir-list/2013-April/msg01539.html In v3 - Split patch 3 into 2 pieces - Added XML formatting tests - Fixed XML formatting - Remove !! from vars that are now bools Daniel P. Berrange (6): Add support for storage format in FS <driver> Re-arrange code setting up ifs/disk loop devices for LXC Fix error handling of readdir() in virFileLoopDeviceOpen Add a helper API for setting up a NBD device with qemu-nbd Add 'nbd' as a valid filesystem driver type Support NBD backed disks/filesystems in LXC driver docs/formatdomain.html.in | 25 +++++ docs/schemas/domaincommon.rng | 74 +++++++++++---- src/conf/domain_conf.c | 33 +++++-- src/conf/domain_conf.h | 7 +- src/libvirt_private.syms | 1 + src/lxc/lxc_controller.c | 152 ++++++++++++++++++++++------- src/qemu/qemu_command.c | 4 +- src/util/virfile.c | 153 +++++++++++++++++++++++++++++- src/util/virfile.h | 6 ++ tests/lxcxml2xmldata/lxc-disk-formats.xml | 31 ++++++ tests/lxcxml2xmltest.c | 1 + 11 files changed, 421 insertions(+), 66 deletions(-) create mode 100644 tests/lxcxml2xmldata/lxc-disk-formats.xml -- 1.8.2.1

2 13

[libvirt] [PATCH] virGetStorageVol: Don't ignore NULL pool name
by Michal Privoznik 10 May '13

10 May '13

The function takes pool name as argument. However, it is not acceptable for it to be NULL. Hence, we should check it and report error in case it is. --- src/datatypes.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/datatypes.c b/src/datatypes.c index f815b6c..884eb3e 100644 --- a/src/datatypes.c +++ b/src/datatypes.c @@ -520,6 +520,7 @@ virGetStorageVol(virConnectPtr conn, const char *pool, const char *name, virLibConnError(VIR_ERR_INVALID_CONN, "%s", _("no connection")); return NULL; } + virCheckNonNullArgReturn(pool, NULL); virCheckNonNullArgReturn(name, NULL); virCheckNonNullArgReturn(key, NULL); -- 1.8.2.1

2 1

[libvirt] [PATCH 0/2] Domain event example C code misues api
by Jesse J. Cook 10 May '13

10 May '13

From: "Jesse J. Cook" <jcook(a)camber.com> The example program makes a call to virEventRegisterDefaultImpl before calling virConnectOpen without a call to virInitialize. Interestingly enough, the example code works. However, once you introduce a call to g_string_new it breaks. This can result in unintentional misuse of the API. Relates to: Red Hat Bugzilla – Bug 961155 Jesse J. Cook (2): dom event example: init before register event impl dom event example: Add error check to impl call examples/domain-events/events-c/event-test.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) -- 1.7.10.4

2 5