December 2012 - Devel - libvirt List Archives

[libvirt] [PATCH 1/N] qemu driver FreeBSD support: fix compilation
by Roman Bogorodskiy 11 Dec '12

11 Dec '12

Another round of the FreeBSD patches. Here's the first chunk to fix compilation. Roman Bogorodskiy

4 4

[libvirt] [PATCH] docs: Document offline migration
by Jiri Denemark 11 Dec '12

11 Dec '12

--- docs/migration.html.in | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/docs/migration.html.in b/docs/migration.html.in index c6b62f7..f311655 100644 --- a/docs/migration.html.in +++ b/docs/migration.html.in @@ -136,6 +136,20 @@ facility should be used. </p> + <h2><a name="offline">Offline migration</a></h2> + + <p> + Offline migration transfers inactive definition of a domain (which + may or may not be active). After successful completion, the domain + remains in its current state on source host and is defined but + inactive on destination host. It's a bit more clever than + <code>virsh dumpxml</code> on source host followed by + <code>virsh define</code> on destination host, as offline migration + will run pre-migration hook to update the domain XML on destination + host. Currently, copying non-shared storage is not supported during + offline migration. + </p> + <h2><a name="uris">Migration URIs</a></h2> <p> -- 1.8.0

2 2

[libvirt] [PATCH 0/5] Fix async job type when doing external snapshots and improve error message handling
by Peter Krempa 11 Dec '12

11 Dec '12

This series adds error messages when trying to do a snapshot of a machine that has hostdevices assigned. Peter Krempa (5): qemu: Restart CPUs with valid async job type when doing external snapshots qemu: Make qemuMigrationIsAllowed more reusable qemu: snapshot: Report better error message if migration isn't allowed qemu: reuse qemuMigrationIsAllowed when doing save and managedsave [OPTIONAL] qemu: allow save and managedsave on guests marked as autodestroyable src/qemu/qemu_driver.c | 16 ++++++---------- src/qemu/qemu_migration.c | 45 ++++++++++++++++++++++++++------------------- src/qemu/qemu_migration.h | 2 ++ 3 files changed, 34 insertions(+), 29 deletions(-) -- 1.8.0

4 16

[libvirt] [PATCH] qemu: assume seccomp sandbox is supported since qemu 1.2
by Ján Tomko 11 Dec '12

11 Dec '12

Currently there is no way to detect it via QMP and requesting "-sandbox off" works correctly even if it was compiled out, so this will work unless someone both requests the sandbox in qemu.conf and builds QEMU without the support for it. --- Relevant discussion in qemu-devel: http://lists.nongnu.org/archive/html/qemu-devel/2012-12/msg00101.html --- src/qemu/qemu_capabilities.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 01a1b98..98e65f1 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -2283,6 +2283,7 @@ qemuCapsInitQMPBasic(qemuCapsPtr caps) qemuCapsSet(caps, QEMU_CAPS_WAKEUP); qemuCapsSet(caps, QEMU_CAPS_NO_USER_CONFIG); qemuCapsSet(caps, QEMU_CAPS_NETDEV_BRIDGE); + qemuCapsSet(caps, QEMU_CAPS_SECCOMP_SANDBOX); } -- 1.7.8.6

2 1

[libvirt] virDomainSetMetadata --> qemuDomainSetMetadata
by SHAH, Ronak (Ronak R) 11 Dec '12

11 Dec '12

Hi, I have requirement to add <metadata> tag into the libvirt XML from the application. While calling virDomainSetMetadata which internally call qemuDomainSetMetadata (correct me here if I am wrong), I am getting following error: qemuDomainSetMetdata:12623 : argument unsupported: QEMU driver does not support<metadata> element Support for setting and getting <metadata> with special namespace is deliberately added in 0.9.10 of libvirt and I am using 0.9.13. I am surprise that the internal qemu driver is still cribbing out it. I am passing following in my call: Type : VIR_DOMAIN_METADATA_ELEMENT Metadata: "<desc> Some Desc </desc>" Key: "Ronak" uri: "Ronak.com/Ronak/libvirt" Flags: 0 Can someone please help? Thanks, Ronak

3 3

[libvirt] [PATCH v3 0/8] Allow minimal bandwidth guarantee
by Michal Privoznik 11 Dec '12

11 Dec '12

This is a rework of my one year old patchset [1]. If you are brave enough and start reviewing it, you may want to read the last patch first. The whole magic hidden behind the scene is documented there. For now, the only supported combination where this works is virtual interface connected to virtual network. This network MUST have an inbound average set, at least. This tells how much bandwidth do we have, and how much can we guarantee. If we would miss this info, then we cannot guarantee anything. On the other hand, this is just a very small part of whole problem. Users MUST configure all other devices on traffic path to follow up their setting in libvirt. But that's out of our scope. 1: http://www.redhat.com/archives/libvir-list/2011-December/msg00486.html diff to v1: -Laine's suggestions worked in diff to v2: -again Laine's suggestions worked in (drop libvirt_network.syms, don't check for floor twice, etc.) Michal Privoznik (8): bandwidth: Attach sfq to leaf node bandwidth: add new 'floor' attribute bandwidth: Create hierarchical shaping classes bandwidth: Create (un)plug functions bandwidth: Create rate update function bandwidth: Create network bandwidth (un)plug functions network: Create real network status files domain: Keep assigned class_id in domstatus XML docs/formatdomain.html.in | 23 +++- docs/schemas/networkcommon.rng | 5 + po/POTFILES.in | 1 + src/conf/domain_conf.c | 19 ++- src/conf/domain_conf.h | 1 + src/conf/netdev_bandwidth_conf.c | 67 +++++++-- src/conf/netdev_bandwidth_conf.h | 3 +- src/conf/network_conf.c | 229 +++++++++++++++++++++----- src/conf/network_conf.h | 6 + src/libvirt_private.syms | 4 + src/lxc/lxc_process.c | 3 +- src/network/bridge_driver.c | 242 +++++++++++++++++++++++++++- src/qemu/qemu_command.c | 3 +- src/qemu/qemu_driver.c | 2 +- src/util/virnetdevbandwidth.c | 331 +++++++++++++++++++++++++++++++++++++- src/util/virnetdevbandwidth.h | 25 +++- src/util/virnetdevmacvlan.c | 2 +- 17 files changed, 886 insertions(+), 80 deletions(-) -- 1.7.8.6

2 17

[libvirt] [PATCH v0] qemu driver FreeBSD support
by Roman Bogorodskiy 11 Dec '12

11 Dec '12

Hello, Attached an initial version of the patch providing FreeBSD support for qemu driver. Initial discussion on the topic started here: https://www.redhat.com/archives/libvir-list/2012-November/msg00841.html Roman Bogorodskiy

4 4

[libvirt] [PATCH 0/8] parallels: add networking support
by Dmitry Guryanov 11 Dec '12

11 Dec '12

The goal of this patch series is to add initial support of networking to Parallels Cloud Server driver. Parallels driver will be able to show read-only list of virtual networks and manage network adapters of virtual machines (list, add, remove, change properties, switch to another virtual network). Dmitry Guryanov (8): parallels: parse information about network interfaces parallels: add support of network interfaces to parallelsDomainDefineXML parallels: move parallelsParseError to parallels_utils.h parallels: add network driver Use size_t for virNetworkIpDef structure parallels: parse virtual network properties parallels: add routed pseudo network parallels: handle network adapters of type 'routed' po/POTFILES.in | 2 + src/Makefile.am | 3 +- src/conf/network_conf.h | 4 +- src/parallels/parallels_driver.c | 314 ++++++++++++++++++- src/parallels/parallels_network.c | 639 +++++++++++++++++++++++++++++++++++++ src/parallels/parallels_utils.h | 9 + 6 files changed, 963 insertions(+), 8 deletions(-) create mode 100644 src/parallels/parallels_network.c -- 1.7.7.6

2 19

[libvirt] [PATCH v2 0/8] Allow minimal bandwidth guarantee
by Michal Privoznik 11 Dec '12

11 Dec '12

This is a rework of my one year old patchset [1]. If you are brave enough and start reviewing it, you may want to read the last patch first. The whole magic hidden behind the scene is documented there. For now, the only supported combination where this works is virtual interface connected to virtual network. This network MUST have an inbound average set, at least. This tells how much bandwidth do we have, and how much can we guarantee. If we would miss this info, then we cannot guarantee anything. On the other hand, this is just a very small part of whole problem. Users MUST configure all other devices on traffic path to follow up their setting in libvirt. But that's out of our scope. 1: http://www.redhat.com/archives/libvir-list/2011-December/msg00486.html diff to v1: -Laine's suggestions worked in Michal Privoznik (8): bandwidth: Attach sfq to leaf node bandwidth: add new 'floor' attribute bandwidth: Create hierarchical shaping classes bandwidth: Create (un)plug functions bandwidth: Create rate update function bandwidth: Create network bandwidth (un)plug functions network: Create real network status files domain: Keep assigned class_id in domstatus XML docs/formatdomain.html.in | 23 ++- docs/schemas/networkcommon.rng | 5 + po/POTFILES.in | 1 + src/Makefile.am | 7 +- src/conf/domain_conf.c | 19 ++- src/conf/domain_conf.h | 1 + src/conf/netdev_bandwidth_conf.c | 67 +++++++- src/conf/netdev_bandwidth_conf.h | 3 +- src/conf/network_conf.c | 230 +++++++++++++++++++++----- src/conf/network_conf.h | 6 + src/libvirt_network.syms | 13 ++ src/libvirt_private.syms | 9 +- src/lxc/lxc_process.c | 3 +- src/network/bridge_driver.c | 253 +++++++++++++++++++++++++++- src/qemu/qemu_command.c | 3 +- src/qemu/qemu_driver.c | 2 +- src/util/virnetdevbandwidth.c | 337 +++++++++++++++++++++++++++++++++++++- src/util/virnetdevbandwidth.h | 24 +++- src/util/virnetdevmacvlan.c | 2 +- 19 files changed, 920 insertions(+), 88 deletions(-) create mode 100644 src/libvirt_network.syms -- 1.7.8.6

2 21

[libvirt] [PATCH] qemu: fix uninitialized variable warning in doPeer2PeerMigrate
by Ján Tomko 11 Dec '12

11 Dec '12

False positive, but it breaks the build with gcc-4.6.3. qemu/qemu_migration.c:2931:37: error: 'offline' may be used uninitialized in this function [-Werror=uninitialized] qemu/qemu_migration.c:2887:10: note: 'offline' was declared here --- src/qemu/qemu_migration.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 0ca7dd4..8796eb6 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -2884,7 +2884,7 @@ static int doPeer2PeerMigrate(virQEMUDriverPtr driver, virConnectPtr dconn = NULL; bool p2p; virErrorPtr orig_err = NULL; - bool offline; + bool offline = false; VIR_DEBUG("driver=%p, sconn=%p, vm=%p, xmlin=%s, dconnuri=%s, " "uri=%s, flags=%lx, dname=%s, resource=%lu", -- 1.7.8.6

2 2