July 2011 - Devel - libvirt List Archives

[libvirt] [PATCH 0/3] RFC: setvcpus: support --current option
by Taku Izumi 15 Jul '11

15 Jul '11

Hi all, This patchset adds the --current option to "virsh setvcpus" command. Currently "virsh setvcpus" command supports "--live" and "--config" , but "--current" option. >From view of consistency, it's reasonable to support "--current" option too. *[PATCH 1/3] setvcpus: extend virDomainSetVcpusFlags API to support current flag *[PATCH 2/3] setvcpus: extend qemuDomainSetVcpusFlags() to support current flag *[PATCH 3/3] setvcpus: add "--current" option to "virsh setvcpus" Best regards, Taku Izumi <izumi.taku(a)jp.fujitsu.com>

2 7

[libvirt] [PATCH]: Add another portion virStream bindings (C# bindings, libvirt-csharp.git)
by Anthony Fox 15 Jul '11

15 Jul '11

2 1

[libvirt] [PATCH 0/8] Introduce new API virDomainUndefineFlags
by Osier Yang 15 Jul '11

15 Jul '11

Hi, Per discussion on https://www.redhat.com/archives/libvir-list/2011-July/msg00556.html, This patch series introduce new API virDomainUndefineFlags, which only support flag VIR_DOMAIN_UNDEFINE_MANAGED_STATE now, might introduce more flags in future. If the flag is specified, the domain managed state file will be removed along with domain undefine process once it exists, the entire domain undefine process will fail if it fails on removing the managed state file. [PATCH 1/8] is small fix on rpc generator scripts, not related with the new API. [PATCH 1/8] Small fixes on rpc generator scripts [PATCH 2/8] UndefineFlags: Define the public API [PATCH 3/8] UndefineFlags: Implement the public API [PATCH 4/8] UndefineFlags: Define the internal API [PATCH 5/8] UndefineFlags: Implement qemu driver handling [PATCH 6/8] UndefineFlags: Implement libxl driver handling [PATCH 7/8] UndefineFlags: Implement the remote protocol [PATCH 8/8] UndefineFlags: Extend virsh undefine to support new flag Regards Osier

4 26

[libvirt] [PATCH] Fix reporting of cert validation failures
by Daniel P. Berrange 15 Jul '11

15 Jul '11

If the server succesfully validates the client cert, it will send back a single byte, under TLS. If it fails, it will close the connection. In this case, we were just reporting the standard I/O error. The original RPC code had a special case hack for the GNUTLS_E_UNEXPECTED_PACKET_LENGTH error code to make us report a more useful error message * src/rpc/virnetclient.c: Return ENOMSG if we get GNUTLS_E_UNEXPECTED_PACKET_LENGTH * src/rpc/virnettlscontext.c: Report cert failure if we see ENOMSG --- src/rpc/virnetclient.c | 2 +- src/rpc/virnettlscontext.c | 3 +++ 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c index b9f0fc8..d3965c6 100644 --- a/src/rpc/virnetclient.c +++ b/src/rpc/virnetclient.c @@ -348,7 +348,7 @@ int virNetClientSetTLSSession(virNetClientPtr client, ignore_value(pthread_sigmask(SIG_BLOCK, &oldmask, NULL)); len = virNetTLSSessionRead(client->tls, buf, 1); - if (len < 0) { + if (len < 0 && errno != ENOMSG) { virReportSystemError(errno, "%s", _("Unable to read TLS confirmation")); goto error; diff --git a/src/rpc/virnettlscontext.c b/src/rpc/virnettlscontext.c index b778550..4963ab7 100644 --- a/src/rpc/virnettlscontext.c +++ b/src/rpc/virnettlscontext.c @@ -932,6 +932,9 @@ ssize_t virNetTLSSessionWrite(virNetTLSSessionPtr sess, case GNUTLS_E_INTERRUPTED: errno = EINTR; break; + case GNUTLS_E_UNEXPECTED_PACKET_LENGTH: + errno = ENOMSG; + break; default: errno = EIO; break; -- 1.7.4.4

2 1

[libvirt] [PATCH] Unregister event callback if a fatal error occurs during dispatch
by Daniel P. Berrange 15 Jul '11

15 Jul '11

If we get an I/O error in the async event callback for an RPC client, we might not have consumed all pending data off the wire. This could result in the callback being immediately invoked again. At which point the same I/O might occur. And we're invoked again. And again...And again... Unregistering the async event callback if an error occurs is a good safety net. The real error will be seen when the next RPC method is invoked * src/rpc/virnetclient.c: Unregister event callback on error --- src/rpc/virnetclient.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c index 9fb8fd4..58d4274 100644 --- a/src/rpc/virnetclient.c +++ b/src/rpc/virnetclient.c @@ -1124,8 +1124,10 @@ void virNetClientIncomingEvent(virNetSocketPtr sock, goto done; } - if (virNetClientIOHandleInput(client) < 0) - VIR_DEBUG("Something went wrong during async message processing"); + if (virNetClientIOHandleInput(client) < 0) { + VIR_WARN("Something went wrong during async message processing"); + virNetSocketRemoveIOCallback(sock); + } done: virNetClientUnlock(client); -- 1.7.4.4

2 1

[libvirt] [PATCH] Fix error message for missing TLS write function
by Daniel P. Berrange 15 Jul '11

15 Jul '11

* src/rpc/virnettlscontext.c: s/read/write/ --- src/rpc/virnettlscontext.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/rpc/virnettlscontext.c b/src/rpc/virnettlscontext.c index 4963ab7..6a06565 100644 --- a/src/rpc/virnettlscontext.c +++ b/src/rpc/virnettlscontext.c @@ -803,7 +803,7 @@ virNetTLSSessionPush(void *opaque, const void *buf, size_t len) { virNetTLSSessionPtr sess = opaque; if (!sess->writeFunc) { - VIR_WARN("TLS session push with missing read function"); + VIR_WARN("TLS session push with missing write function"); errno = EIO; return -1; }; -- 1.7.4.4

2 1

[libvirt] ANNOUNCE: libvirt Perl bindings Sys::Virt 0.9.3 release
by Daniel P. Berrange 15 Jul '11

15 Jul '11

I am happy to announce a new release[1] of the libvirt Perl bindings, Sys::Virt 0.9.3 is available for download: http://search.cpan.org/CPAN/authors/id/D/DA/DANBERR/Sys-Virt-0.9.3.tar.gz Changes in this release - Add all new APIs in libvirt 0.9.3 - Requires libvirt >= 0.9.3 The permanent link for the Sys::Virt package, where all historic releases can be found, is http://search.cpan.org/dist/Sys-Virt/ Thanks to everyone who contributed to this release through testing, bug reporting, patch submission, etc. I am now caught up to main libvirt releases and intended to track each new release more promptly in the future. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

1 0

[libvirt] [PATCH] util: fix a typo error on virStrncpy
by ajia＠redhat.com 15 Jul '11

15 Jul '11

* src/util/util.c: fix a typo error on virStrncpy. --- src/util/util.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/util/util.c b/src/util/util.c index 0ca81df..1080823 100644 --- a/src/util/util.c +++ b/src/util/util.c @@ -1754,7 +1754,7 @@ virStrncpy(char *dest, const char *src, size_t n, size_t destbytes) return NULL; ret = strncpy(dest, src, n); - /* strncpy NULL terminates iff the last character is \0. Therefore + /* strncpy NULL terminates if the last character is \0. Therefore * force the last byte to be \0 */ dest[n] = '\0'; -- 1.7.1

3 2

[libvirt] EMOTIVE Cloud based in Libvirt
by Alex Vaqué Brull 15 Jul '11

15 Jul '11

Hi, We can link in http://libvirt.org/apps.html EMOTIVE Cloud ( www.emotivecloud.net ) ? It is an interesting middleware based in Libvirt. Thank you

2 8

[libvirt] [PATCH] build: fix VPATH build of todo
by Eric Blake 15 Jul '11

15 Jul '11

Without this patch, the make rule in a VPATH build was trying to invoke ../../docs/../../docs/todo.pl, which didn't exist. * docs/Makefile.am (todo.html.in): Using $< already implies $(srcdir) in GNU make VPATH situations. --- Pushing under the trivial rule. docs/Makefile.am | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index 050ebe1..7ff94a0 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -104,7 +104,7 @@ web: $(dot_html) html/index.html devhelp/index.html todo.html.in: todo.pl if [ -f todo.cfg ]; then \ echo "Generating $@"; \ - $(PERL) $(srcdir)/$< > $@ \ + $(PERL) $< > $@ \ || { rm $@ && exit 1; }; \ else \ echo "Stubbing $@"; \ -- 1.7.4.4

2 1