February 2011 - Devel - libvirt List Archives

[libvirt] [PATCH] Update src/README
by Matthias Bolte 13 Feb '11

13 Feb '11

Add missing subdirectories. --- src/README | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/README b/src/README index 75acbe0..ad171a5 100644 --- a/src/README +++ b/src/README @@ -20,6 +20,8 @@ There are two core shared modules to be aware of: files used by the public API. This directory is only in the include path for driver implementation modules + * vmx/ - VMware VMX config handling (used by esx/ and vmware/) + Then there are the hypervisor implementations: @@ -33,7 +35,9 @@ Then there are the hypervisor implementations: * test/ - A "mock" driver for testing * uml/ - User Mode Linux * vbox/ - Virtual Box using native API + * vmware/ - VMware Workstation and Player using the vmrun tool * xen/ - Xen using hypercalls, XenD SEXPR & XenStore + * xenapi/ - Xen using libxenserver Finally some secondary drivers that are shared for several HVs. @@ -41,8 +45,10 @@ Currently these are used by LXC, OpenVZ, QEMU, UML and Xen drivers. The ESX, OpenNebula, Power Hypervisor, Remote, Test & VirtualBox drivers all implement the secondary drivers directly + * cpu/ - CPU feature management * interface/ - Host network interface management * network/ - Virtual NAT networking + * nwfilter/ - Network traffic filtering rules * node_device/ - Host device enumeration * secret/ - Secret management * security/ - Mandatory access control drivers -- 1.7.0.4

2 2

[libvirt] [PATCH] Avoid pthread_sigmask on Win32 platforms
by Daniel P. Berrange 12 Feb '11

12 Feb '11

Win32 doesn't have a concept of signal masks so disable that code. It is unclear how SIGINT is delivered (if at all) on Win32, so this might further work to provide an alternative to pthread_sigmask * tools/virsh.c: Avoid pthread_sigmask on Win32 --- tools/virsh.c | 20 +++++++++++++++----- 1 files changed, 15 insertions(+), 5 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index be2cd67..6d9861f 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -3489,15 +3489,17 @@ doMigrate (void *opaque) const char *migrateuri; const char *dname; int flags = 0, found; - sigset_t sigmask, oldsigmask; vshCtrlData *data = opaque; vshControl *ctl = data->ctl; const vshCmd *cmd = data->cmd; +#if HAVE_PTHREAD_SIGMASK + sigset_t sigmask, oldsigmask; sigemptyset(&sigmask); sigaddset(&sigmask, SIGINT); if (pthread_sigmask(SIG_BLOCK, &sigmask, &oldsigmask) < 0) goto out_sig; +#endif if (!vshConnectionUsability (ctl, ctl->conn)) goto out; @@ -3563,8 +3565,10 @@ doMigrate (void *opaque) } out: +#if HAVE_PTHREAD_SIGMASK pthread_sigmask(SIG_SETMASK, &oldsigmask, NULL); out_sig: +#endif if (dom) virDomainFree (dom); ignore_value(safewrite(data->writefd, &ret, sizeof(ret))); } @@ -3607,12 +3611,16 @@ cmdMigrate (vshControl *ctl, const vshCmd *cmd) struct sigaction old_sig_action; virDomainJobInfo jobinfo; bool verbose = false; - sigset_t sigmask, oldsigmask; int timeout; struct timeval start, curr; bool live_flag = false; - vshCtrlData data; +#if HAVE_PTHREAD_SIGMASK + sigset_t sigmask, oldsigmask; + + sigemptyset(&sigmask); + sigaddset(&sigmask, SIGINT); +#endif if (!(dom = vshCommandOptDomain(ctl, cmd, NULL))) return FALSE; @@ -3665,8 +3673,6 @@ cmdMigrate (vshControl *ctl, const vshCmd *cmd) pollfd.fd = p[0]; pollfd.events = POLLIN; pollfd.revents = 0; - sigemptyset(&sigmask); - sigaddset(&sigmask, SIGINT); GETTIMEOFDAY(&start); while (1) { @@ -3709,9 +3715,13 @@ repoll: } if (verbose) { +#if HAVE_PTHREAD_SIGMASK pthread_sigmask(SIG_BLOCK, &sigmask, &oldsigmask); +#endif ret = virDomainGetJobInfo(dom, &jobinfo); +#if HAVE_PTHREAD_SIGMASK pthread_sigmask(SIG_SETMASK, &oldsigmask, NULL); +#endif if (ret == 0) print_job_progress(jobinfo.dataRemaining, jobinfo.dataTotal); } -- 1.7.4

3 9

[libvirt] [PATCH] build: avoid problems with autogen.sh runs from tarball
by Eric Blake 12 Feb '11

12 Feb '11

Introduced by commit fac97c65c distributing cfg.mk, which previously could blindly assume it was in a git checkout. * cfg.mk (_update_required): Also check for .git. * autogen.sh: Don't run bootstrap from a tarball. Reported by Daniel Veillard. --- This should fix the issues of mistakenly running git on a tarball, as reported here: https://www.redhat.com/archives/libvir-list/2011-February/msg00371.html autogen.sh | 27 +++++++++++++++------------ cfg.mk | 1 + 2 files changed, 16 insertions(+), 12 deletions(-) diff --git a/autogen.sh b/autogen.sh index ff13fd1..b64521e 100755 --- a/autogen.sh +++ b/autogen.sh @@ -8,8 +8,8 @@ THEDIR=`pwd` cd "$srcdir" test -f src/libvirt.c || { - echo "You must run this script in the top-level libvirt directory" - exit 1 + echo "You must run this script in the top-level libvirt directory" + exit 1 } @@ -52,16 +52,19 @@ bootstrap_hash() # Also, running 'make rpm' tends to litter the po/ directory, and some people # like to run 'git clean -x -f po' to fix it; but only ./bootstrap regenerates # the required file po/Makevars. -curr_status=.git-module-status -t=$(bootstrap_hash; git diff .gnulib) -if test "$t" = "$(cat $curr_status 2>/dev/null)" \ - && test -f "po/Makevars"; then - # good, it's up to date, all we need is autoreconf - autoreconf -if -else - echo running bootstrap$no_git... - ./bootstrap$no_git --bootstrap-sync && bootstrap_hash > $curr_status \ - || { echo "Failed to bootstrap, please investigate."; exit 1; } +# Only run bootstrap from a git checkout, never from a tarball. +if test -d .git; then + curr_status=.git-module-status + t=$(bootstrap_hash; git diff .gnulib) + if test "$t" = "$(cat $curr_status 2>/dev/null)" \ + && test -f "po/Makevars"; then + # good, it's up to date, all we need is autoreconf + autoreconf -if + else + echo running bootstrap$no_git... + ./bootstrap$no_git --bootstrap-sync && bootstrap_hash > $curr_status \ + || { echo "Failed to bootstrap, please investigate."; exit 1; } + fi fi cd "$THEDIR" diff --git a/cfg.mk b/cfg.mk index 120f452..4bbeb96 100644 --- a/cfg.mk +++ b/cfg.mk @@ -507,6 +507,7 @@ ifeq (0,$(MAKELEVEL)) _submodule_hash = sed 's/^[ +-]//;s/ .*//' _update_required := $(shell \ cd '$(srcdir)'; \ + test -d .git || { echo 0; exit; }; \ test -f po/Makevars || { echo 1; exit; }; \ actual=$$(git submodule status | $(_submodule_hash); \ git hash-object bootstrap.conf; \ -- 1.7.4

2 2

[libvirt] [PATCH] qemu: Report a more informative error for missing cgroup controllers
by Matthias Bolte 12 Feb '11

12 Feb '11

Patch attached. Matthias

2 2

[libvirt] [PATCH] docs: Distribute XSLT files to generate HACKING
by Matthias Bolte 12 Feb '11

12 Feb '11

Patch attached. Matthias

2 2

[libvirt] Unix socket credentials on OSX?
by Justin Clift 12 Feb '11

12 Feb '11

Hi all, Interestingly, MacOS X has a working PolicyKit port, providing version 0.96. Attempting to build libvirt 0.8.7 against it gives this error though: libvirtd.c:1298:4: error: #error "UNIX socket credentials not supported/implemented on this platform yet..." Does anyone have an idea of whether implementing Unix socket credentials for OSX would be a big task, or a small one, or ? I'm thinking this could be what's needed to let qemu+ssh:// connections from OSX to RHEL/Fedora servers work. Not critical at all, but would be nice, etc. :) Regards and best wishes, Justin Clift

1 0

[libvirt] [PATCH v2] xen: Prevent updating device when attaching a device
by Osier Yang 12 Feb '11

12 Feb '11

When attaching a device that already exists, xend driver updates the device with "device_configure", it causes problems (e.g. for disk device, 'device_configure' only can be used to update device like CDROM), on the other hand, we provide additional API (virDomainUpdateDevice) to update device, this fix is to raise up errors instead of updating the existed device which is not CDROM device. Changes from v1 to v2: - allow update CDROM * src/xen/xend_internal.c --- src/xen/xend_internal.c | 42 +++++++++++++++++++++++++++++++++++++----- 1 files changed, 37 insertions(+), 5 deletions(-) diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c index cd30336..bc23595 100644 --- a/src/xen/xend_internal.c +++ b/src/xen/xend_internal.c @@ -3965,6 +3965,7 @@ xenDaemonAttachDeviceFlags(virDomainPtr domain, const char *xml, virDomainDefPtr def = NULL; virBuffer buf = VIR_BUFFER_INITIALIZER; char class[8], ref[80]; + char *target = NULL; if ((domain == NULL) || (domain->conn == NULL) || (domain->name == NULL)) { virXendError(VIR_ERR_INVALID_ARG, __FUNCTION__); @@ -4029,6 +4030,13 @@ xenDaemonAttachDeviceFlags(virDomainPtr domain, const char *xml, STREQ(def->os.type, "hvm") ? 1 : 0, priv->xendConfigVersion, 1) < 0) goto cleanup; + + if (dev->data.disk->device != VIR_DOMAIN_DISK_DEVICE_CDROM) { + if (!(target = strdup(dev->data.disk->dst))) { + virReportOOMError(); + goto cleanup; + } + } break; case VIR_DOMAIN_DEVICE_NET: @@ -4038,6 +4046,14 @@ xenDaemonAttachDeviceFlags(virDomainPtr domain, const char *xml, STREQ(def->os.type, "hvm") ? 1 : 0, priv->xendConfigVersion, 1) < 0) goto cleanup; + + char macStr[VIR_MAC_STRING_BUFLEN]; + virFormatMacAddr(dev->data.net->mac, macStr); + + if (!(target = strdup(macStr))) { + virReportOOMError(); + goto cleanup; + } break; case VIR_DOMAIN_DEVICE_HOSTDEV: @@ -4046,6 +4062,17 @@ xenDaemonAttachDeviceFlags(virDomainPtr domain, const char *xml, if (xenDaemonFormatSxprOnePCI(dev->data.hostdev, &buf, 0) < 0) goto cleanup; + + virDomainDevicePCIAddress PCIAddr; + + PCIAddr = dev->data.hostdev->source.subsys.u.pci; + virAsprintf(&target, "PCI device: %.4x:%.2x:%.2x", PCIAddr.domain, + PCIAddr.bus, PCIAddr.slot); + + if (target == NULL) { + virReportOOMError(); + goto cleanup; + } } else { virXendError(VIR_ERR_NO_SUPPORT, "%s", _("unsupported device type")); @@ -4065,17 +4092,22 @@ xenDaemonAttachDeviceFlags(virDomainPtr domain, const char *xml, /* device doesn't exist, define it */ ret = xend_op(domain->conn, domain->name, "op", "device_create", "config", sexpr, NULL); - } - else { - /* device exists, attempt to modify it */ - ret = xend_op(domain->conn, domain->name, "op", "device_configure", - "config", sexpr, "dev", ref, NULL); + } else { + if (dev->data.disk->device != VIR_DOMAIN_DISK_DEVICE_CDROM) { + virXendError(VIR_ERR_OPERATION_INVALID, + _("target '%s' already exists"), target); + } else { + /* device exists, attempt to modify it */ + ret = xend_op(domain->conn, domain->name, "op", "device_configure", + "config", sexpr, "dev", ref, NULL); + } } cleanup: VIR_FREE(sexpr); virDomainDefFree(def); virDomainDeviceDefFree(dev); + VIR_FREE(target); return ret; } -- 1.7.3.2

3 5

[libvirt] [PATCH] build: fix cygwin strerror_r failure
by Eric Blake 12 Feb '11

12 Feb '11

Building the 0.8.8 release candidate on cygwin produced this compiler warning, which is indicative of catastrophic failure on any attempt to print an error message with errno turned to a string: CC strerror_r.lo strerror_r.c: In function 'rpl_strerror_r': strerror_r.c:67: warning: assignment makes integer from pointer without a cast This has been fixed in gnulib. * .gnulib: Update to latest, for strerror_r fix. * src/util/memory.c (includes): Satisfy 'make syntax-check'. --- Pushing this under the build-breaker rule, even if cygwin is the only platform where the build was broken. * .gnulib 2f41af6...4cce65c (113): > doc: update users.txt > doc: update users.txt > doc: update users.txt > gnulib-tool: Make copyright notice adjustment more robust. > New module 'towctrans'. > New module 'wctrans'. > New module 'iswctype'. > New module 'wctype'. > wctype-h: Ensure wctype_t and wctrans_t are defined. > flock: fix license typo > Split large sed scripts, for HP-UX sed. > stdlib: improve random_r modularization > stdlib: don't depend on stdint > getloadavg: don't depend on c-strtod, cloexec, fcntl-safer > di-set.h, ino-map.h: add multiple-inclusion guard > iswblank: Ensure declaration on glibc systems. > New module 'iswblank'. > di-set tests: Refactor. > ino-map tests: Refactor. > di-set: add "const" to a cast > ChangeLog: fix my old entry to give credit to Bastien > update from texinfo > Rename module 'wctype' to 'wctype-h'. > New module 'wcswidth'. > New module 'wcstok'. > New module 'wcsstr'. > New module 'wcspbrk'. > New module 'wcsspn'. > New module 'wcscspn'. > New module 'wcsrchr'. > New module 'wcschr'. > New module 'wcsdup'. > New module 'wcsxfrm'. > New module 'wcscoll'. > New module 'wcsncasecmp'. > New module 'wcscasecmp'. > New module 'wcsncmp'. > New module 'wcscmp'. > New module 'wcsncat'. > New module 'wcscat'. > New module 'wcpncpy'. > New module 'wcsncpy'. > New module 'wcpcpy'. > New module 'wcscpy'. > New module 'wcsnlen'. > New module 'wcslen'. > New module 'wmemset'. > New module 'wmemmove'. > New module 'wmemcpy'. > New module 'wmemcmp'. > di-set, ino-map: new modules, from coreutils > getloadavg: merge minor changes from Emacs > Allow multiple gnulib generated replacements to coexist. > libposix: Revert the unreviewed part of yesterday's big merge. > unsetenv: work around Haiku issues > libposix: Add _HEADERS primaries to posix modules. Modify gnulib-tool to strip them from generated Makefile.am-s where they are not needed. Also, replace M4 macro prefixes when requested. Finally, omit calls to error() for libposix. > strerror_r-posix: port to cygwin > New module 'wmemchr', part 3. > New module 'wmemchr', part 2. > New module 'wmemchr'. > fdopendir: detect FreeBSD bug > stdbool: do not define HAVE_STDBOOL_H > wcsnrtombs: Prepare for new module wwcsnrtombs. > wcsrtombs: Prepare for new module wwcsrtombs. > mbsnrtowcs: Prepare for new module mbsnrtowwcs. > mbsrtowcs: Prepare for new module mbsrtowwcs. > vasnprintf: Reduce use of malloc for small format strings. > autoudpate > update from texinfo > dup2: work around Haiku bug > doc: off_t is not available in eglibc 2.11.2 stdio.h. > ignore-value: add missing test dependency > mktime: clarify long_int width checking > ignore-value: Fix self-test. > TYPE_MAXIMUM: avoid theoretically undefined behavior > mktime: #undef mktime before #defining it > mktime: systematically normalize tm_isdst comparisons > mktime: fix some integer overflow issues and sidestep the rest > mktime: avoid infinite loop > rename, unlink, same-inode: Relicense. > mktime: avoid problems on NetBSD 5 / i386 > autoupdate > mktime: fix misspelling in comment > move-if-change: cope with concurrent mv of identical file. > users.txt: Mention sharutils. > doc: Update users.txt > Prepare for supporting FreeBSD 10. > Prepare for supporting FreeBSD 10. > vma-iter, get-rusage-as: Add OpenBSD support. > more make vars for makeinfo > regen > fcntl: work around Haiku F_DUPFD bugs > autoupdate > Enable memory leak tests on AIX. > Tests for module 'get-rusage-data'. > New module 'get-rusage-data'. > get-rusage-as: Allow for easier testing. > vma-iter: Treat Haiku like BeOS. > c-stack: fix regression on cygwin when libsigsegv is present > autoupdate > vma-iter: Avoid empty intervals. > u64: remove unnecessary #include > Allow the user to avoid the GNULIB_TEST_* macros. > New module 'vma-iter'. > uninorm: Tweak includes. > get-rusage-as: Improve on NetBSD. > xreadlink.h: remove unnecessary #include > maint.mk: add syntax-check rule: detect unnecessary #include <stddef.h> > get-rusage-as: Fix bug. > wctype: Ensure valid C syntax. > wctype: Ensure valid C syntax. > getopt: omit HAVE_OPTRESET, HAVE_GETOPT_CLIP from config.h > gl_CHECK_NEXT_HEADERS implies AC_CHECK_HEADERS_ONCE .gnulib | 2 +- src/util/memory.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.gnulib b/.gnulib index 2f41af6..4cce65c 160000 --- a/.gnulib +++ b/.gnulib @@ -1 +1 @@ -Subproject commit 2f41af65087fb2460779bc4e7fb62453f79ebae3 +Subproject commit 4cce65cb2f10936f13760625f39d532564984fde diff --git a/src/util/memory.c b/src/util/memory.c index 03e2e80..bfa32a8 100644 --- a/src/util/memory.c +++ b/src/util/memory.c @@ -1,7 +1,7 @@ /* * memory.c: safer memory allocation * - * Copyright (C) 2010 Red Hat, Inc. + * Copyright (C) 2010-2011 Red Hat, Inc. * Copyright (C) 2008 Daniel P. Berrange * * This library is free software; you can redistribute it and/or @@ -22,7 +22,6 @@ #include <config.h> #include <stdlib.h> -#include <stddef.h> #include "memory.h" #include "ignore-value.h" -- 1.7.4

1 0

[libvirt] [PATCH] qemu: Fix escape_monitor(escape_shell(command))
by Philipp Hahn 12 Feb '11

12 Feb '11

Suspending a VM which contains shell meta characters doesn't work with libvirt-0.8.7: /var/log/libvirt/qemu/andreas_231-ne\ doch\ nicht.log: sh: -c: line 0: syntax error near unexpected token `doch' sh: -c: line 0: `cat | { dd bs=4096 seek=1 if=/dev/null && dd bs=1048576; } Although target="andreas_231-ne doch nicht" contains shell meta characters (here: blanks), they are not properly escaped by src/qemu/qemu_monitor_{json,text}.c#qemuMonitor{JSON,Text}MigrateToFile() First, the filename needs to be properly escaped for the shell, than this command line has to be properly escaped for qemu again. For this to work, remove the old qemuMonitorEscapeArg() wrapper, rename qemuMonitorEscape() to it removing the handling for shell=TRUE, and implement a new qemuMonitorEscapeShell() returning strings using single quotes. Using double quotes or escaping special shell characters with backslashes would also be possible, but the set of special characters heavily depends on the concrete shell (dsh, bash, zsh) and its setting (history expansion, interactive use, ...) Signed-off-by: Philipp Hahn <hahn(a)univention.de> --- src/qemu/qemu_monitor.c | 65 +++++++++++++++++++++++++++------------------- 1 files changed, 38 insertions(+), 27 deletions(-)

2 1

[libvirt] [RFC PATCH 0/6] Switch over qemu command line capabilities to virBitmap
by Jiri Denemark 12 Feb '11

12 Feb '11

There are two main reasons behind this patchset: - we are getting very close to 64 flags which is the maximum we can use with unsigned long long - by using LL constants in enum we already violates C99 constraint that enum values have to fit into int This is a very conflict-prone patchset so I'd like to get some feedback on the ideas and naming used so that this could possible be among the first patches pushed after 0.8.8 release. Patches 2/6 and 4/6 are fully and 3/6 mostly mechanical. 5/6 and 6/6 need to be squashed into a single patch but are provided separately for easier review. Jiri Denemark (6): util: Add API for converting virBitmap into printable string qemu: Rename QEMUD_CMD_FLAG_* to QEMU_CAPS_* qemu: Use helper functions for handling cmd line capabilities qemu: Rename qemud\?CmdFlags to qemuCaps qemu: Switch over command line capabilities to virBitmap tests: Use virBitmap for qemu command line caps src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 238 +++++++++----- src/qemu/qemu_capabilities.h | 150 +++++---- src/qemu/qemu_command.c | 384 +++++++++++----------- src/qemu/qemu_command.h | 30 +- src/qemu/qemu_driver.c | 106 ++++--- src/qemu/qemu_hotplug.c | 162 +++++----- src/qemu/qemu_hotplug.h | 32 +- src/util/bitmap.c | 32 ++- src/util/bitmap.h | 3 + tests/qemuargv2xmltest.c | 2 +- tests/qemuhelptest.c | 745 +++++++++++++++++++++--------------------- tests/qemuxml2argvtest.c | 470 +++++++++++++------------- 13 files changed, 1249 insertions(+), 1106 deletions(-) -- 1.7.4

3 20