February 2011 - Devel - libvirt List Archives

[libvirt] [PATCH] qemu: Remove redundant error reporting codes
by Osier Yang 18 Feb '11

18 Feb '11

As virDomainDefParseString already reported the error if it fails, and the redundant error reports codes will override error reported by virDomainDefParseString with some unclear messages, removed them. * src/qemu/qemu_driver.c --- src/qemu/qemu_driver.c | 33 +++++++++++++-------------------- 1 files changed, 13 insertions(+), 20 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index ab664a0..fd8e401 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3600,8 +3600,10 @@ static virDomainPtr qemudDomainCreate(virConnectPtr conn, const char *xml, virCheckFlags(VIR_DOMAIN_START_PAUSED, NULL); qemuDriverLock(driver); - if (!(def = virDomainDefParseString(driver->caps, xml, - VIR_DOMAIN_XML_INACTIVE))) + + def = virDomainDefParseString(driver->caps, xml, VIR_DOMAIN_XML_INACTIVE); + if (!def) + /* virDomainDefParseString reports the error. */ goto cleanup; if (virSecurityManagerVerify(driver->securityManager, def) < 0) @@ -5746,12 +5748,9 @@ qemudDomainSaveImageOpen(struct qemud_driver *driver, } /* Create a domain from this XML */ - if (!(def = virDomainDefParseString(driver->caps, xml, - VIR_DOMAIN_XML_INACTIVE))) { - qemuReportError(VIR_ERR_OPERATION_FAILED, - "%s", _("failed to parse XML")); + def = virDomainDefParseString(driver->caps, xml, VIR_DOMAIN_XML_INACTIVE); + if (!def) goto error; - } VIR_FREE(xml); @@ -6412,8 +6411,9 @@ static virDomainPtr qemudDomainDefine(virConnectPtr conn, const char *xml) { int dupVM; qemuDriverLock(driver); - if (!(def = virDomainDefParseString(driver->caps, xml, - VIR_DOMAIN_XML_INACTIVE))) + + def = virDomainDefParseString(driver->caps, xml, VIR_DOMAIN_XML_INACTIVE); + if (!def) goto cleanup; if (virSecurityManagerVerify(driver->securityManager, def) < 0) @@ -8046,13 +8046,9 @@ qemudDomainMigratePrepareTunnel(virConnectPtr dconn, } /* Parse the domain XML. */ - if (!(def = virDomainDefParseString(driver->caps, dom_xml, - VIR_DOMAIN_XML_INACTIVE))) { - qemuReportError(VIR_ERR_OPERATION_FAILED, - "%s", _("failed to parse XML, libvirt version may be " - "different between source and destination host")); + def = virDomainDefParseString(driver->caps, dom_xml, VIR_DOMAIN_XML_INACTIVE); + if (!def) goto cleanup; - } if (!qemuDomainIsMigratable(def)) goto cleanup; @@ -8320,12 +8316,9 @@ qemudDomainMigratePrepare2 (virConnectPtr dconn, VIR_DEBUG("Generated uri_out=%s", *uri_out); /* Parse the domain XML. */ - if (!(def = virDomainDefParseString(driver->caps, dom_xml, - VIR_DOMAIN_XML_INACTIVE))) { - qemuReportError(VIR_ERR_OPERATION_FAILED, - "%s", _("failed to parse XML")); + def = virDomainDefParseString(driver->caps, dom_xml, VIR_DOMAIN_XML_INACTIVE); + if (!def) goto cleanup; - } if (!qemuDomainIsMigratable(def)) goto cleanup; -- 1.7.4

2 3

[libvirt] [PATCH 0/2] virsh: freecell --all getting wrong NUMA nodes count
by Michal Privoznik 18 Feb '11

18 Feb '11

This is fix for virsh freecell command. I was using virNodeGetInfo() instead of virConnectGetCapabilities() which returns XML with the right number. Therefore we need XML/XPath function to pick node values from XML kept in buffer. Moreover, this function might be used to replace bad practise in cmdVcpucount(). Michal Privoznik (2): virsh.c: new xPathULong() to parse XML returning ulong value of selected node. virsh: fix wrong NUMA nodes count getting tools/virsh.c | 76 ++++++++++++++++++++++++++++++++++++++++++++++++-------- 1 files changed, 65 insertions(+), 11 deletions(-) -- 1.7.3.5

4 5

[libvirt] [PATCH] Do not add drive 'boot=on' param when a kernel is specified
by Jim Fehlig 18 Feb '11

18 Feb '11

libvirt-tck was failing several domain tests [1] with qemu 0.14, which is now less tolerable of specifying 2 bootroms with the same boot index [2]. Drop the 'boot=on' param if kernel has been specfied. [1] https://www.redhat.com/archives/libvir-list/2011-February/msg00559.html [2] http://lists.nongnu.org/archive/html/qemu-devel/2011-02/msg01892.html --- src/qemu/qemu_command.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 618d3a9..a9cc23b 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -3173,7 +3173,7 @@ qemuBuildCommandLine(virConnectPtr conn, int bootCD = 0, bootFloppy = 0, bootDisk = 0; /* If QEMU supports boot=on for -drive param... */ - if (qemuCmdFlags & QEMUD_CMD_FLAG_DRIVE_BOOT) { + if (qemuCmdFlags & QEMUD_CMD_FLAG_DRIVE_BOOT && !def->os.kernel) { for (i = 0 ; i < def->os.nBootDevs ; i++) { switch (def->os.bootDevs[i]) { case VIR_DOMAIN_BOOT_CDROM: -- 1.7.3.1

2 2

[libvirt] [PATCH 0/2] Refactored XM and SEXPR parsing
by Markus Groß 17 Feb '11

17 Feb '11

Hi, I refactored the XM and SEXPR parsing routines from the xen-unified driver into a seperate directory (xenxs; x for xm and s for sexpr). This way different xen-drivers besides xen-unified are able to use the parsing functionality. For example the upcoming XenLight (libxl) driver. To use the XM parsing functions one includes "xen_xm.h" and for SEXPR parsing "xen_sxpr.h". The patch is rather big, but most of it are code movements. Some parsing functions required a driver object to fetch the tty path and vncport. I removed all references to a specific driver and added additional parameters as a replacement. The tests sexpr2xml, xmconfig and xml2sexpr are adapted and show no error. Thanks in advance for your comments about this. Cheers, Markus Markus Groß (2): Moved Xen SEXPR and XM parsing functionality to seperate directory. Added to authors to please make syntax-check AUTHORS | 1 + configure.ac | 4 + include/libvirt/virterror.h | 2 +- src/Makefile.am | 15 +- src/util/virterror.c | 4 +- src/xen/sexpr.c | 568 ---- src/xen/sexpr.h | 55 - src/xen/xen_driver.c | 19 +- src/xen/xend_internal.c | 6673 ++++++++++++++----------------------------- src/xen/xend_internal.h | 30 - src/xen/xm_internal.c | 1706 +----------- src/xen/xm_internal.h | 3 - src/xenxs/sexpr.c | 647 +++++ src/xenxs/sexpr.h | 63 + src/xenxs/xen_sxpr.c | 2149 ++++++++++++++ src/xenxs/xen_sxpr.h | 62 + src/xenxs/xen_xm.c | 1716 +++++++++++ src/xenxs/xen_xm.h | 41 + src/xenxs/xenxs_private.h | 63 + tests/sexpr2xmltest.c | 12 +- tests/xmconfigtest.c | 5 +- tests/xml2sexprtest.c | 4 +- 22 files changed, 7012 insertions(+), 6830 deletions(-) delete mode 100644 src/xen/sexpr.c delete mode 100644 src/xen/sexpr.h create mode 100644 src/xenxs/sexpr.c create mode 100644 src/xenxs/sexpr.h create mode 100644 src/xenxs/xen_sxpr.c create mode 100644 src/xenxs/xen_sxpr.h create mode 100644 src/xenxs/xen_xm.c create mode 100644 src/xenxs/xen_xm.h create mode 100644 src/xenxs/xenxs_private.h -- 1.7.4.1

4 5

[libvirt] 0.8.8 and virtio console
by Ruben Kerkhof 17 Feb '11

17 Feb '11

Hi all, This used to work on libvirt-0.8.7: <console type='pty'> <target type='virtio'/> </console> Using the same configuration with libvirt-0.8.8: [root@ev004 ~]# virsh create /data/4d5d8a24-bb70-4eff-b1b5-3d8e5bd5c355.xml error: Failed to create domain from /data/4d5d8a24-bb70-4eff-b1b5-3d8e5bd5c355.xml error: internal error no assigned pty for device console0 I'm using qemu-kvm-0.14.0-0.1.201102107aa8c46. Here's the log from starting a guest with 0.8.7: LC_ALL=C PATH=/sbin:/usr/sbin:/bin:/usr/bin QEMU_AUDIO_DRV=none /usr/bin/qemu-kvm -S -M pc-0.14 -cpu core2duo,+lahf_lm,+popcnt,+sse4.2,+sse4.1,+cx16,-monitor,-vme -enable-kvm -m 512 -smp 2,sockets=2,cores=1,threads=1 -name 4d5d8a24-bb70-4eff-b1b5-3d8e5bd5c355 -uuid 4d5d8a24-bb70-4eff-b1b5-3d8e5bd5c355 -nodefconfig -nodefaults -chardev socket,id=monitor,path=/var/lib/libvirt/qemu/4d5d8a24-bb70-4eff-b1b5-3d8e5bd5c355.monitor,server,nowait -mon chardev=monitor,mode=control -rtc base=utc -boot c -device virtio-serial-pci,id=virtio-serial0,bus=pci.0,addr=0x5 -drive file=/dev/vgdata/4d5d8a24-bb70-4eff-b1b5-3d8e5bd5c355-root,if=none,id=drive-virtio-disk0,boot=on,format=raw,cache=none -device virtio-blk-pci,bus=pci.0,addr=0x6,drive=drive-virtio-disk0,id=virtio-disk0 -drive file=/dev/vgdata/4d5d8a24-bb70-4eff-b1b5-3d8e5bd5c355-swap,if=none,id=drive-virtio-disk1,format=raw,cache=none -device virtio-blk-pci,bus=pci.0,addr=0x7,drive=drive-virtio-disk1,id=virtio-disk1 -netdev tap,fd=64,id=hostnet0,vhost=on,vhostfd=65 -device virtio-net-pci,netdev=hostnet0,id=net0,mac=00:16:3e:50:a4:55,bus=pci.0,addr=0x3 -netdev tap,fd=66,id=hostnet1,vhost=on,vhostfd=67 -device virtio-net-pci,netdev=hostnet1,id=net1,mac=00:16:3e:71:c1:49,bus=pci.0,addr=0x4 -chardev pty,id=console0 -device virtconsole,chardev=console0 -usb -device usb-tablet,id=input0 -vnc 0.0.0.0:1,password -vga std char device redirected to /dev/pts/14 And the same guest with 0.8.8: LC_ALL=C PATH=/sbin:/usr/sbin:/bin:/usr/bin QEMU_AUDIO_DRV=none /usr/bin/qemu-kvm -S -M pc-0.14 -cpu core2duo,+lahf_lm,+popcnt,+sse4.2,+sse4.1,+cx16,-monitor,-vme -enable-kvm -m 512 -smp 2,sockets=2,cores=1,threads=1 -name 4d5d8a24-bb70-4eff-b1b5-3d8e5bd5c355 -uuid 4d5d8a24-bb70-4eff-b1b5-3d8e5bd5c355 -nodefconfig -nodefaults -chardev socket,id=charmonitor,path=/var/lib/libvirt/qemu/4d5d8a24-bb70-4eff-b1b5-3d8e5bd5c355.monitor,server,nowait -mon chardev=charmonitor,id=monitor,mode=control -rtc base=utc -boot c -device virtio-serial-pci,id=virtio-serial0,bus=pci.0,addr=0x5 -drive file=/dev/vgdata/4d5d8a24-bb70-4eff-b1b5-3d8e5bd5c355-root,if=none,id=drive-virtio-disk0,boot=on,format=raw,cache=none -device virtio-blk-pci,bus=pci.0,addr=0x6,drive=drive-virtio-disk0,id=virtio-disk0 -drive file=/dev/vgdata/4d5d8a24-bb70-4eff-b1b5-3d8e5bd5c355-swap,if=none,id=drive-virtio-disk1,format=raw,cache=none -device virtio-blk-pci,bus=pci.0,addr=0x7,drive=drive-virtio-disk1,id=virtio-disk1 -netdev tap,fd=33,id=hostnet0,vhost=on,vhostfd=34 -device virtio-net-pci,netdev=hostnet0,id=net0,mac=00:16:3e:50:a4:55,bus=pci.0,addr=0x3 -netdev tap,fd=35,id=hostnet1,vhost=on,vhostfd=36 -device virtio-net-pci,netdev=hostnet1,id=net1,mac=00:16:3e:71:c1:49,bus=pci.0,addr=0x4 -chardev pty,id=charconsole0 -device virtconsole,chardev=charconsole0,id=console0 -usb -device usb-tablet,id=input0 -vnc 0.0.0.0:1,password -vga std char device redirected to /dev/pts/14 Kind regards, Ruben Kerkhof

1 0

[libvirt] Still in freeze, third rc tarball available
by Daniel Veillard 17 Feb '11

17 Feb '11

Thanks everybody for the testing feedback and fixes, in retrospect I should really had done this in previous releases ! So the third rc tarball is out, it's likely to be the last one before the release (within 48 hours): ftp://libvirt.org/libvirt/libvirt-0.8.8-rc3.tar.gz give it a try ! thanks, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

8 11

[libvirt] [PATCH] check more error info about whether drive_add failed
by Wen Congyang 17 Feb '11

17 Feb '11

When we attach a disk, but we specify a wrong format of disk image, qemu monitor command drive_add will fail, but libvirt does not detect this error. Signed-off-by: Wen Congyang <wency(a)cn.fujitsu.com> --- src/qemu/qemu_monitor_text.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_monitor_text.c b/src/qemu/qemu_monitor_text.c index 6d0ba4c..0fd7546 100644 --- a/src/qemu/qemu_monitor_text.c +++ b/src/qemu/qemu_monitor_text.c @@ -2453,6 +2453,12 @@ int qemuMonitorTextAddDrive(qemuMonitorPtr mon, goto cleanup; } + if (strstr(reply, "could not open disk image")) { + qemuReportError(VIR_ERR_OPERATION_FAILED, "%s", + _("open disk image file failed")); + goto cleanup; + } + ret = 0; cleanup: -- 1.7.1

2 1

[libvirt] [PATCH] cgroup: preserve correct errno on failure
by Eric Blake 17 Feb '11

17 Feb '11

* src/util/cgroup.c (virCgroupSetValueStr, virCgroupGetValueStr) (virCgroupRemoveRecursively): VIR_DEBUG can clobber errno. (virCgroupRemove): Use VIR_DEBUG rather than DEBUG. --- src/util/cgroup.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/util/cgroup.c b/src/util/cgroup.c index 47c4633..b71eef9 100644 --- a/src/util/cgroup.c +++ b/src/util/cgroup.c @@ -290,8 +290,8 @@ static int virCgroupSetValueStr(virCgroupPtr group, VIR_DEBUG("Set value '%s' to '%s'", keypath, value); rc = virFileWriteStr(keypath, value, 0); if (rc < 0) { - DEBUG("Failed to write value '%s': %m", value); rc = -errno; + VIR_DEBUG("Failed to write value '%s': %m", value); } else { rc = 0; } @@ -313,7 +313,7 @@ static int virCgroupGetValueStr(virCgroupPtr group, rc = virCgroupPathOfController(group, controller, key, &keypath); if (rc != 0) { - DEBUG("No path of %s, %s", group->path, key); + VIR_DEBUG("No path of %s, %s", group->path, key); return rc; } @@ -321,8 +321,8 @@ static int virCgroupGetValueStr(virCgroupPtr group, rc = virFileReadAll(keypath, 1024, value); if (rc < 0) { - DEBUG("Failed to read %s: %m\n", keypath); rc = -errno; + VIR_DEBUG("Failed to read %s: %m\n", keypath); } else { /* Terminated with '\n' has sometimes harmful effects to the caller */ char *p = strchr(*value, '\n'); @@ -635,8 +635,8 @@ static int virCgroupRemoveRecursively(char *grppath) if (grpdir == NULL) { if (errno == ENOENT) return 0; - VIR_ERROR(_("Unable to open %s (%d)"), grppath, errno); rc = -errno; + VIR_ERROR(_("Unable to open %s (%d)"), grppath, errno); return rc; } @@ -665,7 +665,7 @@ static int virCgroupRemoveRecursively(char *grppath) } closedir(grpdir); - DEBUG("Removing cgroup %s", grppath); + VIR_DEBUG("Removing cgroup %s", grppath); if (rmdir(grppath) != 0 && errno != ENOENT) { rc = -errno; VIR_ERROR(_("Unable to remove %s (%d)"), grppath, errno); @@ -710,7 +710,7 @@ int virCgroupRemove(virCgroupPtr group) &grppath) != 0) continue; - DEBUG("Removing cgroup %s and all child cgroups", grppath); + VIR_DEBUG("Removing cgroup %s and all child cgroups", grppath); rc = virCgroupRemoveRecursively(grppath); VIR_FREE(grppath); } -- 1.7.4

4 8

[libvirt] Release of libvirt-0.8.8
by Daniel Veillard 17 Feb '11

17 Feb '11

As scheduled the release is out, and available from the site: ftp://libvirt.org/libvirt/ Thanks everybody for the earlier testing on the release candidate series that was I think quite useful ! So this release is again mostly consisting of a very large batch of small improvements and bug fixes, and a few new features: Features: - sysinfo: expose new API (Eric Blake) - cgroup blkio weight support. (Gui Jianfeng) - smartcard device support (Eric Blake) - qemu: Support per-device boot ordering (Jiri Denemark) Documentation: - docs: fix typos (Eric Blake) - docs: added link for nimbus to apps page (Justin Clift) - Update src/README (Matthias Bolte) - docs: Add information about libvirt-php new location (Michal Novotny) - Add libvirt-php information page (Michal Novotny) - cgroup: Add documentation for blkiotune elements. (Gui Jianfeng) - docs/index.html.in: update KVM url (Niels de Vos) - docs/index.html.in: update QEMU url (Alon Levy) - docs: more on qemu locking patterns (Eric Blake) - docs: renamed hudson project link to jenkins, matching project rename (Justin Clift) - docs: Update docs for cpu_shares setting (Osier Yang) - docs: replace CRLF with LF (Juerg Haefliger) - docs: Add docs for new extra parameter pkipath (Osier Yang) - docs: expand the man page text for virsh setmaxmem (Justin Clift) - docs: fix incorrect XML element mentioned by setmem text (Justin Clift) - docs: add a link to the bindings page under the downloads menu item (Justin Clift) - docs: document <controller> element (Eric Blake) - docs: move the apps page to the top level as its good promo (Justin Clift) - docs: added new entries to apps page, plus adjusted a few existing (Justin Clift) - docs: document <sysinfo> and <smbios> elements (Eric Blake) - datatypes: Fix outdated function names in the documentation (Matthias Bolte) - Add documentation for VIR_DOMAIN_MEMORY_PARAM_UNLIMITED (Matthias Bolte) - docs: Move the "Network Filtering" page one level up in the hierarchy (Matthias Bolte) - docs: add buildbot to the apps page (Justin Clift) - docs: add new conversion heading to the apps listing (Justin Clift) - docs: updated windows page for new 0.8.7 installer (Justin Clift) - docs: clarify virsh setvcpus and setmem usage with active domains (Justin Clift) - Document HAP domain feature (Jim Fehlig) - docs: fix trivial typos in currentMemory description (Justin Clift) - doc: improve the documentation of desturi (Wen Congyang) - docs: reorder apps page alphabetically, plus add libguestfs entries (Justin Clift) - docs: add entry for archipel to the apps page (Justin Clift) - docs: use xml entity encoding for extended character last name (Justin Clift) - docs: updated memtune info again in virsh command reference (Justin Clift) - docs: updated release of virsh cmd reference, with memtune info (Justin Clift) - maint: document dislike of mismatched if/else bracing (Eric Blake) - docs: added libvirt-announce to contact page (Justin Clift) Portability: - qemu: ignore failure of qemu -M ? on older qemu (Eric Blake) - virsh: avoid mingw compiler warnings (Eric Blake) - build: avoid problems with autogen.sh runs from tarball (Eric Blake) - build: fix cygwin strerror_r failure (Eric Blake) - Avoid pthread_sigmask on Win32 platforms (Daniel P. Berrange) - Fix compilation when building without sasl (Daniel Veillard) - build: fix parted detection at configure time (Eric Blake) - Fix setup of lib directory with autogen.sh --system (Daniel P. Berrange) - build: fix 'make check' with older git (Eric Blake) - maint: support --no-git option during autogen.sh (Eric Blake) - libvirt-guests: remove bashisms (Laurent Léonard) - build: restore mingw build (Eric Blake) - commandtest: avoid printing loader-control variables from commandhelper (Diego Elio Pettenò) Bug Fixes: - cgroup: preserve correct errno on failure (Eric Blake) - qemu: Fix command line generation with faked host CPU (Jiri Denemark) - tests: Fake host capabilities properly (Jiri Denemark) - build: address clang reports about virCommand (Eric Blake) - qemu: don't mask real error with oom report (Eric Blake) - qemu: avoid NULL derefs (Eric Blake) - virDomainMemoryStats: avoid null dereference (Eric Blake) - Fix leak of mutex attributes in POSIX threads impl (Daniel P. Berrange) - Fix leak in SCSI storage backend (Daniel P. Berrange) - storage: Create enough volumes for mpath pool (Osier Yang) - qemu: avoid NULL deref on error (Eric Blake) - conf: Fix XML generation for smartcards (Jiri Denemark) - Fix cleanup on VM state after failed QEMU startup (Daniel P. Berrange) - libvirt-qemu: Fix enum type declaration (Jiri Denemark) - xen: Prevent updating device when attaching a device (Osier Yang) - qemu: Fix escape_monitor(escape_shell(command)) (Philipp Hahn) - qemu: fix attach-interface regression (Wen Congyang) - Fix typo in parsing of spice 'auth' data (Michal Privoznik) - Reset logging filter function when forking (Daniel P. Berrange) - Block SIGPIPE around virExec hook functions (Daniel P. Berrange) - Only initialize/cleanup libpciaccess once (Daniel P. Berrange) - macvtap: fix 2 nla_put expressions (non-serious bug) (Stefan Berger) - qemu: avoid double shutdown (Eric Blake) - Fix conflicts with glibc globals (Davidlohr Bueso) - qemuBuildDeviceAddressStr() checks for QEMUD_CMD_FLAG_PCI_MULTIBUS (Niels de Vos) - Don't sleep in poll() if there is existing SASL decoded data (Daniel P. Berrange) - Initialization error of controller in QEmu SCSI hotplug (Wen Congyang) - esx: Ensure max-memory has 4 megabyte granularity (Matthias Bolte) - Remove double close of qemu monitor (Daniel P. Berrange) - Prevent overfilling of self-pipe in python event loop (Daniel P. Berrange) - avoid vm to be deleted if qemuConnectMonitor failed (Wen Congyang) - tests: Fix virtio channel tests (Jiri Denemark) - event: fix event-handling allocation crash (Eric Blake) - storage: Round up capacity for LVM volume creation (Osier Yang) - Do not use virtio-serial port 0 for generic ports (David Allan) - Manually kill gzip if restore fails before starting qemu (Laine Stump) - Set SELinux context label of pipes used for qemu migration (Laine Stump) - virsh: require --mac to avoid detach-interface ambiguity (Michal Privoznik) - dispatch error before return (Wen Congyang) - event: fix event-handling data race (Eric Blake) - qemu: Retry JSON monitor cont cmd on MigrationExpected error (Jim Fehlig) - Fix startup with VNC password expiry on old QEMU (Daniel P. Berrange) - Fix error reporting when machine type probe fails (Daniel P. Berrange) - Avoid crash in security driver if model is NULL (Daniel P. Berrange) - qemu: Fix a possible deadlock in p2p migration (Wen Congyang) - qemu: Avoid sending STOPPED event twice (Jiri Denemark) - spec: Start libvirt-guests only if it's on in current runlevel (Jiri Denemark) - Increase size of driver table to make UML work again (Daniel P. Berrange) - qemu: don't fail capabilities check on 0.12.x (Eric Blake) - Fix 'make check' after commit 04197350 (Jim Fehlig) - esx: Fix memory leak in HostSystem managed object free function (Matthias Bolte) - qemu: Watchdog IB700 is not a PCI device (RHBZ#667091). (Richard W.M. Jones) - cpu: plug memory leak (Eric Blake) - network: plug memory leak (Eric Blake) - network: plug unininitialized read found by valgrind (Eric Blake) - remote: Don't lose track of events when callbacks are slow (Cole Robinson) - conf: Report error if invalid type specified for character device (Osier Yang) - daemon: Fix core dumps if unix_sock_group is set (Jiri Denemark) - vbox: Use correct VRAM size unit (Matthias Bolte) - bridge: Fix generation of dnsmasq's --dhcp-hostsfile option (Kay Schubert) - qemu: Fix bogus warning about uninitialized saveptr (Jiri Denemark) - Don't chown qemu saved image back to root after save if dynamic_ownership=0 (Laine Stump) Improvements: - maint: delete unused 'make install' step (Eric Blake) - Update czech localization (Zdenek Styblik) - Avoid empty strings when --with-packager(-version) is not specified (Matthias Bolte) - Output commandline on status != 0 in virCommandWait (Matthias Bolte) - add missing error handling to virGetDomain (Christophe Fergeau) - call virReportOOMError when appropriate in hash.c (Christophe Fergeau) - xml: avoid compiler warning (Eric Blake) - nwfilter: reorder match extensions relative to state match (Stefan Berger) - fix OOM handling in hash routines (Christophe Fergeau) - docs: Distribute XSLT files to generate HACKING (Matthias Bolte) - qemu: Report a more informative error for missing cgroup controllers (Matthias Bolte) - Imprint all logs with version + package build information (Daniel P. Berrange) - Reduce log level when cgroups aren't mounted (Daniel P. Berrange) - Avoid warnings from nwfilter driver when run non-root (Daniel P. Berrange) - build: distribute 'make syntax-check' tweaks (Eric Blake) - Adjust some log levels in udev driver (Daniel P. Berrange) - Add check for binary existing in machine type probe (Daniel P. Berrange) - Add a little more debugging for async events (Daniel P. Berrange) - Move connection driver modules directory (Daniel P. Berrange) - Support SCSI RAID type & lower log level for unknown types (Daniel P. Berrange) - Don't use CLONE_NEWUSER for now (Serge E. Hallyn) - sysinfo: implement qemu support (Eric Blake) - sysinfo: refactor xml formatting (Eric Blake) - sysinfo: implement virsh support (Eric Blake) - sysinfo: implement the remote protocol (Eric Blake) - sysinfo: implement the public API (Eric Blake) - sysinfo: define internal driver API (Eric Blake) - LXC: LXC Blkio weight configuration support. (Gui Jianfeng) - qemu: Implement blkio tunable XML configuration and parsing. (Gui Jianfeng) - cgroup: Update XML Schema for new entries. (Gui Jianfeng) - cgroup: Implement blkio.weight tuning API. (Gui Jianfeng) - cgroup: Enable cgroup hierarchy for blkio cgroup (Gui Jianfeng) - Update Dutch and Polish localizations (Daniel Veillard) - Vietnamese translations for libvirt (Hero Phương) - spicevmc: support older -device spicevmc of qemu 0.13.0 (Eric Blake) - smartcard: add spicevmc support (Eric Blake) - spicevmc: support new qemu chardev (Daniel P. Berrange) - smartcard: turn on qemu support (Eric Blake) - smartcard: enable SELinux support (Eric Blake) - smartcard: check for qemu capability (Eric Blake) - smartcard: add domain conf support (Eric Blake) - smartcard: add XML support for <smartcard> device (Eric Blake) - qemu: Support booting from hostdev PCI devices (Jiri Denemark) - Support booting from hostdev devices (Jiri Denemark) - qemu: Add shortcut for HMP pass through (Jiri Denemark) - macvtap: fix variable in debugging output (Stefan Berger) - qemu: Build command line for incoming tunneled migration (Osier Yang) - bridge_driver: handle DNS over IPv6 (Paweł Krześniak) - tests: handle backspace-newline pairs in test input files (Juerg Haefliger) - qemu: More clear error parsing domain def failure of tunneled migration (Osier Yang) - maint: reject raw close, popen in 'make syntax-check' (Eric Blake) - build: avoid close, system (Eric Blake) - Add VIR_DIV_UP to divide memory or storage request sizes with round up (Matthias Bolte) - qemu: fix augeas support for vnc_auto_unix_socket (Eric Blake) - virsh: added --all flag to freecell command (Michal Privoznik) - esx: Don't try to change max-memory of an active domain (Matthias Bolte) - qemu aio: enable support (Eric Blake) - qemu aio: parse aio support from qemu -help (Matthias Dahl) - qemu aio: add XML parsing (Matthias Dahl) - Remove bogus log warning lines when launching QEMU (Daniel P. Berrange) - qemu: fix error messages (Eric Blake) - qemu: Report more accurate error on failure to attach device. (Hu Tao) - Force guest suspend at timeout (Wen Congyang) - Show migration progress. (Wen Congyang) - Cancel migration if user presses Ctrl-C when migration is in progress (Hu Tao) - qemu: use separate alias for chardev and associated device (Eric Blake) - remote: Add extra parameter pkipath for URI (Osier Yang) - Update localization files from Fedora i10n (Daniel Veillard) - Add check for poll error events in monitor (Daniel P. Berrange) - Filter out certain expected error messages from libvirtd (Daniel P. Berrange) - Add a function to the security driver API that sets the label of an open fd. (Laine Stump) - qemu: Error prompt when managed save a shutoff domain (Osier Yang) - build: avoid corrupted gnulib/tests/Makefile (Eric Blake) - qemu: sound: Support intel 'ich6' model (Cole Robinson) - vmx: Use VIR_ERR_CONFIG_UNSUPPORTED when appropriated (Matthias Bolte) - Push unapplied fixups for previous patch (Cole Robinson) - qemu: Add conf option to auto setup VNC unix sockets (Cole Robinson) - qemu: Allow serving VNC over a unix domain socket (Cole Robinson) - qemu: Set domain def transient at beginning of startup process (Cole Robinson) - qemu: report more proper error for unsupported graphics (Osier Yang) - qemu: Fail if per-device boot is used but deviceboot is not supported (Jiri Denemark) - Turn libvirt.c error reporting functions into macros (Daniel P. Berrange) - build: use more gnulib modules for simpler code (Eric Blake) - Remove two unused PATH_MAX-sized char arrays from the stack (Matthias Bolte) - Use VIR_ERR_OPERATION_INVALID when appropriated (Matthias Bolte) - Fix misuse of VIR_ERR_INVALID_* error code (Matthias Bolte) - Simplify "NWFilterPool" to "NWFilter" (Matthias Bolte) - datatypes: Get virSecretFreeName in sync with the other free functions (Matthias Bolte) - qemu: use -incoming fd:n to avoid qemu holding fd indefinitely (Eric Blake) - tests: Add tests for per-device boot elements (Jiri Denemark) - Introduce per-device boot element (Jiri Denemark) - conf: Move boot parsing into a separate function (Jiri Denemark) - build: let xgettext see strings in libvirt-guests (Eric Blake) - A couple of fixes for the search PHP code (Daniel Veillard) - virsh: Use WITH_SECDRIVER_APPARMOR to detect AppArmor support (Matthias Bolte) - memtune: Let virsh know the unlimited value for memory tunables (Nikunj A. Dadhania) - maint: improve sc_prohibit_strncmp syntax check (Eric Blake) - Enable tuning of qemu network tap device "sndbuf" size (Laine Stump) - Add XML config switch to enable/disable vhost-net support (Laine Stump) - Use the new set_password monitor command to set password. (Marc-André Lureau) - qemu: add set_password and expire_password monitor commands (Marc-André Lureau) - qemu: move monitor device out of domain_conf common code (Eric Blake) - domain_conf: split source data out from ChrDef (Eric Blake) - cpu: Add support for Westmere CPU model (Jiri Denemark) - qemu: improve device flag parsing (Eric Blake) - util: add missing string->integer conversion functions (Eric Blake) - qemu: convert capabilities to use virCommand (Eric Blake) - virsh: ensure --maximum flag used only with --config for setvcpus (Justin Clift) - Add HAP to xen hypervisor capabilities (Jim Fehlig) - Add support for HAP feature to xen drivers (Jim Fehlig) - Add HAP to virDomainFeature enum (Jim Fehlig) - tests: virsh is no longer in builddir/src (Eric Blake) - virFindFileInPath: only find executable non-directory (Eric Blake) - Fix old PHP syntax in the search online form (Daniel Veillard) - report error when specifying wrong desturi (Wen Congyang) - qemu: Reject SDL graphic if it's not supported by qemu (Osier Yang) - vbox: Silently ignore missing registry key on Windows (Matthias Bolte) - python: Use PyCapsule API if available (Cole Robinson) - event-test: Simplify debug on/off (Cole Robinson) - Refactor the security drivers to simplify usage (Daniel P. Berrange) - Add AM_MAINTAINER_MODE (Guido Günther) - esx: Move occurrence check into esxVI_LookupObjectContentByType (Matthias Bolte) - esx: Add domain autostart support (Matthias Bolte) - vmx: Add support for video device VRAM size (Matthias Bolte) - API: Improve log for domain related APIs (Osier Yang) - schema: tighten <serial><protocol type=...> relaxNG (Eric Blake) - Log an error on attempts to add a NAT rule for non-IPv4 addresses (Laine Stump) - Improve error reporting when parsing dhcp info for virtual networks (Laine Stump) - qemu driver: fix positioning to end of log file (Stefan Berger) - build: satisfy 'make syntax-check' regarding year change (Eric Blake) Cleanups: - build: silence some clang warnings (Eric Blake) - maint: kill dead assignments (Eric Blake) - build: silence false positive clang report (Eric Blake) - maint: whitespace cleanup (Eric Blake) - maint: update AUTHORS (Eric Blake) - Prefer C style comments over C++ ones (Matthias Bolte) - Revert all previous error log priority hacks (Daniel P. Berrange) - Cleanup code style in logging APIs (Daniel P. Berrange) - Remove redundant brackets around return values (Daniel P. Berrange) - tests: Remove obsolete secaatest (Matthias Bolte) - datatypes: avoid redundant __FUNCTION__ (Eric Blake) Thanks everybody for the patches, reports and documentation improvements ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

4 5

[libvirt] [PATCH 0/2] Add tx_alg attribute to interface XML for virtio backend
by Laine Stump 17 Feb '11

17 Feb '11

These two patches provide the ability to configure which of two algorithms is used on the TX side of the virtio-net-pci device. Details are in the comments for PATCH 2/2. There are also at least a couple of open questions about the patch, which are posed in the comments of 2/2. It's highly unlikely this patch will be pushed as-is - I'm sending it mostly to solicit comments on those questions.

2 11