April 2008 - Devel - libvirt List Archives

[libvir] [PATCH] Bad permissions on /var/run/libvirt/
by Anton Protopopov 24 Apr '08

24 Apr '08

Hi, Non-root can't use /var/run/libvirt/libvirt-sock even in the case "unix_sock_group" and "unix_sock_rw_perms" are set properly. The reason: # ls -l /var/run /var/run/libvirt | grep libvirt | grep -v pid drwx------ 2 root root 4096 Apr 14 19:14 libvirt srwxrwx--- 1 root libvirt 0 Apr 14 19:14 libvirt-sock srwxrwxrwx 1 root libvirt 0 Apr 14 19:14 libvirt-sock-ro i.e., bad permissions on /var/run/libvirt One possible solution (implied in the attached patch) is the following: Every time libvirtd starts * it implicitly sets the group id of /var/run/libvirt: chown(/var/run/libvirt, -1, unix_sock_gid). * if "unix_sock_group" defined in /etc/libvirt/libvirtd.conf, libvirtd does chmod g+x /var/run/libvirt otherwise, chmod g-x /var/run/libvirt A.

2 5

[Libvir] Extra options to dnsmasq
by PATTE, Mathieu 22 Apr '08

22 Apr '08

Hi everyone! Is there any way I can pass extra options to dnsmasq when starting a virtual network? I need that in order to specify static dhcp leases. (is there another way to do that?) Thanks, Mathieu Patte Electronic Ground Support Equipment Engineer EADS Astrium 31 rue des Cosmonautes Z.I. du Palays 31402 Toulouse Cedex 4 France Phone : +33562199032 Mail : mathieu.patte(a)astrium.eads.net <mailto:mathieu.patte@astrium.eads.net> Ce courriel (incluant ses eventuelles pieces jointes) peut contenir des informations confidentielles et/ou protegees ou dont la diffusion est restreinte. Si vous avez recu ce courriel par erreur, vous ne devez ni le copier, ni l'utiliser, ni en divulguer le contenu a quiconque. Merci d'en avertir immediatement l'expediteur et d'effacer ce courriel de votre systeme. Astrium decline toute responsabilite en cas de corruption par virus, d'alteration ou de falsification de ce courriel lors de sa transmission par voie electronique. This email (including any attachments) may contain confidential and/or privileged information or information otherwise protected from disclosure. If you are not the intended recipient, please notify the sender immediately, do not copy this message or any attachments and do not use it for any purpose or disclose its content to any person, but delete this message and any attachments from your system. Astrium disclaims any and all liability if this email transmission was virus corrupted, altered or falsified. --------------------------------------------------------------------- Astrium SAS (393 341 516 RCS Paris) - Siege social: 6 rue Laurent Pichat, 75016 Paris, France

2 1

[Libvir] [patch] fix typos
by Atsushi SAKAI 22 Apr '08

22 Apr '08

Hi, Fix typos on proxy/libvirt_proxy.c. Thanks Atsushi SAKAI

2 1

[Libvir] PATCH: Re-structuring the libvirt.org website content
by Daniel P. Berrange 21 Apr '08

21 Apr '08

The current way we structure and manage the website for libvirt.org is becoming (has become) unsustainable as we add more features which in turn require more documentation. The first problem is all content is in a single huge file docs/libvir.html, from which each individual page is then extracted. When adding new content I find myself spending more time just scrolling up & down the file trying to find my place, than actually writing content. The obvious change is to split this file up, so that it is one file per page on the website. With some clever XSL we can still keep the benefit of automatically merging the content with the shared HTML layout / navigation. The second problem is that the navigation is completely flat, giving rise to the increasingly long set of the links down the left hand side. This is discouraging the addition of new pages with the result too much content is lumped together in the same page, and making it harder to navigate the site. I started to write some more content for the serial device format, but gave up and decided to spent the time this weekend attempting to address these two problems to create a more developer & user friendly website, and then writing some more general content for the site too. The patch is rather unsuprisingly enourmous so I am not attaching it to this mail. Instead I have uploaded it to http://berrange.fedorapeople.org/libvirt/libvirt-website.patch Reading the patch isn't too interesting - you're probably more interested in the end result, so I've also uploaded a demo copy showing the proposed new style and site navigation: http://berrange.fedorapeople.org/libvirt/website-demo/index.html The 'sitemap' page is a good place to start if you want to see how it all fits together. NB, this demo of the site structure will be removed after a few days because we don't want to disrupt the google index for the main site, so if you're reading this message from the archives just go to the main http://libvirt.org site to see how it all evolved... The changes to the build process / source structure are as follows: - The giant docs/libvir.html file is now removed, and all its content is placed into individual files named XXX.html.in where XXX is the name of the page as viewed on the site. The markup in the XXX.html.in files consists soley of the actual page content inside the <body> tag. There is no <head> data. There is no navigation or style markup in these XXX.html.in files. They are the pure content of each page. This makes writing new content very clear and straightforward. - There is now a hiearchical navigation structure, with 10 pages at the top level, and the rest nested below these levels. The master structure for the site is defined in the file sitemap.html.in which is also exposed directly on the site http://berrange.fedorapeople.org/libvirt/website-demo/sitemap.html - The page.xsl file reads the site structure from the sitemap.html.in file and builds up a context-sensitive menu on the left hand site of every page. Sub-levels in the hierarchy will be automatically expanded as neccessary. - Content from the XXX.html.in files is processed by the site.xsl transform to add in the page navigation and metadata. The site.xsl transform calls to the page.xsl file to pull in navigation. The resulting generated pages are named XXX.html as before. - The newapi.xsl file has been updated to make use of page.xsl to pull in the navigation menu to the API reference pages. - The ChangeLog.xsl file has been updated to make use of page.xsl to pull in the navigation menu Adding a new page is now very straightforward: - Create a new file XXX.html.in in the docs/ directory and write the content you desire - Edit the docs/sitemap.html.in file and add a link to the new page at the appropriate place in the site hierarchy - this automagically deals with the left hand context nav menu. - Type 'make web' to generate the XXX.html page with navigation and update navigation in the other pages. Finally the content changes / additions. First of all, all existing content from the site is still there - it has merely been re-arranged in places. - The content on the front page is refreshed to give a succinct summary of what libvirt is about, inspired by the oVirt front page: http://berrange.fedorapeople.org/libvirt/website-demo/index.html - There is a page for every hypervisor driver, which is intended to describe the requirements of the driver, and provide example XML documents for the driver. I have added some basic content for the Xen and QEMU drivers - other drivers still need docs http://berrange.fedorapeople.org/libvirt/website-demo/drvxen.html http://berrange.fedorapeople.org/libvirt/website-demo/drvqemu.html - There is a page for every XML format used by libvirt. I've mostly copied content from the existing format.html and storage.html pages into these new pages unchanged, and added some info on the virtual network XML. All of thee pages need some major revision though, since the existing content is severely out of date for domains, and capabilities. http://berrange.fedorapeople.org/libvirt/website-demo/formatdomain.html http://berrange.fedorapeople.org/libvirt/website-demo/formatnetwork.html http://berrange.fedorapeople.org/libvirt/website-demo/formatstorage.html http://berrange.fedorapeople.org/libvirt/website-demo/formatcaps.html - There is a page for every major subsystem in libvirt, describing the concepts behind that part of the API. There are pages for domains, networks, storage and node devices. Again we have a need for more content in this area to give developers a high level overview of our API concepts. Much of this information exists in email threads from the time at which we designed the APIs (in particular true for storage & network APIs). http://berrange.fedorapeople.org/libvirt/website-demo/intro.html http://berrange.fedorapeople.org/libvirt/website-demo/archdomain.html http://berrange.fedorapeople.org/libvirt/website-demo/archnetwork.html http://berrange.fedorapeople.org/libvirt/website-demo/archstorage.html - There are pages for language bindings, though there is only content for python http://berrange.fedorapeople.org/libvirt/website-demo/bindings.html http://berrange.fedorapeople.org/libvirt/website-demo/python.html - There are pages focusing on deployment issues such as building / install of libvirt, deploying on windows, remote management config, authentication config and URI formats. This content is all unchanged from existing pages http://berrange.fedorapeople.org/libvirt/website-demo/uri.html http://berrange.fedorapeople.org/libvirt/website-demo/remote.html http://berrange.fedorapeople.org/libvirt/website-demo/auth.html http://berrange.fedorapeople.org/libvirt/website-demo/windows.html - The API docs are of course seemlessly included in the site structure http://berrange.fedorapeople.org/libvirt/website-demo/html/index.html http://berrange.fedorapeople.org/libvirt/website-demo/html/libvirt-libvirt.… http://berrange.fedorapeople.org/libvirt/website-demo/html/libvirt-virterro… IMHO, we could do with re-structuring these APIs docs though. The main libvirt-libvirt.html page is getting too large to deal with. It would be better for developers if we could split up into sections for each of the major public objects, virConnectPtr, virDomainPtr, virNetworkPtr virStoragePoolPtr and virStorageVolPtr and their associated APIs. This shouldn't be too hard todo with a little tweaking of the API docs generator. - The related links are now on a page of their own, since the list on the left hand menu was getting too large. http://berrange.fedorapeople.org/libvirt/website-demo/relatedlinks.html - There is a page describing all applications using libvirt as their API http://berrange.fedorapeople.org/libvirt/website-demo/apps.html Shout if you have more applications you want added to this page... - Expanded content a little wrt to bug reporting and mailing lists http://berrange.fedorapeople.org/libvirt/website-demo/bugs.html http://berrange.fedorapeople.org/libvirt/website-demo/contact.html - Linked to the new wiki site, and added seemless integration betweeen the wiki navigation & styling, and the main site. - There is a new updated CSS graphic design - I can't take credit for that - it is from mockups done by one of the Red Hat designers. Again, if all this is too much to take in, just go straight to the sitemap page on the demo site and click around... http://berrange.fedorapeople.org/libvirt/website-demo/sitemap.html The patch for all this is at http://berrange.fedorapeople.org/libvirt/libvirt-website.patch The giant and fairly meaningless diffstat is: ChangeLog.xsl | 72 FAQ.html | 225 +- FAQ.html.in | 144 + Makefile.am | 49 apps.html | 179 + apps.html.in | 108 archdomain.html | 99 archdomain.html.in | 5 architecture.html | 142 + architecture.html.in | 101 archnetwork.html | 99 archnetwork.html.in | 5 archnode.html | 99 archnode.html.in | 5 archstorage.html | 119 + archstorage.html.in | 30 auth.html | 198 + auth.html.in | 183 + bindings.html | 109 bindings.html.in | 24 bugs.html | 141 + bugs.html.in | 82 contact.html | 91 contact.html.in | 37 deployment.html | 131 + deployment.html.in | 46 devhelp/libvirt-virterror.html | 6 docs.html | 85 docs.html.in | 5 downloads.html | 142 + downloads.html.in | 89 drivers.html | 146 + drivers.html.in | 27 drvlxc.html | 108 drvlxc.html.in | 5 drvopenvz.html | 108 drvopenvz.html.in | 5 drvqemu.html | 187 + drvqemu.html.in | 97 drvremote.html | 108 drvremote.html.in | 5 drvtest.html | 108 drvtest.html.in | 5 drvxen.html | 303 ++ drvxen.html.in | 221 + errors.html | 141 - errors.html.in | 83 format.html | 450 +--- format.html.in | 243 ++ formatcaps.html | 165 + formatcaps.html.in | 70 formatdomain.html | 115 + formatdomain.html.in | 18 formatnetwork.html | 175 + formatnetwork.html.in | 93 formatnode.html | 102 formatnode.html.in | 5 formatstorage.html | 331 ++ formatstorage.html.in | 237 ++ generic.css | 74 html/book1.html | 3 html/index.html | 5 html/libvirt-conf.html | 44 html/libvirt-lib.html | 3 html/libvirt-libvirt.html | 961 +++----- html/libvirt-virterror.html | 173 - hvsupport.html | 1031 +++++---- hvsupport.html.in | 597 +++++ index.html | 238 -- index.html.in | 68 intro.html | 132 + intro.html.in | 46 libvir.html | 4596 ----------------------------------------- libvirt-api.xml | 6 libvirt-header-bg.png |binary libvirt-header-logo.png |binary libvirt-net-logical.fig | 159 + libvirt-net-logical.png |binary libvirt-net-physical.fig | 139 + libvirt-net-physical.png |binary libvirt-refs.xml | 7 libvirt.css | 345 +-- main.css | 2 newapi.xsl | 380 +-- news.html | 462 ++-- news.html.in | 607 +++++ page.xsl | 94 python.html | 161 + python.html.in | 71 relatedlinks.html | 114 + relatedlinks.html.in | 55 remote.html | 851 +++++-- remote.html.in | 893 +++++++ site.xsl | 407 --- sitemap.html | 279 ++ sitemap.html.in | 220 + storage.html | 963 +++----- storage.html.in | 354 +++ uri.html | 349 ++- uri.html.in | 295 ++ windows.html | 303 +- windows.html.in | 239 ++ 103 files changed, 13910 insertions(+), 8327 deletions(-) Regards, Daniel. -- |: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

3 6

[Libvir] PATCH: Use macros to remove duplicate test code
by Daniel P. Berrange 21 Apr '08

21 Apr '08

The test suite files contain alot of boilerplate duplicated code. With a few more macros I can significantly cut down the size of the test code. I also change abs_top_srcdir to abs_srcdir, and automatically initialize it to 'getcwd' if the env variable is missing. This lets me run the test cases directly, rather than having to go via 'make check'. statstest.c | 207 ++++++++++++++++++++++------------------------------- test_conf.sh | 16 +++- xencapstest.c | 10 -- xmconfigtest.c | 220 ++++++++++++--------------------------------------------- 4 files changed, 149 insertions(+), 304 deletions(-) Dan. Index: statstest.c =================================================================== RCS file: /data/cvs/libvirt/tests/statstest.c,v retrieving revision 1.5 diff -u -p -r1.5 statstest.c --- statstest.c 10 Apr 2008 16:53:29 -0000 1.5 +++ statstest.c 18 Apr 2008 00:29:55 -0000 @@ -7,6 +7,8 @@ #include "stats_linux.h" #include "internal.h" +#include "testutils.h" + #if WITH_XEN static void testQuietError(void *userData ATTRIBUTE_UNUSED, virErrorPtr error ATTRIBUTE_UNUSED) @@ -21,13 +23,26 @@ static int testDevice(const char *path, int actual = xenLinuxDomainDeviceID(NULL, 1, path); if (actual == expect) { - fprintf(stderr, "%-14s == %-6d OK\n", path, expect); return 0; } else { - fprintf(stderr, "%-14s == %-6d (%-6d) FAILED\n", path, expect, actual); + if (getenv("DEBUG_TESTS")) + fprintf(stderr, "Expect %-6d Actual %-6d\n", expect, actual); return -1; } } + +struct testInfo +{ + const char *dev; + int num; +}; + +static int testDeviceHelper(const void *data) +{ + const struct testInfo *info = data; + return testDevice(info->dev, info->num); +} + #endif int @@ -42,85 +57,67 @@ main(void) if (!getenv("DEBUG_TESTS")) virSetErrorFunc(NULL, testQuietError); +#define DO_TEST(dev, num) \ + do { \ + struct testInfo info = { dev, num }; \ + if (virtTestRun("Device " dev " -> " # num, \ + 1, testDeviceHelper, &info) < 0) \ + ret = -1; \ + } while (0) + /******************************** * Xen paravirt disks ********************************/ /* first valid disk */ - if (testDevice("xvda", 51712) < 0) - ret = -1; - if (testDevice("xvda1", 51713) < 0) - ret = -1; - if (testDevice("xvda15", 51727) < 0) - ret = -1; + DO_TEST("xvda", 51712); + DO_TEST("xvda1", 51713); + DO_TEST("xvda15", 51727); /* Last valid disk */ - if (testDevice("xvdp", 51952) < 0) - ret = -1; - if (testDevice("xvdp1", 51953) < 0) - ret = -1; - if (testDevice("xvdp15", 51967) < 0) - ret = -1; + DO_TEST("xvdp", 51952); + DO_TEST("xvdp1", 51953); + DO_TEST("xvdp15", 51967); /* Disk letter to large */ - if (testDevice("xvdq", -1) < 0) - ret = -1; + DO_TEST("xvdq", -1); /* missing disk letter */ - if (testDevice("xvd1", -1) < 0) - ret = -1; + DO_TEST("xvd1", -1); /* partition to large */ - if (testDevice("xvda16", -1) < 0) - ret = -1; + DO_TEST("xvda16", -1); /* partition to small */ - if (testDevice("xvda0", -1) < 0) - ret = -1; + DO_TEST("xvda0", -1); /* leading zeros */ - if (testDevice("xvda01", -1) < 0) - ret = -1; + DO_TEST("xvda01", -1); /* leading + */ - if (testDevice("xvda+1", -1) < 0) - ret = -1; + DO_TEST("xvda+1", -1); /* leading - */ - if (testDevice("xvda-1", -1) < 0) - ret = -1; + DO_TEST("xvda-1", -1); /******************************** * IDE disks ********************************/ /* odd numbered disk */ - if (testDevice("hda", 768) < 0) - ret = -1; - if (testDevice("hda1", 769) < 0) - ret = -1; - if (testDevice("hda63", 831) < 0) - ret = -1; + DO_TEST("hda", 768); + DO_TEST("hda1", 769); + DO_TEST("hda63", 831); /* even number disk */ - if (testDevice("hdd", 5695) < 0) - ret = -1; - if (testDevice("hdd1", 5696) < 0) - ret = -1; - if (testDevice("hdd63", 5758) < 0) - ret = -1; + DO_TEST("hdd", 5695); + DO_TEST("hdd1", 5696); + DO_TEST("hdd63", 5758); /* last valid disk */ - if (testDevice("hdt", 23359) < 0) - ret = -1; - if (testDevice("hdt1", 23360) < 0) - ret = -1; - if (testDevice("hdt63", 23422) < 0) - ret = -1; + DO_TEST("hdt", 23359); + DO_TEST("hdt1", 23360); + DO_TEST("hdt63", 23422); /* Disk letter to large */ - if (testDevice("hdu", -1) < 0) - ret = -1; + DO_TEST("hdu", -1); /* missing disk letter */ - if (testDevice("hd1", -1) < 0) - ret = -1; + DO_TEST("hd1", -1); /* partition to large */ - if (testDevice("hda64", -1) < 0) - ret = -1; + DO_TEST("hda64", -1); /* partition to small */ - if (testDevice("hda0", -1) < 0) - ret = -1; + DO_TEST("hda0", -1); @@ -129,89 +126,55 @@ main(void) ********************************/ /* first valid disk */ - if (testDevice("sda", 2048) < 0) - ret = -1; - if (testDevice("sda1", 2049) < 0) - ret = -1; - if (testDevice("sda15", 2063) < 0) - ret = -1; + DO_TEST("sda", 2048); + DO_TEST("sda1", 2049); + DO_TEST("sda15", 2063); /* last valid disk of first SCSI major number */ - if (testDevice("sdp", 2288) < 0) - ret = -1; - if (testDevice("sdp1", 2289) < 0) - ret = -1; - if (testDevice("sdp15", 2303) < 0) - ret = -1; + DO_TEST("sdp", 2288); + DO_TEST("sdp1", 2289); + DO_TEST("sdp15", 2303); /* first valid disk of second SCSI major number */ - if (testDevice("sdq", 16640) < 0) - ret = -1; - if (testDevice("sdq1", 16641) < 0) - ret = -1; - if (testDevice("sdq15", 16655) < 0) - ret = -1; + DO_TEST("sdq", 16640); + DO_TEST("sdq1", 16641); + DO_TEST("sdq15", 16655); /* last valid single letter disk */ - if (testDevice("sdz", 16784) < 0) - ret = -1; - if (testDevice("sdz1", 16785) < 0) - ret = -1; - if (testDevice("sdz15", 16799) < 0) - ret = -1; + DO_TEST("sdz", 16784); + DO_TEST("sdz1", 16785); + DO_TEST("sdz15", 16799); /* first valid dual letter disk */ - if (testDevice("sdaa", 16800) < 0) - ret = -1; - if (testDevice("sdaa1", 16801) < 0) - ret = -1; - if (testDevice("sdaa15", 16815) < 0) - ret = -1; + DO_TEST("sdaa", 16800); + DO_TEST("sdaa1", 16801); + DO_TEST("sdaa15", 16815); /* second valid dual letter disk */ - if (testDevice("sdab", 16816) < 0) - ret = -1; - if (testDevice("sdab1", 16817) < 0) - ret = -1; - if (testDevice("sdab15", 16831) < 0) - ret = -1; + DO_TEST("sdab", 16816); + DO_TEST("sdab1", 16817); + DO_TEST("sdab15", 16831); /* first letter of second sequence of dual letter disk */ - if (testDevice("sdba", 17216) < 0) - ret = -1; - if (testDevice("sdba1", 17217) < 0) - ret = -1; - if (testDevice("sdba15", 17231) < 0) - ret = -1; + DO_TEST("sdba", 17216); + DO_TEST("sdba1", 17217); + DO_TEST("sdba15", 17231); /* last valid dual letter disk */ - if (testDevice("sdiv", 34800) < 0) - ret = -1; - if (testDevice("sdiv1", 34801) < 0) - ret = -1; - if (testDevice("sdiv15", 34815) < 0) - ret = -1; + DO_TEST("sdiv", 34800); + DO_TEST("sdiv1", 34801); + DO_TEST("sdiv15", 34815); /* Disk letter to large */ - if (testDevice("sdix", -1) < 0) - ret = -1; + DO_TEST("sdix", -1); /* missing disk letter */ - if (testDevice("sd1", -1) < 0) - ret = -1; + DO_TEST("sd1", -1); /* partition to large */ - if (testDevice("sda16", -1) < 0) - ret = -1; + DO_TEST("sda16", -1); /* partition to small */ - if (testDevice("sda0", -1) < 0) - ret = -1; + DO_TEST("sda0", -1); /* Path stripping */ - if (testDevice("/dev", -1) < 0) - ret = -1; - if (testDevice("/dev/", -1) < 0) - ret = -1; - if (testDevice("/dev/xvd", -1) < 0) - ret = -1; - if (testDevice("/dev/xvda", 51712) < 0) - ret = -1; - if (testDevice("/dev/xvda1", 51713) < 0) - ret = -1; - if (testDevice("/dev/xvda15", 51727) < 0) - ret = -1; + DO_TEST("/dev", -1); + DO_TEST("/dev/", -1); + DO_TEST("/dev/xvd", -1); + DO_TEST("/dev/xvda", 51712); + DO_TEST("/dev/xvda1", 51713); + DO_TEST("/dev/xvda15", 51727); #endif exit(ret==0 ? EXIT_SUCCESS : EXIT_FAILURE); Index: test_conf.sh =================================================================== RCS file: /data/cvs/libvirt/tests/test_conf.sh,v retrieving revision 1.4 diff -u -p -r1.4 test_conf.sh --- test_conf.sh 5 Feb 2008 19:27:37 -0000 1.4 +++ test_conf.sh 18 Apr 2008 00:29:55 -0000 @@ -1,8 +1,15 @@ #!/bin/bash -set -x +#set -x +set -e +if [ -z "$abs_srcdir" ]; then + abs_srcdir=`pwd` +fi + NOK=0 -for f in $abs_top_srcdir/tests/confdata/*.conf +i=1 +for f in $abs_srcdir/confdata/*.conf do + n=`echo $f | sed -e "s,$abs_srcdir/confdata/,,"` ./conftest $f > conftest.$$ outfile=`echo "$f" | sed s+\.conf$+\.out+` diff $outfile conftest.$$ > /dev/null @@ -11,11 +18,12 @@ do if [ -n "$DEBUG_TESTS" ]; then diff -u $outfile conftest.$$ fi - echo "$f FAILED" + printf "%2d) %-60s ... %s\n" $i $n "FAILED" NOK=1 else - echo "$f OK" + printf "%2d) %-60s ... %s\n" $i $n "OK" fi + i=`expr $i + 1` done rm -f conftest.$$ exit $NOK Index: xencapstest.c =================================================================== RCS file: /data/cvs/libvirt/tests/xencapstest.c,v retrieving revision 1.11 diff -u -p -r1.11 xencapstest.c --- xencapstest.c 10 Apr 2008 16:54:54 -0000 1.11 +++ xencapstest.c 18 Apr 2008 00:29:56 -0000 @@ -50,14 +50,10 @@ static int testCompareFiles(const char * if (!(actualxml = xenHypervisorMakeCapabilitiesXML(NULL, hostmachine, fp1, fp2))) goto fail; - if (getenv("DEBUG_TESTS") && - STRNEQ(expectxml, actualxml)) { - printf("In test file %s:\n", capabilities); - printf("Expect %d '%s'\n", (int)strlen(expectxml), expectxml); - printf("Actual %d '%s'\n", (int)strlen(actualxml), actualxml); + if (STRNEQ(expectxml, actualxml)) { + virtTestDifference(stderr, expectxml, actualxml); + goto fail; } - if (strcmp(expectxml, actualxml)) - goto fail; ret = 0; Index: xmconfigtest.c =================================================================== RCS file: /data/cvs/libvirt/tests/xmconfigtest.c,v retrieving revision 1.13 diff -u -p -r1.13 xmconfigtest.c --- xmconfigtest.c 10 Apr 2008 16:53:29 -0000 1.13 +++ xmconfigtest.c 18 Apr 2008 00:29:56 -0000 @@ -25,6 +25,7 @@ #include <stdio.h> #include <string.h> +#include <unistd.h> #ifdef WITH_XEN @@ -35,11 +36,11 @@ #include "conf.h" static char *progname; -static char *abs_top_srcdir; +static char *abs_srcdir; #define MAX_FILE 4096 -static int testCompareParseXML(const char *xmcfg_rel, const char *xml_rel, +static int testCompareParseXML(const char *xmcfg, const char *xml, int xendConfigVersion) { char xmlData[MAX_FILE]; char xmcfgData[MAX_FILE]; @@ -53,11 +54,6 @@ static int testCompareParseXML(const cha int wrote = MAX_FILE; void *old_priv = NULL; struct _xenUnifiedPrivate priv; - char xmcfg[PATH_MAX]; - char xml[PATH_MAX]; - - snprintf(xmcfg, sizeof xmcfg - 1, "%s/tests/%s", abs_top_srcdir, xmcfg_rel); - snprintf(xml, sizeof xml - 1, "%s/tests/%s", abs_top_srcdir, xml_rel); conn = virConnectOpenReadOnly("test:///default"); if (!conn) goto fail; @@ -80,11 +76,8 @@ static int testCompareParseXML(const cha goto fail; gotxmcfgPtr[wrote] = '\0'; - if (strcmp(xmcfgData, gotxmcfgData)) { - if (getenv("DEBUG_TESTS")) { - printf("Expect %d '%s'\n", (int)strlen(xmcfgData), xmcfgData); - printf("Actual %d '%s'\n", (int)strlen(gotxmcfgData), gotxmcfgData); - } + if (STRNEQ(xmcfgData, gotxmcfgData)) { + virtTestDifference(stderr, xmcfgData, gotxmcfgData); goto fail; } @@ -102,7 +95,7 @@ static int testCompareParseXML(const cha return ret; } -static int testCompareFormatXML(const char *xmcfg_rel, const char *xml_rel, +static int testCompareFormatXML(const char *xmcfg, const char *xml, int xendConfigVersion) { char xmlData[MAX_FILE]; char xmcfgData[MAX_FILE]; @@ -114,11 +107,6 @@ static int testCompareFormatXML(const ch virConnectPtr conn; void *old_priv; struct _xenUnifiedPrivate priv; - char xmcfg[PATH_MAX]; - char xml[PATH_MAX]; - - snprintf(xmcfg, sizeof xmcfg - 1, "%s/tests/%s", abs_top_srcdir, xmcfg_rel); - snprintf(xml, sizeof xml - 1, "%s/tests/%s", abs_top_srcdir, xml_rel); conn = virConnectOpenReadOnly("test:///default"); if (!conn) goto fail; @@ -163,102 +151,25 @@ static int testCompareFormatXML(const ch return ret; } -static int testCompareParavirtOldPVFBFormat(const void *data ATTRIBUTE_UNUSED) { - return testCompareFormatXML("xmconfigdata/test-paravirt-old-pvfb.cfg", - "xmconfigdata/test-paravirt-old-pvfb.xml", - 2); -} -static int testCompareParavirtOldPVFBParse(const void *data ATTRIBUTE_UNUSED) { - return testCompareParseXML("xmconfigdata/test-paravirt-old-pvfb.cfg", - "xmconfigdata/test-paravirt-old-pvfb.xml", - 2); -} - -static int testCompareParavirtNewPVFBFormat(const void *data ATTRIBUTE_UNUSED) { - return testCompareFormatXML("xmconfigdata/test-paravirt-new-pvfb.cfg", - "xmconfigdata/test-paravirt-new-pvfb.xml", - 3); -} -static int testCompareParavirtNewPVFBParse(const void *data ATTRIBUTE_UNUSED) { - return testCompareParseXML("xmconfigdata/test-paravirt-new-pvfb.cfg", - "xmconfigdata/test-paravirt-new-pvfb.xml", - 3); -} - -static int testCompareFullvirtOldCDROMFormat(const void *data ATTRIBUTE_UNUSED) { - return testCompareFormatXML("xmconfigdata/test-fullvirt-old-cdrom.cfg", - "xmconfigdata/test-fullvirt-old-cdrom.xml", - 1); -} -static int testCompareFullvirtOldCDROMParse(const void *data ATTRIBUTE_UNUSED) { - return testCompareParseXML("xmconfigdata/test-fullvirt-old-cdrom.cfg", - "xmconfigdata/test-fullvirt-old-cdrom.xml", - 1); -} - -static int testCompareFullvirtNewCDROMFormat(const void *data ATTRIBUTE_UNUSED) { - return testCompareFormatXML("xmconfigdata/test-fullvirt-new-cdrom.cfg", - "xmconfigdata/test-fullvirt-new-cdrom.xml", - 2); -} -static int testCompareFullvirtNewCDROMParse(const void *data ATTRIBUTE_UNUSED) { - return testCompareParseXML("xmconfigdata/test-fullvirt-new-cdrom.cfg", - "xmconfigdata/test-fullvirt-new-cdrom.xml", - 2); -} - -static int testCompareFullvirtClockUTCFormat(const void *data ATTRIBUTE_UNUSED) { - return testCompareFormatXML("xmconfigdata/test-fullvirt-utc.cfg", - "xmconfigdata/test-fullvirt-utc.xml", - 2); -} -static int testCompareFullvirtClockUTCParse(const void *data ATTRIBUTE_UNUSED) { - return testCompareParseXML("xmconfigdata/test-fullvirt-utc.cfg", - "xmconfigdata/test-fullvirt-utc.xml", - 2); -} - -static int testCompareFullvirtClockLocaltimeFormat(const void *data ATTRIBUTE_UNUSED) { - return testCompareFormatXML("xmconfigdata/test-fullvirt-localtime.cfg", - "xmconfigdata/test-fullvirt-localtime.xml", - 2); -} - -static int testCompareFullvirtClockLocaltimeParse(const void *data ATTRIBUTE_UNUSED) { - return testCompareParseXML("xmconfigdata/test-fullvirt-localtime.cfg", - "xmconfigdata/test-fullvirt-localtime.xml", - 2); -} - -static int testCompareFullvirtInputUSBTabletFormat(const void *data ATTRIBUTE_UNUSED) { - return testCompareFormatXML("xmconfigdata/test-fullvirt-usbtablet.cfg", - "xmconfigdata/test-fullvirt-usbtablet.xml", - 2); -} +struct testInfo { + const char *name; + int version; + int mode; +}; -static int testCompareFullvirtInputUSBTabletParse(const void *data ATTRIBUTE_UNUSED) { - return testCompareParseXML("xmconfigdata/test-fullvirt-usbtablet.cfg", - "xmconfigdata/test-fullvirt-usbtablet.xml", - 2); -} - -static int testCompareFullvirtInputUSBTabletNoBusParse(const void *data ATTRIBUTE_UNUSED) { - return testCompareParseXML("xmconfigdata/test-fullvirt-usbtablet.cfg", - "xmconfigdata/test-fullvirt-usbtablet-no-bus.xml", - 2); -} - -static int testCompareFullvirtInputUSBMouseFormat(const void *data ATTRIBUTE_UNUSED) { - return testCompareParseXML("xmconfigdata/test-fullvirt-usbmouse.cfg", - "xmconfigdata/test-fullvirt-usbmouse.xml", - 2); -} - -static int testCompareFullvirtInputUSBMouseParse(const void *data ATTRIBUTE_UNUSED) { - return testCompareParseXML("xmconfigdata/test-fullvirt-usbmouse.cfg", - "xmconfigdata/test-fullvirt-usbmouse.xml", - 2); +static int testCompareHelper(const void *data) { + const struct testInfo *info = data; + char xml[PATH_MAX]; + char cfg[PATH_MAX]; + snprintf(xml, PATH_MAX, "%s/xmconfigdata/test-%s.xml", + abs_srcdir, info->name); + snprintf(cfg, PATH_MAX, "%s/xmconfigdata/test-%s.cfg", + abs_srcdir, info->name); + if (info->mode == 0) + return testCompareParseXML(cfg, xml, info->version); + else + return testCompareFormatXML(cfg, xml, info->version); } @@ -266,6 +177,7 @@ int main(int argc, char **argv) { int ret = 0; + char cwd[PATH_MAX]; progname = argv[0]; @@ -274,65 +186,31 @@ main(int argc, char **argv) exit(EXIT_FAILURE); } - abs_top_srcdir = getenv("abs_top_srcdir"); - if (!abs_top_srcdir) - return 1; - - /* Config -> XML */ - if (virtTestRun("Paravirt old PVFB (Format)", - 1, testCompareParavirtOldPVFBFormat, NULL) != 0) - ret = -1; - if (virtTestRun("Paravirt new PVFB (Format)", - 1, testCompareParavirtNewPVFBFormat, NULL) != 0) - ret = -1; - if (virtTestRun("Fullvirt old PVFB (Format)", - 1, testCompareFullvirtOldCDROMFormat, NULL) != 0) - ret = -1; - if (virtTestRun("Fullvirt new PVFB (Format)", - 1, testCompareFullvirtNewCDROMFormat, NULL) != 0) - ret = -1; - if (virtTestRun("Fullvirt clock Localtime (Format)", - 1, testCompareFullvirtClockLocaltimeFormat, NULL) != 0) - ret = -1; - if (virtTestRun("Fullvirt clock UTC (Format)", - 1, testCompareFullvirtClockUTCFormat, NULL) != 0) - ret = -1; - if (virtTestRun("Fullvirt USB mouse (Format)", - 1, testCompareFullvirtInputUSBMouseFormat, NULL) != 0) - ret = -1; - if (virtTestRun("Fullvirt USB tablet (Format)", - 1, testCompareFullvirtInputUSBTabletFormat, NULL) != 0) - ret = -1; - - /* XML -> Config */ - if (virtTestRun("Paravirt old PVFB (Parse)", - 1, testCompareParavirtOldPVFBParse, NULL) != 0) - ret = -1; - if (virtTestRun("Paravirt new PVFB (Parse)", - 1, testCompareParavirtNewPVFBParse, NULL) != 0) - ret = -1; - if (virtTestRun("Fullvirt old PVFB (Parse)", - 1, testCompareFullvirtOldCDROMParse, NULL) != 0) - ret = -1; - if (virtTestRun("Fullvirt new PVFB (Parse)", - 1, testCompareFullvirtNewCDROMParse, NULL) != 0) - ret = -1; - if (virtTestRun("Fullvirt clock Localtime (Parse)", - 1, testCompareFullvirtClockLocaltimeParse, NULL) != 0) - ret = -1; - if (virtTestRun("Fullvirt clock UTC (Parse)", - 1, testCompareFullvirtClockUTCParse, NULL) != 0) - ret = -1; - if (virtTestRun("Fullvirt USB mouse (Parse)", - 1, testCompareFullvirtInputUSBMouseParse, NULL) != 0) - ret = -1; - if (virtTestRun("Fullvirt USB tablet (Parse)", - 1, testCompareFullvirtInputUSBTabletParse, NULL) != 0) - ret = -1; - if (virtTestRun("Fullvirt USB tablet no bus (Parse)", - 1, testCompareFullvirtInputUSBTabletNoBusParse, NULL) != 0) - ret = -1; - + abs_srcdir = getenv("abs_srcdir"); + if (!abs_srcdir) + abs_srcdir = getcwd(cwd, sizeof(cwd)); + + +#define DO_TEST(name, version) \ + do { \ + struct testInfo info0 = { name, version, 0 }; \ + struct testInfo info1 = { name, version, 1 }; \ + if (virtTestRun("Xen XM-2-XML Parse " name, \ + 1, testCompareHelper, &info0) < 0) \ + ret = -1; \ + if (virtTestRun("Xen XM-2-XML Format " name, \ + 1, testCompareHelper, &info1) < 0) \ + ret = -1; \ + } while (0) + + DO_TEST("paravirt-old-pvfb", 2); + DO_TEST("paravirt-new-pvfb", 3); + DO_TEST("fullvirt-old-cdrom", 1); + DO_TEST("fullvirt-new-cdrom", 2); + DO_TEST("fullvirt-utc", 2); + DO_TEST("fullvirt-localtime", 2); + DO_TEST("fullvirt-usbtablet", 2); + DO_TEST("fullvirt-usbmouse", 2); exit(ret==0 ? EXIT_SUCCESS : EXIT_FAILURE); } -- |: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

4 4

[Libvir] MinGW patch
by Richard W.M. Jones 21 Apr '08

21 Apr '08

I got about 95% of the way towards compiling on MinGW using the MinGW cross-compiler from http://mirzam.it.vu.nl/mingw/. Attached are some fairly non-controversial patches which fix some of the problems I found. Build notes follow below. Rich. ---------------------------------------------------------------------- Install the MinGW cross-compiler. Compile and install the following packages: (1) libgpg-error (2) libgcrypt (3) gnutls (4) libxml2 (5) PortableXDR I'm building into a local area. Most of them will compile straight with: CFLAGS="-I$HOME/win32/include" \ LDFLAGS="-L$HOME/win32/lib" \ ./configure --host=i386-mingw32 --prefix=$HOME/win32 make make install GnuTLS (3) is troublesome. I ended up using version 1.6.3, upgrading the gnulib packages in the gl/ subdirectory, and doing a bit of bug-fixing on the Makefile.am files (mainly just making sure my custom LDFLAGS gets through everywhere). Then build libvirt + attached patch: PKG_CONFIG_PATH=$HOME/win32/lib/pkgconfig \ CFLAGS="-I$HOME/win32/include" \ LDFLAGS="-L$HOME/win32/lib" \ ./configure --host=i386-mingw32 --prefix=$HOME/win32 \ --without-xen --without-qemu --without-libvirtd \ --without-sasl --without-python make [Currently it fails when linking virsh because of the usual weirdness in libtool] -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top

5 7

[Libvir] FYI, typo fix
by Jim Meyering 21 Apr '08

21 Apr '08

I updated and couldn't compile. Here's the fix: avoid compile error when <pthread.h> is absent * src/internal.h (HAVE_PTHREAD_H): Test with "#ifdef", not "#if". diff --git a/src/internal.h b/src/internal.h index 6b2b633..6bed477 100644 --- a/src/internal.h +++ b/src/internal.h @@ -12,7 +12,7 @@ #include <sys/syslimits.h> #endif -#if HAVE_PTHREAD_H +#ifdef HAVE_PTHREAD_H #include <pthread.h> #define PTHREAD_MUTEX_T(v) pthread_mutex_t v #else -- 1.5.5.68.gd193e

2 1

[Libvir] PATCH: Make test suite debug mode more friendly
by Daniel P. Berrange 21 Apr '08

21 Apr '08

When the test suites fail, we have a DEBUG_TESTS=1 environment variable which can be set to show the full XML doc or string pair that failed to match. Unfortunately these docs can be quite large, so it is hard to spot the difference between the actual and expected output. So this patch introduces a virtTestDifference(actual, expect) method which will trim the head & tail of the actual & expected strings until the point at which they differ. This gives immediate clear feedback on where the bug is Second, it will enumerate each test condition & pretty print align things a little better. When I apply this to a test which fails, i now see output like this: 19) Xen SEXPR-2-XML fv-usbmouse -> fv-usbmouse ... Expect [localtime'/> <devices> <emulator>/usr/lib64/xen/bin/qemu-dm</emulator> <disk type='file' device='disk'> <driver name='file'/> <source file='/root/foo.img'/> <target dev='hda'/> </disk> <interface type='network] Actual [utc'/> <devices> <emulator>/usr/lib64/xen/bin/qemu-dm</emulator> <disk type='file' device='disk'> <driver name='file'/> <source file='/root/foo.img'/> <target dev='hda'/> </disk> <interface type='bridge] ... FAILED So you can see immediately that they start to differ in the 'localtime' vs 'utc' value, and the last place at which they differ is the network interface which has type of 'network' vs 'bridge'. This has dramatically eased my debugging of tests when adding the serial device options :-) This patch is merely the helper routines. I'll include the actualy test suite changes later. Dan. Index: testutils.h =================================================================== RCS file: /data/cvs/libvirt/tests/testutils.h,v retrieving revision 1.6 diff -u -p -r1.6 testutils.h --- testutils.h 10 Apr 2008 16:53:29 -0000 1.6 +++ testutils.h 18 Apr 2008 00:22:55 -0000 @@ -32,6 +32,11 @@ extern "C" { char **buf, int buflen); + + int virtTestDifference(FILE *stream, + const char *expect, + const char *actual); + #ifdef __cplusplus } #endif Index: testutils.c =================================================================== RCS file: /data/cvs/libvirt/tests/testutils.c,v retrieving revision 1.11 diff -u -p -r1.11 testutils.c --- testutils.c 10 Apr 2008 16:53:29 -0000 1.11 +++ testutils.c 18 Apr 2008 00:22:55 -0000 @@ -19,6 +19,7 @@ #include <sys/stat.h> #include <sys/wait.h> #include <unistd.h> +#include <string.h> #include <fcntl.h> #include <limits.h> #include "testutils.h" @@ -58,6 +59,12 @@ virtTestRun(const char *title, int nloop { int i, ret = 0; double *ts = NULL; + static int counter = 0; + + counter++; + + fprintf(stderr, "%2d) %-65s ... ", counter, title); + fflush(stderr); if (nloops > 1 && (ts = calloc(nloops, sizeof(double)))==NULL) @@ -76,12 +83,12 @@ virtTestRun(const char *title, int nloop } } if (ret == 0 && ts) - fprintf(stderr, "%-50s ... OK [%.5f ms]\n", title, + fprintf(stderr, "OK [%.5f ms]\n", virtTestCountAverage(ts, nloops)); else if (ret == 0) - fprintf(stderr, "%-50s ... OK\n", title); + fprintf(stderr, "OK\n"); else - fprintf(stderr, "%-50s ... FAILED\n", title); + fprintf(stderr, "FAILED\n"); free(ts); return ret; @@ -206,3 +213,57 @@ int virtTestCaptureProgramOutput(const c } } } + + +/** + * @param stream: output stream write to differences to + * @param expect: expected output text + * @param actual: actual output text + * + * Display expected and actual output text, trimmed to + * first and last characters at which differences occur + */ +int virtTestDifference(FILE *stream, + const char *expect, + const char *actual) +{ + const char *expectStart = expect; + const char *expectEnd = expect + (strlen(expect)-1); + const char *actualStart = actual; + const char *actualEnd = actual + (strlen(actual)-1); + + if (getenv("DEBUG_TESTS") == NULL) + return 0; + + /* Skip to first character where they differ */ + while (*expectStart && *actualStart && + *actualStart == *expectStart) { + actualStart++; + expectStart++; + } + + /* Work backwards to last character where they differ */ + while (actualEnd > actualStart && + expectEnd > expectStart && + *actualEnd == *expectEnd) { + actualEnd--; + expectEnd--; + } + + /* Show the trimmed differences */ + fprintf(stream, "\nExpect ["); + if ((expectEnd - expectStart + 1) && + fwrite(expectStart, (expectEnd-expectStart+1), 1, stream) != 1) + return -1; + fprintf(stream, "]\n"); + fprintf(stream, "Actual ["); + if ((actualEnd - actualStart + 1) && + fwrite(actualStart, (actualEnd-actualStart+1), 1, stream) != 1) + return -1; + fprintf(stream, "]\n"); + + /* Pad to line up with test name ... in virTestRun */ + fprintf(stream, " ... "); + + return 0; +} -- |: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

4 3

[Libvir] proposal: remove contradictory indentation directive
by Jim Meyering 21 Apr '08

21 Apr '08

Dave Leskovec <dlesko(a)linux.vnet.ibm.com> wrote: > This is a repost of the start container support. Changes from the last version: ... > +/* > + * Local variables: > + * indent-tabs-mode: nil > + * c-indent-level: 4 > + * c-basic-offset: 4 > + * tab-width: 4 > + * End: > + */ Please don't add the "tab-width: 4" specifier. Specifying a tab-width at all in a new file with "indent-tabs-mode: nil" is a contradiction. The latter says there should be no TABs, yet the former says "when there are, give them width 4." Coding style guidelines are universal in their recommendations to stick with 8-byte TAB stops, independent of whether you actually use TAB or spaces. Just yesterday I experienced first hand how adding code with existing 8-byte tab stops to a file with settings like the above mangles the indentation of the new code. FYI, a better approach would be to ensure that TAB is never used for indentation in a file with "indent-tabs-mode: nil". Both directives are in over 70 files, and I propose to straighten things out. There are many instances of invalid and misleading indentation, in part because of this sort of mix-up. To give an idea of the scope, while 77 files have those settings, removing 'tab-width: 4' would only affect those that use TABs for indentation in spite of "indent-tabs-mode: nil" (perhaps added via copy/paste, or added with a non-emacs editor). Many distro-provided versions of Vim do not honor :se-style settings, due to security concerns. Here are counts of lines with TAB indentation in those 77 files. Each TAB would have to be changed to 4 or 8 spaces, depending on context. That'd be the minimal change. An alternative is simply to filter each of these files through indent with appropriate options. $ git grep -l tab-width:|xargs grep -c '^ '|grep -v :0 proxy/libvirt_proxy.c:316 python/libvir.c:17 src/buf.c:27 src/conf.c:161 src/conf.h:7 src/driver.h:130 src/internal.h:9 src/libvirt.c:81 src/lxc_conf.c:17 src/openvz_driver.h:6 src/proxy_internal.c:122 src/proxy_internal.h:13 src/qemu_conf.c:1 src/qemu_driver.c:5 src/qparams.h:1 src/remote_internal.c:4 src/stats_linux.h:3 src/virsh.c:33 src/virterror.c:166 src/xen_internal.c:105 src/xen_unified.c:25 src/xen_unified.h:37 src/xend_internal.c:43 src/xm_internal.c:25 src/xml.c:6 src/xs_internal.c:45 tests/nodeinfotest.c:1 tests/sexpr2xmltest.c:83

5 23

[Libvir] Cross-compiling to Windows
by Richard W.M. Jones 17 Apr '08

17 Apr '08

I was reading this rather timely blog posting about the Trouble With Windows: http://www.mega-nerd.com/erikd/Blog/CodeHacking/MinGWCross/cross_compiling.… He mentions that he's managed to set up an entire cross-compiler environment to do the compiles (actually, it's a package in Debian called mingw32 -- we don't have it in Fedora), and he's set up Wine so he can run tests too. Good idea for libvirt too? Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v

3 10