Re: [Libvirt-cim] [PATCH] REDSAP: Fix double exception possibilty

On 09/09/2013 02:46 PM, John Ferlan wrote: >> > > Yes - unfortunately. Although not very repeatable. Sometimes running > twice in a row works and sometimes it doesn't. Chasing after those > kind of timing problems is never easy. When I worked my way through the > API's, I ended up in the VNC port allocation routines - I think > get_vnc_sessions() - but I was never quite sure exactly where the fault > was and chasing it seemed to be a too time consuming task. > it still looks to me as if there was a "dangling" running domain. This here looks suspicious ... status = vsxml.cim_start(server) if not ret: raise Exception("Failed to start the dom: %s" % test_dom) and looks as if could trigger a false error condition, resulting in an undestroyed test doamain, should probably be ret = vsxml.cim_start(server)