January 2009 - CIM - libvirt List Archives

[Fwd: [Libvirt-cim] [PATCH] [TEST] Adding 01_enum_KVMredSAP.py of KVMRedirectionSAP]
by Deepti B Kalakeri 23 Jan '09

23 Jan '09

Please use these two patches for reviewing the 01_enum_KVMredSAP.py of KVMRedirectionSAP tc. Sorry for the confusion. -- Thanks and Regards, Deepti B. Kalakeri IBM Linux Technology Center deeptik(a)linux.vnet.ibm.com

1 0

[PATCH] [CU] Update README - indicate autogen.sh is run when building from a cloned tree
by Kaitlin Rupert 23 Jan '09

23 Jan '09

# HG changeset patch # User Kaitlin Rupert <karupert(a)us.ibm.com> # Date 1232652800 28800 # Node ID d4a9e07d6738f76780bcb1ada5b7c0dbc57e4e0f # Parent 0ef95d18e20c364966938676a8023c9bca167724 [CU] Update README - indicate autogen.sh is run when building from a cloned tree Signed-off-by: Kaitlin Rupert <karupert(a)us.ibm.com> diff -r 0ef95d18e20c -r d4a9e07d6738 README --- a/README Tue Dec 02 09:09:48 2008 -0800 +++ b/README Thu Jan 22 11:33:20 2009 -0800 @@ -29,7 +29,9 @@ Procedure: - $ ./autogen.sh + -If building a tree cloned from the hg repository, run this step first: + $ ./autogen.sh + $ # You probably want the EO parser enabled $ ./configure --enable-eoparser $ make

2 1

[PATCH] Update README so instructions to restart Pegasus / sfcb are comments
by Kaitlin Rupert 23 Jan '09

23 Jan '09

# HG changeset patch # User Kaitlin Rupert <karupert(a)us.ibm.com> # Date 1232652569 28800 # Node ID e91ea7a0cecb9449ae5b415f50944ca97b4d3126 # Parent 42c9ad8b71cf38acc2e968d6fdf255b5715b6ae2 Update README so instructions to restart Pegasus / sfcb are comments And don't look like instructions that should be entered on the command line Signed-off-by: Kaitlin Rupert <karupert(a)us.ibm.com> diff -r 42c9ad8b71cf -r e91ea7a0cecb README --- a/README Wed Jan 21 10:20:00 2009 -0800 +++ b/README Thu Jan 22 11:29:29 2009 -0800 @@ -35,7 +35,10 @@ $ ./configure $ make $ make preinstall - $ Restart Pegasus or SFCB + + # Restart Pegasus or SFCB + $ sudo make install $ sudo make postinstall - $ Restart Pegasus or SFCB + + # Restart Pegasus or SFCB

2 1

[PATCH] [TEST] #3 Add some error checking when detecting hypervisor version
by Kaitlin Rupert 23 Jan '09

23 Jan '09

# HG changeset patch # User Kaitlin Rupert <karupert(a)us.ibm.com> # Date 1232643309 28800 # Node ID 9436d51e3f6f699ccba16cb6183095f0f4dabdfc # Parent 79d847b2acf889cc83d62003e9cbf8617b1272aa [TEST] #3 Add some error checking when detecting hypervisor version Updates from 2 to 3: -Simplfy the splitline logic. Updates from 1 to 2: -In libvirt or hypervisior version cannot be determined, print error message to console. Signed-off-by: Kaitlin Rupert <karupert(a)us.ibm.com> diff -r 79d847b2acf8 -r 9436d51e3f6f suites/libvirt-cim/lib/XenKvmLib/reporting.py --- a/suites/libvirt-cim/lib/XenKvmLib/reporting.py Mon Jan 19 09:10:19 2009 -0800 +++ b/suites/libvirt-cim/lib/XenKvmLib/reporting.py Thu Jan 22 08:55:09 2009 -0800 @@ -45,13 +45,24 @@ cmd = "virsh version" virsh_ver = get_cmd_val(cmd, ip) if virsh_ver != "Unknown": - if len(virsh_ver.splitlines()) == 4: - if virsh_ver.splitlines()[0].find("libvir"): - libvirt_ver = virsh_ver.splitlines()[0].split()[4] + libvirt, tok1, tok2, hypervisor = virsh_ver.splitlines() + if libvirt.find("libvir"): + libvirt_ver = libvirt.split()[4] - if virsh_ver.splitlines()[3].find("hypervisor"): - hyp_ver = virsh_ver.splitlines()[3].split("hypervisor")[1] - hyp_ver = hyp_ver.split(": ")[1] + if hypervisor.find("hypervisor"): + tok = hypervisor.split("hypervisor") + #We need these checks here, because sometimes hypervisor is found, + #but the rest of the version info isn't available + if len(tok) > 1: + tok = tok[1].split(": ") + if len(tok) > 1: + hyp_ver = tok[1] + + if libvirt_ver == "Unknown": + print "\nUnable to determine libvirt version\n" + + if hyp_ver == "Unknown": + print "\nUnable to determine hypervisior version\n" return libvirt_ver, hyp_ver

2 1

[PATCH] Remove fopen() from out in KVMRedirectionSAP
by Kaitlin Rupert 22 Jan '09

22 Jan '09

# HG changeset patch # User Kaitlin Rupert <karupert(a)us.ibm.com> # Date 1232584945 28800 # Node ID 1efa2d18e09bb7851ca70ca0112d8363190e81d1 # Parent 6fa1f52dc8298b4d643fc94bb3f91715cc40dd58 Remove fopen() from out in KVMRedirectionSAP The file is already open, we just need to close it. Signed-off-by: Kaitlin Rupert <karupert(a)us.ibm.com> diff -r 6fa1f52dc829 -r 1efa2d18e09b src/Virt_KVMRedirectionSAP.c --- a/src/Virt_KVMRedirectionSAP.c Tue Jan 20 22:27:01 2009 -0800 +++ b/src/Virt_KVMRedirectionSAP.c Wed Jan 21 16:42:25 2009 -0800 @@ -213,7 +213,6 @@ } out: - tcp_info = fopen(path, "r"); fclose(tcp_info); return s; }

2 1

[PATCH] [TEST] #2 Add some error checking when detecting hypervisor version
by Kaitlin Rupert 22 Jan '09

22 Jan '09

# HG changeset patch # User Kaitlin Rupert <karupert(a)us.ibm.com> # Date 1232382714 28800 # Node ID a5a4d35749d1d9ed8604ea4879e12828c7f5b169 # Parent 57f3bc7c3105bb779b41e19b1c03a1e5f214cec1 [TEST] #2 Add some error checking when detecting hypervisor version Updates: -In libvirt or hypervisior version cannot be determined, print error message to console. Signed-off-by: Kaitlin Rupert <karupert(a)us.ibm.com> diff -r 57f3bc7c3105 -r a5a4d35749d1 suites/libvirt-cim/lib/XenKvmLib/reporting.py --- a/suites/libvirt-cim/lib/XenKvmLib/reporting.py Fri Jan 16 11:51:26 2009 -0800 +++ b/suites/libvirt-cim/lib/XenKvmLib/reporting.py Mon Jan 19 08:31:54 2009 -0800 @@ -50,8 +50,17 @@ libvirt_ver = virsh_ver.splitlines()[0].split()[4] if virsh_ver.splitlines()[3].find("hypervisor"): - hyp_ver = virsh_ver.splitlines()[3].split("hypervisor")[1] - hyp_ver = hyp_ver.split(": ")[1] + tok = virsh_ver.splitlines()[3].split("hypervisor") + if len(tok) > 1: + tok = tok[1].split(": ") + if len(tok) > 1: + hyp_ver = tok[1] + + if libvirt_ver == "Unknown": + print "\nUnable to determine libvirt version\n" + + if hyp_ver == "Unknown": + print "\nUnable to determine hypervisior version\n" return libvirt_ver, hyp_ver

2 3

[PATCH] [TEST] #3 Fix verify_rasds() and verify_devices() in SD 02_reverse.py
by Kaitlin Rupert 22 Jan '09

22 Jan '09

# HG changeset patch # User Kaitlin Rupert <karupert(a)us.ibm.com> # Date 1232580651 28800 # Node ID 6e23c06353a1529f295109cd79858cdea4dbf0be # Parent c48f4ad82a02ab19ff0d30d77d492060d0a30145 [TEST] #3 Fix verify_rasds() and verify_devices() in SD 02_reverse.py Since VSSDC should return RASDs that all correspond to the guest, there's no need to parse the InstanceID to see if the guest name matches the guest we've created. Also, fix the logic of the verify functions to be a little cleaner. Compare all the properties of the instances, not just the InstanceIDs/DeviceIDs. Remove parse_instance_id() from verify_devices(); guest and dev_id were not being used in the function. Updates from 2 to 3: -Fix typo in setup_env(). cmxl should be cxml -Fixed bug in cim_define() that was causing this to fail with LXC Updates from 1 to 2: -Removed unnecessary undefine() call -Moved the verification of the number of RASDs before the for loop - in the case of LXC, we remove one of the RASDs from this list so we don't verify it, but we still want to verify the appropriate number of RASDs was returned. -Print an error message if comparing all the instance properties fails. Signed-off-by: Kaitlin Rupert <karupert(a)us.ibm.com> diff -r c48f4ad82a02 -r 6e23c06353a1 suites/libvirt-cim/cimtest/SettingsDefine/02_reverse.py --- a/suites/libvirt-cim/cimtest/SettingsDefine/02_reverse.py Tue Jan 20 18:24:05 2009 -0800 +++ b/suites/libvirt-cim/cimtest/SettingsDefine/02_reverse.py Wed Jan 21 15:30:51 2009 -0800 @@ -55,7 +55,7 @@ from CimTest.Globals import logger from CimTest.ReturnCodes import PASS, FAIL from XenKvmLib.const import do_main -from XenKvmLib.assoc import AssociatorNames +from XenKvmLib.assoc import AssociatorNames, compare_all_prop from XenKvmLib.vxml import get_class from XenKvmLib.classes import get_typed_class from XenKvmLib.rasd import enum_rasds @@ -80,7 +80,7 @@ ret = cxml.cim_define(server) if not ret: logger.error("Failed to Create the dom: %s", test_dom) - return FAIL, cmxl + return FAIL, cxml status = cxml.cim_start(server) if status != PASS: @@ -101,9 +101,6 @@ return rasd_insts, status for rasd_cn, rasd_list in rasds.iteritems(): - if virt == "LXC" and rasd_cn == proc_rasd_cn: - continue - for rasd in rasd_list: guest, dev, status = parse_instance_id(rasd.InstanceID) if status != PASS: @@ -135,56 +132,44 @@ return dev_insts, PASS -def verify_rasd(virt, enum_list, rasds, guest_name): - proc_rasd_cn = get_typed_class(virt, "ProcResourceAllocationSettingData") +def verify_rasd(virt, enum_list, rasds): + if len(enum_list) != len(rasds): + logger.error("Got %d RASDs, expected %d", len(enum_list), len(rasds)) + return FAIL + + status = FAIL for rasd in enum_list: - if virt == "LXC" and rasd.classname == proc_rasd_cn: - enum_list.remove(rasd) - continue - - guest, dev, status = parse_instance_id(rasd['InstanceID']) - if status != PASS: - logger.error("Unable to parse InstanceID: %s", rasd['InstanceID']) - return status - - if guest != guest_name: - continue - exp_rasd = rasds[rasd.classname] - if rasd['InstanceID'] == exp_rasd.InstanceID: - status = PASS - else: - logger.info("Got %s instead of %s" % (rasd['InstanceID'], - exp_rasd.InstanceID)) - status = FAIL + if rasd['InstanceID'] != exp_rasd.InstanceID: + logger.error("Got %s instead of %s", rasd['InstanceID'], + exp_rasd.InstanceID) + return FAIL - if status != PASS: - logger.error("RASD with id %s not returned", exp_rasd.InstanceID) + status = compare_all_prop(rasd, exp_rasd) + if status != PASS: + logger.error("Verifying instance properties failed.") + + return status + +def verify_devices(enum_list, devs): + dev = enum_list[0] + dev_cn = dev.classname + + if len(enum_list) != 1: + logger.error("Got %d %s devices, expected 1", len(enum_list), dev_cn) return FAIL - return PASS + exp_dev = devs[dev_cn] -def verify_devices(enum_list, devs): - for dev in enum_list: - guest, dev_id, status = parse_instance_id(dev['DeviceID']) - if status != PASS: - logger.error("Unable to parse InstanceID: %s", dev['DeviceID']) - return status + if dev['DeviceID'] != exp_dev.DeviceID: + logger.error("Got %s instead of %s", dev['DeviceID'], exp_dev.DeviceID) + return FAIL - exp_dev = devs[dev.classname] - - if dev['DeviceID'] == exp_dev.DeviceID: - status = PASS - else: - logger.info("Got %s instead of %s" % (dev['DeviceID'], - exp_dev.DeviceID)) - status = FAIL - + status = compare_all_prop(dev, exp_dev) if status != PASS: - logger.error("Device with id %s not returned", exp_dev.DeviceID) - return FAIL + return status return PASS @@ -196,7 +181,6 @@ status, cxml = setup_env(options.ip, virt) if status != PASS: - cxml.undefine(options.ip) return status if virt == 'XenFV': @@ -217,21 +201,24 @@ assoc = AssociatorNames(options.ip, vssdc_cn, vssd_cn, InstanceID = instIdval) - status = verify_rasd(virt, assoc, rasds, test_dom) + status = verify_rasd(virt, assoc, rasds) if status != PASS: raise Exception("Failed to verify RASDs") - if len(assoc) != len(rasds): - raise Exception("Got %d RASDs, exp %d" % (len(assoc), len(rasds))) - sds_cn = get_typed_class(virt, 'SettingsDefineState') devs, status = init_device_list(virt, options.ip, test_dom) if status != PASS: raise Exception("Unable to build device instance list") + proc_cn = get_typed_class(virt, 'ProcResourceAllocationSettingData') for rasd in assoc: rasd_cn = rasd.classname + + # LXC guests don't have proc devices + if virt == "LXC" and rasd_cn == proc_cn: + continue + sdc_assoc = AssociatorNames(options.ip, sds_cn, rasd_cn, InstanceID = rasd['InstanceID']) diff -r c48f4ad82a02 -r 6e23c06353a1 suites/libvirt-cim/lib/XenKvmLib/vxml.py --- a/suites/libvirt-cim/lib/XenKvmLib/vxml.py Tue Jan 20 18:24:05 2009 -0800 +++ b/suites/libvirt-cim/lib/XenKvmLib/vxml.py Wed Jan 21 15:30:51 2009 -0800 @@ -501,9 +501,11 @@ res_settings.append(str(self.pasd)) if self.masd is not None: res_settings.append(str(self.masd)) - if self.nasd is not None or \ - (self.virt == 'LXC' and const.LXC_netns_support is False): - res_settings.append(str(self.nasd)) + if self.nasd is not None: + if self.virt == 'LXC' and const.LXC_netns_support is False: + pass + else: + res_settings.append(str(self.nasd)) if ref_conf is None: ref_conf = ' '

2 1

What is the current state of VM guest creation/modification, storage pools, and metrics in Libvirt-CIM?
by Medlyn, Dayne (VSL - Ft Collins) 21 Jan '09

21 Jan '09

Hi, We have been looking into what some of the Libvirt-CIM wholes might be for our needs and possibly how we can help close some of those wholes. I recently sat in on Dan Smiths presentation on the Libvirt-CIM and need a little bit of clarification. >From Dan's presentation it sounds like the ability to create a VM configuration (currently we are most interested in Xen) already exists. Can someone help me understand what that looks like right now? I presume it involves something like establishing a configuration, adding components to it (such as memory, CPUs, storage, network, etc.), posting that configuration to host (the xenstore for Xen?), then starting the VM guest. Does this include configuring to boot from install media? How about configuring for a network boot from which to do an install? Does this interface also support modifying this configuration, either live or off-line? Is there mechanism to validate new configurations before committing them? Another aspect Dan talked about was Resource Pools. I realize there is work going on to enhance Resource Pools. Is the current implementation of Resource Pools limited to storage pools? What type of storage is supported (iSCSI, NFS, Fibrechannel?, etc.)? An area we are looking to help augment is around guest metrics, at least those that can be collected from the host. Of particular interest are counters. Is there anyone currently working on this that I should collaborate with? I am beginning to dig into the code but I could use some quick answers. Thanks for the help. Dayne Medlyn Software Engineer Hewlett Packard

3 3

[PATCH] [TEST] #2 Fix verify_rasds() and verify_devices() in SD 02_reverse.py
by Kaitlin Rupert 21 Jan '09

21 Jan '09

# HG changeset patch # User Kaitlin Rupert <karupert(a)us.ibm.com> # Date 1232505043 28800 # Node ID c9633428563c23db5154195f9a5fe645a0b4a3eb # Parent c48f4ad82a02ab19ff0d30d77d492060d0a30145 [TEST] #2 Fix verify_rasds() and verify_devices() in SD 02_reverse.py Since VSSDC should return RASDs that all correspond to the guest, there's no need to parse the InstanceID to see if the guest name matches the guest we've created. Also, fix the logic of the verify functions to be a little cleaner. Compare all the properties of the instances, not just the InstanceIDs/DeviceIDs. Remove parse_instance_id() from verify_devices(); guest and dev_id were not being used in the function. Updates: -Removed unnecessary undefine() call -Moved the verification of the number of RASDs before the for loop - in the case of LXC, we remove one of the RASDs from this list so we don't verify it, but we still want to verify the appropriate number of RASDs was returned. -Print an error message if comparing all the instance properties fails. Signed-off-by: Kaitlin Rupert <karupert(a)us.ibm.com> diff -r c48f4ad82a02 -r c9633428563c suites/libvirt-cim/cimtest/SettingsDefine/02_reverse.py --- a/suites/libvirt-cim/cimtest/SettingsDefine/02_reverse.py Tue Jan 20 18:24:05 2009 -0800 +++ b/suites/libvirt-cim/cimtest/SettingsDefine/02_reverse.py Tue Jan 20 18:30:43 2009 -0800 @@ -55,7 +55,7 @@ from CimTest.Globals import logger from CimTest.ReturnCodes import PASS, FAIL from XenKvmLib.const import do_main -from XenKvmLib.assoc import AssociatorNames +from XenKvmLib.assoc import AssociatorNames, compare_all_prop from XenKvmLib.vxml import get_class from XenKvmLib.classes import get_typed_class from XenKvmLib.rasd import enum_rasds @@ -135,56 +135,50 @@ return dev_insts, PASS -def verify_rasd(virt, enum_list, rasds, guest_name): +def verify_rasd(virt, enum_list, rasds): proc_rasd_cn = get_typed_class(virt, "ProcResourceAllocationSettingData") + if len(enum_list) != len(rasds): + logger.error("Got %d RASDs, expected %d", len(enum_list), len(rasds)) + return FAIL + + status = FAIL + for rasd in enum_list: if virt == "LXC" and rasd.classname == proc_rasd_cn: enum_list.remove(rasd) continue - guest, dev, status = parse_instance_id(rasd['InstanceID']) - if status != PASS: - logger.error("Unable to parse InstanceID: %s", rasd['InstanceID']) - return status - - if guest != guest_name: - continue - exp_rasd = rasds[rasd.classname] - if rasd['InstanceID'] == exp_rasd.InstanceID: - status = PASS - else: - logger.info("Got %s instead of %s" % (rasd['InstanceID'], - exp_rasd.InstanceID)) - status = FAIL + if rasd['InstanceID'] != exp_rasd.InstanceID: + logger.error("Got %s instead of %s", rasd['InstanceID'], + exp_rasd.InstanceID) + return FAIL - if status != PASS: - logger.error("RASD with id %s not returned", exp_rasd.InstanceID) + status = compare_all_prop(rasd, exp_rasd) + if status != PASS: + logger.error("Verifying instance properties failed.") + + return status + +def verify_devices(enum_list, devs): + dev = enum_list[0] + dev_cn = dev.classname + + if len(enum_list) != 1: + logger.error("Got %d %s devices, expected 1", len(enum_list), dev_cn) return FAIL - return PASS + exp_dev = devs[dev_cn] -def verify_devices(enum_list, devs): - for dev in enum_list: - guest, dev_id, status = parse_instance_id(dev['DeviceID']) - if status != PASS: - logger.error("Unable to parse InstanceID: %s", dev['DeviceID']) - return status + if dev['DeviceID'] != exp_dev.DeviceID: + logger.error("Got %s instead of %s", dev['DeviceID'], exp_dev.DeviceID) + return FAIL - exp_dev = devs[dev.classname] - - if dev['DeviceID'] == exp_dev.DeviceID: - status = PASS - else: - logger.info("Got %s instead of %s" % (dev['DeviceID'], - exp_dev.DeviceID)) - status = FAIL - + status = compare_all_prop(dev, exp_dev) if status != PASS: - logger.error("Device with id %s not returned", exp_dev.DeviceID) - return FAIL + return status return PASS @@ -196,7 +190,6 @@ status, cxml = setup_env(options.ip, virt) if status != PASS: - cxml.undefine(options.ip) return status if virt == 'XenFV': @@ -217,13 +210,10 @@ assoc = AssociatorNames(options.ip, vssdc_cn, vssd_cn, InstanceID = instIdval) - status = verify_rasd(virt, assoc, rasds, test_dom) + status = verify_rasd(virt, assoc, rasds) if status != PASS: raise Exception("Failed to verify RASDs") - if len(assoc) != len(rasds): - raise Exception("Got %d RASDs, exp %d" % (len(assoc), len(rasds))) - sds_cn = get_typed_class(virt, 'SettingsDefineState') devs, status = init_device_list(virt, options.ip, test_dom)

2 1

'Parsing error' during make postinstall step of installing libvirt-cim
by U Gopalakrishnan 20 Jan '09

20 Jan '09

Hello, I am trying to setup latest libvirt-cim in RHEL 5.2 with Pegasus server 2.8.0-1. I am using libvirt-cim source snapshot dated 01/13/09 obtained from ftp://libvirt.org/libvirt/CIM/ . Following the README in the source, the 'make postinstall' step fails with the following error. Processing provider modules: Virt_AllocationCapabilities Virt_ComputerSystem Virt_ComputerSystemIndication Virt_ComputerSystemMigrationIndication Virt_ConcreteComponent Virt_ConsoleRedirectionService Virt_ConsoleRedirectionServiceCapabilities Virt_Device Virt_DevicePool Virt_ElementAllocatedFromPool Virt_ElementCapabilities Virt_ElementConformsToProfile Virt_ElementSettingData Virt_EnabledLogicalElementCapabilities Virt_HostedAccessPoint Virt_HostedDependency Virt_HostedResourcePool Virt_HostedService Virt_HostSystem Virt_KVMRedirectionSAP Virt_RASD Virt_ResourceAllocationFromPool Virt_ResourcePoolConfigurationCapabilities Virt_ResourcePoolConfigurationService Virt_SAPAvailableForElement Virt_ServiceAccessBySAP Virt_ServiceAffectsElement Virt_SettingsDefineCapabilities Virt_SettingsDefineState Virt_SystemDevice Virt_VirtualSystemManagementCapabilities Virt_VirtualSystemManagementService Virt_VirtualSystemSnapshotService Virt_VirtualSystemSnapshotServiceCapabilities Virt_VSMigrationCapabilities Virt_VSMigrationService Virt_VSMigrationSettingData Virt_VSSD Virt_VSSDComponent Registering providers with active cimserver Parsing error: parse error: Could not find declaration for Qualifier named ASSOCIATION make: *** [postinstall] Error 250 Any ideas? Thanks Gopal

3 14