Kaitlin Rupert wrote:
# HG changeset patch
# User Kaitlin Rupert <karupert(a)us.ibm.com>
# Date 1209426269 25200
# Node ID 92702225dbafa13d2f7201b3fe5baeaebd07100d
# Parent a9f38d1726784a85db09602c53ad990819047690
Remove extra cu_statusf() call from VSMigrationService.c
Unfortunately, the patch doesn't include the appropriate context (see below). The
issue here is that the if/else blocks call cu_statusf() to set the status. There's no
goto in the else block, so this extra cu_statusf() is called - even when we've
encountered an error.
if (remote >= local) {
/* Success */
} else {
/* Failure */
}
Signed-off-by: Kaitlin Rupert <karupert(a)us.ibm.com>
Yup, totally extraneous call there. Nice catch, +1.
--
-Jay