# HG changeset patch
# User Richard Maciel <rmaciel(a)linux.vnet.ibm.com>
# Date 1259357082 7200
# Node ID 9e0d6ff3f5f6ec6653059ef1422ed6b70f8728f5
# Parent 5467bdbfdaf8a3716cbbf489410b15025b23c7ce
[TEST] (#2) LXC currently doesn't support VNC, so skip appropriated tests
#2:
- Added missing testcase fix
Signed-off-by: Richard Maciel <rmaciel(a)linux.vnet.ibm.com>
diff -r 5467bdbfdaf8 -r 9e0d6ff3f5f6
suites/libvirt-cim/cimtest/HostedAccessPoint/01_forward.py
--- a/suites/libvirt-cim/cimtest/HostedAccessPoint/01_forward.py Wed Nov 25 18:45:49 2009
-0200
+++ b/suites/libvirt-cim/cimtest/HostedAccessPoint/01_forward.py Fri Nov 27 19:24:42 2009
-0200
@@ -110,6 +110,10 @@
"skipping the tc ....")
return SKIP
+ if options.virt == 'LXC':
+ logger.info("VNC is not supported by LXC, hence skipping the "
+ "tc ....")
+ return SKIP
status, cxml = setup_env(options.ip, options.virt)
if status != PASS:
diff -r 5467bdbfdaf8 -r 9e0d6ff3f5f6
suites/libvirt-cim/cimtest/HostedAccessPoint/02_reverse.py
--- a/suites/libvirt-cim/cimtest/HostedAccessPoint/02_reverse.py Wed Nov 25 18:45:49 2009
-0200
+++ b/suites/libvirt-cim/cimtest/HostedAccessPoint/02_reverse.py Fri Nov 27 19:24:42 2009
-0200
@@ -116,6 +116,11 @@
logger.info("'HostedAccessPoint' provider not supported, hence
" +
"skipping the tc ....")
return SKIP
+
+ if options.virt == 'LXC':
+ logger.info("VNC is not supported by LXC, hence skipping the "
+ "tc ....")
+ return SKIP
status, cxml = setup_env(options.ip, options.virt)
if status != PASS:
diff -r 5467bdbfdaf8 -r 9e0d6ff3f5f6
suites/libvirt-cim/cimtest/KVMRedirectionSAP/01_enum_KVMredSAP.py
--- a/suites/libvirt-cim/cimtest/KVMRedirectionSAP/01_enum_KVMredSAP.py Wed Nov 25
18:45:49 2009 -0200
+++ b/suites/libvirt-cim/cimtest/KVMRedirectionSAP/01_enum_KVMredSAP.py Fri Nov 27
19:24:42 2009 -0200
@@ -100,6 +100,11 @@
classname)
return SKIP
+ if virt == 'LXC':
+ logger.info("VNC is not supported by LXC, hence skipping the "
+ "tc ....")
+ return SKIP
+
vsxml = None
action_start = False
diff -r 5467bdbfdaf8 -r 9e0d6ff3f5f6
suites/libvirt-cim/cimtest/RedirectionService/03_RedirectionSAP_errs.py
--- a/suites/libvirt-cim/cimtest/RedirectionService/03_RedirectionSAP_errs.py Wed Nov 25
18:45:49 2009 -0200
+++ b/suites/libvirt-cim/cimtest/RedirectionService/03_RedirectionSAP_errs.py Fri Nov 27
19:24:42 2009 -0200
@@ -76,6 +76,11 @@
"hence skipping the test ....")
return SKIP
+ if options.virt == 'LXC':
+ logger.info("VNC is not supported by LXC, hence skipping the "
+ "tc ....")
+ return SKIP
+
# Getting the VS list and deleting the test_dom if it already exists.
cxml = vxml.get_class(options.virt)(test_dom, vcpus=test_vcpus)
ret = cxml.cim_define(options.ip)
diff -r 5467bdbfdaf8 -r 9e0d6ff3f5f6
suites/libvirt-cim/cimtest/VirtualSystemManagementService/20_verify_vnc_password.py
---
a/suites/libvirt-cim/cimtest/VirtualSystemManagementService/20_verify_vnc_password.py Wed
Nov 25 18:45:49 2009 -0200
+++
b/suites/libvirt-cim/cimtest/VirtualSystemManagementService/20_verify_vnc_password.py Fri
Nov 27 19:24:42 2009 -0200
@@ -76,6 +76,11 @@
logger.info("VNC Password support not available, feature available
in"\
" '%s' revision..", libvirtcim_vnc_passwd_changes)
return SKIP
+
+ if virt == 'LXC':
+ logger.info("VNC is not supported by LXC, hence skipping the "
+ "tc ....")
+ return SKIP
cxml = vxml.get_class(virt)(default_dom, vnc_passwd=passwd)
Show replies by date
Richard Maciel wrote:
# HG changeset patch
# User Richard Maciel <rmaciel(a)linux.vnet.ibm.com>
# Date 1259357082 7200
# Node ID 9e0d6ff3f5f6ec6653059ef1422ed6b70f8728f5
# Parent 5467bdbfdaf8a3716cbbf489410b15025b23c7ce
[TEST] (#2) LXC currently doesn't support VNC, so skip appropriated tests
These look good. Although, no need to have the message span multiple
lines. For each test case, you can do the following instead:
logger.info("VNC is not supported by LXC, hence skipping the tc ....")
This will fit within 80 character limit. And looks cleaner, since you
don't have a string spanning multiple lines.
--
Kaitlin Rupert
IBM Linux Technology Center
kaitlin(a)linux.vnet.ibm.com