[PATCH] [TEST]Fix ElementConforms/04_ectp_rev_errs.py err message
# HG changeset patch # User Guolian Yun <yunguol@cn.ibm.com> # Date 1236245435 28800 # Node ID 9b27878b650523b6353ddb2ffca93ad8158b7bbc # Parent c6f7256013b97dc57a31312897e45eb3cd8604a7 [TEST]Fix ElementConforms/04_ectp_rev_errs.py err message Updates tc err message to meet the provder updates Tested for KVM/LXC with current sources and rpm Signed-off-by: Guolian Yun<yunguol@cn.ibm.com> diff -r c6f7256013b9 -r 9b27878b6505 suites/libvirt-cim/cimtest/ElementConforms/04_ectp_rev_errs.py --- a/suites/libvirt-cim/cimtest/ElementConforms/04_ectp_rev_errs.py Tue Mar 03 08:47:40 2009 -0800 +++ b/suites/libvirt-cim/cimtest/ElementConforms/04_ectp_rev_errs.py Thu Mar 05 01:30:35 2009 -0800 @@ -89,7 +89,7 @@ from XenKvmLib.test_doms import destroy_and_undefine_all from CimTest.ReturnCodes import PASS, FAIL from CimTest.Globals import logger, CIM_USER, CIM_PASS, CIM_NS -from XenKvmLib.const import do_main +from XenKvmLib.const import do_main, get_provider_version sup_types = ['Xen', 'XenFV', 'KVM', 'LXC'] @@ -169,8 +169,12 @@ retval = try_invalid_assoc(hs, host_name_val, i, tc_scen[i], options.virt) if retval != PASS: status = retval + curr_cim_rev, changeset = get_provider_version(options.virt, options.ip) + for i in range(len(tc_scen)): + if i == 3 and curr_cim_rev >= 817: + cs_values[tc_scen[i]]['desc'] = "Referenced domain `INVALID_Name_Keyvalue' \ +does not exist: Domain not found" - for i in range(len(tc_scen)): retval = try_invalid_assoc(cs, comp_name_val, i, tc_scen[i], options.virt) if retval != PASS: status = retval
yunguol@cn.ibm.com wrote:
# HG changeset patch # User Guolian Yun <yunguol@cn.ibm.com> # Date 1236245435 28800 # Node ID 9b27878b650523b6353ddb2ffca93ad8158b7bbc # Parent c6f7256013b97dc57a31312897e45eb3cd8604a7 [TEST]Fix ElementConforms/04_ectp_rev_errs.py err message
Updates tc err message to meet the provder updates
Tested for KVM/LXC with current sources and rpm
Signed-off-by: Guolian Yun<yunguol@cn.ibm.com>
diff -r c6f7256013b9 -r 9b27878b6505 suites/libvirt-cim/cimtest/ElementConforms/04_ectp_rev_errs.py --- a/suites/libvirt-cim/cimtest/ElementConforms/04_ectp_rev_errs.py Tue Mar 03 08:47:40 2009 -0800 +++ b/suites/libvirt-cim/cimtest/ElementConforms/04_ectp_rev_errs.py Thu Mar 05 01:30:35 2009 -0800 @@ -89,7 +89,7 @@ from XenKvmLib.test_doms import destroy_and_undefine_all from CimTest.ReturnCodes import PASS, FAIL from CimTest.Globals import logger, CIM_USER, CIM_PASS, CIM_NS -from XenKvmLib.const import do_main +from XenKvmLib.const import do_main, get_provider_version
sup_types = ['Xen', 'XenFV', 'KVM', 'LXC']
@@ -169,8 +169,12 @@ retval = try_invalid_assoc(hs, host_name_val, i, tc_scen[i], options.virt) if retval != PASS: status = retval + curr_cim_rev, changeset = get_provider_version(options.virt, options.ip) + for i in range(len(tc_scen)): + if i == 3 and curr_cim_rev >= 817:
I think the revision in which the changes went in was 815 and not 817. Also, can you please assign the revision value to a variable instead of directly using it for the comparison.
+ cs_values[tc_scen[i]]['desc'] = "Referenced domain `INVALID_Name_Keyvalue' \ +does not exist: Domain not found"
- for i in range(len(tc_scen)): retval = try_invalid_assoc(cs, comp_name_val, i, tc_scen[i], options.virt) if retval != PASS: status = retval
_______________________________________________ Libvirt-cim mailing list Libvirt-cim@redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim
-- Thanks and Regards, Deepti B. Kalakeri IBM Linux Technology Center deeptik@linux.vnet.ibm.com
@@ -169,8 +169,12 @@ retval = try_invalid_assoc(hs, host_name_val, i, tc_scen[i], options.virt) if retval != PASS: status = retval + curr_cim_rev, changeset = get_provider_version(options.virt, options.ip) + for i in range(len(tc_scen)): + if i == 3 and curr_cim_rev >= 817:
Also, can you use a variable for the changeset revision number?
+ cs_values[tc_scen[i]]['desc'] = "Referenced domain `INVALID_Name_Keyvalue' \ +does not exist: Domain not found"
cs_values[tc_scen[i]]['desc'] = "Referenced domain" + \ " `INVALID_Name_Keyvalue' does" + \ " not exist: Domain not found" -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com
participants (3)
-
Deepti B Kalakeri -
Kaitlin Rupert -
yunguol＠cn.ibm.com