[PATCH] [TEST] Modifying devices.py to fix tc 01_netport.py which was failing on F9 libvirt-cim rpm
# HG changeset patch # User Deepti B. Kalakeri <deeptik@linux.vnet.ibm.com> # Date 1213868143 25200 # Node ID f67381970add8e02ecd3ebbdc600f397c7fa51fe # Parent 0986ab7af5023cac28da15c59fffcca60c78866c [TEST] Modifying devices.py to fix tc 01_netport.py which was failing on F9 libvirt-cim rpm. Signed-off-by: Deepti B. Kalakeri <deeptik@linux.vnet.ibm.com> diff -r 0986ab7af502 -r f67381970add suites/libvirt-cim/lib/XenKvmLib/devices.py --- a/suites/libvirt-cim/lib/XenKvmLib/devices.py Thu Jun 19 01:42:12 2008 -0700 +++ b/suites/libvirt-cim/lib/XenKvmLib/devices.py Thu Jun 19 02:35:43 2008 -0700 @@ -26,9 +26,19 @@ from CimTest import CimExt from CimTest import CimExt from CimTest import Globals from XenKvmLib import assoc +from XenKvmLib.const import CIM_REV from XenKvmLib.classes import get_typed_class -LinkTechnology_Ethernet = 2 +net_rev = 598 + +# The branch has to be removed once the new rpm +# including the changes in revision 598 is available. +# The value of LinkTechnology should be set to 2 for +# network, bridge and ethernet type interfaces. +if net_rev > CIM_REV: + LinkTechnology_Ethernet = 0 +else: + LinkTechnology_Ethernet = 2 class CIM_Instance: def __init__(self, inst):
from XenKvmLib.classes import get_typed_class
-LinkTechnology_Ethernet = 2 +net_rev = 598 + +# The branch has to be removed once the new rpm +# including the changes in revision 598 is available. +# The value of LinkTechnology should be set to 2 for +# network, bridge and ethernet type interfaces. +if net_rev > CIM_REV: + LinkTechnology_Ethernet = 0
This change occurred due to changeset 599. I know this is a minor change, but can you change this yo be net_rev >= CIM_REV and use 599 as the changeset number. When I looked at rev 598, I was confused that it didn't have anything to do with network interfaces, so using 599 is a little clearer I think. -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com
from XenKvmLib.classes import get_typed_class
-LinkTechnology_Ethernet = 2 +net_rev = 598 + +# The branch has to be removed once the new rpm +# including the changes in revision 598 is available. +# The value of LinkTechnology should be set to 2 for +# network, bridge and ethernet type interfaces. +if net_rev > CIM_REV: + LinkTechnology_Ethernet = 0
This change occurred due to changeset 599. I know this is a minor change, but can you change this yo be net_rev >= CIM_REV and use 599 as the changeset number.
When I looked at rev 598, I was confused that it didn't have anything to do with network interfaces, so using 599 is a little clearer I think. Sorry, I just used someother no other than the changeset present in the
Kaitlin Rupert wrote: patch. yeah it shld be 599 instead of 598 and the patch which I was referring is "Fix setting of the proper CIM network type for network devices". Modified this and submitted the patch. Thanks and Regards, Deepti.
participants (3)
-
Deepti B Kalakeri -
Deepti B. Kalakeri
-
Kaitlin Rupert