[PATCH] [TEST] Add the missing Address value in NetRASD init
# HG changeset patch # User Zhengang Li <lizg@cn.ibm.com> # Date 1208509526 -28800 # Node ID 4ee138efe1ef8332366db16b30fd777bae8b2a08 # Parent 1fc0ff2248ae99860b83abb5ce8952df82218798 [TEST] Add the missing Address value in NetRASD init Provider code already has this NetRASD Address as the mac. Signed-off-by: Zhengang Li <lizg@cn.ibm.com> diff -r 1fc0ff2248ae -r 4ee138efe1ef suites/libvirt-cim/lib/XenKvmLib/vsms.py --- a/suites/libvirt-cim/lib/XenKvmLib/vsms.py Fri Apr 18 17:00:16 2008 +0800 +++ b/suites/libvirt-cim/lib/XenKvmLib/vsms.py Fri Apr 18 17:05:26 2008 +0800 @@ -138,6 +138,7 @@ def get_dasd_class(virt): class CIM_NetResourceAllocationSettingData(CIMClassMOF): def __init__(self, type, mac, name): + self.Address = mac self.NetworkType = type if type == 'ethernet' or type == 'bridge' : self.ResourceType = RASD_TYPE_NET_ETHER
Don't we need to include the changeset number and revision number before including this field ? I think if we run this version on the F9, will it not fail ? Regards, Deepti zli@linux.vnet.ibm.com wrote:
# HG changeset patch # User Zhengang Li <lizg@cn.ibm.com> # Date 1208509526 -28800 # Node ID 4ee138efe1ef8332366db16b30fd777bae8b2a08 # Parent 1fc0ff2248ae99860b83abb5ce8952df82218798 [TEST] Add the missing Address value in NetRASD init
Provider code already has this NetRASD Address as the mac.
Signed-off-by: Zhengang Li <lizg@cn.ibm.com>
diff -r 1fc0ff2248ae -r 4ee138efe1ef suites/libvirt-cim/lib/XenKvmLib/vsms.py --- a/suites/libvirt-cim/lib/XenKvmLib/vsms.py Fri Apr 18 17:00:16 2008 +0800 +++ b/suites/libvirt-cim/lib/XenKvmLib/vsms.py Fri Apr 18 17:05:26 2008 +0800 @@ -138,6 +138,7 @@ def get_dasd_class(virt):
class CIM_NetResourceAllocationSettingData(CIMClassMOF): def __init__(self, type, mac, name): + self.Address = mac self.NetworkType = type if type == 'ethernet' or type == 'bridge' : self.ResourceType = RASD_TYPE_NET_ETHER
_______________________________________________ Libvirt-cim mailing list Libvirt-cim@redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim
DK> Don't we need to include the changeset number and revision number DK> before including this field ? I think if we run this version on DK> the F9, will it not fail ? No, it won't fail just because you give it more information than it needs, it just won't use that value. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms@us.ibm.com
Dan Smith wrote:
DK> Don't we need to include the changeset number and revision number DK> before including this field ? I think if we run this version on DK> the F9, will it not fail ?
No, it won't fail just because you give it more information than it needs, it just won't use that value.
Yep, this worked fine for me on F9 with a release rpm. -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com
participants (4)
-
Dan Smith -
Deepti B Kalakeri -
Kaitlin Rupert -
zli＠linux.vnet.ibm.com