[PATCH] Make schema zip download during 'build', not 'dist'
# HG changeset patch # User Dan Smith <danms@us.ibm.com> # Date 1197477759 28800 # Node ID c9edd5bc7202c0ee76bfba68aac98fd97ca87b34 # Parent 85e3ec9836b74c4d3424fc4e67d7c6a22c00863d Make schema zip download during 'build', not 'dist' This makes the tarball not include the zip, which is close to 2MB in size. I think it's safe to assume that users of the tarball can allow the wget of the zip file during build. For the RPM, I will make it download the zip during 'dist' so that the SRPM already contains it. Signed-off-by: Dan Smith <danms@us.ibm.com> diff -r 85e3ec9836b7 -r c9edd5bc7202 base_schema/Makefile.am --- a/base_schema/Makefile.am Wed Dec 12 08:40:39 2007 -0800 +++ b/base_schema/Makefile.am Wed Dec 12 08:42:39 2007 -0800 @@ -2,8 +2,9 @@ CIM_SCHEMA_REL = $(CIM_SCHEMA_VER)Experi CIM_SCHEMA_REL = $(CIM_SCHEMA_VER)Experimental CIM_SCHEMA_ZIP = cimv$(CIM_SCHEMA_REL)-MOFs.zip -dist_pkgdata_DATA = $(CIM_SCHEMA_ZIP) fix_schema.patch cimv216-interop_mof +pkgdata_DATA = $(CIM_SCHEMA_ZIP) +dist_pkgdata_DATA = fix_schema.patch cimv216-interop_mof dist_pkgdata_SCRIPTS = install_base_schema.sh $(CIM_SCHEMA_ZIP): - wget http://www.dmtf.org/standards/cim/cim_schema_v$(CIM_SCHEMA_VER)/$(CIM_SCHEMA...) \ No newline at end of file + wget http://www.dmtf.org/standards/cim/cim_schema_v$(CIM_SCHEMA_VER)/$(CIM_SCHEMA...)
On Wed, Dec 12, 2007 at 08:48:20AM -0700, Dan Smith wrote:
# HG changeset patch # User Dan Smith <danms@us.ibm.com> # Date 1197477759 28800 # Node ID c9edd5bc7202c0ee76bfba68aac98fd97ca87b34 # Parent 85e3ec9836b74c4d3424fc4e67d7c6a22c00863d Make schema zip download during 'build', not 'dist'
This makes the tarball not include the zip, which is close to 2MB in size. I think it's safe to assume that users of the tarball can allow the wget of the zip file during build. For the RPM, I will make it download the
I don't think it's a good assumption. For example it may break in some build system where the machines are not allowed to access outside machine. Keep it in the dist, it's heavier, but the only reasonnable safe way. Also if you were to rebuild the package from source say 2 years from now, the zip may not be available anymore from that URL. Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
DV> I don't think it's a good assumption. For example it may break in DV> some build system where the machines are not allowed to access DV> outside machine. Okay, that's valid. DV> Also if you were to rebuild the package from source say 2 years DV> from now, the zip may not be available anymore from that URL. It's possible, but I think the DMTF will be pretty good about preserving that. Anyway, that's fine. I'll nuke this patch. Thanks :) -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms@us.ibm.com
participants (2)
-
Dan Smith -
Daniel Veillard