[PATCH] [TEST] Change default KVM emulator to qemu-kvm
# HG changeset patch # User Zhengang Li <lizg@cn.ibm.com> # Date 1207709819 25200 # Node ID b5857217c64a081450cd21219035084eac455d85 # Parent 262153788503c8b10c76c77719bba081df9a7b88 [TEST] Change default KVM emulator to qemu-kvm We're more close to KVM full coverage support. It makes sense to set the default emulator to a real one instead of a pure-qemu version. Signed-off-by: Zhengang Li <lizg@cn.ibm.com> diff -r 262153788503 -r b5857217c64a suites/libvirt-cim/lib/XenKvmLib/const.py --- a/suites/libvirt-cim/lib/XenKvmLib/const.py Tue Apr 08 17:58:44 2008 +0530 +++ b/suites/libvirt-cim/lib/XenKvmLib/const.py Tue Apr 08 19:56:59 2008 -0700 @@ -43,7 +43,7 @@ Xen_default_net_type = 'ethernet' # vxml.KVMXML -KVM_default_emulator = '/usr/bin/qemu' +KVM_default_emulator = '/usr/bin/qemu-kvm' KVM_disk_path = os.path.join(_image_dir, 'default-kvm-dimage') KVM_secondary_disk_path = os.path.join(_image_dir, 'default-kvm-dimage.2ND') KVM_default_disk_dev = 'hda'
ZL> # vxml.KVMXML ZL> -KVM_default_emulator = '/usr/bin/qemu' ZL> +KVM_default_emulator = '/usr/bin/qemu-kvm' I'd like this to be more intelligent. I'd like to be able to continue to run the suite on a machine that doesn't have VT, using a QEMU domain without KVM support. Setting this based on the presence of 'vmx' or 'svm' in /proc/cpuinfo seems like a reasonable way, and provides the most flexibility. We can even log which we're using so that any report that differs because of the emulator type (which I think is unlikely) will be marked as such. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms@us.ibm.com
Dan Smith wrote:
ZL> # vxml.KVMXML ZL> -KVM_default_emulator = '/usr/bin/qemu' ZL> +KVM_default_emulator = '/usr/bin/qemu-kvm'
I'd like this to be more intelligent. I'd like to be able to continue to run the suite on a machine that doesn't have VT, using a QEMU domain without KVM support.
Sorry Dan, I missed your response here and pushed this patch in. I think this is a good idea. Zhengang - can you work on a follow up patch since I already did a push on this? Thanks!
Setting this based on the presence of 'vmx' or 'svm' in /proc/cpuinfo seems like a reasonable way, and provides the most flexibility. We can even log which we're using so that any report that differs because of the emulator type (which I think is unlikely) will be marked as such.
-- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com
zli@linux.vnet.ibm.com wrote:
# HG changeset patch # User Zhengang Li <lizg@cn.ibm.com> # Date 1207709819 25200 # Node ID b5857217c64a081450cd21219035084eac455d85 # Parent 262153788503c8b10c76c77719bba081df9a7b88 [TEST] Change default KVM emulator to qemu-kvm
We're more close to KVM full coverage support. It makes sense to set the default emulator to a real one instead of a pure-qemu version.
Signed-off-by: Zhengang Li <lizg@cn.ibm.com>
Good catch - thanks! -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com
participants (3)
-
Dan Smith -
Kaitlin Rupert -
zli＠linux.vnet.ibm.com