From: "Eduardo Lima (Etrunko)"<eblima(a)br.ibm.com> Signed-off-by: Eduardo Lima (Etrunko)<eblima(a)br.ibm.com> --- src/Virt_ComputerSystemIndication.c | 51 +++++++++++++++++------------------ 1 files changed, 25 insertions(+), 26 deletions(-) diff --git a/src/Virt_ComputerSystemIndication.c b/src/Virt_ComputerSystemIndication.c index ab6ffe4..b60138a 100644 --- a/src/Virt_ComputerSystemIndication.c +++ b/src/Virt_ComputerSystemIndication.c @@ -692,36 +692,35 @@ static CMPIStatus ActivateFilter(CMPIIndicationMI* mi, thread =&csi_thread_data[platform]; thread->active_filters += 1; - if (thread->id == 0) { - args = malloc(sizeof(*args)); - if (args == NULL) { - CU_DEBUG("Failed to allocate ind_args"); - cu_statusf(_BROKER,&s, - CMPI_RC_ERR_FAILED, - "Unable to allocate ind_args"); - error = true; - goto out; - } - - args->context = CBPrepareAttachThread(_BROKER, ctx); - if (args->context == NULL) { - CU_DEBUG("Failed to create thread context"); - cu_statusf(_BROKER,&s, - CMPI_RC_ERR_FAILED, - "Unable to create thread context"); - error = true; - goto out; - } + /* Check if thread is already running */ + if (thread->id> 0) + goto out; - args->ns = strdup(NAMESPACE(op)); - args->classname = strdup(CLASSNAME(op)); - args->_ctx = _ctx; + args = malloc(sizeof(*args)); + if (args == NULL) { + CU_DEBUG("Failed to allocate ind_args"); + cu_statusf(_BROKER,&s, CMPI_RC_ERR_FAILED, + "Unable to allocate ind_args"); + error = true; + goto out; + } - thread->args = args; - thread->id = _BROKER->xft->newThread(lifecycle_thread, - thread, 0); + args->context = CBPrepareAttachThread(_BROKER, ctx); + if (args->context == NULL) { + CU_DEBUG("Failed to create thread context"); + cu_statusf(_BROKER,&s, CMPI_RC_ERR_FAILED, + "Unable to create thread context"); + error = true; + goto out; } + args->ns = strdup(NAMESPACE(op)); + args->classname = strdup(CLASSNAME(op)); + args->_ctx = _ctx; + + thread->args = args; + thread->id = _BROKER->xft->newThread(lifecycle_thread, thread, 0); + out: if (error == true) { thread->active_filters -= 1;

+1 On 02/20/2012 02:36 PM, Eduardo Lima (Etrunko) wrote: > From: "Eduardo Lima (Etrunko)"<eblima(a)br.ibm.com> > > Signed-off-by: Eduardo Lima (Etrunko)<eblima(a)br.ibm.com> > --- > src/Virt_ComputerSystemIndication.c | 51 +++++++++++++++++------------------ > 1 files changed, 25 insertions(+), 26 deletions(-) > > diff --git a/src/Virt_ComputerSystemIndication.c > b/src/Virt_ComputerSystemIndication.c > index ab6ffe4..b60138a 100644 > --- a/src/Virt_ComputerSystemIndication.c > +++ b/src/Virt_ComputerSystemIndication.c > @@ -692,36 +692,35 @@ static CMPIStatus ActivateFilter(CMPIIndicationMI* mi, > thread =&csi_thread_data[platform]; > thread->active_filters += 1; > > - if (thread->id == 0) { > - args = malloc(sizeof(*args)); > - if (args == NULL) { > - CU_DEBUG("Failed to allocate ind_args"); > - cu_statusf(_BROKER,&s, > - CMPI_RC_ERR_FAILED, > - "Unable to allocate ind_args"); > - error = true; > - goto out; > - } > - > - args->context = CBPrepareAttachThread(_BROKER, ctx); > - if (args->context == NULL) { > - CU_DEBUG("Failed to create thread context"); > - cu_statusf(_BROKER,&s, > - CMPI_RC_ERR_FAILED, > - "Unable to create thread context"); > - error = true; > - goto out; > - } > + /* Check if thread is already running */ > + if (thread->id> 0) > + goto out; > > - args->ns = strdup(NAMESPACE(op)); > - args->classname = strdup(CLASSNAME(op)); > - args->_ctx = _ctx; > + args = malloc(sizeof(*args)); > + if (args == NULL) { > + CU_DEBUG("Failed to allocate ind_args"); > + cu_statusf(_BROKER,&s, CMPI_RC_ERR_FAILED, > + "Unable to allocate ind_args"); > + error = true; > + goto out; > + } > > - thread->args = args; > - thread->id = _BROKER->xft->newThread(lifecycle_thread, > - thread, 0); > + args->context = CBPrepareAttachThread(_BROKER, ctx); > + if (args->context == NULL) { > + CU_DEBUG("Failed to create thread context"); > + cu_statusf(_BROKER,&s, CMPI_RC_ERR_FAILED, > + "Unable to create thread context"); > + error = true; > + goto out; > } > > + args->ns = strdup(NAMESPACE(op)); > + args->classname = strdup(CLASSNAME(op)); > + args->_ctx = _ctx; > + > + thread->args = args; > + thread->id = _BROKER->xft->newThread(lifecycle_thread, thread, 0); > + > out: > if (error == true) { > thread->active_filters -= 1;

+1. On RHEL 6.2 (libvirt-0.9.4) I was able to run all cimtests without seeing a core, but my local indication tests still do not work properly. It's a configuration issue I need to resolve. I always see the following: ComputerSystemIndication - 01_created_indication.py: FAIL ERROR - Waited too long for define indication ERROR - Exception: Poll for indication Failed ERROR - Waited too long for start indication ERROR - Exception: Poll for indication Failed ERROR - Waited too long for destroy indication ERROR - Exception: Poll for indication Failed Sharad: Can you give this patchset a try and see if it resolves the problem you were seeing? On 02/20/2012 02:36 PM, Eduardo Lima (Etrunko) wrote: > From: "Eduardo Lima (Etrunko)&quot;&lt;eblima(a)br.ibm.com&gt; > > Signed-off-by: Eduardo Lima (Etrunko)&lt;eblima(a)br.ibm.com&gt; > --- > src/Virt_ComputerSystemIndication.c | 16 ++++++++++------ > 1 files changed, 10 insertions(+), 6 deletions(-) > > diff --git a/src/Virt_ComputerSystemIndication.c > b/src/Virt_ComputerSystemIndication.c > index 712e12c..ab6ffe4 100644 > --- a/src/Virt_ComputerSystemIndication.c > +++ b/src/Virt_ComputerSystemIndication.c > @@ -489,11 +489,11 @@ static int update_domain_list(virConnectPtr conn, > csi_thread_data_t *thread) > return s.rc; > } > > -static int csi_domain_event_cb(virConnectPtr conn, > - virDomainPtr dom, > - int event, > - int detail, > - void *data) > +static void csi_domain_event_cb(virConnectPtr conn, > + virDomainPtr dom, > + int event, > + int detail, > + void *data) > { > int cs_event = CS_MODIFIED; > csi_thread_data_t *thread = (csi_thread_data_t *) data; > @@ -501,6 +501,11 @@ static int csi_domain_event_cb(virConnectPtr conn, > char *prefix = class_prefix_name(thread->args->classname); > CMPIStatus s = {CMPI_RC_OK, NULL}; > > + if (lifecycle_enabled == false || thread->active_filters<= 0) { > + CU_DEBUG("%s indications deactivated, return"); > + return; > + } > + > CU_DEBUG("Event: Domain %s(%d) event: %d detail: %d\n", > virDomainGetName(dom), virDomainGetID(dom), event, detail); > > @@ -557,7 +562,6 @@ static int csi_domain_event_cb(virConnectPtr conn, > > end: > free(prefix); > - return 0; > } > > static CMPI_THREAD_RETURN lifecycle_thread(void *params)