Re: [Libvirt-cim] [PATCH] [CU] Merge do_ref() and do_assoc()
Heidi Eckhart wrote:
# HG changeset patch
# User Heidi Eckhart <heidieck(a)linux.vnet.ibm.com>
# Date 1197540659 -3600
# Node ID 0b30c3a70c3aa076d8aac5a6cf63af06413b056c
# Parent b5847180d00719ff39f2d451d4e79d4369952ad5
[CU] Merge do_ref() and do_assoc()
The two functions do_ref() and do_assoc() run through
the same logic. The only difference are the returned
instances. By configuring the do_assoc() function with
an additional paramter (ref_rslt) to inidcate the type
of the returned instance(s) - either reference(names) or
associator(names) - the two functions can be merged.
Signed-off-by: Heidi Eckhart <heidieck(a)linux.vnet.ibm.com>
Time for me to play PCO. This is #2, correct? And the changes since
the original are limited to cleaning up the logic in the new function
and breaking some stuff out into helper functions, as Dan suggested? It
looks much nicer this way. Good patch codewise, sorry I've got to be a
pain about the guidelines. :)
--
-Jay