Re: [Libvirt-cim] [PATCH] [RFC] #2 - variable renaming in make_ref() of associations
Heidi Eckhart wrote:
# HG changeset patch
# User Heidi Eckhart <heidieck(a)linux.vnet.ibm.com>
# Date 1196858495 -3600
# Node ID af64285fa953aca6c4183d0fd6845d110ddd1a1d
# Parent 012fc8655c2b443511ba536ef2b425ac86f69f7b
[RFC] #2 - variable renaming in make_ref() of associations
Suggestion to rename some of the variables in make_ref()
to make the relations clearer.
Also moved the content of make_ref() to make_reference()
in libxkutil to generalize it. This make_reference can
then be used by each association's make_ref().
Signed-off-by: Heidi Eckhart <heidieck(a)linux.vnet.ibm.com>
I like this. The rename is definitely more worthwhile if we generalize
it, and I agree that it really can be generalized, as this patch shows.
My only question is: would this be better suited to being part of
std_association instead of libxkutil? Seems like anything that will use
std_association will probably want to use make_reference().
--
-Jay