Re: [Libvirt-cim] [PATCH] Enable localhost migration

KR> - if (domain_exists(job->conn, job->domain)) { KR> - CU_DEBUG("Remote domain `%s' exists", job->domain); KR> - cu_statusf(_BROKER, &s, KR> - CMPI_RC_ERR_FAILED, KR> - "Remote already has domain `%s'", job->domain); KR> - goto out; KR> + if (!STREQ(job->host, "localhost")) { KR> + if (domain_exists(job->conn, job->domain)) { This is a minor thing, but can't these two conditions be joined with && to avoid increasing the nesting level unnecessarily? KR> + CU_DEBUG("Remote domain `%s' exists", job->domain); KR> + cu_statusf(_BROKER, &s, KR> + CMPI_RC_ERR_FAILED, KR> + "Remote already has domain `%s'", KR> + job->domain); KR> + goto out; KR> + } KR> } -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms(a)us.ibm.com