15 Apr
2008
15 Apr
'08
2:04 p.m.
Kaitlin Rupert wrote:
- return 1; + return count;
You could do return count + 1 here and then use the quantity instead of number. This would save you a step in the rasd_from_vdev() call.
But either way is fine by me. I think returning count + 1 here would cause problems for non-proc RASDs. I basically went with the assumption that this time around I should make as few changes as possible to code that wasn't explicitly only going to run for proc RASDs.
Probably doesn't matter for this case, but the type here should match the type you set in CMSetProperty.
This needs to be CMPI_uint64 (per the mof) - otherwise, the attribute might not set correctly in all cases.
Okay, I can fix those things easily enough. -- -Jay