
On 04/24/2013 10:09 AM, John Ferlan wrote:
This is primarily a repost of the previous series:
https://www.redhat.com/archives/libvirt-cim/2013-March/msg00051.html
and
https://www.redhat.com/archives/libvirt-cim/2013-April/msg00014.html
The primary difference in this patch vs. the previous sets is to fix the version string checking for nfs server checking in common_util.py and to add patch 12/12 which handles a problem in 'enum_volumes()' in pool.py.
I assume patches 1-4 and 6-9 were reviewed without issue. So focus on 5/12 and 10-12/12.
John Ferlan (12): Need to check "slp=true", not just "slp" since "slp=false" is possible Change the MAC from "99:" to "88:" Create a temporary directory for disk pool tests Use symbols as named in libvirt-cim for easier reference Fix nfs-server lookup code Fix os_status passing to reporter functions Resolve issues found in test. On Fedora systems default to using 'em1' instead of 'eth1' 19 - resolve issues found in test vxml: Add which volume could not be found to error message Add and utilize virsh_version_cmp pool: Need to handle when there are no volumes in the default pool
.../Profile/04_verify_libvirt_cim_slp_profiles.py | 2 +- .../08_CreateDiskResourcePool.py | 30 +++++-- .../09_DeleteDiskPool.py | 19 +++-- .../10_create_storagevolume.py | 6 +- .../11_create_dir_storagevolume_errs.py | 5 +- .../12_create_netfs_storagevolume_errs.py | 5 +- .../13_delete_storagevolume.py | 5 +- .../14_delete_storagevolume_errs.py | 5 +- .../15_DiskPoolAutostart.py | 15 +++- .../SettingsDefineCapabilities/01_forward.py | 1 - .../libvirt-cim/cimtest/VSSD/06_duplicate_uuid.py | 2 +- .../06_addresource.py | 2 +- .../08_modifyresource.py | 4 +- .../13_refconfig_additional_devs.py | 4 +- .../15_mod_system_settings.py | 11 ++- .../18_define_sys_bridge.py | 2 +- .../19_definenetwork_ers.py | 23 +++--- .../22_addmulti_brg_interface.py | 2 +- .../27_definesystem_macvtap_dev.py | 19 ++++- .../28_definesystem_with_vsi_profile.py | 15 ++++ suites/libvirt-cim/lib/XenKvmLib/common_util.py | 93 +++++++++++++++++----- suites/libvirt-cim/lib/XenKvmLib/const.py | 6 +- suites/libvirt-cim/lib/XenKvmLib/pool.py | 10 +-- suites/libvirt-cim/lib/XenKvmLib/rasd.py | 10 ++- suites/libvirt-cim/lib/XenKvmLib/test_xml.py | 2 +- suites/libvirt-cim/lib/XenKvmLib/vxml.py | 4 +- suites/libvirt-cim/lib/XenKvmLib/xm_virt_util.py | 6 ++ suites/libvirt-cim/main.py | 15 ++++ 28 files changed, 237 insertions(+), 86 deletions(-)
I have pushed the series to cimtest.git I have a fix for the issues mentioned in follow-up exchanges regarding 22_addmulti_brg_interface.py which I will post shortly. John