Re: [Libvirt-cim] [PATCH 1 of 2] Add new provider - VirtualSystemMigrationSettingData

6 Feb 2008


      Heidi Eckhart wrote:
...
Kaitlin Rupert wrote:
...
+static CMPIStatus get_migration_sd(const CMPIObjectPath *ref,
+                                   CMPIInstance **_inst,
+                                   const CMPIBroker *broker,
+                                   bool is_get_inst)
+{
+        CMPIInstance *inst;
+        CMPIStatus s;
Please check if you can get a connection to libvirt with the given 
classname. Otherwise you return Xen instances on a KVM only system (and 
reverse). ResourcePoolConfigurationService is already doing so (was a 
fix some days ago). Thanks.
Oh yes, excellent point.  I've sent a new patch.  Thanks!

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin@linux.vnet.ibm.com