Re: [Libvirt-cim] [PATCH 1 of 2] Add an EmulatedType field to DiskRASD to select CDROM or Disk
Dan Smith wrote:
# HG changeset patch
# User Dan Smith <danms(a)us.ibm.com>
# Date 1226005676 28800
# Node ID 049f0bb012190e680257d00463138391405a5c60
# Parent 9385e61cd401162bef9c44bc11f64ca349a41abf
Add an EmulatedType field to DiskRASD to select CDROM or Disk
This seems like a pretty reasonable way to do this, but comments are welcome.
I had initially planned to have a specific RASD type to represent a CDROM,
but I don't think that makes much sense, and is significantly more complex.
Adding this gives us a way to set and query the CDROM-ness of a disk, and
with the following patch, avoids dropping this qualifier from existing
configurations.
I like this approach. You'd mentioned in the previous set that you
wanted the CDROM support to be an extension of the current disk support.
I think this achieves this well.
I don't think there's a reason to have a different CDROM device, since
it's just an extension of the disk device. It similar to how a guest
might have both a mouse and a tablet device (even though both are input
devices).
+1
--
Kaitlin Rupert
IBM Linux Technology Center
kaitlin(a)linux.vnet.ibm.com