Re: [Libvirt-cim] [PATCH 1 of 2]

KR> + tcp_info = fopen(path, "r"); KR> + if (tcp_info== NULL) { Whitespace before the == ... KR> + port_list.list = malloc(count * sizeof(struct vnc_port *)); Why not allocate the space for the structs too? KR> + port_list.list[port_list.cur] = malloc(sizeof(struct vnc_port)); If you do the above, then you won't have to allocate here. Otherwise I think it looks fine. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms(a)us.ibm.com