Re: [Libvirt-cim] [PATCH 2 of 3] Allow device_parsing modules to return multiple devices per cycle

Dan Smith wrote: > > -static bool parse_disk_device(xmlNode *dnode, struct virt_device *vdev) > -{ > - struct disk_device *ddev = &(vdev->dev.disk); > +static int parse_disk_device(xmlNode *dnode, struct virt_device **vdevs) Why the move from int to bool and now back to int? > + > + devices = do_real_parse(dev_nodes[devidx], &tmp_list); > + if (devices <= 0) > + continue; Why is the check devices <= 0? The parse functions only return either 0 or 1.