Re: [Libvirt-cim] [PATCH] [TEST] Modifying HostedDependency/04_reverse_errs.py tc to use cim_define() and cim_start(), cim_destroy()

Kaitlin Rupert wrote: >> @@ -138,7 +148,9 @@ def main(): >> keys = { 'CreationClassName' : field, 'Name' : host_name } >> ret_value = verify_err_fields(cxml, server, conn, keys, classname, >> acn, msg, field, expr_values) >> - cxml.destroy(server) >> + if ret_value == PASS: > > You want to destroy and undefine the guest, even if ret_value != PASS. > >> + cxml.cim_destroy(server) >> + cxml.undefine(server) > > Also, there's a few places in this test where the test is returned but > the guest isn't destroyed / undefined. Can you fix those spots? Look > at lines 128, 136, and 144. > > Thanks! > The verify_err_fields() takes care of destroy/undefine of the guest in case of failure, hence I need to only destroy and undefine for the last verify_err_fields() call and only when ret_value from the verify_err_fields() is PASS.