Re: [Libvirt-cim] [PATCH 3 of 3] [TEST] Fixing SettingsDefineCapabilities/01_forward.py
+
+ curr_cim_rev, changeset = get_provider_version(virt, server)
+ if curr_cim_rev >= libvirt_rasd_storagepool_changes:
+ sto_vol_cn = 'StorageVolumeResourceAllocationSettingData'
+ storagevol_rasd_cn = get_typed_class(virt, sto_vol_cn)
+ rtype[storagevol_rasd_cn] = 32768
Same here, can you use a const value?
@@ -176,12 +184,9 @@
" of %i", assoc_cname, len(assoc_info), exp_len)
status = FAIL
break
- status = verify_rasd_fields(loop, assoc_info, cllist, rtype,
- rangelist)
+ status = verify_rasd_fields(assoc_info, rtype, rangelist)
if status != PASS:
break
- else:
- loop = loop + 1
except Exception, detail:
logger.error(CIM_ERROR_ASSOCIATORS, assoc_cname)
I like the changes here to get rid of the loop. Make the test a little
cleaner I think.
Thanks!
--
Kaitlin Rupert
IBM Linux Technology Center
kaitlin(a)linux.vnet.ibm.com