Re: [Libvirt-cim] [PATCH 3 of 3] [RFC] Add external check functionality to CheckIsVSMigratable()

10 Mar 2008


      ...
+static CMPIStatus call_external_checks(virDomainPtr dom,
+                                       const char *param_path)
+{
+        CMPIStatus s = {CMPI_RC_OK, NULL};
+        char **list = NULL;
+        int count = 0;
+        int i;
+
+        list = list_migration_checks(&count);
+        if (count < 0) {
+                cu_statusf(_BROKER, &s,
+                           CMPI_RC_ERR_FAILED,
+                           "Unable to execute migration checks");
+                goto out;
+        } else if (list == NULL) {
+                goto out;
+        }
Shouldn't you include an error in the list == NULL case as well?

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin@linux.vnet.ibm.com