Re: [Libvirt-cim] [PATCH 1 of 2] Add an EmulatedType field to DiskRASD to select CDROM or Disk

JF> After thinking about this more (and taking another look at JF> CIM_RASD), couldn't the existing ResourceType CD Drive or DVD JF> drive be leveraged instead of adding a new property? I went down this path a few weeks ago, which ended in frustration and patches sitting in my tree for a while. Because of the way we correlate things, we end up having to change the implementation of a lot of bits to handle that new ResourceType all the way through the stack. Every time I tried to compress Disk,CD to Disk, I'd find something further down the stack that expected them to be separate. ResourcePools, Devices, etc. Now, that's not a good justification for deciding how the model is designed, for sure, and it's definitely doable. If the preference is for this method, then I can revert the patch and we can go for the more heavy-weight option. I probably won't have time to finish my half-complete set for a while though. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms(a)us.ibm.com